On Mon, May 11, 2015 at 04:24:45PM +0200, Maarten Lankhorst wrote:
> This should be safe.
Usual request: A few more details about what you've changed to help guide
the review would be great. E.g. which functions from the atomic helpers
you're trying to copy here exactly.
It looks like this models
On Mon, May 11, 2015 at 11:51:56AM -0700, Chandra Konduru wrote:
> From: chandra konduru
>
> kms_panel_fitting currently enabled for SKL only, but as
> panel_fitters are available on prior platforms, enable this
> kms test for them too.
>
> Signed-off-by: chandra konduru
Makes sense, applied.
On Mon, May 11, 2015 at 07:36:07PM +0100, Damien Lespiau wrote:
> With the recent developments, add scaler and NV12 registers to the dump.
> Also add the cursor registers that were missing in the first batch.
>
> Signed-off-by: Damien Lespiau
Jani has this shiny new swiss army knive tool now ...
On Mon, May 11, 2015 at 09:26:40PM +0100, Chris Wilson wrote:
> On Mon, May 11, 2015 at 06:37:14PM +0200, Daniel Vetter wrote:
> > On Mon, May 11, 2015 at 04:03:27PM +0100, Peter Antoine wrote:
> > > If an batch ends while the IRQs are not turned on the notification can
> > > go missing and the GPU
On Mon, May 11, 2015 at 02:35:47PM -0700, Chandra Konduru wrote:
> During check_crtc_state, scaler_id mispatch is being reported for HSW.
> This is applicable for skl+ and not for HSW. It is introduced by
> commit id:
> commit a1b2278e4dfcd2dbea85e319ebf73a6b7b2f180b
> Author: Chandra Kondu
On 12 May 2015 at 11:50, Dave Airlie wrote:
> Hi,
>
> So I have a branch that makes no sound,
> http://cgit.freedesktop.org/~airlied/linux/log/?h=dp-mst-audio
>
> and I'm not sure where I need to turn to next,
>
> The Intel docs I've read are kinda vague, assuming you know lots of
> things I clear
Hi,
So I have a branch that makes no sound,
http://cgit.freedesktop.org/~airlied/linux/log/?h=dp-mst-audio
and I'm not sure where I need to turn to next,
The Intel docs I've read are kinda vague, assuming you know lots of
things I clearly don't.
so in theory my branch, sets up the SDP stream to
From: Abhay
Current WM calculation is causing regression on SR residency.
Recomputing WM using new formula as provided by VPG
Change-Id: I9dbd6a7b70c84454748dee41738130934230b763
Signed-off-by: Abhay
---
drivers/gpu/drm/i915/intel_pm.c | 26 +++---
1 file changed, 15 insert
> -Original Message-
> From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com]
> Sent: Monday, May 11, 2015 5:03 AM
> To: Konduru, Chandra
> Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Syrjala, Ville
> Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add 90/270 rotation for NV12
> -Original Message-
> From: Thomas Wood [mailto:thomas.w...@intel.com]
> Sent: Wednesday, April 22, 2015 9:58 AM
> To: Konduru, Chandra
> Cc: Intel Graphics Development
> Subject: Re: [Intel-gfx] [PATCH] i-g-t: Adding rotation to plane scaling test
>
> "kms_plane_scaling" would be a bet
From: chandra konduru
Resending with correct subject-prefix.
This patch has below improvements:
- use tile-Y for fb1 which is used for 90/270 rotation
- add 90/270 rotation tests along with scaling
- remove primary_plane_scaling flag which isn't required anymore
- use helper igt_get_image_si
From: chandra konduru
This patch has below improvements:
- use tile-Y for fb1 which is used for 90/270 rotation
- add 90/270 rotation tests along with scaling
- remove primary_plane_scaling flag which isn't required anymore
- use helper igt_get_image_size() to get image size
- use fb's width
During check_crtc_state, scaler_id mispatch is being reported for HSW.
This is applicable for skl+ and not for HSW. It is introduced by
commit id:
commit a1b2278e4dfcd2dbea85e319ebf73a6b7b2f180b
Author: Chandra Konduru
Date: Tue Apr 7 15:28:45 2015 -0700
drm/i915: skylake pa
> > Scaler id is added for skylake to handle its shared scalers.
> > This is not applicable for platforms before SKL. This patch limits
> > the scaler_id check during intel_pipe_config_compare to platforms
> > SKL and above.
>
> Please add a References: line here with the bug report from mailing
On Mon, May 11, 2015 at 06:37:14PM +0200, Daniel Vetter wrote:
> On Mon, May 11, 2015 at 04:03:27PM +0100, Peter Antoine wrote:
> > If an batch ends while the IRQs are not turned on the notification can
> > go missing and the GPU can hang. So generate a warning in this case.
> >
> > Signed-off-by:
On Mon, May 11, 2015 at 06:51:03PM +0200, Daniel Vetter wrote:
> On Mon, Apr 27, 2015 at 01:41:16PM +0100, Chris Wilson wrote:
> > As we perform the mmio-flip without any locking and then try to acquire
> > the struct_mutex prior to dereferencing the request, it is possible for
> > userspace to que
> Yeah that one is busted unfortunately. I've just pushed out a new -nightly
> with an updated patch from Maarten:
> commit c363376d3d5586c1e99f92969a7a7baf179206d7
> Author: Maarten Lankhorst
> Date: Mon May 11 10:45:15 2015 +0200
> drm/i915: Always keep crtc_state->active in sync with enable
Hello siewhoon
Thanks for your reply
I wanted to be sure if there was another VBIOS that I should/could use.
I'm considering testing the EMGD drivers, thanks for your suggestion.
Do you know if there is a way to override the device_type on the open source
graphic drivers?
Best Regards,
Adolfo.
From: chandra konduru
kms_panel_fitting currently enabled for SKL only, but as
panel_fitters are available on prior platforms, enable this
kms test for them too.
Signed-off-by: chandra konduru
---
tests/kms_panel_fitting.c |8
1 file changed, 8 deletions(-)
diff --git a/tests/kms
With the recent developments, add scaler and NV12 registers to the dump.
Also add the cursor registers that were missing in the first batch.
Signed-off-by: Damien Lespiau
---
tools/quick_dump/skl_display.txt | 97
1 file changed, 97 insertions(+)
diff --
This is another drm-intel-collector updated notice:
http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector
Here goes the update list in order for better reviewers assignment:
Patch drm/i915: Remove pinned check from madvise_ioctl - Reviewer:
Patch drm/i915: Remove unne
From: "sonika.jin...@intel.com"
Currently, if bios fails to drive an edp panel due to any reason,
the ddi buffer will not be enabled. And the DDIA lane capability
will remain 0. This leads to assumption of DDIA x2 which means DDIA
supports 2 lanes and DDIE supports 2 lanes. For some higher resolu
From: Mika Kuoppala
We just allocated the intel_ringbuffer with kzalloc. There
is no chance of the ringbuf->obj being other than NULL
so remove the redudant check.
Signed-off-by: Mika Kuoppala
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/intel_lrc.c | 29 +
Let userspace know the status of Panel Self-Refresh by virtue of a
property on the appropriate connector.
v2: Only attach the property if the driver is capable of PSR.
v3: Add docbook courtesy of Damien.
v4: Mark the initial value as 'unsupported' - it will be determined
correctly when we late
With frontbuffer tracking taking care of fbc
we were duplicating fbc update call on these cases here.
Cc: Paulo Zanoni
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/intel_display.c | 12
drivers/gpu/drm/i915/intel_drv.h | 1 -
2 files changed, 13 deletions(-)
diff --g
From: Gaurav K Singh
On CHT, changes are required for calculating the correct m,n & p with
minimal error +/- for the required DSI clock, so that the correct dividor
& ctrl values are written in cck regs for DSI. This patch has been tested
on CHT RVP with 1200 x 1920 panel.
Signed-off-by: Gaurav
From: Gaurav K Singh
For MIPI panels requiring higher DSI clk, values needs to be added
in lfsr_converts table for getting the correct values of pll ctrl
and dividor values which gets programmed in cck regs, otherwise DSI
PLL does not get locked leading to no display on the MIPI panel.
Signed-of
From: Chris Wilson
We don't need to incur the overhead of checking whether the object is
pinned prior to changing its madvise. If the object is pinned, the
madvise will not take effect until it is unpinned and so we cannot free
the pages being pointed at by hardware. Marking a pinned object with
From: Tvrtko Ursulin
It would require watermark reprogramming which we do not want to do.
Signed-off-by: Tvrtko Ursulin
Cc: Daniel Vetter
Cc: Sonika Jindal
Cc: Damien Lespiau
Cc: Chris Wilson
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact:
shuang...@intel.com)
Sign
On Mon, May 11, 2015 at 04:24:44PM +0200, Maarten Lankhorst wrote:
> Assume the function is locked with drm_modeset_lock_all for now.
s/toggle/control/ in the commit message.
And a bit of blabla would be good to explain why we need to make a
mass-replacement of state->enable to state->active here
On Mon, 11 May 2015 15:54:24 +0200
Patrik Jakobsson wrote:
> On Mon, May 11, 2015 at 12:50:36PM +0200, Gabriel Laskar wrote:
> > On Wed, 6 May 2015 16:48:01 +0200
> > Patrik Jakobsson wrote:
> >
> > > This patch set aims to make strace more useful when tracing i915 ioctls.
> > > The ioctl type
From: Ville Syrjälä
Remove some inline keywords. One of the functions has clearly outgrown
it anyway, so let's just leave it to the compiler.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_irq.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/
From: Ville Syrjälä
Use HOTPLUG_INT_STATUS_G4X instead of HOTPLUG_INT_STATUS_I915 on VLV/CHV
so that we don't confuse the AUX status bits with SDVO status bits.
Avoid pointless log spam as below while handling AUX interrupts:
[drm:intel_hpd_irq_handler] hotplug event received, stat 0x0040, d
On Mon, May 11, 2015 at 07:33:01PM +0200, Daniel Vetter wrote:
> On Mon, May 11, 2015 at 04:24:43PM +0200, Maarten Lankhorst wrote:
> > @@ -14679,7 +14646,8 @@ static bool primary_get_hw_state(struct intel_crtc
> > *crtc)
> > return I915_READ(DSPCNTR(crtc->plane)) & DISPLAY_PLANE_ENABLE;
> >
On Mon, May 11, 2015 at 04:24:43PM +0200, Maarten Lankhorst wrote:
> @@ -14679,7 +14646,8 @@ static bool primary_get_hw_state(struct intel_crtc
> *crtc)
> return I915_READ(DSPCNTR(crtc->plane)) & DISPLAY_PLANE_ENABLE;
> }
>
> -static void intel_modeset_readout_hw_state(struct drm_device *
On Mon, May 11, 2015 at 04:24:42PM +0200, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst
Same comment about the terse commit message as in the previous patch.
> ---
> drivers/gpu/drm/i915/intel_display.c | 15 ---
> drivers/gpu/drm/i915/intel_drv.h | 5 -
> 2 f
On Mon, May 11, 2015 at 04:24:41PM +0200, Maarten Lankhorst wrote:
Too terse commit message, especially explaining why the changes in
restore_mode are what we want seems appropriate. And mentioning the
general replacement is connector->new_encoder ->
free_standing_state->best_encoder would be good
On Mon, May 11, 2015 at 04:24:40PM +0200, Maarten Lankhorst wrote:
> @@ -6079,26 +6059,29 @@ void intel_crtc_control(struct drm_crtc *crtc, bool
> enable)
> enum intel_display_power_domain domain;
> unsigned long domains;
>
> + if (enable == intel_crtc->active)
> + re
On Mon, May 11, 2015 at 04:24:38PM +0200, Maarten Lankhorst wrote:
> Now that the dpll updates are (mostly) atomic, the .off() code is no longer
> used,
> and there are no more callers for intel_put_shared_dpll. Move all the updates
> done in intel_crtc_disable to intel_modeset_update_state, one l
On Mon, May 11, 2015 at 04:24:39PM +0200, Maarten Lankhorst wrote:
> This prevents unnecessarily updating power domains, while still
> enabling all power domains on initial setup.
>
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_display.c | 52
> ++
On Mon, Apr 27, 2015 at 01:41:16PM +0100, Chris Wilson wrote:
> As we perform the mmio-flip without any locking and then try to acquire
> the struct_mutex prior to dereferencing the request, it is possible for
> userspace to queue a new pageflip before the worker can finish clearing
> the old state
When -lrt was added, it was missing a '\' at the end of line. Add it.
Cc: Tim Gore
Cc: Thomas Wood
Signed-off-by: Damien Lespiau
---
tools/quick_dump/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/quick_dump/Makefile.am b/tools/quick_dump/Makefile.am
inde
On Mon, Apr 27, 2015 at 01:41:15PM +0100, Chris Wilson wrote:
> Synchronising to an object active on the same ring is a no-op, for the
> benefit of execbuffer scheduler. However, for CS flips this means that
> we can forgo checking whether the last write request of the object is
> actually queued a
On Mon, Apr 27, 2015 at 01:41:14PM +0100, Chris Wilson wrote:
> We no longer interpolate domains in the same manner, and even if we did,
> we should trust setting either of the other write domains would trigger
> an invalidation rather than force it. Remove the tweaking of the
> read_domains since
On Mon, May 11, 2015 at 04:03:27PM +0100, Peter Antoine wrote:
> If an batch ends while the IRQs are not turned on the notification can
> go missing and the GPU can hang. So generate a warning in this case.
>
> Signed-off-by: Peter Antoine
Queued for -next, thanks for the patch.
-Daniel
> ---
>
Signed-off-by: Damien Lespiau
---
tests/kms_cursor_crc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 9f20ae2..98a91d9 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -158,11 +158,10 @@ static vo
On Mon, May 11, 2015 at 12:34:37PM +0200, Daniel Vetter wrote:
> On Mon, May 11, 2015 at 08:51:36AM +0100, Chris Wilson wrote:
> > With the advent of mmap(wc), we have a path to write directly into
> > active GPU buffers. When combined with async updates (i.e. avoiding the
> > explicit domain manag
If an batch ends while the IRQs are not turned on the notification can
go missing and the GPU can hang. So generate a warning in this case.
Signed-off-by: Peter Antoine
---
drivers/gpu/drm/i915/intel_lrc.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c
On 5/7/2015 2:57 PM, Imre Deak wrote:
On to, 2015-05-07 at 12:00 +0530, Vandana Kannan wrote:
BUN 1: prop_coeff, int_coeff, tdctargetcnt programming updated and tied to
VCO frequencies. Program i_lockthresh in PORT_PLL_9.
VCO calculated based on the formula:
Desired Output = Port bit rate in
On 5/7/2015 1:07 PM, Jani Nikula wrote:
On Thu, 07 May 2015, Vandana Kannan wrote:
Changes for BXT - added a IS_BROXTON check to use the macro related to PPS
registers for BXT.
BXT does not have PP_DIV register. Making changes to handle this.
Second set of PPS registers have been defined but
From: Ander Conselvan de Oliveira
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/i915_drv.h | 1 -
drivers/gpu/drm/i915/intel_atomic.c | 49
drivers/gpu/drm/i915/intel_display.c | 111 +++
drivers/gpu/drm/i915/intel_drv.h
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 109 +--
drivers/gpu/drm/i915/intel_drv.h | 2 +
2 files changed, 81 insertions(+), 30 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_di
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_atomic.c | 10 +++---
drivers/gpu/drm/i915/intel_sprite.c | 4 ++--
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_atomic.c
b/drivers/gpu/drm/i915/intel_atomic.c
index 7ed8033aae60..ac
Must start somewhere to get rid of crtc->config.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/i915_irq.c | 13 ++---
drivers/gpu/drm/i915/intel_display.c | 6 ++
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drive
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_fbc.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 6abb83432d4d..098461ce1fe4 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++
No need to repeatedly call update_watermarks, or update_fbc.
For update_watermarks once should be enough after disabling crtc's
and swapping the state.
Down to a single call to update_watermarks in .crtc_enable
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 79 +
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_dp.c | 33 ++---
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index eda1b22c3111..e6876faca7f0 100644
--- a/drivers/gpu/
This patch makes this happen by consolidating all modeset paths
and getting rid of most transitional state.
This happens first by unifying all paths so all code that
disables a crtc goes through either intel_crtc_toggle or
__intel_set_mode. After that's done crtc_state->active is
updated in intel_
Assume the function is locked with drm_modeset_lock_all for now.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/i915_irq.c | 2 +-
drivers/gpu/drm/i915/intel_display.c | 79 ++--
2 files changed, 50 insertions(+), 31 deletions(-)
diff --git a/dri
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_pm.c | 96 -
1 file changed, 46 insertions(+), 50 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index a70b2d1fc844..869b587f463d 100644
--- a/driv
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/i915_drv.h | 3 +-
drivers/gpu/drm/i915/intel_display.c | 207 ++-
drivers/gpu/drm/i915/intel_dp.c | 2 +
drivers/gpu/drm/i915/intel_drv.h | 10 +-
drivers/gpu/drm/i915/intel_panel.c |
Don't walk the crtc_state twice if there's no need for it.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
inde
From: Ander Conselvan de Oliveira
It makes more sense there, since these are computation steps that can
fail.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 70 ++--
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/dri
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_overlay.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_overlay.c
b/drivers/gpu/drm/i915/intel_overlay.c
index 5fd2d5ac02e2..fa0ff6974dcc 100644
--- a/drivers/gpu/drm/i915/int
From: Ander Conselvan de Oliveira
The last remaining portion that required the modeset_crtc argument is
converted to deal with all crtcs in the state that need_modeset(). By
doing that, __intel_set_mode() is generic enough, behaving like a commit
function for the atomic state.
Signed-off-by: Maa
Small behavioral change: DPLL_DVO_2X_MODE may stay enabled during modeset
for I830 if new state requires it, instead of being disabled and enabled
again.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 140 ++-
drivers/gpu/drm/i915/inte
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 15 ---
drivers/gpu/drm/i915/intel_drv.h | 5 -
2 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 00b15
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_dsi.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 3f28b046751b..ec5f4509dc87 100644
--- a/drivers/gpu/drm/i915/intel_dsi
Another abuser gone.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/i915_debugfs.c | 42 -
1 file changed, 27 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915/i915_debugfs.c
index acd4d2c7613a.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_fbdev.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fbdev.c
b/drivers/gpu/drm/i915/intel_fbdev.c
index 4e7e7da2e03b..cc180bfe4c1b 100644
--- a/drivers/gpu/drm/i
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_sdvo.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c
b/drivers/gpu/drm/i915/intel_sdvo.c
index 6a68098f8b08..93b31d66a1ab 100644
--- a/drivers/gpu/drm/i915
Done as a separate commit to allow better bisecting.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 50 +---
1 file changed, 7 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/in
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 16 +---
drivers/gpu/drm/i915/intel_drv.h | 6 --
2 files changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 702
From: Ander Conselvan de Oliveira
Compute new pipe_configs for all crtcs in the atomic state. The commit
part of the mode set (__intel_set_mode()) is already enabled to support
multiple pipes, the only thing missing was calculating a new pipe_config
for every crtc.
Signed-off-by: Maarten Lankhor
This kills off most of the transitional helpers and uses atomic plane updates
in the modeset path to update everything.
Getting rid of the transitional plane helpers meant that planes had to be added
in the crtc check function. On modeset a connector can be moved to a different
crtc, and this is n
Convert the rest of the file, but remove crtc->config in a separate
commit to hopefully allow easier bisecting.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 351 ++-
drivers/gpu/drm/i915/intel_dp.c | 4 +-
drivers/gpu/drm/i915
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/i915_debugfs.c | 18 --
drivers/gpu/drm/i915/intel_display.c | 68 +---
drivers/gpu/drm/i915/intel_drv.h | 1 -
3 files changed, 39 insertions(+), 48 deletions(-)
diff --git a/drivers/gpu/drm/
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_dp_mst.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c
b/drivers/gpu/drm/i915/intel_dp_mst.c
index 4992c8025520..4ecbc58c4e04 100644
--- a/drivers/gpu/drm/i915/intel_d
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c
b/drivers/gpu/drm/i915/intel_audio.c
index c4312177b0ee..dd74fd3157ee 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++
No longer any different from state->enable.
v2: Keep track of enabled crtc's for calling intel_crtc_restore_mode.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 63 +++-
drivers/gpu/drm/i915/intel_drv.h | 1 -
2 files changed, 18
From: Ander Conselvan de Oliveira
This lets us change the force restore path in setup_hw_state() to use a
single call to intel_mode_set() to restore all the previous user
requested state.
Signed-off-by: Ander Conselvan de Oliveira
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/int
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_ddi.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index c5a9e36d6a0e..388f02a8e6e1 100644
--- a/drivers/gpu/drm/i915/intel_dd
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_psr.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 5ee0fa57ed19..868817402c11 100644
--- a/drivers/gpu/drm/i
This should be safe.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 82 ++--
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index a21b2e51c05
This removes a lot of users for crtc->config.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_crt.c | 21 ++
drivers/gpu/drm/i915/intel_ddi.c | 78 +---
drivers/gpu/drm/i915/intel_display.c | 36 ++---
drivers/gpu/drm/i9
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_hdmi.c | 58 +++
1 file changed, 35 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
b/drivers/gpu/drm/i915/intel_hdmi.c
index 76994dc033a3..9efc3dd62a00 100644
--- a
This prevents unnecessarily updating power domains, while still
enabling all power domains on initial setup.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 52
1 file changed, 41 insertions(+), 11 deletions(-)
diff --git a/driver
Drivers may need to store the state of shared resources, such as PLLs
or FIFO space, into the atomic state. Allow this by making it possible
to subclass drm_atomic_state.
Cc: dri-de...@lists.freedesktop.org
Acked-by: Ander Conselvan de Oliveira
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/d
crtc->config is gone, swap swap swap. :D
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_atomic.c | 36 ++--
drivers/gpu/drm/i915/intel_display.c | 7 +--
2 files changed, 7 insertions(+), 36 deletions(-)
diff --git a/drivers/gpu/drm/i915/in
This is now unused, goodbye. :-)
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 2 --
drivers/gpu/drm/i915/intel_drv.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 2c467cda
Now that the dpll updates are (mostly) atomic, the .off() code is no longer
used,
and there are no more callers for intel_put_shared_dpll. Move all the updates
done in intel_crtc_disable to intel_modeset_update_state, one less special case
to worry about.
Changes since v1:
- Move drm_atomic_helpe
Removed some occurences, roughly based on where the errors of
removing crtc->config occured. Because it's used a lot in this
file the changes are done in passes.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 205 ++-
drivers/gpu/drm/i
From: Ander Conselvan de Oliveira
A follow up patch will make intel_modeset_compute_config() deal with
multiple crtcs, so move crtc specific stuff into the lower level crtc
specific function.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 37 ---
Those messages where missing a new line at the end. Take the opportunity
to re-format the messages to fit in the 80 chars limit.
Signed-off-by: Damien Lespiau
---
lib/igt_aux.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 84
On 11 May 2015 at 12:35, Daniel Vetter wrote:
> On Mon, May 11, 2015 at 10:19:58AM +0200, Daniel Martin wrote:
>> Just tested
>> b5a0fd0 drm-intel-nightly: 2015y-05m-11d-06h-03m-04s UTC
>> integration manifest
>>
>> The problem still exists.
>
> Yeah that one is busted unfortunately. I've just
On Mon, May 11, 2015 at 12:50:36PM +0200, Gabriel Laskar wrote:
> On Wed, 6 May 2015 16:48:01 +0200
> Patrik Jakobsson wrote:
>
> > This patch set aims to make strace more useful when tracing i915 ioctls.
> > The ioctl type is first checked for being drm and then the driver
> > backing the opene
This patch fixed a timing issue that causes a GPU hang when a the system
comes out of power saving.
During pm_resume, We are submitting batchbuffers before enabling
Interrupts this is causing us to miss the context switch interrupt,
and in consequence intel_execlists_handle_ctx_events is not trigg
On Mon, May 11, 2015 at 12:05:27PM +0100, Peter Antoine wrote:
> This patch fixed a timing issue that causes a GPU hang when a the system
> comes out of power saving.
>
> During pm_resume, We are submitting batchbuffers before enabling
> Interrupts this is causing us to miss the context switch int
Hi,
On 05/09/2015 05:32 AM, Chandra Konduru wrote:
From: chandra konduru
This patch adds kms_nv12 test case. It covers testing NV12 in
all supported linear/tile-X/tile-Y/tile-Yf tile formats in
0 and 180 orientations. For each tiling format, it tests
various combinations of planes and scaling
On Fri, May 08, 2015 at 08:22:47PM -0700, Chandra Konduru wrote:
> Adding NV12 90/270 rotation support for primary and sprite planes.
>
> Signed-off-by: Chandra Konduru
> ---
> drivers/gpu/drm/i915/intel_display.c | 23 ---
> drivers/gpu/drm/i915/intel_sprite.c | 32
1 - 100 of 140 matches
Mail list logo
