Re: [Intel-gfx] [PATCH 6/7] drm/i915: Implement PHY lane power gating for CHV

2015-05-08 Thread Deepak S
On Friday 08 May 2015 09:35 PM, Ville Syrjälä wrote: On Fri, May 08, 2015 at 08:19:12PM +0530, Deepak S wrote: On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Powergate the PHY lanes when they're not needed. For HDMI all four lanes are needed alwa

Re: [Intel-gfx] [PATCH v4] drm/i915/chv: Set min freq to efficient frequency on chv

2015-05-08 Thread Deepak S
On Friday 08 May 2015 10:09 PM, Ville Syrjälä wrote: On Fri, May 08, 2015 at 08:43:12PM +0530, deepa...@linux.intel.com wrote: From: Deepak S After feedback from the hardware team, now we set the GPU min/idel freq to RPe. Punit is expecting us to operate GPU between Rpe & Rp0. If we drop the

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/vlv: Remove wait for for punit to updates freq.

2015-05-08 Thread Deepak S
On Friday 08 May 2015 10:04 PM, Ville Syrjälä wrote: On Fri, May 08, 2015 at 08:43:10PM +0530, deepa...@linux.intel.com wrote: From: Deepak S When GPU is idle on VLV, Request freq to punit should be good enough to get the voltage back to VNN. Also, make sure gfx clock force applies before re

Re: [Intel-gfx] [PATCH] drm/i915: Set crtc_state->active to false when CRTC is disabled (v2)

2015-05-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6352 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

[Intel-gfx] [PATCH] i-g-t: Adding display NV12 testcase

2015-05-08 Thread Chandra Konduru
From: chandra konduru This patch adds kms_nv12 test case. It covers testing NV12 in all supported linear/tile-X/tile-Y/tile-Yf tile formats in 0 and 180 orientations. For each tiling format, it tests various combinations of planes and scaling. v2: -Added 90/270 tests (me) -took out crc test as i

[Intel-gfx] [PATCH 0/2] Add NV12 90/270 support for skl planes

2015-05-08 Thread Chandra Konduru
First attempt to enabling 90/270 rotation for NV12 format using Tvrtko's recent rotated mapping for NV12. Calling intel_plane_obj_offset(plane, obj, 1) is causing kernel NULL pointer reference. Sending early out early for Tvrtko to work on the issue. Very first NV12 flip with 90/270 rotation givi

[Intel-gfx] [PATCH 2/2] drm/i915: Add 90/270 rotation for NV12 format.

2015-05-08 Thread Chandra Konduru
Adding NV12 90/270 rotation support for primary and sprite planes. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c | 23 --- drivers/gpu/drm/i915/intel_sprite.c | 32 +--- 2 files changed, 41 insertions(+), 14 deletions

[Intel-gfx] [PATCH 1/2] drm/i915: call intel_tile_height with correct parameter

2015-05-08 Thread Chandra Konduru
In skylake update plane functions, intel_tile_height() is called with bits_per_pixel instead of pixel_format. Correcting it. Signed-off-by: Chandra Konduru --- drivers/gpu/drm/i915/intel_display.c |2 +- drivers/gpu/drm/i915/intel_sprite.c |2 +- 2 files changed, 2 insertions(+), 2 dele

Re: [Intel-gfx] [PATCH] drm: Fix missing kerneldoc for the edid_corrupt field in struct drm_connector

2015-05-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6359 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

[Intel-gfx] [PATCH] drm/i915: Be optimistic about future display engines having 7 WM levels

2015-05-08 Thread Damien Lespiau
As we're doing throughout the code, being optimistic that platform n + 1 will mostly reuse the same things as platform n allows us to minimize the enabling work needed. This time, it's about the number of WM levels. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 fil

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make hangcheck logging more compact

2015-05-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6357 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH] drm/i915: Reject huge tiled objects

2015-05-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6355 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

[Intel-gfx] [PATCH 10/11] drm/i915: Add NV12 to primary plane programming.

2015-05-08 Thread Chandra Konduru
This patch is adding NV12 support to skylake primary plane programming. It is covering linear/X/Y/Yf tiling formats for 0 and 180 rotations. For 90/270 rotation, Y and UV subplanes should be treated as separate surfaces and GTT remapping for rotation should be done separately for each subplane. On

Re: [Intel-gfx] [PATCH] drm/i915/bxt: edp1.4 Intermediate Freq support

2015-05-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6354 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

[Intel-gfx] [PATCH] drm/i915: Enable runtime pm

2015-05-08 Thread Daniel Vetter
Like with every other feature that's not enabled by default we break runtime pm support way too often by accident because the overall test coverage isn't great. And it's been almost 2 years since we enabled the power well code by default commit bf51d5e2cda5d36d98e4b46ac7fca9461e512c41 Author: Paul

Re: [Intel-gfx] [PATCH i-g-t 3/4] igt_kms: Do not reset plane position on assigning a fb

2015-05-08 Thread Konduru, Chandra
> -Original Message- > From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com] > Sent: Friday, May 08, 2015 1:36 AM > To: Konduru, Chandra; Intel-gfx@lists.freedesktop.org > Cc: Ursulin, Tvrtko > Subject: Re: [PATCH i-g-t 3/4] igt_kms: Do not reset plane position on > assigning > a

Re: [Intel-gfx] [PATCH] drm/i915: Adding dbuf support for skl nv12 format.

2015-05-08 Thread Damien Lespiau
On Mon, Apr 27, 2015 at 03:47:37PM -0700, Chandra Konduru wrote: > Skylake nv12 format requires dbuf (aka. ddb) calculations > and programming for each of y and uv sub-planes. Made minor > changes to reuse current dbuf calculations and programming > for uv plane. i.e., with this change, existing co

Re: [Intel-gfx] [PATCH] drm/i915: perform scaler_id check for skl+

2015-05-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6353 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [WARNING 4.1-rc2] i915: Unclaimed register detected before writing to register 0xc4040

2015-05-08 Thread Steven Rostedt
On Fri, 8 May 2015 12:18:10 -0400 Steven Rostedt wrote: > On Fri, 8 May 2015 12:08:31 -0400 > Steven Rostedt wrote: > > > > Maybe it's my bios still (it is an older box). I'll just block out > > compiling in SND_HDA_INTEL, so that it doesn't break my tests (they > > fail on a WARNING). > > Hm

Re: [Intel-gfx] [PATCH for 4.1] drm/i915: Don't clear exec_start if batch was not copied

2015-05-08 Thread Rebecca N. Palmer
i915_gem_execbuffer_parse returns the original batch_obj on batches it can't check (currently, chained batches). Don't clear offset or set I915_DISPATCH_SECURE in this case. Fixes 17cabf571e50677d980e9ab2a43c5f11213003ae. Signed-off-by: Rebecca Palmer --- > > This version also brings exec_start

[Intel-gfx] [PATCH i-g-t] tests/kms_3d: Reduce the number of expected stereo 3D modes

2015-05-08 Thread ville . syrjala
From: Ville Syrjälä Currently the test expects to find 15 stereo 3D modes, however the number of stereo modes we get from the current kernel EDID parser is actually 13. The extra two modes we had previously were GTF modes, which are no longer getting added by the kernel since we have correspondi

Re: [Intel-gfx] [PATCH v4] drm/i915/chv: Set min freq to efficient frequency on chv

2015-05-08 Thread Ville Syrjälä
On Fri, May 08, 2015 at 08:43:12PM +0530, deepa...@linux.intel.com wrote: > From: Deepak S > > After feedback from the hardware team, now we set the GPU min/idel freq to > RPe. > Punit is expecting us to operate GPU between Rpe & Rp0. If we drop the > frequency to RPn, punit is failing to change

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/chv: Extend set idle rps wa to chv

2015-05-08 Thread Ville Syrjälä
On Fri, May 08, 2015 at 08:43:11PM +0530, deepa...@linux.intel.com wrote: > From: Deepak S > > It is obsered on BSW that requesting a new frequency from Punit > does nothing when the GPU is in rc6, and if we let it enter rc6 with a > high frequency Vnn also remains high. I would perhaps rephrase

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/vlv: Remove wait for for punit to updates freq.

2015-05-08 Thread Ville Syrjälä
On Fri, May 08, 2015 at 08:43:10PM +0530, deepa...@linux.intel.com wrote: > From: Deepak S > > When GPU is idle on VLV, Request freq to punit should be good enough to > get the voltage back to VNN. Also, make sure gfx clock force applies > before requesting the freq fot vlv. > > v2: Do forcewake

Re: [Intel-gfx] [RFC PATCH 00/11] drm/i915: Expose OA metrics via perf PMU

2015-05-08 Thread Peter Zijlstra
On Thu, May 07, 2015 at 03:15:43PM +0100, Robert Bragg wrote: > I've changed the uapi for configuring the i915_oa specific attributes > when calling perf_event_open(2) whereby instead of cramming lots of > bitfields into the perf_event_attr config members, I'm now > daisy-chaining a drm_i915_oa_ev

Re: [Intel-gfx] [RFC PATCH 00/11] drm/i915: Expose OA metrics via perf PMU

2015-05-08 Thread Peter Zijlstra
So I've not yet went through the entire series; but I'm wondering if its at all possible to re-use some of this work: lkml.kernel.org/r/1428453299-19121-1-git-send-email-suka...@linux.vnet.ibm.com That's for a Power8 HV call that can basically return an array of values; which on a superficial le

Re: [Intel-gfx] [WARNING 4.1-rc2] i915: Unclaimed register detected before writing to register 0xc4040

2015-05-08 Thread Steven Rostedt
On Fri, 8 May 2015 12:08:31 -0400 Steven Rostedt wrote: > Maybe it's my bios still (it is an older box). I'll just block out > compiling in SND_HDA_INTEL, so that it doesn't break my tests (they > fail on a WARNING). Hmm, right after I posted this I triggered the Call Trace again with # CONFI

Re: [Intel-gfx] [WARNING 4.1-rc2] i915: Unclaimed register detected before writing to register 0xc4040

2015-05-08 Thread Steven Rostedt
On Fri, 8 May 2015 08:55:46 +0200 Daniel Vetter wrote: > On Thu, May 7, 2015 at 9:40 PM, Steven Rostedt wrote: > Please retry with snd-hda-intel blacklisted. At least last time I > checked that was the only culprit left, i915 is just the messenger > here. The other one was stupid things done b

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Implement PHY lane power gating for CHV

2015-05-08 Thread Ville Syrjälä
On Fri, May 08, 2015 at 08:19:12PM +0530, Deepak S wrote: > > > On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Powergate the PHY lanes when they're not needed. For HDMI all four lanes > > are needed always, but for DP we can enable only the

[Intel-gfx] [PATCH] drm/i915: Remove unused variable from i915_gem_mmap_gtt

2015-05-08 Thread Daniel Vetter
Lost in commit c5ad54cf7dd8922bd1cee2d5871aebf73dc9638e Author: Joonas Lahtinen Date: Wed May 6 14:36:09 2015 +0300 drm/i915: Use partial view in mmap fault handler Cc: Joonas Lahtinen Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_gem.c | 1 - 1 file changed, 1 deletion(-)

[Intel-gfx] [PATCH v4 i-g-t] kms_flip_tiling: New tiling tests, including Y/Yf

2015-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin New subtests to excercise flips from tiled to tiled and from linear to tiled frame buffers. These will catch display programming issues like not preserving the tiling mode in page flips or not re-programming the watermarks. v2: Cleanup crc object after failing subtests. v3

[Intel-gfx] Updated drm-intel-testing

2015-05-08 Thread Daniel Vetter
Hi all, New -testing cycle with cool stuff: - skl plane scaler support (Chandra Kondru) - enable hsw cmd parser (Daniel and fix from Rebecca Palmer) - skl dc5/6 support (low power display modes) from Suketu&Sunil - dp compliance testing patches (Todd Previte) - dp link training optimization (Mika

Re: [Intel-gfx] [PATCH v4] drm/i915/chv: Set min freq to efficient frequency on chv

2015-05-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6282 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH] drm/i915: Fix screen flickering on X

2015-05-08 Thread Ismael Luceno
On Fri, 8 May 2015 12:10:15 -0300 Ismael Luceno wrote: > On Thu, 07 May 2015 16:41:48 +0300 > Jani Nikula wrote: > > On Thu, 07 May 2015, Matt Roper wrote: > > > On Thu, May 07, 2015 at 12:12:18PM +0300, Jani Nikula wrote: > > >> On Thu, 23 Apr 2015, Chris Wilson > > >> wrote: > > >> > [cc'ing

[Intel-gfx] [PATCH v4] drm/i915/chv: Set min freq to efficient frequency on chv

2015-05-08 Thread deepak . s
From: Deepak S After feedback from the hardware team, now we set the GPU min/idel freq to RPe. Punit is expecting us to operate GPU between Rpe & Rp0. If we drop the frequency to RPn, punit is failing to change the input voltage to minimum :( Since Punit validates the rps range [RPe, RP0]. This

[Intel-gfx] [PATCH v2 2/2] drm/i915/chv: Extend set idle rps wa to chv

2015-05-08 Thread deepak . s
From: Deepak S It is obsered on BSW that requesting a new frequency from Punit does nothing when the GPU is in rc6, and if we let it enter rc6 with a high frequency Vnn also remains high. Extending vlv_set_rps_idle() workaround on CHV/BSW. suggested-by: Ville Syrjälä Signed-off-by: Deepak S --

[Intel-gfx] [PATCH v2 1/2] drm/i915/vlv: Remove wait for for punit to updates freq.

2015-05-08 Thread deepak . s
From: Deepak S When GPU is idle on VLV, Request freq to punit should be good enough to get the voltage back to VNN. Also, make sure gfx clock force applies before requesting the freq fot vlv. v2: Do forcewake before setting idle frequency (ville) Update function comments to match the code (D

Re: [Intel-gfx] [i915 dp mst] drm-intel-nightly-2015y-05m-07d dies when monitor at docking station

2015-05-08 Thread Jani Nikula
On Fri, 08 May 2015, Daniel Martin wrote: > On 8 May 2015 at 11:26, Daniel Martin wrote: >> Hi, >> >> I've just tested drm-intel-nightly, last commit: >> >> 20e7fca drm-intel-nightly: 2015y-05m-07d-16h-16m-10s UTC >> integration manifest >> >> and it makes the machine crash as soon as I plug

Re: [Intel-gfx] [PATCH] drm/i915: Fix screen flickering on X

2015-05-08 Thread Ismael Luceno
On Thu, 07 May 2015 16:41:48 +0300 Jani Nikula wrote: > On Thu, 07 May 2015, Matt Roper wrote: > > On Thu, May 07, 2015 at 12:12:18PM +0300, Jani Nikula wrote: > >> On Thu, 23 Apr 2015, Chris Wilson wrote: > >> > [cc'ing the authors] > >> > >> This has been posted earlier [1] and it has review

Re: [Intel-gfx] [PATCH v3] drm/i915: Setup static bias for GPU

2015-05-08 Thread Deepak S
On Wednesday 06 May 2015 02:32 PM, Daniel Vetter wrote: On Tue, May 05, 2015 at 01:12:41PM +0530, Deepak S wrote: On Monday 04 May 2015 08:58 PM, Ville Syrjälä wrote: On Mon, May 04, 2015 at 10:12:23AM +0200, Daniel Vetter wrote: On Mon, May 04, 2015 at 10:58:02AM +0530, Deepak S wrote: On

Re: [Intel-gfx] [PATCH 0/8] NV12 90/270 rotated GGTT mapping

2015-05-08 Thread Tvrtko Ursulin
On 05/08/2015 03:59 PM, Damien Lespiau wrote: On Fri, May 08, 2015 at 01:02:35PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin First attempt at rotated GGTT mapping for the NV12 format. It compiles and even does not crash on first use. But some parts are probably too simplistic at the mo

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Throw out WIP CHV power well definitions

2015-05-08 Thread Deepak S
On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Expecting CHV power wells to be just an extended versions of the VLV power wells, a bunch of commented out power wells were added in anticipation when Punit folks would implement it all. Turns out they

Re: [Intel-gfx] [PATCH 0/8] NV12 90/270 rotated GGTT mapping

2015-05-08 Thread Damien Lespiau
On Fri, May 08, 2015 at 01:02:35PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > First attempt at rotated GGTT mapping for the NV12 format. > > It compiles and even does not crash on first use. But some parts are > probably too simplistic at the moment and need further polish. > > Sen

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Implement PHY lane power gating for CHV

2015-05-08 Thread Deepak S
On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Powergate the PHY lanes when they're not needed. For HDMI all four lanes are needed always, but for DP we can enable only the needed lanes. And when the port is not used all lanes can be power gated. Th

[Intel-gfx] [PATCH] drm/i915/skl: Fix a stale comment in the DDB allocation code

2015-05-08 Thread Damien Lespiau
'available' was the name for a variable in the previous version of that code. Also add the reason why being < alloc_size is important: it's because the result will indeed fit into plane_blocks. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_pm.c | 3 ++- 1 file changed, 2 insertion

Re: [Intel-gfx] [PATCH] drm/i915: Adding dbuf support for skl nv12 format.

2015-05-08 Thread Damien Lespiau
Hi Chandra, On Mon, Apr 27, 2015 at 03:47:37PM -0700, Chandra Konduru wrote: > Skylake nv12 format requires dbuf (aka. ddb) calculations > and programming for each of y and uv sub-planes. Made minor > changes to reuse current dbuf calculations and programming > for uv plane. i.e., with this change

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Only wait for required lanes in vlv_wait_port_ready()

2015-05-08 Thread Daniel Vetter
On Fri, May 08, 2015 at 07:23:42PM +0530, Deepak S wrote: > > > On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: > >From: Ville Syrjälä > > > >Currently vlv_wait_port_ready() waits for all four lanes on the > >appropriate channel. This no longer works on CHV when the unused

Re: [Intel-gfx] [PATCH igt] lib/debugfs: wait_for_keypress("crc") when collecting CRC

2015-05-08 Thread Daniel Vetter
On Fri, May 08, 2015 at 11:07:30AM -0300, Paulo Zanoni wrote: > 2015-05-08 4:29 GMT-03:00 Daniel Vetter : > > On Thu, May 07, 2015 at 03:23:17PM -0300, Paulo Zanoni wrote: > >> From: Paulo Zanoni > >> > >> Let's just steal the "crc" namespace and add this by default to > >> igt_pipe_crc_collect_cr

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix possible security hole in command parsing

2015-05-08 Thread Daniel Vetter
orry about. > > > This version also brings exec_start = 0 inside this check, as it > > appears to be there because the copying (i915_cmd_parser.c:1054) > > removes any offset the original might have had. > > > > When tested on next-20150508 (675b3fb), it pass

[Intel-gfx] [PATCH] drm: Fix missing kerneldoc for the edid_corrupt field in struct drm_connector

2015-05-08 Thread Todd Previte
The kerneldoc for this newly added parameter was missing from the original patch. This patch adds the appropriate kerneldoc entry. Signed-off-by: Todd Previte --- include/drm/drm_crtc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 8bc2

[Intel-gfx] [PATCH] drm/edid: Kerneldoc for newly added edid_corrupt

2015-05-08 Thread Daniel Vetter
Also treat it as a proper boolean. Cc: Todd Previte Cc: Paulo Zanoni Cc: dri-de...@lists.freedesktop.org Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_edid.c | 8 drivers/gpu/drm/i915/intel_dp.c | 2 +- include/drm/drm_crtc.h | 1 + 3 files changed, 6 insertions(+

Re: [Intel-gfx] [PATCH igt] lib/debugfs: wait_for_keypress("crc") when collecting CRC

2015-05-08 Thread Paulo Zanoni
2015-05-08 4:29 GMT-03:00 Daniel Vetter : > On Thu, May 07, 2015 at 03:23:17PM -0300, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> Let's just steal the "crc" namespace and add this by default to >> igt_pipe_crc_collect_crc() instead of adding more calls to other >> tests. If tests want special

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix possible security hole in command parsing

2015-05-08 Thread Mika Kuoppala
use the copying (i915_cmd_parser.c:1054) > removes any offset the original might have had. > > When tested on next-20150508 (675b3fb), it passed my checks > (libva tests, vlc video, glxgears, beignet tests), and didn't > show the "missing window title bar" problem [0

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Only wait for required lanes in vlv_wait_port_ready()

2015-05-08 Thread Deepak S
On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Currently vlv_wait_port_ready() waits for all four lanes on the appropriate channel. This no longer works on CHV when the unused lanes may be power gated. So pass in a mask of lanes that the caller is e

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Work around DISPLAY_PHY_CONTROL register corruption on CHV

2015-05-08 Thread Daniel Vetter
On Fri, May 08, 2015 at 04:19:13PM +0300, Ville Syrjälä wrote: > On Fri, May 08, 2015 at 06:24:42PM +0530, Deepak S wrote: > > > > > > On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: > > > diff --git a/drivers/gpu/drm/i915/i915_reg.h > > > b/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 2/2] drm/i915: Make hangcheck logging more compact

2015-05-08 Thread Mika Kuoppala
With commit aaecdf611a05 ("drm/i915: Stop gathering error states for CS error interrupts") we only call i915_handle_error() on call sites where there is a stuck/hung gpu. So there is no more need to carry around extra information into dmesg. Emit one loud bang into dmesg with first hanging ring as

[Intel-gfx] [PATCH 1/2] drm/i915: Detach hangcheck from request lists

2015-05-08 Thread Mika Kuoppala
Hangcheck tries to peek into request list to see if the ring was busy or not. But that leads to race against the list addition in request submission. And hangcheck saw a ring being idle, when in fact work was just being submitted. There is strong desire to keep hangcheck without locks of any kind

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Use the default 600ns LDO programming sequence delay

2015-05-08 Thread Deepak S
On Friday 08 May 2015 06:52 PM, Ville Syrjälä wrote: On Fri, May 08, 2015 at 06:31:23PM +0530, Deepak S wrote: On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Not sure which LDO programming sequence delay should be used for the CHV PHY, but the sp

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Work around DISPLAY_PHY_CONTROL register corruption on CHV

2015-05-08 Thread Deepak S
On Friday 08 May 2015 06:49 PM, Ville Syrjälä wrote: On Fri, May 08, 2015 at 06:24:42PM +0530, Deepak S wrote: On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Sometimes (exactly when is a bit unclear) DISPLAY_PHY_CONTROL appears to get corrupted.

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix possible security hole in command parsing

2015-05-08 Thread Rebecca N. Palmer
> where cmdparser is disabled, batch_obj is > left dangling Sorry! Fixed now. This version also brings exec_start = 0 inside this check, as it appears to be there because the copying (i915_cmd_parser.c:1054) removes any offset the original might have had. When tested on next-20150508 (6

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Use the default 600ns LDO programming sequence delay

2015-05-08 Thread Ville Syrjälä
On Fri, May 08, 2015 at 06:31:23PM +0530, Deepak S wrote: > > > On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Not sure which LDO programming sequence delay should be used for the CHV > > PHY, but the spec says that 600ns is "Used by defaul

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Work around DISPLAY_PHY_CONTROL register corruption on CHV

2015-05-08 Thread Ville Syrjälä
On Fri, May 08, 2015 at 06:24:42PM +0530, Deepak S wrote: > > > On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Sometimes (exactly when is a bit unclear) DISPLAY_PHY_CONTROL appears to > > get corrupted. The values I've managed to read from

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Use the default 600ns LDO programming sequence delay

2015-05-08 Thread Deepak S
On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Not sure which LDO programming sequence delay should be used for the CHV PHY, but the spec says that 600ns is "Used by default for initial bringup", and the BIOS seems to use that, so let's do the same.

Re: [Intel-gfx] [PATCH intel-gpu-tools 1/3] drmtest: Add non-i915 device open helpers

2015-05-08 Thread Daniel Vetter
On Tue, Apr 21, 2015 at 5:06 PM, Daniel Stone wrote: > On 21 April 2015 at 16:03, Micah Fedke wrote: >> + * drm_open_any_any: >> + * >> + * Literally the worst-named function I've ever written. > > And I stand by this. This is really an RFC, partly to find out whether > it would be better to find

Re: [Intel-gfx] [PATCH 3/7] Revert "drm/i915: Hack to tie both common lanes together on chv"

2015-05-08 Thread Deepak S
On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä With recent hardware/firmware there don't appear to be any glitches on the other PHY when we toggle the cmnreset for the other PHY. So detangle the cmnlane power wells from one another and let them be c

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Work around DISPLAY_PHY_CONTROL register corruption on CHV

2015-05-08 Thread Deepak S
On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Sometimes (exactly when is a bit unclear) DISPLAY_PHY_CONTROL appears to get corrupted. The values I've managed to read from it seem to have some pattern but vary quite a lot. The corruption doesn't see

Re: [Intel-gfx] [i915 dp mst] drm-intel-nightly-2015y-05m-07d dies when monitor at docking station

2015-05-08 Thread Daniel Martin
On 8 May 2015 at 11:26, Daniel Martin wrote: > Hi, > > I've just tested drm-intel-nightly, last commit: > > 20e7fca drm-intel-nightly: 2015y-05m-07d-16h-16m-10s UTC > integration manifest > > and it makes the machine crash as soon as I plug a monitor to the > docking station or boot with one a

Re: [Intel-gfx] [i915]] *ERROR* mismatch in scaler_state.scaler_id

2015-05-08 Thread Sergey Senozhatsky
On (05/08/15 01:27), Konduru, Chandra wrote: > > there are no specific steps, happens during boot and every time the screen > > goes > > unblank. attached dmesg, .config. > > > OK, I am able reproduce the mismatch scaler id log on HSW system. > Though, this log doesn't affect system functionality

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Implement chv display PHY lane stagger setup

2015-05-08 Thread Deepak S
On Friday 10 April 2015 08:51 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Set up the chv display PHY lane stagger registers according to "Programming Guide for 1273 CHV eDP/DP/HDMI Display PHY" v1.04 Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 13

Re: [Intel-gfx] [PATCH] drm/i915/bxt: edp1.4 Intermediate Freq support

2015-05-08 Thread Ville Syrjälä
On Fri, May 08, 2015 at 11:04:06AM +0530, Sonika Jindal wrote: > BXT supports following intermediate link rates for edp: > 2.16GHz, 2.43GHz, 3.24GHz, 4.32GHz. > Adding support for programming the intermediate rates. > > v2: Adding clock in bxt_clk_div struct and then look for the entry with > requ

Re: [Intel-gfx] [PATCH 13/13] drm/i915/skl: Prefer even dividers for SKL DPLLs

2015-05-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6348 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH] drm/i915: Reject huge tiled objects

2015-05-08 Thread Joonas Lahtinen
On pe, 2015-05-08 at 12:46 +0100, Chris Wilson wrote: > On Fri, May 08, 2015 at 02:37:39PM +0300, Joonas Lahtinen wrote: > > We do not yet support tiled objects bigger than the mappable > > aperture size so reject them. > > > > Reported-by: Chris Wilson > > Signed-off-by: Joonas Lahtinen > > Th

[Intel-gfx] [PATCH 8/8] drm/i915: Allow NV12 with 90/270 rotation

2015-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_atomic_plane.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_atomic_plane.c b/drivers/gpu/drm/i915/intel_atomic_plane.c index 119439d..da82504 100644 --- a/drive

[Intel-gfx] [PATCH 4/8] drm/i915: Extract tiled geometry calculation into a helper function

2015-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It will be used twice with support for planar NV12. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_gtt.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm

[Intel-gfx] [PATCH 7/8] drm/i915: Enable querying offset of UV plane with intel_plane_obj_offset

2015-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Do we need this? Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 ++ drivers/gpu/drm/i915/i915_gem_gtt.h | 2 ++ drivers/gpu/drm/i915/intel_display.c | 27 ++- drivers/gpu/drm/i915/intel_drv.h | 3 ++- drivers/gpu/

[Intel-gfx] [PATCH 5/8] drm/i915: Support appending to the rotated pages mapping

2015-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin By providing a start offset into the source array of pages, and returning the end position in the scatter-gather table, we will be able to append the UV plane to the rotated mapping in later patches. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_gtt.c | 1

[Intel-gfx] [PATCH 0/8] NV12 90/270 rotated GGTT mapping

2015-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin First attempt at rotated GGTT mapping for the NV12 format. It compiles and even does not crash on first use. But some parts are probably too simplistic at the moment and need further polish. Sending out early since Chandra needs this to complete his display programming patc

[Intel-gfx] [PATCH 3/8] drm/i915: Remove pointless calculation in intel_rotate_fb_obj_pages

2015-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Leftover from refactoring and it serves no purpose now. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_gtt.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt

[Intel-gfx] [PATCH 6/8] drm/i915: Support NV12 in rotated GGTT mapping

2015-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Just adding the rotated UV plane at the end of the rotated Y plane. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_gtt.c | 47 ++-- drivers/gpu/drm/i915/i915_gem_gtt.h | 1 + drivers/gpu/drm/i915/intel_display.c | 1 + 3

[Intel-gfx] [PATCH 1/8] drm/i915: Remove duplicated intel_tile_height declaration

2015-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_drv.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index ae551d8..cc2ed60 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gp

[Intel-gfx] [PATCH 2/8] drm/i915: Support planar formats in tile height calculations

2015-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This will be needed for NV12 support. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 8 drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gpu/drm/i915/intel_sprite.c | 2 +- 4 files changed

Re: [Intel-gfx] [PATCH] drm/i915: Reject huge tiled objects

2015-05-08 Thread Chris Wilson
On Fri, May 08, 2015 at 02:37:39PM +0300, Joonas Lahtinen wrote: > We do not yet support tiled objects bigger than the mappable > aperture size so reject them. > > Reported-by: Chris Wilson > Signed-off-by: Joonas Lahtinen This still turns the EINVAL into a SIGBUS. There is only one client that

Re: [Intel-gfx] VBIOS doesn't recognize the eDP port on Baytrail-I

2015-05-08 Thread Ville Syrjälä
On Thu, May 07, 2015 at 10:44:21PM +, Sanchez, AdolfoX wrote: > Which VBIOS should be used with the Baytrail-I when trying to configure two > local flat panels as eDP > The EMGD VBIOS creates a device_type 0x1004 and the i915 drivers looks for a > device_type=0x1806 so it seems that the EMGD

[Intel-gfx] [PATCH] drm/i915: Reject huge tiled objects

2015-05-08 Thread Joonas Lahtinen
We do not yet support tiled objects bigger than the mappable aperture size so reject them. Reported-by: Chris Wilson Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_gem.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Possible security hole in command parsing

2015-05-08 Thread Daniel Vetter
On Thu, Apr 30, 2015 at 12:32:15PM +0100, Rebecca N. Palmer wrote: > i915_parse_cmds returns -EACCES on chained batches, which "tells the > caller to abort and dispatch the workload as a non-secure batch", > but the mechanism implementing that was broken when > flags |= I915_DISPATCH_SECURE was mov

[Intel-gfx] [PULL] drm-intel-fixes

2015-05-08 Thread Jani Nikula
Hi Dave, sorry, I'm a bit late this week with the i915 fixes. BR, Jani. The following changes since commit 5ebe6afaf0057ac3eaeb98defd5456894b446d22: Linux 4.1-rc2 (2015-05-03 19:22:23 -0700) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/drm-intel-fix

Re: [Intel-gfx] [PATCH] drm/i915: Allocate connector state together with the connectors

2015-05-08 Thread Nicolas Kalkhof
Hello,   the kernel oops reported back in April (http://lists.freedesktop.org/archives/intel-gfx/2015-April/064066.html) is back resulting in the same oops as soon as I connect my Laptop to its docking station or boot with docking already connected. The issue was introduced again somewhere betw

Re: [Intel-gfx] [PATCH] drm/i915: clean up dsi pll calculation

2015-05-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6346 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH] drm/i915: Possible security hole in command parsing

2015-05-08 Thread Mika Kuoppala
"Rebecca N. Palmer" writes: Hi, > i915_parse_cmds returns -EACCES on chained batches, which "tells the > caller to abort and dispatch the workload as a non-secure batch", > but the mechanism implementing that was broken when > flags |= I915_DISPATCH_SECURE was moved from i915_gem_execbuffer_pars

Re: [Intel-gfx] [PATCH 9/9] drm/i915/bxt: Mark WaCcsTlbPrefetchDisable as for Broxton also.

2015-05-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6345 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH i-g-t 3/4] igt_kms: Do not reset plane position on assigning a fb

2015-05-08 Thread Tvrtko Ursulin
On 05/08/2015 01:03 AM, Konduru, Chandra wrote: -Original Message- From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com] Sent: Thursday, May 07, 2015 2:15 AM To: Konduru, Chandra; Intel-gfx@lists.freedesktop.org Cc: Ursulin, Tvrtko Subject: Re: [PATCH i-g-t 3/4] igt_kms: Do not r

Re: [Intel-gfx] [PATCH] drm/i915: Set crtc_state->active to false when CRTC is disabled (v2)

2015-05-08 Thread Daniel Vetter
On Fri, May 08, 2015 at 10:56:03AM +0300, Ander Conselvan De Oliveira wrote: > On Thu, 2015-05-07 at 14:31 -0700, Matt Roper wrote: > > With the recent modeset internal rework, we wind up setting > > crtc_state->enable to false, but leave crtc_state->active as true, which > > is incorrect. This mi

Re: [Intel-gfx] [PATCH] drm/i915: Set crtc_state->active to false when CRTC is disabled (v2)

2015-05-08 Thread Ander Conselvan De Oliveira
On Thu, 2015-05-07 at 14:31 -0700, Matt Roper wrote: > With the recent modeset internal rework, we wind up setting > crtc_state->enable to false, but leave crtc_state->active as true, which > is incorrect. This mismatch gets caught by drm_atomic_crtc_check() and > causes subsequent atomic operatio

Re: [Intel-gfx] [PATCH] drm/i915/bxt: edp1.4 Intermediate Freq support

2015-05-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6344 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH igt] lib/debugfs: wait_for_keypress("crc") when collecting CRC

2015-05-08 Thread Daniel Vetter
On Thu, May 07, 2015 at 03:23:17PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Let's just steal the "crc" namespace and add this by default to > igt_pipe_crc_collect_crc() instead of adding more calls to other > tests. If tests want special waits on just some of their collect_crc() > call

Re: [Intel-gfx] [PATCH 01/13] drm/i915/skl: Re-indent part of skl_ddi_calculate_wrpll()

2015-05-08 Thread Daniel Vetter
On Thu, May 07, 2015 at 06:38:37PM +0100, Damien Lespiau wrote: > A part of this function was indented with 2 tabs and 1 space instead of > just 2 tabs. We're going to touch that code, so start by re-indenting > it. > > Signed-off-by: Damien Lespiau Queued for -next, thanks for the patch. -Danie

Re: [Intel-gfx] [PATCH] igt/gem_create_stolen: Verifying extended gem_create ioctl

2015-05-08 Thread Daniel Vetter
On Fri, May 08, 2015 at 10:54:26AM +0530, Ankitprasad Sharma wrote: > On Thu, 2015-05-07 at 08:52 +0200, Daniel Vetter wrote: > > On Wed, May 06, 2015 at 03:51:52PM +0530, ankitprasad.r.sha...@intel.com > > wrote: > > > From: Ankitprasad Sharma > > > > > > This patch adds the testcases for verif

Re: [Intel-gfx] [PATCH 06/11] drm/i915: Add NV12 as supported format for primary plane

2015-05-08 Thread Daniel Vetter
On Fri, May 08, 2015 at 02:29:30AM +, Konduru, Chandra wrote: > > > +/* Primary plane formats for gen >= 9 */ > > > +static const uint32_t intel_primary_formats_gen9[] = { > > > + COMMON_PRIMARY_FORMATS, \ > > > + DRM_FORMAT_XBGR, > > > + DRM_FORMAT_ABGR, > > > + DRM_FORMAT_XRGB2101010,

Re: [Intel-gfx] [PATCH] drm/i915: perform scaler_id check for skl+

2015-05-08 Thread Daniel Vetter
On Thu, May 07, 2015 at 06:16:04PM -0700, Chandra Konduru wrote: > Scaler id is added for skylake to handle its shared scalers. > This is not applicable for platforms before SKL. This patch limits > the scaler_id check during intel_pipe_config_compare to platforms > SKL and above. Please add a Ref