Re: [Intel-gfx] [PATCH] drm/i915/skl: Add module parameter to select edp vswing table

2015-05-05 Thread Jani Nikula
On Wed, 06 May 2015, "Jindal, Sonika" wrote: > On 5/5/2015 7:28 PM, Jani Nikula wrote: >> On Tue, 05 May 2015, Damien Lespiau wrote: >>> On Tue, May 05, 2015 at 02:39:48PM +0300, Jani Nikula wrote: There's still the question whether we can default to using the vbt value if that can be b

[Intel-gfx] [BUG] i915: suspend by closing Laptop lid broken

2015-05-05 Thread Martin Kepplinger
So. -rc1 broke suspending by closing my laptop lid and it's not fixed in -rc2. It works exactly *one* first time and every subsequent lid-closing is ignored. Biscted and tested first bad commit: 14aa02449064541217836b9f3d3295e241d5ae9c This pulls in i915 changes as well as ACPI changes. I don't k

Re: [Intel-gfx] [PATCH] drm/i915/skl: Add module parameter to select edp vswing table

2015-05-05 Thread Jindal, Sonika
On 5/5/2015 7:28 PM, Jani Nikula wrote: On Tue, 05 May 2015, Damien Lespiau wrote: On Tue, May 05, 2015 at 02:39:48PM +0300, Jani Nikula wrote: There's still the question whether we can default to using the vbt value if that can be broken... This is a workaround for SDPs loaded with a "def

[Intel-gfx] [PATCH i-g-t] scripts/run-tests.sh: use single combined test list

2015-05-05 Thread Mike Mason
i-g-t now creates a single combined test list for tests with and without subtests. This patch adapts run-tests.sh to that change. Signed-off-by: Mike Mason --- scripts/run-tests.sh | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/scripts/run-tests.sh b/scr

Re: [Intel-gfx] drm/i915: Possible security hole in command parsing

2015-05-05 Thread Rebecca N. Palmer
Repeating those tests[1] on linux-next 20150505 gave the same results, but having seen the intermittent "no window title bar" problem twice more, I now have to consider it a result of my patch[0], and hence withdraw it. However, that doesn't mean there isn't a security proble

Re: [Intel-gfx] [PATCH 7/7] lib: add igt_draw

2015-05-05 Thread Paulo Zanoni
2015-04-07 10:44 GMT-03:00 Daniel Vetter : > On Tue, Apr 07, 2015 at 11:12:09AM +0100, Chris Wilson wrote: >> On Tue, Apr 07, 2015 at 11:07:07AM +0200, Daniel Vetter wrote: >> > On Tue, Apr 07, 2015 at 09:36:37AM +0100, Chris Wilson wrote: >> > > On Tue, Apr 07, 2015 at 10:10:25AM +0200, Daniel Vet

[Intel-gfx] [PATCH igt] tests/kms_fbc_crc: fix debugfs read

2015-05-05 Thread Paulo Zanoni
From: Paulo Zanoni Commit 47f6b1305cc3752f318a555b932e194e1500c1d8 completely broke this test due to the fread() assertion. When we're reading the debugfs file we really don't care about how many bytes we read because the number is not constant and we just use strstr() later. Change the assertion

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Ring frequency table programming changes

2015-05-05 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6320 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH] drm/vblank: Fixup and document timestamp update/read barriers

2015-05-05 Thread Peter Hurley
On 05/05/2015 11:57 AM, Peter Hurley wrote: > On 05/05/2015 11:42 AM, Daniel Vetter wrote: >> I'm also somewhat confused about how you to a line across both cpus for >> barriers because barriers only have cpu-local effects (which is why we >> always need a barrier on both ends of a transaction). I

Re: [Intel-gfx] [PATCH 8/8] drm/i915/skl: gen6+ platforms support runtime PM

2015-05-05 Thread Ville Syrjälä
On Thu, Apr 30, 2015 at 04:39:23PM +0100, Damien Lespiau wrote: > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/i915_drv.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index f637667..25

Re: [Intel-gfx] [PATCH 6/8] drm/i915/skl: Deinit/init the display at suspend/resume

2015-05-05 Thread Ville Syrjälä
On Thu, Apr 30, 2015 at 04:39:21PM +0100, Damien Lespiau wrote: > We need to re-init the display hardware when going out of suspend. This > includes: > > - Hooking the PCH to the reset logic > - Restoring CDCDLK > - Enabling the DDB power > > Among those, only the CDCDLK one is a bit tricky

Re: [Intel-gfx] [PATCH 5/8] drm/i915/skl: Make the Misc I/O power well part of the PLLS domain

2015-05-05 Thread Ville Syrjälä
On Thu, Apr 30, 2015 at 04:39:20PM +0100, Damien Lespiau wrote: > The specs tell us to ungate PG1 and Misc I/O at display init. We'll use > the PLLS power domain to ensure those two power wells are up. > > Signed-off-by: Damien Lespiau Yep, spec does say that. Reviewed-by: Ville Syrjälä > ---

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Merge the GEN9 memory latency PCU opcode with its friends

2015-05-05 Thread Ville Syrjälä
On Thu, Apr 30, 2015 at 04:39:19PM +0100, Damien Lespiau wrote: > Signed-off-by: Damien Lespiau Patches 2,3,4 satisfy my brain's visual pattern matcher. Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/i915_reg.h | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > >

Re: [Intel-gfx] [PATCH 1/8] drm/i915/skl: Add the INIT power domain to the MISC I/O power well

2015-05-05 Thread Ville Syrjälä
On Thu, Apr 30, 2015 at 04:39:16PM +0100, Damien Lespiau wrote: > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/intel_runtime_pm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c > b/drivers/gpu/drm/i915/intel_runti

Re: [Intel-gfx] [PATCH v6 07/14] drm/i915: Add functions to allocate / release gem obj for GuC

2015-05-05 Thread Dave Gordon
On 29/04/15 23:13, yu@intel.com wrote: > From: Alex Dai > > All gem objects used by GuC are pinned to ggtt space out of range > [0, WOPCM size]. In GuC address space mapping, [0, WPOCM size] is > used internally for its Boot ROM, SRAM etc. Currently this WPOCM > size is 512K. This is done by

Re: [Intel-gfx] [PATCH i-g-t 4/4] kms_plane_scaling: Find the image regardless how the test is run

2015-05-05 Thread Konduru, Chandra
> -Original Message- > From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com] > Sent: Tuesday, May 05, 2015 2:53 AM > To: Intel-gfx@lists.freedesktop.org > Cc: Ursulin, Tvrtko; Konduru, Chandra; Wood, Thomas > Subject: [PATCH i-g-t 4/4] kms_plane_scaling: Find the image regardless h

Re: [Intel-gfx] [PATCH] drm/i915/skl: Add module parameter to select edp vswing table

2015-05-05 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6319 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Port PLL programming BUN

2015-05-05 Thread Imre Deak
On ti, 2015-05-05 at 22:14 +0530, Kannan, Vandana wrote: > > On 5/5/2015 9:14 PM, Imre Deak wrote: > > On ma, 2015-05-04 at 20:50 +0530, Vandana Kannan wrote: > >> BUN 1: prop_coeff, int_coeff, tdctargetcnt programming updated and tied to > >> VCO frequencies. Program i_lockthresh in PORT_PLL_9. >

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Port PLL programming BUN

2015-05-05 Thread Kannan, Vandana
On 5/5/2015 9:14 PM, Imre Deak wrote: On ma, 2015-05-04 at 20:50 +0530, Vandana Kannan wrote: BUN 1: prop_coeff, int_coeff, tdctargetcnt programming updated and tied to VCO frequencies. Program i_lockthresh in PORT_PLL_9. VCO calculated based on the formula: Desired Output = Port bit rate in

Re: [Intel-gfx] [PATCH] drm/i195/bxt: Add A1 stepping for Broxton

2015-05-05 Thread Imre Deak
On ti, 2015-05-05 at 15:20 +0100, Nick Hoath wrote: > On 29/04/2015 15:35, Deak, Imre wrote: > > On pe, 2015-03-20 at 09:29 +, Nick Hoath wrote: > >> This stepping isn't listed separately in the specs, so needs confirmation. > >> > >> Signed-off-by: Nick Hoath > >> --- > >> drivers/gpu/drm/i

Re: [Intel-gfx] [Mesa-dev] [PATCH 4/4] i965: Introduce a context-local batch manager

2015-05-05 Thread Emil Velikov
On 1 May 2015 at 15:53, Chris Wilson wrote: > * where is the doubly-linked circular list? IIRC there was some patches from Jason, that move the the gallium one to src/util/list.h [1]. Not sure on the status of it though. On a related note - would be great if one day we nuke the glsl one (exec_no

Re: [Intel-gfx] [PATCH] drm/vblank: Fixup and document timestamp update/read barriers

2015-05-05 Thread Peter Hurley
On 05/05/2015 11:42 AM, Daniel Vetter wrote: > On Tue, May 05, 2015 at 10:36:24AM -0400, Peter Hurley wrote: >> On 05/04/2015 12:52 AM, Mario Kleiner wrote: >>> On 04/16/2015 03:03 PM, Daniel Vetter wrote: On Thu, Apr 16, 2015 at 08:30:55AM -0400, Peter Hurley wrote: > On 04/15/2015 01:31

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Port PLL programming BUN

2015-05-05 Thread Imre Deak
On ma, 2015-05-04 at 20:50 +0530, Vandana Kannan wrote: > BUN 1: prop_coeff, int_coeff, tdctargetcnt programming updated and tied to > VCO frequencies. Program i_lockthresh in PORT_PLL_9. > > VCO calculated based on the formula: > Desired Output = Port bit rate in MHz (DisplayPort HBR2 is 5400 MHz

Re: [Intel-gfx] [PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table

2015-05-05 Thread Daniel Vetter
On Tue, May 05, 2015 at 11:45:05AM +0100, Lee Jones wrote: > This is not how we submit subsequent patch-sets. It is unfortunately how we handle patches on dri-devel&intel-gfx to be able to cope with massive mail load. If everyone who submits to intel-gfx would always resend the entire series for m

Re: [Intel-gfx] [PATCH] drm/vblank: Fixup and document timestamp update/read barriers

2015-05-05 Thread Daniel Vetter
On Tue, May 05, 2015 at 10:36:24AM -0400, Peter Hurley wrote: > On 05/04/2015 12:52 AM, Mario Kleiner wrote: > > On 04/16/2015 03:03 PM, Daniel Vetter wrote: > >> On Thu, Apr 16, 2015 at 08:30:55AM -0400, Peter Hurley wrote: > >>> On 04/15/2015 01:31 PM, Daniel Vetter wrote: > On Wed, Apr 15,

Re: [Intel-gfx] [PATCH] drm/vblank: Fixup and document timestamp update/read barriers

2015-05-05 Thread Peter Hurley
On 05/04/2015 12:52 AM, Mario Kleiner wrote: > On 04/16/2015 03:03 PM, Daniel Vetter wrote: >> On Thu, Apr 16, 2015 at 08:30:55AM -0400, Peter Hurley wrote: >>> On 04/15/2015 01:31 PM, Daniel Vetter wrote: On Wed, Apr 15, 2015 at 09:00:04AM -0400, Peter Hurley wrote: > Hi Daniel, > >>>

Re: [Intel-gfx] [PATCH v9] drm/i915/skl: Add support for SKL background color

2015-05-05 Thread Ville Syrjälä
On Mon, May 04, 2015 at 09:57:17AM +0200, Daniel Vetter wrote: > On Mon, Apr 27, 2015 at 08:33:38PM +, Konduru, Chandra wrote: > > > -Original Message- > > > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > > > Sent: Monday, April 27, 2015 8:28 AM > > > On Fri, Feb 20, 2015

Re: [Intel-gfx] [PATCH] drm/i915/bxt: BLC implementation

2015-05-05 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6318 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH 2/3] drm/i915/bxt: Add WaDisableSbeCacheDispatchPortSharing

2015-05-05 Thread Nick Hoath
On 29/04/2015 13:26, Deak, Imre wrote: On pe, 2015-04-10 at 13:12 +0100, Nick Hoath wrote: Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/i9

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915: Implement WaEnableHDMI8bpcBefore12bpc:snb, ivb

2015-05-05 Thread Jani Nikula
On Tue, 05 May 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > CPT/PPT require a specific procedure for enabling 12bpc HDMI. Implement > it, and to keep things neat pull the code into a function. > > v2: Rebased due to crtc->config changes > s/HDMI_GC/HDMIUNIT_GC/ to match

Re: [Intel-gfx] [PATCH] drm/i195/bxt: Add A1 stepping for Broxton

2015-05-05 Thread Nick Hoath
On 29/04/2015 15:35, Deak, Imre wrote: On pe, 2015-03-20 at 09:29 +, Nick Hoath wrote: This stepping isn't listed separately in the specs, so needs confirmation. Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_drv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 07/12] drm/i915: Write the SDVO reg twice on IBX

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä On IBX the SDVO/HDMI register write may be masked when enabling the port, so it may need to written twice. The HDMI code does this, but the SDVO code does not. Add the workaround to the SDVO code as well. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sdvo.c |

[Intel-gfx] [PATCH 12/12] drm/i915: Disable FDI RX/TX before the ports

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä Bspec says we should disable the FDI RX/TX before disabling the PCH ports. Do so. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/g

[Intel-gfx] [PATCH 08/12] drm/i915: Fix the IBX transcoder B workarounds

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä Currently the IBX transcoder B workarounds are not working correctly. Well, the HDMI one seems to be working somewhat, but the DP one is definitely busted. After a bit of experimentation it looks like the best way to make this work is first disable the port on transcoder B, a

[Intel-gfx] [PATCH 11/12] drm/i915: Disable CRT port after pipe on PCH platforms

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä Follow the BSpec sequence for the CRT port as well on PCH platforms, ie. disable the pipe before the port. Didn't bother looking at DDI in detail yet, so leave that one be even though the CRT is a PCH port there. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH 10/12] drm/i915: Disable SDVO port after the pipe on PCH platforms

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sdvo.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index 4a87691..d24ef75 100644 --- a/driver

[Intel-gfx] [PATCH 06/12] drm/i915: Use POSTING_READ() in intel_sdvo_write_sdvox()

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä Use POSTING_READ() in intel_sdvo_write_sdvox() as appropriate. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sdvo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c

[Intel-gfx] [PATCH 09/12] drm/i915: Disable HDMI port after the pipe on PCH platforms

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä BSpec says we should disable all ports after the pipe on PCH platforms. Do so. Fixes a pipe off timeout on ILK now caused by the transcoder B workaround. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_hdmi.c | 33 + 1 file change

[Intel-gfx] [PATCH 05/12] drm/i915: Fix DP enhanced framing for CPT

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä Currently we're always enabling enhanced framing on CPT even if the sink doesn't support it. Fix this up by actaully looking at what the sink tells us. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 3 +-- drivers/gpu/drm/i915/intel_dp.c | 9 ++

[Intel-gfx] [PATCH 02/12] drm/i915: Remove the double register write from intel_disable_hdmi()

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä IBX can have problems with the first write to the port register getting masked when enabling the port. We are trying to apply the workaround also when disabling the port where it's not needed, and we also try to apply it for CPT/PPT as well which don't need it. Just kill it.

[Intel-gfx] [PATCH 03/12] drm/i915: Clarfify the DP code platform checks

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä intel_dp.c is a mess with all the checks for different platform/PCH variants and ports. Try to clean it up by recognizing the following facts: - IVB port A, and CPT port B/C/D are always the special cases - VLV/CHV don't have port A - Using the same kind of logic everywhere ma

[Intel-gfx] [PATCH 04/12] drm/i915: Clean up the CPT DP .get_hw_state() port readout

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä Define a TRANS_DP_PIPE_TO_PORT() to make the CPT DP .get_hw_state() pipe readout neater. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_dp.c | 26 +- 2 files changed, 6 insertions(+), 21 deletions(

[Intel-gfx] [PATCH 00/12] drm/i915: PCH modeset sequence fixes

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä While fixing up the 12bpc HDMI code I ran afoul of the IBX transcoder B workaround. Turns out that's currently busted. So I fixed it, but that caused the dreaded pipe off timeout to make a reappearance. So to fix that I had to reorganize the crtc disable sequence to actually m

[Intel-gfx] [PATCH 01/12] drm/i915: Remove a bogus 12bpc "toggle" from intel_disable_hdmi()

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä The IBX 12bpc port enable toggle is only relevant when enabling the port, not when disabling it. Also this code doesn't actually toggle anything, and essentially just writes the port register one extra time. Furthermore CPT/PPT don't need such workarounds and yet we include th

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Add missing MacBook Pro models with dual channel LVDS

2015-05-05 Thread Jani Nikula
On Mon, 04 May 2015, Lukas Wunner wrote: > Single channel LVDS maxes out at 112 MHz. The 15" pre-retina models > shipped with 1440x900 (106 MHz) by default or 1680x1050 (119 MHz) > as a BTO option, both versions used dual channel LVDS even though > the smaller one would have fit into a single chan

[Intel-gfx] [PATCH 9/9] drm/i915: Double the port clock when using double clocked modes with 12bpc

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä Currently we're forgetting to double the port clock when using double clocked modes with 12bpc on HDMI. We're only accounting for the 1.5x factor due to the 12bpc. So further double the 1.5x port clock when we have a double clocked mode. Unfortunately I don't have any display

[Intel-gfx] [PATCH 8/9] drm/i915: Fix hdmi clock readout with pixel repeat

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä Account for the pixel multiplier when reading out the HDMI mode dotclock. Makes the state checked happier on my ILK when using double clocked modes. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dri

[Intel-gfx] [PATCH v2 2/9] drm/i915: Send GCP infoframes for deep color HDMI sinks

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä GCP infoframes are required to inform the HDMI sink about the color depth. Send the GCP infoframe whenever the sink supports any deep color modes since such sinks must anyway be capable of receiving them. For sinks that don't support deep color let's skip the GCP in case it m

[Intel-gfx] [PATCH 7/9] drm/i915: Check infoframe state more diligently.

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä Check that the DIP is enabled on the right port on IBX and VLV/CHV as we're doing on g4x, and also check for all the infoframe enable bits on all platforms. Eventually we should track each infoframe type independently, and also their contents. This is a small step in that dir

[Intel-gfx] [PATCH 0/9] drm/i915: HDMI 12bpc fixes

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä Our HDMI 12bpc support has always been broken. This series aims to fix that. The problems addressed include: - missing GCP infoframes entirely - IBX w/a code was mostly nonsense - missing w/a for CPT/PPT - 12bpc vs. DBLCLK was busted Part of this was already posted [1] quite

[Intel-gfx] [PATCH v2 5/9] drm/i915: Fix 12bpc HDMI enable for IBX

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä Follow the procedure listed in Bspec to toggle the port enable bit off and on when enabling HDMI with 12bpc and pixel repeat on IBX. The old code didn't actually enable the port before "toggling" the bit back off, so the whole workaround was essentially a nop. Also take the o

[Intel-gfx] [PATCH v2 4/9] drm/i915: Fix HDMI 12bpc TRANSCONF bpc value

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä IBX BSpec says we must specify 8bpc in TRANSCONF for both 8bpc and 12bpc HDMI output. Do so. v2: Pass intel_crtc to intel_pipe_has_type() Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-)

[Intel-gfx] [PATCH v2 6/9] drm/i915: Disable all infoframes when turning off the HDMI port

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä Currently we just disable the GCP infoframe when turning off the port. That means if the same transcoder is used on a DP port next, we might end up pushing infoframes over DP, which isn't intended. Just disable all the infoframes when turning off the port. Also protect agains

[Intel-gfx] [PATCH v2 3/9] drm/i915: Enable default_phase in GCP when possible

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä When the video timings are suitably aligned so that all different periods start at phase 0 (ie. none of the periods start mid-pixel) we can inform the sink about this. Supposedly the sink can then optimize certain things. Obviously this is only relevant when outputting >8bpc d

[Intel-gfx] [PATCH v2 1/9] drm/i915: Implement WaEnableHDMI8bpcBefore12bpc:snb, ivb

2015-05-05 Thread ville . syrjala
From: Ville Syrjälä CPT/PPT require a specific procedure for enabling 12bpc HDMI. Implement it, and to keep things neat pull the code into a function. v2: Rebased due to crtc->config changes s/HDMI_GC/HDMIUNIT_GC/ to match spec better Factor out intel_enable_hdmi_audio() Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915/skl: Add module parameter to select edp vswing table

2015-05-05 Thread Jani Nikula
On Tue, 05 May 2015, Damien Lespiau wrote: > On Tue, May 05, 2015 at 02:39:48PM +0300, Jani Nikula wrote: >> There's still the question whether we can default to using the vbt value >> if that can be broken... > > This is a workaround for SDPs loaded with a "default" VBT which doesn't > correspond

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Implement the intel_dp_autotest_edid function for DP EDID complaince tests

2015-05-05 Thread Jani Nikula
On Mon, 04 May 2015, Daniel Vetter wrote: > On Thu, Apr 30, 2015 at 03:30:10PM -0300, Paulo Zanoni wrote: >> 2015-04-18 4:04 GMT-03:00 Todd Previte : >> > Updates the EDID compliance test function to perform the analyze and react >> > to >> > the EDID data read as a result of a hot plug event. Th

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: there is no audio on port A on non-DDI platforms

2015-05-05 Thread Sivakumar Thulasimani
missed the changes attached. so adding rb tag Reviewed-by: Sivakumar Thulasimani On 5/5/2015 7:02 PM, Jani Nikula wrote: On Tue, 05 May 2015, Sivakumar Thulasimani wrote: two points 1) The eDP spec says Audio is optional so it is allowed to have audio, but i am yet to come across any eDP p

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: there is no audio on port A on non-DDI platforms

2015-05-05 Thread Sivakumar Thulasimani
sure, you can check for port A alone then. DDI A will have edp in all SKUs so checking for eDP should ideally be the same as DDIA. On 5/5/2015 7:02 PM, Jani Nikula wrote: On Tue, 05 May 2015, Sivakumar Thulasimani wrote: two points 1) The eDP spec says Audio is optional so it is allowed to h

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: there is no audio on port A on non-DDI platforms

2015-05-05 Thread Jani Nikula
On Tue, 05 May 2015, Sivakumar Thulasimani wrote: > two points > 1) The eDP spec says Audio is optional so it is allowed to have audio, > but i am yet to come across any eDP panel that supports Audio. > 2) Also, there is no support for audio in DDI A port as well :) > > So please change the chec

Re: [Intel-gfx] [PATCH] drm/i915/skl: Add module parameter to select edp vswing table

2015-05-05 Thread Damien Lespiau
On Tue, May 05, 2015 at 02:39:48PM +0300, Jani Nikula wrote: > There's still the question whether we can default to using the vbt value > if that can be broken... This is a workaround for SDPs loaded with a "default" VBT which doesn't correspond to the full fleet of SPDs. For actual product, it's

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Add support for getting size of the stolen region

2015-05-05 Thread Chris Wilson
On Tue, May 05, 2015 at 05:12:25PM +0530, Ankitprasad Sharma wrote: > On Wed, 2015-04-29 at 11:27 +0100, Chris Wilson wrote: > > On Wed, Apr 29, 2015 at 03:01:59PM +0530, ankitprasad.r.sha...@intel.com > > wrote: > > > From: Ankitprasad Sharma > > > > > > This patch extends the get_aperture_ioct

Re: [Intel-gfx] [PATCH v6 13/14] drm/i915: Enable GuC firmware log

2015-05-05 Thread Dave Gordon
On 29/04/15 23:13, yu@intel.com wrote: > From: Alex Dai > > Allocate a gem obj to hold GuC log data. Also a debugfs interface > (i915_guc_log_dump) is provided to print out the log content. > > Issue: VIZ-4884 > Signed-off-by: Alex Dai > --- > drivers/gpu/drm/i915/i915_debugfs.c | 41 +

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: there is no audio on port A on non-DDI platforms

2015-05-05 Thread Sivakumar Thulasimani
two points 1) The eDP spec says Audio is optional so it is allowed to have audio, but i am yet to come across any eDP panel that supports Audio. 2) Also, there is no support for audio in DDI A port as well :) So please change the check to if (!is_edp(encoder)) On 5/5/2015 2:39 PM, Jani Nikula

Re: [Intel-gfx] [PATCH] drm/i915: Store device pointer in contexts for late tracepoint usafe

2015-05-05 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6317 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Add support for getting size of the stolen region

2015-05-05 Thread Ankitprasad Sharma
On Wed, 2015-04-29 at 11:27 +0100, Chris Wilson wrote: > On Wed, Apr 29, 2015 at 03:01:59PM +0530, ankitprasad.r.sha...@intel.com > wrote: > > From: Ankitprasad Sharma > > > > This patch extends the get_aperture_ioctl to add support > > for getting total size of the stolen region and available >

Re: [Intel-gfx] [PATCH] drm/i915/skl: Add module parameter to select edp vswing table

2015-05-05 Thread Jani Nikula
On Tue, 05 May 2015, Sonika Jindal wrote: > This provides an option to override the value set by VBT > for selecting edp Vswing Pre-emph setting table. > > https://bugs.freedesktop.org/show_bug.cgi?id=89554 > Signed-off-by: Sonika Jindal > --- > drivers/gpu/drm/i915/i915_drv.h|4 +++- >

Re: [Intel-gfx] [PATCH] drm/i915/bxt: BLC implementation

2015-05-05 Thread Jani Nikula
On Tue, 05 May 2015, Vandana Kannan wrote: > Enabling BLC on BXT. > Includes register definition, and new functions for BXT. > > In BXT, there are 2 sets of registers for BLC. Until there is clarity > about which set would be effective, set 1 is being used. > This would have to be re-visited if th

Re: [Intel-gfx] [PATCH v3] drm/i915: Add missing MacBook Pro models with dual channel LVDS

2015-05-05 Thread Jani Nikula
On Mon, 04 May 2015, Lukas Wunner wrote: > Hi Ville, > >> I would suggest splitting that into a separate patch. Otherwise it's >> going to harder to revert either change separately, should the need >> arise. So that part is >> Reviewed-by: Ville Syrjälä > > Okay, commit split in two as requested.

[Intel-gfx] [PATCH 1/2] drm/i915/skl: Retrieve the Rpe value from Pcode

2015-05-05 Thread akash . goel
From: Akash Goel Read the efficient frequency (aka RPe) value through the the mailbox command (0x1A) from the pcode, as done on Haswell and Broadwell. The turbo minimum frequency softlimit is not revised as per the efficient frequency value. Issue: VIZ-5143 Signed-off-by: Akash Goel --- driver

[Intel-gfx] [PATCH 2/2] drm/i915/skl: Ring frequency table programming changes

2015-05-05 Thread akash . goel
From: Akash Goel Ring frequency table programming changes for SKL. No need for a floor on ring frequency, as the issue of performance impact with ring running below DDR frequency, is believed to be fixed on SKL Issue: VIZ-5144 Signed-off-by: Akash Goel --- drivers/gpu/drm/i915/intel_pm.c | 26

Re: [Intel-gfx] [PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table

2015-05-05 Thread Lee Jones
This is not how we submit subsequent patch-sets. Please submit them as a whole, seperately from the first submission and with versioning information i.e. [PATCH v2 X/Y] Stuff ... > In case we unload and load a driver module again that is registering a > lookup table, without this it will result i

Re: [Intel-gfx] [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM

2015-05-05 Thread Lee Jones
On Tue, 05 May 2015, Shobhit Kumar wrote: > On 04/29/2015 07:54 PM, Lee Jones wrote: > > On Wed, 29 Apr 2015, Shobhit Kumar wrote: > > > >> On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup > >> entry for the same to be used by the consumer (Intel GFX) > >> > >> v2: Remove t

Re: [Intel-gfx] [PATCH] drm/i915: CD clock frequency to debugfs

2015-05-05 Thread Mika Kahola
On Mon, 2015-05-04 at 16:18 +0200, Daniel Vetter wrote: > On Fri, Apr 24, 2015 at 11:06:10AM +0300, Mika Kahola wrote: > > This patch adds information on current CD clock > > frequency to debugfs i915_frequency_info > > > > Signed-off-by: Mika Kahola > > --- > > drivers/gpu/drm/i915/i915_debugfs

Re: [Intel-gfx] [PATCH i-g-t v2] man: add man page for intel_reg in reStructured text format

2015-05-05 Thread Jani Nikula
On Mon, 04 May 2015, Daniel Vetter wrote: > On Tue, Apr 28, 2015 at 03:30:54PM +0300, Jani Nikula wrote: >> Produce the intel_reg man page from rst using rst2man. Also facilitate >> writing any man page in reStructured text, as long as rst2man is >> available. >> >> v2: configure check for rst2ma

Re: [Intel-gfx] [PATCH i-g-t 01/10] lib: add 16 and 8 bit versions of INREG and OUTREG

2015-05-05 Thread Jani Nikula
On Mon, 04 May 2015, Daniel Vetter wrote: > On Tue, Apr 28, 2015 at 03:04:26PM +0300, Jani Nikula wrote: >> Signed-off-by: Jani Nikula >> --- >> lib/intel_io.h | 4 >> lib/intel_mmio.c | 24 >> 2 files changed, 28 insertions(+) >> >> diff --git a/lib/intel_io.h

[Intel-gfx] [PATCH] drm/i915/skl: Add module parameter to select edp vswing table

2015-05-05 Thread Sonika Jindal
This provides an option to override the value set by VBT for selecting edp Vswing Pre-emph setting table. https://bugs.freedesktop.org/show_bug.cgi?id=89554 Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/i915_drv.h|4 +++- drivers/gpu/drm/i915/i915_params.c |7 +++ drivers

[Intel-gfx] [PATCH v2 i-g-t 1/4] igt_kms: Avoid NULL ptr deref when commiting disabled planes

2015-05-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I think; commit a26f9f9ad0e679c7ce413a25d34f6914e1174151 Author: chandra konduru Date: Mon Mar 30 13:52:04 2015 -0700 i-g-t: Adding plane scaling test case introduced a condition where it attempts to update a disabled plane because of the newly introduce

[Intel-gfx] [PATCH i-g-t 2/4] igt_kms: Merge condition in igt_plane_set_fb

2015-05-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin There were two paths for fb and !fb. Signed-off-by: Tvrtko Ursulin Cc: chandra konduru Cc: Thomas Wood --- lib/igt_kms.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 33d437d..b5ba273 100644 --- a/lib/

[Intel-gfx] [PATCH i-g-t 3/4] igt_kms: Do not reset plane position on assigning a fb

2015-05-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin commit a26f9f9ad0e679c7ce413a25d34f6914e1174151 Author: chandra konduru Date: Mon Mar 30 13:52:04 2015 -0700 i-g-t: Adding plane scaling test case Started doing this and broke kms_rotation_crc. Signed-off-by: Tvrtko Ursulin Cc: chandra konduru ---

[Intel-gfx] [PATCH i-g-t 4/4] kms_plane_scaling: Find the image regardless how the test is run

2015-05-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As it stands running the test like "sudo tests/kms_plane_scaling" does not work. Fix it by using the same method igt_paint_image uses. v2: Export Cairo read callback instead of duplicating it. (Thomas Wood) Signed-off-by: Tvrtko Ursulin Cc: chandra konduru Cc: Thomas Woo

Re: [Intel-gfx] [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM

2015-05-05 Thread Shobhit Kumar
On 04/29/2015 07:54 PM, Lee Jones wrote: > On Wed, 29 Apr 2015, Shobhit Kumar wrote: > >> On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup >> entry for the same to be used by the consumer (Intel GFX) >> >> v2: Remove the lookup table on driver unload (Thierry) >> >> CC: Samu

[Intel-gfx] [PATCH 5/8] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM

2015-05-05 Thread Shobhit Kumar
On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup entry for the same to be used by the consumer (Intel GFX) v2: Remove the lookup table on driver unload (Thierry) v3: Correct the subject line (Lee jones) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierr

[Intel-gfx] [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-05-05 Thread Shobhit Kumar
The Crystalcove PMIC controls PWM signals and this driver exports that capability as a PWM chip driver. This is platform device implementtaion of the drivers/mfd cell device for CRC PMIC v2: Use the existing config callback with duty_ns and period_ns(Thierry) v3: Correct the subject line (Lee jon

[Intel-gfx] [PATCH 3/8] mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal

2015-05-05 Thread Shobhit Kumar
On some Intel SoC platforms, the panel enable/disable signals are controlled by CRC PMIC. Add those control as a new GPIO in a lookup table for gpio-crystalcove chip during CRC driver load v2: Make the lookup table static (Thierry) Remove the lookup table during driver remove (Thierry) v3: Co

[Intel-gfx] [PATCH 4/8] mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC

2015-05-05 Thread Shobhit Kumar
Needed for PWM control suuported by the PMIC v2: Correct the subject line (Lee jones) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Acked-by: Lee Jones Signed-off-by: Shobhit Kumar --- drivers/mfd/intel_soc_pmic_crc.c | 3 +++ 1 file changed, 3 insertions(+)

[Intel-gfx] [PATCH 2/8] pwm: core: Add support to remove registered consumer lookup tables

2015-05-05 Thread Shobhit Kumar
In case some drivers are unloading, they can remove lookup tables which they would have registered during their load time to avoid redundant entries if loaded again v2: Ccing maintainers v3: Correct the subject line (Lee jones) CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thier

[Intel-gfx] [PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table

2015-05-05 Thread Shobhit Kumar
In case we unload and load a driver module again that is registering a lookup table, without this it will result in multiple entries. Provide an option to remove the lookup table on driver unload v2: Ccing maintainers v3: Correct the subject line (Lee jones) Cc: Samuel Ortiz Cc: Linus Walleij C

Re: [Intel-gfx] [PATCH v2 5/5] drm/i915: Use partial view in mmap fault handler

2015-05-05 Thread Tvrtko Ursulin
On 05/04/2015 12:51 PM, Joonas Lahtinen wrote: On to, 2015-04-30 at 15:54 +0100, Tvrtko Ursulin wrote: On 04/30/2015 12:21 PM, Joonas Lahtinen wrote: Use partial view for huge BOs (bigger than the mappable aperture) in fault handler so that they can be accessed without trying to make room for

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: there is no audio on port A on non-DDI platforms

2015-05-05 Thread Jani Nikula
On Tue, 05 May 2015, Sivakumar Thulasimani wrote: > On 5/4/2015 7:50 PM, Jani Nikula wrote: >> The eDP port A register on PCH split platforms has a slightly different >> register layout from the other ports, with bit 6 being either alternate >> scrambler reset or reserved, depending on the genera

[Intel-gfx] [PATCH] drm/i915/bxt: BLC implementation

2015-05-05 Thread Vandana Kannan
Enabling BLC on BXT. Includes register definition, and new functions for BXT. In BXT, there are 2 sets of registers for BLC. Until there is clarity about which set would be effective, set 1 is being used. This would have to be re-visited if there is any change or when 2 LFPs are enabled on BXT. T

[Intel-gfx] [PATCH 3/6] intel: Export raw GEM mmap interfaces

2015-05-05 Thread Chris Wilson
Export a set of interfaces to allow the caller to have precise control over mapping the buffer - but still provide caching of the mmaps between callers. Signed-off-by: Chris Wilson --- intel/intel_bufmgr.h | 4 ++ intel/intel_bufmgr_gem.c | 148 +

[Intel-gfx] [PATCH 2/6] intel: Use WAIT for wait-rendering

2015-05-05 Thread Chris Wilson
Using WAIT is preferrable to SET_DOMAIN as it doesn't have any domain management side-effects - but has the same flushing semantics. Signed-off-by: Chris Wilson Cc: Daniel Vetter --- intel/intel_bufmgr_gem.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/intel/intel_buf

[Intel-gfx] [PATCH 6/6] intel: Keep live buffers in the cache

2015-05-05 Thread Chris Wilson
If the GPU is still processing the buffers, then keep them alive as the pages are still pinned and hot - ripe for reuse. Signed-off-by: Chris Wilson --- intel/intel_bufmgr_gem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c index 22f75

[Intel-gfx] [PATCH 1/6] intel: Defer setting madv on the bo cache

2015-05-05 Thread Chris Wilson
Convert the bo-cache into 2 phases: 1. A two second cache of recently used buffers, keep untouched. 2. A two second cache of older buffers, marked for eviction. This helps reduce ioctl traffic on a rapid turnover in working sets. The issue is that even a 2 second window is enough for an applicati

[Intel-gfx] [PATCH 5/6] intel: Round large allocations upto PAGE_SIZE

2015-05-05 Thread Chris Wilson
The kernel interface requires us to request only PAGE_SIZE aligned buffers, so make sure that all allocation requests are indeed sized correctly (and in the process remove the excess calls to getpagesize()). Signed-off-by: Chris Wilson --- intel/intel_bufmgr_gem.c | 14 -- 1 file cha

[Intel-gfx] [PATCH 4/6] intel: Keep the caches in loose active order

2015-05-05 Thread Chris Wilson
Though we don't have precise tracking for when buffers in the cache list become idle (we don't have request tracking at this layer), we do have some basic assumptions that the head is inactive and the tail active. So when inserting buffers in the cache, it would be good not to completely ignore tho

[Intel-gfx] [PATCH] drm/i915: Store device pointer in contexts for late tracepoint usafe

2015-05-05 Thread Chris Wilson
[ 1572.417121] BUG: unable to handle kernel NULL pointer dereference at (null) [ 1572.421010] IP: [] ftrace_raw_event_i915_context+0x5d/0x70 [i915] [ 1572.424970] PGD 1766a3067 PUD 1767a2067 PMD 0 [ 1572.428892] Oops: [#1] SMP [ 1572.432787] Modules linked in: ipv6 dm_mod iTCO_wdt

Re: [Intel-gfx] [PATCH v3] drm/i915: Setup static bias for GPU

2015-05-05 Thread Deepak S
On Monday 04 May 2015 08:58 PM, Ville Syrjälä wrote: On Mon, May 04, 2015 at 10:12:23AM +0200, Daniel Vetter wrote: On Mon, May 04, 2015 at 10:58:02AM +0530, Deepak S wrote: On Wednesday 29 April 2015 02:59 PM, Ville Syrjälä wrote: On Wed, Apr 29, 2015 at 08:36:24AM +0530, deepa...@linux.in

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid GPU hang when coming out of S3 or S4

2015-05-05 Thread S, Deepak
I agree Daniel. We need two patches here, 1) moving the enabling of the interrupts early on. 2) split the WA initialization into GT & Display and move GT workarounds before ring init. Thanks Deepak -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Dan

  1   2   >