On 4/21/2015 5:24 PM, Tvrtko Ursulin wrote:
Hi,
On 04/07/2015 09:29 AM, Sonika Jindal wrote:
Adding 90/270 rotation testcase for primary and sprite planes.
v2: Added position test for sprite. Checking for gen > 9 for 90/270.
Some cleanup and rebase.
v3: Added test for unsupported tiling and
So I just go the appended NULL pointer de-reference when trying to
look at a video from my GoPro.
The code disassembles to
0: 81 fb 00 04 00 00 cmp$0x400,%ebx
6: 41 89 07 mov%eax,(%r15)
9: 74 78 je 0x83
b: 48 8d 7c 24 18 lea0x18(%r
On Tue, Apr 21, 2015 at 11:07 AM, Linus Torvalds
wrote:
> Hmm. The odd Intel PCI resource mess is back.
>
> Or maybe it never went away.
>
> I get these when suspending. Things *work*, but it's really spamming
> my logs a fair bit:
>
> i915 :00:02.0: BAR 6: [??? 0x flags 0x2] has bog
On Tue, Apr 21, 2015 at 06:23:52PM +0100, Dave Gordon wrote:
> On 20/04/15 21:33, Chris Wilson wrote:
> > On Mon, Apr 20, 2015 at 01:09:18PM -0700, Yu Dai wrote:
> >>
> >> On 04/20/2015 12:52 PM, Chris Wilson wrote:
> >>> On Mon, Apr 20, 2015 at 09:02:20AM -0700, Yu Dai wrote:
>
> On 04/1
On 21/04/15 19:41, Dave Gordon wrote:
> On 17/04/15 22:21, yu@intel.com wrote:
>> From: "Michael H. Nguyen"
>>
>> i915_gem_object_write() is a generic function to copy data from
>> user memory to gem object.
>>
>> Issue: VIZ-4884
>> Signed-off-by: Alex Dai
>> ---
>> drivers/gpu/drm/i915/i915
On 17/04/15 22:21, yu@intel.com wrote:
> From: "Michael H. Nguyen"
>
> i915_gem_object_write() is a generic function to copy data from
> user memory to gem object.
>
> Issue: VIZ-4884
> Signed-off-by: Alex Dai
> ---
> drivers/gpu/drm/i915/i915_drv.h | 3 +++
> drivers/gpu/drm/i915/i915_ge
Displayport compliance test 4.2.2.6 requires that a source device be capable of
detecting a corrupt EDID. The test specification states that the sink device
sets up the EDID with an invalid checksum. To do this, the sink sets up an
invalid EDID header, expecting the source device to generate the ch
On 20/04/15 21:33, Chris Wilson wrote:
> On Mon, Apr 20, 2015 at 01:09:18PM -0700, Yu Dai wrote:
>>
>> On 04/20/2015 12:52 PM, Chris Wilson wrote:
>>> On Mon, Apr 20, 2015 at 09:02:20AM -0700, Yu Dai wrote:
On 04/18/2015 06:47 AM, Chris Wilson wrote:
> On Fri, Apr 17, 2015 at 02:21:12
On Tue, Apr 21, 2015 at 9:49 AM, Dmitry Torokhov
wrote:
> The hardware, according to the specs, is limited to 256 byte transfers,
> and current driver has no protections in case users attempt to do larger
> transfers. The code will just stomp over status register and mayhem
> ensues.
Thanks, look
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact:
shuang...@intel.com)
Task id: 6244
-Summary-
Platform Delta drm-intel-nightly Series Applied
PNV
The hardware, according to the specs, is limited to 256 byte transfers,
and current driver has no protections in case users attempt to do larger
transfers. The code will just stomp over status register and mayhem
ensues.
Let's split larger transfers into digestable chunks. Doing this allows
Atmel
On Tue, Apr 21, 2015 at 12:24 AM, Chris Wilson wrote:
>
> Though I am tempted to say we should impose the 256 byte limit for
> stable@
If the docs say 256, I'd suggest using that not just for stable, but
for anything. Maybe 511 bytes work everywhere and the docs are just
wrong. And maybe it doesn
From: Tim Gore
Attempting to build IGT on linux without libunwind fails
due to tools/quick_dump not linking the rt library,
causing an undefined symbol error for clock_gettime.
Adding -lrt to the list of libraries in Makefile.am fixes
this.
Signed-off-by: Tim Gore
---
tools/quick_dump/Makefile
Hmm. The odd Intel PCI resource mess is back.
Or maybe it never went away.
I get these when suspending. Things *work*, but it's really spamming
my logs a fair bit:
i915 :00:02.0: BAR 6: [??? 0x flags 0x2] has bogus alignment
pci_bus :01: Allocating resources
pci_bus :02
Op 21-04-15 om 16:12 schreef Ander Conselvan de Oliveira:
> Hi,
>
> This patch series changes the legacy modeset path to be a lot more
> atomic like. Among other things, it
>
> - unifies the flip-only and the modeset path;
> - implements a full state swap as part of the modeset;
> - gets rid of
Hi,
On 21 April 2015 at 16:03, Micah Fedke wrote:
> + * drm_open_any_any:
> + *
> + * Literally the worst-named function I've ever written.
And I stand by this. This is really an RFC, partly to find out whether
it would be better to find a new name for these functions (open a
modeset-capable DRM
From: Daniel Stone
Don't restrict ourselves to just i915; open any device we see. Allows
non-Intel-specific tests to run on ARM hardware.
Signed-off-by: Daniel Stone
---
tests/core_get_client_auth.c | 6 +++---
tests/core_getclient.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(
These patches add support for non-intel GPUs to i-g-t. The getclient and
get_client_auth tests are implemented.
Daniel Stone (3):
drmtest: Add non-i915 device open helpers
tests: core: Open any DRM device
drm-lib: Skip test when not running on i915
lib/drmtest.c| 139 +
From: Daniel Stone
Since drm_lib.sh tries to access the i915 debugfs path, skip the test if
we find that we have GPUs in debugfs, but none of them are i915.
Signed-off-by: Daniel Stone
---
tests/drm_lib.sh | 9 +
1 file changed, 9 insertions(+)
diff --git a/tests/drm_lib.sh b/tests/dr
From: Daniel Stone
Add helpers which will open a device which may or may not be i915 to
test on.
Signed-off-by: Daniel Stone
---
lib/drmtest.c | 139 ++
lib/drmtest.h | 6 ++-
tests/gem_alive.c | 2 +-
3 files changed, 125 inserti
Use the helpers introduced by the commit below to properly initialize
the duplicated states.
commit f5e7840b0c4368f8cdbb055188c2a0eef50c3052
Author: Thierry Reding
Date: Wed Jan 28 14:54:32 2015 +0100
drm/atomic: Add helpers for state-subclassing drivers
Signed-off-by: Ander Conselvan de
Use the similar fields in crtc_state instead, so that this code can be
moved to our future implementation of atomic_check().
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 66 +++-
1 file changed, 34 insertions(+), 32 deleti
When a new pipe_config is calculated, the fields related to shared dplls
are reset, under the assumption that they will be recalculated as part
of the modeset, which is true with the current state of the code.
As we convert to atomic, however, it will be possible to calculate a new
pipe_config and
Set the mode_changed field on the crtc_states and use that instead.
Note that even though this patch doesn't completely replace the logic in
intel_modeset_affected_pipes(), that logic was never fully used to its
full extent. Since the commit mentioned below, modeset_pipes and
prepare_pipes would o
Now that we do proper state swaps, we don't depend on this function
anymore to keep the state in sync.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel
The modeset code is now properly divided in two phases, so that it only
changes hardware state if it succeeds, so there's no ill-effect that
needs to be undone on failure anymore.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 48 --
Hi,
This patch series changes the legacy modeset path to be a lot more
atomic like. Among other things, it
- unifies the flip-only and the modeset path;
- implements a full state swap as part of the modeset;
- gets rid of the recovery logic in case of a failed modeset;
- replaces some i915 fu
From: Maarten Lankhorst
Some of the flags that were used are still useful when transitioning
to atomic, so keep those around for now. This removes some of the
complications of crtc->primary_enabled, making it easier to remove.
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ander Conselvan de Oli
Add a helper function to make the code slightly more readable.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 44 ++--
1 file changed, 27 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/d
With the current implementation of intel_modeset_affected_pipes(), if a
pipe will be enabled then it is in modeset_pipes. We'll remove that mask
in a follow up patch, but want to preserve this behavior, so just make
that explicit.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i
We don't need to pass it down the call chain anymore now that the plane
state is set up properly.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_
The remaining parts of the failure path could only be reached if the
allocation of crtc_state_copy would fail. In that case, there is nothing
to undo, so just get rid of the label for error handling and return an
error code immediately.
We also always allocate a pipe_config, even if the pipe is be
Use the atomic state instead.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 49 ++--
1 file changed, 25 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display
From: Maarten Lankhorst
This allows disabling all planes affecting a crtc without caring what type it
is.
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/i915_drv.h | 5 ++
drivers/gpu/drm/i915/intel_display.c | 91 ++--
So the i915 driver can use the same logic for setting mode and active
changed flags, without having to implement encoder helpers and the
mode_fixup() callback.
Cc: dri-de...@lists.freedestkop.org
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/drm_atomic_helper.c | 5 +
1 fil
Replace the drivers own logic for computing mode_changed, active_changed
and planes_changed flags with the check_modeset() atomic helper. Since
that function needs to compare the crtc's new mode with the current,
this patch also moves the set up of crtc_state->mode earlier in the call
chain.
Note
Replace the commit output state function with a simple swap of states.
Note that we still need to reconcile the legacy state after the swap,
since there are still code that relies on those.
Also note that even though changes to the state of a crtc different than
the one passed as an argument to __
In a follow up patch the function that computes mode changes will be
replaced with the one from the atomic helpers. To preserve the behavior
of legacy modeset forcing DPMS on, that function will need to detect a
change in the active state of the crtc, so that has to be kept up to
date.
Signed-off-
Call intel_set_mode() uncondionally from intel_crtc_set_config(), since
the former function is now properly wired to ignore all the modesets if
the mode_changed and active_changed flags are false in crtc_state.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c
To match the behavior of ->atomic_commit().
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
in
This is no longer necessary since we only update the staged config on
successfull modeset. The new configuration is stored in an atomic state
struct which is freed in case of failure.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 113 ++---
The logic that stages the state before the modeset was still updating
first the old staged config and then populating the atomic state based
on that. Change this to use only the atomic state.
Note that now the staged config is updated in the function
intel_modeset_commit_output_state(). This is do
Use lower level calls to better integrate with the modeset code and
allow a full state swap in a follow up patch.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 47 +++-
1 file changed, 25 insertions(+), 22 deletions(-)
dif
Add the primary plane state to the legacy modeset atomic state and use
it when configuring the primary plane in __intel_set_mode(). This is a
first step towards merging the flip path in intel_crtc_set_config() and
__intel_set_mode().
v2: Set crtc to NULL if fb is NULL. (Maarten)
Signed-off-by: An
The code in intel_modeset_pipe_config() still needs changes before it
can calculate more than just one pipe_config, and pretending it can will
only make those changes more difficult.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 45 +++
The first function calls done in that function can still cause changes
to the atomic state and may fail. This should eventually be part of our
atomic check function, while the rest of the code in __intel_set_mode()
is the commit hook. So this makes the legacy mode set more atomic-y.
Signed-off-by:
The function intel_modeset_compute_config() needs to eventually become
part of atomic_check(). At that point, all the affected crtcs need to be
in the atomic state with the new values. So move the logic of adding
crtc states out of that function.
v2: Set crtc_state->enable in all cases. (Ander)
S
There's no way that function can fail after it sets crtc->mode anymore,
so there's no need to save the old mode for the failure case.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/gpu/d
This should make the conversion to atomic easier, by splitting the
initialization of the atomic state from the logic that decides if a
modeset is needed.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 73
1 file changed
From: Maarten Lankhorst
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 50
drivers/gpu/drm/i915/intel_drv.h | 1 -
drivers/gpu/drm/i915/intel_fbc.c | 2 +-
3 files changed, 29 i
This is not necessary after the below commit.
commit a0211bb482c346820506c546a6a58b8357999a99
Author: Ander Conselvan de Oliveira
Date: Mon Mar 30 14:05:43 2015 +0300
drm/atomic: Don't try to free a NULL state
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_di
From: Maarten Lankhorst
This makes disabling planes more explicit.
Signed-off-by: Maarten Lankhorst
[anderco: fixed warning due to using drm_crtc instead of intel_crtc]
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/i915_debugfs.c | 6 ++---
drivers/gpu/drm/i915/intel_
Simplifies looping over connector states a bit.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_ddi.c | 9 +++--
drivers/gpu/drm/i915/intel_display.c | 72 +++-
drivers/gpu/drm/i915/intel_dp_mst.c | 13 ---
drivers/gpu/drm/i915
From: Maarten Lankhorst
They're the same code, so why not?
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 158 ++-
drivers/gpu/drm/i915/intel_drv.h | 2 -
drivers/gpu/drm/i915/intel_spr
From: Maarten Lankhorst
To make it clear that it isn't called during crtc enable.
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/
From: Maarten Lankhorst
This is used by the next commit to disable all planes on a crtc
without caring what type it is.
Signed-off-by: Maarten Lankhorst
Reviewed-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 38 +---
drivers/gpu/drm
From: Tim Gore
In android mmap64 was redirected to mmap2 because mmap64
was not alway available. But now mmap2 has been removed
from 64 bit android builds (and mmap64 is available), so
update preprocessor conditional to check for __x86_64__.
Signed-off-by: Tim Gore
---
lib/drmtest.h | 2 +-
1
Daniel Vetter writes:
> We have this neat abstraction between ppgtt and ggtt for (un)bind_vma
> and didn't end up using it really. What a shame, so fix this and make
> the ->bind_vma hook a bit more useful.
>
> Signed-off-by: Daniel Vetter
This one I had problems with applying. But it looks sim
Daniel Vetter writes:
> Currently we have the problem that the decision whether ptes need to
> be (re)written is splattered all over the codebase. Move all that into
> i915_vma_bind. This needs a few changes:
> - Just reuse the PIN_* flags for i915_vma_bind and do the conversion
> to vma->bound
From: Tvrtko Ursulin
It would require watermark reprogramming which we do not want to do.
Signed-off-by: Tvrtko Ursulin
Cc: Daniel Vetter
Cc: Sonika Jindal
Cc: Damien Lespiau
Cc: Chris Wilson
---
Why do we not want to reprogram wms?
This doesn't do anything about rotation. I don't see how
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact:
shuang...@intel.com)
Task id: 6243
-Summary-
Platform Delta drm-intel-nightly Series Applied
PNV
On 04/21/2015 11:07 AM, Chris Wilson wrote:
On Tue, Apr 21, 2015 at 11:01:03AM +0100, Tvrtko Ursulin wrote:
Hi,
On 04/21/2015 10:51 AM, Chris Wilson wrote:
On Tue, Apr 21, 2015 at 10:29:52AM +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Avoids duplicating the code.
Signed-off-by: Tvr
Hi,
On 04/07/2015 09:29 AM, Sonika Jindal wrote:
Adding 90/270 rotation testcase for primary and sprite planes.
v2: Added position test for sprite. Checking for gen > 9 for 90/270.
Some cleanup and rebase.
v3: Added test for unsupported tiling and unsupported pixel format for 90/270
Signed-of
On 04/07/2015 09:29 AM, Sonika Jindal wrote:
Return the return value of the set_property ioctl and add check for
the failure.
Signed-off-by: Sonika Jindal
---
lib/igt_kms.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 6cb1
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact:
shuang...@intel.com)
Task id: 6242
-Summary-
Platform Delta drm-intel-nightly Series Applied
PNV
On Tue, Apr 21, 2015 at 11:01:03AM +0100, Tvrtko Ursulin wrote:
>
> Hi,
>
> On 04/21/2015 10:51 AM, Chris Wilson wrote:
> >On Tue, Apr 21, 2015 at 10:29:52AM +0100, Tvrtko Ursulin wrote:
> >>From: Tvrtko Ursulin
> >>
> >>Avoids duplicating the code.
> >>
> >>Signed-off-by: Tvrtko Ursulin
> >>Cc
Avoid having to escape certain characters in documentation comments by
not allowing docbook markup tags. Markdown formatting in documentation
comments is still supported.
Signed-off-by: Thomas Wood
---
docs/reference/intel-gpu-tools/Makefile.am | 2 +-
lib/igt_aux.c
Hi,
On 04/21/2015 10:51 AM, Chris Wilson wrote:
On Tue, Apr 21, 2015 at 10:29:52AM +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Avoids duplicating the code.
Signed-off-by: Tvrtko Ursulin
Cc: Daniel Vetter
Cc: Sonika Jindal
Cc: Damien Lespiau
---
Can we do this?
Sure, but I'd like
On Tue, Apr 21, 2015 at 10:29:52AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Avoids duplicating the code.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Daniel Vetter
> Cc: Sonika Jindal
> Cc: Damien Lespiau
> ---
> Can we do this?
Sure, but I'd like to see update_primary_plane split
From: Tvrtko Ursulin
Avoids duplicating the code.
Signed-off-by: Tvrtko Ursulin
Cc: Daniel Vetter
Cc: Sonika Jindal
Cc: Damien Lespiau
---
Can we do this?
---
drivers/gpu/drm/i915/intel_display.c | 44
1 file changed, 4 insertions(+), 40 deletions(-)
di
On 04/21/2015 05:55 AM, Jindal, Sonika wrote:
On 4/20/2015 11:14 PM, Daniel Vetter wrote:
On Mon, Apr 20, 2015 at 05:38:20PM +0100, Tvrtko Ursulin wrote:
On 04/20/2015 05:22 PM, Daniel Vetter wrote:
On Mon, Apr 20, 2015 at 04:22:48PM +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Add Y
Daniel Vetter writes:
> On Fri, Apr 17, 2015 at 04:49:18PM +0300, Mika Kuoppala wrote:
>> Daniel Vetter writes:
>>
>> > On Tue, Apr 14, 2015 at 06:53:41PM +0100, Chris Wilson wrote:
>> >> On Tue, Apr 14, 2015 at 07:11:25PM +0200, Daniel Vetter wrote:
>> >> > On Tue, Apr 14, 2015 at 05:06:36PM +
On Mon, Apr 20, 2015 at 03:11:16PM -0700, Dmitry Torokhov wrote:
> The hardware is limited to 2^9 - 1 (511) bytes transfers, and current
> driver has no protections in case users attempt to do larger transfers.
> The code will just stomp over status register and mayhem ensues.
Interesting. The spe
Reading from disconnected ports will spit out timeout error
on the dmesg. Skip the attempted read if the port is not
connected and avoid confusing users/testcases about
expected timeouts.
This new dpcd debugfs entry was introduced by commit aa7471d228eb
("drm/i915: add i915 specific connector debu
74 matches
Mail list logo
