[Intel-gfx] [PULL] topic/drm-misc

2015-02-05 Thread Daniel Vetter
Hi Dave, Flushing out my drm-misc queue with a few oddball things all over. Cheers, Daniel The following changes since commit b7703726251191cd9f3ef3a80b2d9667901eec95: drm/probe-helper: clamp unknown connector status in the poll work (2015-01-22 06:11:39 +0100) are available in the git rep

Re: [Intel-gfx] [PATCH] drm/i915: Take runtime pm reference on hangcheck_info

2015-02-05 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5723 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -2 282/283

Re: [Intel-gfx] [PATCH 1/5] agp/intel: Serialise after GTT updates

2015-02-05 Thread Jesse Barnes
On Wed, 14 Jan 2015 11:20:55 + Chris Wilson wrote: > diff --git a/drivers/char/agp/intel-gtt.c > b/drivers/char/agp/intel-gtt.c index 92aa43fa8d70..15685ca39193 100644 > --- a/drivers/char/agp/intel-gtt.c > +++ b/drivers/char/agp/intel-gtt.c > @@ -225,7 +225,7 @@ static int i810_insert_dcache

Re: [Intel-gfx] [PATCH] drm/i915: Correct the IOSF Dev_FN field for IOSF transfers

2015-02-05 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5719 -Summary- Platform Delta drm-intel-nightly Series Applied PNV +1 282/283

Re: [Intel-gfx] [PATCH 6/5] drm/i915: Make sure the primary plane is enabled before reading out the fb state

2015-02-05 Thread Matt Roper
On Thu, Feb 05, 2015 at 07:35:13PM +, Damien Lespiau wrote: > We don't want to end up in a state where we track that the pipe has its > primary plane enabled when primary plane registers are programmed with > values that look possible but the plane actually disabled. > > Refuse to read out the

Re: [Intel-gfx] [PATCH] drm/i915: Correct the base value while updating LP_OUTPUT_HOLD in MIPI_PORT_CTRL

2015-02-05 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5718 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -8 282/283

[Intel-gfx] [PATCH 6/5] drm/i915: Make sure the primary plane is enabled before reading out the fb state

2015-02-05 Thread Damien Lespiau
We don't want to end up in a state where we track that the pipe has its primary plane enabled when primary plane registers are programmed with values that look possible but the plane actually disabled. Refuse to read out the fb state when the primary plane isn't enabled. Suggested-by: Ville Syrjä

[Intel-gfx] [PATCH 5/5 v2] drm/i915: Fix atomic state when reusing the firmware fb

2015-02-05 Thread Damien Lespiau
Right now, we get a warning when taking over the firmware fb: [drm:drm_atomic_plane_check] FB set but no CRTC with the following backtrace: [] drm_atomic_check_only+0x35d/0x510 [drm] [] drm_atomic_commit+0x17/0x60 [drm] [] drm_atomic_helper_plane_set_property+0x8d/0xd0 [drm_kms_helper]

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 11:12:20AM -0800, Matt Roper wrote: > I think the only thing we need to close on is Ville's concern about the > plane winding up with non-NULL fb and crtc pointers even though a crazy > firmware or bootloader somehow left the plane turned off. I'm not super > familiar with

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb

2015-02-05 Thread Matt Roper
On Thu, Feb 05, 2015 at 06:58:06PM +, Damien Lespiau wrote: > On Thu, Feb 05, 2015 at 10:10:26AM -0800, Matt Roper wrote: > > On Thu, Feb 05, 2015 at 05:22:19PM +, Damien Lespiau wrote: > > > Right now, we get a warning when taking over the firmware fb: > > > > > > [drm:drm_atomic_plane_

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 10:10:26AM -0800, Matt Roper wrote: > On Thu, Feb 05, 2015 at 05:22:19PM +, Damien Lespiau wrote: > > Right now, we get a warning when taking over the firmware fb: > > > > [drm:drm_atomic_plane_check] FB set but no CRTC > > > > with the following backtrace: > > > >

[Intel-gfx] [PATCH 3/5 v2] drm/i915: Don't try to reference the fb in get_initial_plane_config()

2015-02-05 Thread Damien Lespiau
Tvrtko noticed a new warning on boot: WARNING: CPU: 1 PID: 353 at include/linux/kref.h:47 drm_framebuffer_reference+0x6c/0x80 [drm]() Call Trace: [] dump_stack+0x4f/0x7b [] warn_slowpath_common+0xaa/0xd0 [] warn_slowpath_null+0x1a/0x20 [] drm_framebuffer_reference+0x6c/0x80 [drm] []

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb

2015-02-05 Thread Ville Syrjälä
On Thu, Feb 05, 2015 at 10:10:26AM -0800, Matt Roper wrote: > On Thu, Feb 05, 2015 at 05:22:19PM +, Damien Lespiau wrote: > > Right now, we get a warning when taking over the firmware fb: > > > > [drm:drm_atomic_plane_check] FB set but no CRTC > > > > with the following backtrace: > > > >

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Don't try to reference the fb in get_initial_plane_config()

2015-02-05 Thread Matt Roper
On Thu, Feb 05, 2015 at 05:22:17PM +, Damien Lespiau wrote: > Tvrtko noticed a new warning on boot: > > WARNING: CPU: 1 PID: 353 at include/linux/kref.h:47 > drm_framebuffer_reference+0x6c/0x80 [drm]() > Call Trace: > [] dump_stack+0x4f/0x7b > [] warn_slowpath_common+0xaa/0xd0 > []

Re: [Intel-gfx] [PATCH 10/10] drm/i915: gen 9 h/w w/a (WaEnableForceRestoreInCtxtDescForVCS)

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 10:47:25AM +, Nick Hoath wrote: > From: "Hoath, Nicholas" > > Add: > WaEnableForceRestoreInCtxtDescForVCS > > v1: Add stepping check. > > Signed-off-by: Nick Hoath > --- > drivers/gpu/drm/i915/intel_lrc.c | 15 --- > 1 file changed, 12 insertions(+), 3

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb

2015-02-05 Thread Matt Roper
On Thu, Feb 05, 2015 at 05:22:19PM +, Damien Lespiau wrote: > Right now, we get a warning when taking over the firmware fb: > > [drm:drm_atomic_plane_check] FB set but no CRTC > > with the following backtrace: > > [] drm_atomic_check_only+0x35d/0x510 [drm] > [] drm_atomic_commit+0x17/0

Re: [Intel-gfx] [PATCH 09/10] drm/i915: gen 9 h/w w/a (WaForceEnableNonCoherent)

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 10:47:24AM +, Nick Hoath wrote: > From: "Hoath, Nicholas" > > Add: > WaForceEnableNonCoherent > > v1: Don't add WaHdcDisableFetchWhenMasked. Add stepping check for > WaForceEnableNonCoherent > > Signed-off-by: Nick Hoath Reviewed-by: Damien Lespiau -- Damien >

Re: [Intel-gfx] [PATCH 08/10] drm/i915: gen 9 h/w w/a (Wa4x4STCOptimizationDisable)

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 10:47:23AM +, Nick Hoath wrote: > From: "Hoath, Nicholas" > > Move Wa4x4STCOptimizationDisable to gen9_init_workarounds > > v1: rebase > > Signed-off-by: Nick Hoath Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/intel_pm.c | 4

Re: [Intel-gfx] [PATCH] drm/i915: Squelch overzealous uncore reset WARN_ON

2015-02-05 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5716 -Summary- Platform Delta drm-intel-nightly Series Applied PNV +1 282/283

Re: [Intel-gfx] [PATCH 07/10] drm/i915: gen 9 h/w w/a (WaEnableYV12BugFixInHalfSliceChicken7)

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 10:47:22AM +, Nick Hoath wrote: > Move WaEnableYV12BugFixInHalfSliceChicken7 to gen9_init_workarounds > > v1: Add stepping check. > > Signed-off-by: Nick Hoath Reviewed-by: Damien Lespiau > --- > drivers/gpu/drm/i915/i915_reg.h | 3 +++ > drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH 06/10] drm/i915: gen 9 h/w w/a (WaDisableSDEUnitClockGating)

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 10:47:21AM +, Nick Hoath wrote: > From: "Hoath, Nicholas" > > Add stepping check for WaDisableSDEUnitClockGating. > > Signed-off-by: Nick Hoath Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/intel_pm.c | 14 -- > 1 file changed,

Re: [Intel-gfx] [PATCH 05/10] drm/i915: gen 9 h/w w/a (syncing dependencies between camera and graphics)

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 10:47:20AM +, Nick Hoath wrote: > Added: > Syncing dependencies between camera and graphics > > v1: Added missing register bitmap > Signed-off-by: Nick Hoath For the record, this W/A has no name nor documentation. So well... Reviewed-by: Damien Lespiau -- Damien

Re: [Intel-gfx] [PATCH 04/10] drm/i915: gen 9 h/w w/a (WaDisableDgMirrorFixInHalfSliceChicken5)

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 05:55:06PM +, Damien Lespiau wrote: > > + if (INTEL_REVID(dev) == SKL_A0_REVID) { > > for SKL, I read B0 only. Well B0 only in the W/A db, but A0 and B0 in BSpec. I'd trust BSpec on those. -- Damien ___ Intel-gfx mailing

Re: [Intel-gfx] [PATCH 04/10] drm/i915: gen 9 h/w w/a (WaDisableDgMirrorFixInHalfSliceChicken5)

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 10:47:19AM +, Nick Hoath wrote: > Move WaDisableDgMirrorFixInHalfSliceChicken5 to gen9_init_workarounds > > v1: Added stepping check > > v2: Removed unused register bitmap > > Signed-off-by: Nick Hoath > --- > drivers/gpu/drm/i915/intel_pm.c | 8 >

Re: [Intel-gfx] [PATCH 03/10] drm/i915: gen 9 h/w w/a (WaDisablePartialInstShootdown)

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 10:47:18AM +, Nick Hoath wrote: > From: "Hoath, Nicholas" > > Add: > WaDisablePartialInstShootdown Just an editor note: that's not really additional information compared to the subject of the patch. Also subject message could be a bit more direct and mention SKL: d

Re: [Intel-gfx] [PATCH 02/10] drm/i915: ring w/a gen 9 revision definitions

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 10:47:17AM +, Nick Hoath wrote: > From: "Hoath, Nicholas" > > Add Skylake stepping Revision IDs definitions. > > v1: Use existing revision id. > > Signed-off-by: Nick Hoath Namespacing is usually NAMESPACE_VALUE, so I guess it'd be SKL_REVID_A0, but meh. Also:

Re: [Intel-gfx] [PATCH 10/10] drm/i915: gen 9 h/w w/a (WaEnableForceRestoreInCtxtDescForVCS)

2015-02-05 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5717 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 282/283

Re: [Intel-gfx] [PATCH 01/10] drm/i915: ring w/a initialisation for gen 9

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 10:47:16AM +, Nick Hoath wrote: > From: "Hoath, Nicholas" > > Add framework for gen 9 HW WAs > > v1: Changed SOC specific WA function to gen 9 common function (Req: Damien > Lespiau) > > Signed-off-by: Nick Hoath Reviewed-by: Damien Lespiau > --- > drivers/gpu/

[Intel-gfx] [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb

2015-02-05 Thread Damien Lespiau
Right now, we get a warning when taking over the firmware fb: [drm:drm_atomic_plane_check] FB set but no CRTC with the following backtrace: [] drm_atomic_check_only+0x35d/0x510 [drm] [] drm_atomic_commit+0x17/0x60 [drm] [] drm_atomic_helper_plane_set_property+0x8d/0xd0 [drm_kms_helper]

[Intel-gfx] [PATCH 4/5] drm/i915: Store the initial framebuffer in initial_plane_config

2015-02-05 Thread Damien Lespiau
At the moment we use crtc->base.primary->fb to hold the initial framebuffer allocation, disregarding if it's valid or not. This lead to believe we were actually updating the fb at this point, but it's not true and we haven't even called drm_framebuffer_init() on this fb. Instead, let's store the

[Intel-gfx] [PATCH 1/5] drm/i915: Put update_state_fb() next to the fb update

2015-02-05 Thread Damien Lespiau
update_state_fb() at the end of intel_find_plane_obj() is misleading as it leads us to believe the update is done for all code path. A successful call to intel_alloc_plane_obj() will return and update_state_fb() is then only needed when we share a fb from another CRTC. Put the update() function th

[Intel-gfx] [PATCH 0/5] Fix a couple of warning introduced recently

2015-02-05 Thread Damien Lespiau
At least here, the following commit introduced 2 warnings when loading the driver: commit 706dc7b549175e47f23e913b7f1e52874a7d0f56 Author: Matt Roper Date: Tue Feb 3 13:10:04 2015 -0800 drm/i915: Ensure plane->state->fb stays in sync with plane->fb The series

[Intel-gfx] [PATCH 2/5] drm/i915: Use an intermediate variable to avoid repeating ourselves

2015-02-05 Thread Damien Lespiau
The code look slightly better this way and will ease the next commit, changing where we take the fb pointer from. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_di

[Intel-gfx] [PATCH 3/5] drm/i915: Don't try to reference the fb in get_initial_plane_config()

2015-02-05 Thread Damien Lespiau
Tvrtko noticed a new warning on boot: WARNING: CPU: 1 PID: 353 at include/linux/kref.h:47 drm_framebuffer_reference+0x6c/0x80 [drm]() Call Trace: [] dump_stack+0x4f/0x7b [] warn_slowpath_common+0xaa/0xd0 [] warn_slowpath_null+0x1a/0x20 [] drm_framebuffer_reference+0x6c/0x80 [drm] []

Re: [Intel-gfx] [PATCH] drm/i915: Correct the IOSF Dev_FN field for IOSF transfers

2015-02-05 Thread Ville Syrjälä
On Thu, Feb 05, 2015 at 05:10:56PM +0530, Shobhit Kumar wrote: > As per the specififcation, the SB_DevFn is the PCI_DEVFN of the target > device and not the source. So PCI_DEVFN(2,0) is not correct. Further the > port ID should be enough to identify devices unless they are MFD. The > SB_DevFn was i

Re: [Intel-gfx] [PATCH] drm/i915/fbc: fix the check for already reserved fbc size

2015-02-05 Thread Ben Widawsky
On Thu, Feb 05, 2015 at 12:04:27PM +0200, Jani Nikula wrote: > The check for previously reserved stolen space size for FBC in > i915_gem_stolen_setup_compression() did not take the compression > threshold into account. Fix this by storing and comparing to > uncompressed size instead. > > The bug h

Re: [Intel-gfx] [PATCH] drm/i915: Take runtime pm reference on hangcheck_info

2015-02-05 Thread Chris Wilson
On Thu, Feb 05, 2015 at 06:41:48PM +0200, Mika Kuoppala wrote: > We read the coherent current seqno and actual head from ring. > For hardware access we need to take runtime_pm reference. > > Get hardware specific values with runtime reference held > and print them first to emphasize hw state vs bo

Re: [Intel-gfx] [PATCH] drm/i915: Squelch overzealous uncore reset WARN_ON

2015-02-05 Thread Chris Wilson
On Thu, Feb 05, 2015 at 05:45:42PM +0200, Mika Kuoppala wrote: > We added this WARN_ON to guard against using uninitialized > forcewake domains. But forgot blissfully that not all > gens have forcewake domains in the first place. > > v2: Move WARN_ON to fw_domains_init (Chris) > > Bugzilla: https

[Intel-gfx] [PATCH] drm/i915: Take runtime pm reference on hangcheck_info

2015-02-05 Thread Mika Kuoppala
We read the coherent current seqno and actual head from ring. For hardware access we need to take runtime_pm reference. Get hardware specific values with runtime reference held and print them first to emphasize hw state vs bookkeepping. v2: Reorder output according to hw access (Chris) remove

Re: [Intel-gfx] [PATCH] drm/i915: Take runtime pm reference on hangcheck_info

2015-02-05 Thread Mika Kuoppala
Daniel Vetter writes: > On Thu, Feb 05, 2015 at 12:16:32PM +0200, Mika Kuoppala wrote: >> We read the coherent current seqno and actual head from ring. >> For hardware access we need to take runtime_pm reference, which brings in >> locking. As this debugfs entry is for debugging hangcheck behavio

[Intel-gfx] [PATCH] drm/i915: Squelch overzealous uncore reset WARN_ON

2015-02-05 Thread Mika Kuoppala
We added this WARN_ON to guard against using uninitialized forcewake domains. But forgot blissfully that not all gens have forcewake domains in the first place. v2: Move WARN_ON to fw_domains_init (Chris) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88911 Tested-by: Ding Heng (v1) Sign

Re: [Intel-gfx] [PATCH] drm/i915: Take runtime pm reference on hangcheck_info

2015-02-05 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5715 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -6 282/283

Re: [Intel-gfx] [PATCH 1/4] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-02-05 Thread Daniel Stone
On 5 February 2015 at 14:41, Tvrtko Ursulin wrote: > In DRM/KMS we are lacking a good way to deal with tiled/compressed > formats. Especially in the case of dmabuf/prime buffer sharing, where > we cannot always rely on under-the-hood flags passed to driver specific > gem-create ioctl to pass arou

Re: [Intel-gfx] [PATCH] tests/kms_addfb: Add support for fb modifiers

2015-02-05 Thread Tvrtko Ursulin
On 02/05/2015 02:21 PM, Daniel Vetter wrote: On Wed, Feb 04, 2015 at 04:42:14PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Just a few basic tests to make sure fb modifiers can be used and behave sanely when mixed with the old set_tiling API. Signed-off-by: Tvrtko Ursulin --- lib/io

[Intel-gfx] [PATCH 4/4] drm/i915: Announce support for framebuffer modifiers

2015-02-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Let the DRM core know we can handle it. v2: Change to boolean true. (Daniel Vetter) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/in

[Intel-gfx] [PATCH 3/4] drm/i915: Use frame buffer modifiers for tiled display

2015-02-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Start using frame buffer modifiers instead of object tiling mode for display purposes. To ensure compatibility with old userspace which is using set_tiling and does not know about frame buffer modifiers, the latter are faked internally when tile object is set for display. Th

[Intel-gfx] [PATCH 1/4] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-02-05 Thread Tvrtko Ursulin
From: Rob Clark In DRM/KMS we are lacking a good way to deal with tiled/compressed formats. Especially in the case of dmabuf/prime buffer sharing, where we cannot always rely on under-the-hood flags passed to driver specific gem-create ioctl to pass around these extra flags. The proposal is to

[Intel-gfx] [PATCH 2/4] drm/i915: Add tiled framebuffer modifiers

2015-02-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To be used from the new addfb2 extension. Signed-off-by: Tvrtko Ursulin --- include/uapi/drm/i915_drm.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h index 6eed16b..e4c09e2 100644 --- a/includ

[Intel-gfx] [RFC v3 0/4] Use framebuffer modifiers for tiled display

2015-02-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Instead of using driver private set tiling ioctl, use the proposed addfb2 ioctl extension to tell the driver about display buffer special formatting. Lightly tested only with a hacked up igt/testdisplay. v2: * Refactor the series to use fb->modifier[0] directly at call s

Re: [Intel-gfx] [PATCH] drm/i915: Prevent use-after-free in invalidate_range_start callback

2015-02-05 Thread Jani Nikula
On Tue, 03 Feb 2015, Daniel Vetter wrote: > On Tue, Feb 03, 2015 at 03:08:17PM +, Chris Wilson wrote: >> On Tue, Feb 03, 2015 at 03:48:17PM +0100, Michał Winiarski wrote: >> > It's possible for invalidate_range_start mmu notifier callback to race >> > against userptr object release. If the gem

Re: [Intel-gfx] [PATCH] drm/i915: Take runtime pm reference on hangcheck_info

2015-02-05 Thread Daniel Vetter
On Thu, Feb 05, 2015 at 12:16:32PM +0200, Mika Kuoppala wrote: > We read the coherent current seqno and actual head from ring. > For hardware access we need to take runtime_pm reference, which brings in > locking. As this debugfs entry is for debugging hangcheck behaviour, > including locking probl

Re: [Intel-gfx] [PATCH] drm/i915/fbc: fix the check for already reserved fbc size

2015-02-05 Thread Daniel Vetter
On Thu, Feb 05, 2015 at 10:06:05AM +, Chris Wilson wrote: > On Thu, Feb 05, 2015 at 12:04:27PM +0200, Jani Nikula wrote: > > The check for previously reserved stolen space size for FBC in > > i915_gem_stolen_setup_compression() did not take the compression > > threshold into account. Fix this b

Re: [Intel-gfx] [PATCH] tests/kms_addfb: Add support for fb modifiers

2015-02-05 Thread Daniel Vetter
On Wed, Feb 04, 2015 at 04:42:14PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Just a few basic tests to make sure fb modifiers can be used and > behave sanely when mixed with the old set_tiling API. > > Signed-off-by: Tvrtko Ursulin > --- > lib/ioctl_wrappers.c | 45 ++

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use frame buffer modifiers for tiled display

2015-02-05 Thread Daniel Vetter
On Wed, Feb 04, 2015 at 03:44:58PM +, Tvrtko Ursulin wrote: > > On 02/04/2015 03:33 PM, Daniel Vetter wrote: > >On Wed, Feb 04, 2015 at 03:09:38PM +, Tvrtko Ursulin wrote: > >>On 02/04/2015 02:25 PM, Daniel Vetter wrote: > >>>On Wed, Feb 04, 2015 at 10:01:45AM +, Tvrtko Ursulin wrote:

Re: [Intel-gfx] [PATCH] drm/i915/fbc: fix the check for already reserved fbc size

2015-02-05 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5714 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 282/283

[Intel-gfx] [PATCH] drm/i915: Correct the IOSF Dev_FN field for IOSF transfers

2015-02-05 Thread Shobhit Kumar
As per the specififcation, the SB_DevFn is the PCI_DEVFN of the target device and not the source. So PCI_DEVFN(2,0) is not correct. Further the port ID should be enough to identify devices unless they are MFD. The SB_DevFn was intended to remove ambiguity in case of these MFD devices. For non MFD

[Intel-gfx] [PATCH] drm/i915: Correct the base value while updating LP_OUTPUT_HOLD in MIPI_PORT_CTRL

2015-02-05 Thread Shobhit Kumar
LP_OUTPUT_HOLD is only in MIPI_PORT_CTRL(PORT_A) even for PORT_C in case of dual link. In the dual link implementation, the bit is correctly set or unset for hardcoded PORT_A, but for bit update the register base value is read by using MIPI_PORT_CTRL(port) in a loop. The second iteration will read

Re: [Intel-gfx] Kernel 3.19rc6 flooding intel_check_page_flip warnings when using compton

2015-02-05 Thread Chris Wilson
On Thu, Feb 05, 2015 at 12:44:21PM +0200, Sakari Kapanen wrote: > On 02/04/2015 11:26 AM, Jani Nikula wrote: > >On Mon, 02 Feb 2015, Sakari Kapanen wrote: > >>Dear maintainers, > >> > >>On an Asus Zenbook UX32VD laptop with an i5-3317U CPU and Intel HD4000 > >>graphics, I'm experiencing the follow

[Intel-gfx] [PATCH 00/10] drm/i915: HardWare WorkArounds for gen 9

2015-02-05 Thread Nick Hoath
Implement a subset of known HardWare WorkArounds for gen 9. v1: Make gen 9 common patchset, remove non-common w/a's, tidy up patch names, tidy up register names (Req: Damien Lespiau). Removed invalid WA (Found by Arun Siluvery). Removed WaSetHdcUnitClockGatingDisableInUcgctl6 until

[Intel-gfx] [PATCH 05/10] drm/i915: gen 9 h/w w/a (syncing dependencies between camera and graphics)

2015-02-05 Thread Nick Hoath
Added: Syncing dependencies between camera and graphics v1: Added missing register bitmap Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_ringbuffer.c | 4 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 09/10] drm/i915: gen 9 h/w w/a (WaForceEnableNonCoherent)

2015-02-05 Thread Nick Hoath
From: "Hoath, Nicholas" Add: WaForceEnableNonCoherent v1: Don't add WaHdcDisableFetchWhenMasked. Add stepping check for WaForceEnableNonCoherent Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH 06/10] drm/i915: gen 9 h/w w/a (WaDisableSDEUnitClockGating)

2015-02-05 Thread Nick Hoath
From: "Hoath, Nicholas" Add stepping check for WaDisableSDEUnitClockGating. Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_pm.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 2

[Intel-gfx] [PATCH 01/10] drm/i915: ring w/a initialisation for gen 9

2015-02-05 Thread Nick Hoath
From: "Hoath, Nicholas" Add framework for gen 9 HW WAs v1: Changed SOC specific WA function to gen 9 common function (Req: Damien Lespiau) Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/in

[Intel-gfx] [PATCH 07/10] drm/i915: gen 9 h/w w/a (WaEnableYV12BugFixInHalfSliceChicken7)

2015-02-05 Thread Nick Hoath
Move WaEnableYV12BugFixInHalfSliceChicken7 to gen9_init_workarounds v1: Add stepping check. Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_ringbuffer.c | 6 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/i915

[Intel-gfx] [PATCH 03/10] drm/i915: gen 9 h/w w/a (WaDisablePartialInstShootdown)

2015-02-05 Thread Nick Hoath
From: "Hoath, Nicholas" Add: WaDisablePartialInstShootdown v1: Dont add WaDisableThreadStallDopClockGating as not SKL WA. (Found by Damien Lespiau) Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 02/10] drm/i915: ring w/a gen 9 revision definitions

2015-02-05 Thread Nick Hoath
From: "Hoath, Nicholas" Add Skylake stepping Revision IDs definitions. v1: Use existing revision id. Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_drv.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index

[Intel-gfx] [PATCH 10/10] drm/i915: gen 9 h/w w/a (WaEnableForceRestoreInCtxtDescForVCS)

2015-02-05 Thread Nick Hoath
From: "Hoath, Nicholas" Add: WaEnableForceRestoreInCtxtDescForVCS v1: Add stepping check. Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_lrc.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 08/10] drm/i915: gen 9 h/w w/a (Wa4x4STCOptimizationDisable)

2015-02-05 Thread Nick Hoath
From: "Hoath, Nicholas" Move Wa4x4STCOptimizationDisable to gen9_init_workarounds v1: rebase Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_pm.c | 4 drivers/gpu/drm/i915/intel_ringbuffer.c | 3 +++ 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/

[Intel-gfx] [PATCH 04/10] drm/i915: gen 9 h/w w/a (WaDisableDgMirrorFixInHalfSliceChicken5)

2015-02-05 Thread Nick Hoath
Move WaDisableDgMirrorFixInHalfSliceChicken5 to gen9_init_workarounds v1: Added stepping check v2: Removed unused register bitmap Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_pm.c | 8 drivers/gpu/drm/i915/intel_ringbuffer.c | 10 ++ 2 files changed, 10 in

Re: [Intel-gfx] [PATCH] drm/i915: Squelch overzealous uncore reset WARN_ON

2015-02-05 Thread Chris Wilson
On Thu, Feb 05, 2015 at 12:21:11PM +0200, Mika Kuoppala wrote: > We added this WARN_ON to guard against using uninitialized > forcewake domains. But forgot blissfully that not all > gens have forcewake domains in the first place. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88911 > T

Re: [Intel-gfx] flickering console

2015-02-05 Thread Jani Nikula
On Thu, 05 Feb 2015, Stéphane ANCELOT wrote: > Hi > I don't know if it is the right place... but I will explain my problem : > > I am using an ATOM INTEL E3826 platform. > > I have got flickering problems at bottom of my tty console, using 3.16.2 > kernel. > > I tried kernel 3.18 and it has not t

Re: [Intel-gfx] [PATCH] drm/i915: Take runtime pm reference on hangcheck_info

2015-02-05 Thread Chris Wilson
On Thu, Feb 05, 2015 at 12:16:32PM +0200, Mika Kuoppala wrote: > We read the coherent current seqno and actual head from ring. > For hardware access we need to take runtime_pm reference, which brings in > locking. As this debugfs entry is for debugging hangcheck behaviour, > including locking probl

[Intel-gfx] [PATCH] drm/i915: Squelch overzealous uncore reset WARN_ON

2015-02-05 Thread Mika Kuoppala
We added this WARN_ON to guard against using uninitialized forcewake domains. But forgot blissfully that not all gens have forcewake domains in the first place. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88911 Tested-by: Ding Heng Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH] drm/i915: Take runtime pm reference on hangcheck_info

2015-02-05 Thread Mika Kuoppala
We read the coherent current seqno and actual head from ring. For hardware access we need to take runtime_pm reference, which brings in locking. As this debugfs entry is for debugging hangcheck behaviour, including locking problems, we need to be flexible on taking them. Try to see if we get a loc

Re: [Intel-gfx] [PATCH] drm/i915/fbc: fix the check for already reserved fbc size

2015-02-05 Thread Chris Wilson
On Thu, Feb 05, 2015 at 12:04:27PM +0200, Jani Nikula wrote: > The check for previously reserved stolen space size for FBC in > i915_gem_stolen_setup_compression() did not take the compression > threshold into account. Fix this by storing and comparing to > uncompressed size instead. > > The bug h

[Intel-gfx] [PATCH] drm/i915/fbc: fix the check for already reserved fbc size

2015-02-05 Thread Jani Nikula
The check for previously reserved stolen space size for FBC in i915_gem_stolen_setup_compression() did not take the compression threshold into account. Fix this by storing and comparing to uncompressed size instead. The bug has been introduced in commit 5e59f7175f96550ede91f58d267d2b551cb6fbba Au

[Intel-gfx] flickering console

2015-02-05 Thread Stéphane ANCELOT
Hi I don't know if it is the right place... but I will explain my problem : I am using an ATOM INTEL E3826 platform. I have got flickering problems at bottom of my tty console, using 3.16.2 kernel. I tried kernel 3.18 and it has not the problem. For some technical reasons, I can not switch t

Re: [Intel-gfx] [RFC v3 3/4] drm/i915: Add new panel driver based on crystal cove pmic

2015-02-05 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 02:16:53PM +0100, Thierry Reding wrote: > On Wed, Jan 21, 2015 at 04:48:12PM +0530, Shobhit Kumar wrote: > > diff --git a/drivers/gpu/drm/i915/intel-panel-crystalcove.c > > b/drivers/gpu/drm/i915/intel-panel-crystalcove.c > [...] > > +#define PMIC_PANEL_EN 0x52