Re: [Intel-gfx] [PATCH] drm/i915/hdmi: Compute port_clock for 27.027 pixel replicated modes

2014-10-06 Thread Clint Taylor
On 09/30/2014 05:46 AM, Ville Syrjälä wrote: On Fri, Sep 26, 2014 at 09:28:50AM -0700, Clint Taylor wrote: On 09/26/2014 08:58 AM, Ville Syrjälä wrote: On Wed, Sep 24, 2014 at 03:49:39PM -0700, clinton.a.tay...@intel.com wrote: From: Clint Taylor port_clock was being incorrectly computed and

[Intel-gfx] [PATCH i-g-t 3/3] quick_dump/skl: Make quick_dump SKL aware

2014-10-06 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- tools/quick_dump/chipset.i| 2 ++ tools/quick_dump/chipset_macro_wrap.c | 5 + tools/quick_dump/quick_dump.py| 2 ++ tools/quick_dump/skylake | 1 + 4 files changed, 10 insertions(+) create mode 100644 tools/quick_dump/skylak

[Intel-gfx] [PATCH i-g-t 1/3] quick_dump: Move base_display.txt to indivual platforms

2014-10-06 Thread Damien Lespiau
SKL will have a whole separate display regs file, so merge base_display.txt into each platform file. Signed-off-by: Damien Lespiau --- tools/quick_dump/broadwell| 1 + tools/quick_dump/cherryview | 1 + tools/quick_dump/{base_display.

[Intel-gfx] [PATCH i-g-t 2/3] quick_dump/skl: Add some display registers

2014-10-06 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- tools/quick_dump/skl_display.txt | 285 +++ 1 file changed, 285 insertions(+) create mode 100644 tools/quick_dump/skl_display.txt diff --git a/tools/quick_dump/skl_display.txt b/tools/quick_dump/skl_display.txt new file mode

[Intel-gfx] [PATCH i-g-t 1/2] gem_seqno_wrap: Remove unused variable

2014-10-06 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- tests/gem_seqno_wrap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/gem_seqno_wrap.c b/tests/gem_seqno_wrap.c index 6772d1e..51fd88c 100644 --- a/tests/gem_seqno_wrap.c +++ b/tests/gem_seqno_wrap.c @@ -475,7 +475,6 @@ static int parse_options(int opt,

[Intel-gfx] [PATCH i-g-t 2/2] overlay: Fix compilation warning when not having xrandr

2014-10-06 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- overlay/x11/position.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/overlay/x11/position.c b/overlay/x11/position.c index f430281..cd00353 100644 --- a/overlay/x11/position.c +++ b/overlay/x11/position.c @@ -76,10 +76,11 @@ static enum po

[Intel-gfx] Taking tiling and rotation into account in watermark computations

2014-10-06 Thread Tvrtko Ursulin
Hi all, We need to refactor the current code a bit to allow parameters like plane rotation and framebuffer tiling mode be taken into account when calculating display watermarks. I looked into this code a bit and am at the moment a bit confused with what is where and why. For example the p

[Intel-gfx] [PATCH i-g-t] gem_wait: Use PRIu64 in format string

2014-10-06 Thread Damien Lespiau
../../tests/gem_wait.c: In function ‘render_timeout’: ../../tests/gem_wait.c:182:3: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘uint64_t’ [-Wformat=] igt_info("Finished with %llu time remaining\n", timeout); Cc: Daniel Vetter Signed-off-b

[Intel-gfx] [PATCH i-g-t 1/2] quick-dump: Make quick dump link against libintel_tools

2014-10-06 Thread Damien Lespiau
Because quick-dump was only selecting a few files in lib/ and we move stuff around and/or add new dependencies we were failing to provide the necessary symbols to the shim library providing python bindings. And so we had a run-time error: Traceback (most recent call last): File "./tools/quick_du

[Intel-gfx] [PATCH i-g-t 2/2] quick_dump: Add a test to verify we can load the dynamic library

2014-10-06 Thread Damien Lespiau
quick_dump was failing to load because of a non resolved symbol in the python binding library. Let's add a small test that makes sure we can run ./quick_dump.py --help, ie load the python package and the shim library. Signed-off-by: Damien Lespiau --- tools/quick_dump/Makefile.am | 2 ++ tools

Re: [Intel-gfx] [RFC 00/21] Replace seqno values with request structures

2014-10-06 Thread Chris Wilson
On Mon, Oct 06, 2014 at 03:15:04PM +0100, john.c.harri...@intel.com wrote: > From: John Harrison > > Work in progress for replacing seqno usage with requst structures. You fail to end up with my earlier code. Nak. -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [Intel-gfx] [RFC 01/21] Bug: missing i915_seqno_passed() call?

2014-10-06 Thread John Harrison
On 06/10/2014 15:45, Daniel Vetter wrote: On Mon, Oct 06, 2014 at 03:15:05PM +0100, john.c.harri...@intel.com wrote: From: John Harrison --- drivers/gpu/drm/i915/i915_gem.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/d

Re: [Intel-gfx] [RFC 01/21] Bug: missing i915_seqno_passed() call?

2014-10-06 Thread Daniel Vetter
On Mon, Oct 06, 2014 at 03:15:05PM +0100, john.c.harri...@intel.com wrote: > From: John Harrison > > --- > drivers/gpu/drm/i915/i915_gem.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 2a5351

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move DIV_ROUND_CLOSEST_ULL macro to header

2014-10-06 Thread Joe Konno
Reviewed-By: Joe Konno On 09/29/2014 03:49 PM, U. Artie Eoff wrote: > Move the duplicated DIV_ROUND_CLOSEST_ULL macro into the intel_drv.h > header file so that it can be shared between intel_display.c > and intel_panel.c. > > Signed-off-by: U. Artie Eoff > --- > drivers/gpu/drm/i915/intel_disp

Re: [Intel-gfx] [PATCH 1/2 v3] drm/i915: intel_backlight scale() math WA

2014-10-06 Thread Joe Konno
Reviewed-By: Joe Konno On 09/29/2014 03:49 PM, U. Artie Eoff wrote: > Improper truncated integer division in the scale() function causes > actual_brightness != brightness. This (partial) work-around should be > sufficient for a majority of use-cases, but it is by no means a complete > solution. >

[Intel-gfx] [RFC 20/21] drm/i915: Convert 'ring_idle()' to use requests not seqnos

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 4847ed5..c2a7127 100644 --- a/

[Intel-gfx] [RFC 14/21] drm/i915: Convert 'flip_queued_seqno' into 'flip_queued_request'

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c |4 ++-- drivers/gpu/drm/i915/intel_display.c |9 ++--- drivers/gpu/drm/i915/intel_drv.h |2 +- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/d

[Intel-gfx] [RFC 10/21] drm/i915: Convert 'last_flip_req' to be a request not a seqno

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/intel_overlay.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_overlay.c b/drivers/gpu/drm/i915/intel_overlay.c index dc2f4f2..c

[Intel-gfx] [RFC 21/21] drm/i915: Remove 'obj->ring'

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c |9 + drivers/gpu/drm/i915/i915_drv.h |2 -- drivers/gpu/drm/i915/i915_gem.c | 32 +++ drivers/gpu/drm/i915/i915_ge

[Intel-gfx] [RFC 17/21] drm/i915: Convert trace functions from seqno to request

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_gem.c| 10 +++--- drivers/gpu/drm/i915/i915_gem_execbuffer.c |2 +- drivers/gpu/drm/i915/i915_trace.h | 47 3 files changed, 33 inser

[Intel-gfx] [RFC 19/21] drm/i915: Convert semaphores to handle requests not seqnos

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c |3 ++- drivers/gpu/drm/i915/i915_gem.c | 14 ++ drivers/gpu/drm/i915/i915_gpu_error.c | 12 drivers/gpu/drm/i915/intel_ringbuffer.c |

[Intel-gfx] [RFC 05/21] drm/i915: Add helper functions to aid seqno -> request transition

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_drv.h | 12 drivers/gpu/drm/i915/intel_ringbuffer.h |7 +++ 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i9

[Intel-gfx] [RFC 16/21] drm/i915: Convert __wait_seqno() to __wait_request()

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_gem.c | 57 +-- 1 file changed, 24 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index d

[Intel-gfx] [RFC 15/21] drm/i915: Convert most 'i915_seqno_passed' calls into 'i915_gem_request_completed'

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c |3 +-- drivers/gpu/drm/i915/i915_drv.h | 17 + drivers/gpu/drm/i915/i915_gem.c | 12 drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [RFC 13/21] drm/i915: Convert mmio_flip::seqno to struct request

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 12 +++- drivers/gpu/drm/i915/intel_drv.h |2 +- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/

[Intel-gfx] [RFC 08/21] drm/i915: Remove 'outstanding_lazy_seqno'

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_gem.c| 13 +++- drivers/gpu/drm/i915/i915_gem_execbuffer.c |2 +- drivers/gpu/drm/i915/intel_display.c |2 +- drivers/gpu/drm/i915/intel_lrc.c | 20

[Intel-gfx] [RFC 11/21] drm/i915: Convert i915_wait_seqno to i915_wait_request

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_drv.h | 18 +- drivers/gpu/drm/i915/i915_gem.c | 30 +++--- drivers/gpu/drm/i915/intel_lrc.c|6 ++ drivers/gpu/drm/

[Intel-gfx] [RFC 12/21] drm/i915: Convert 'i915_add_request' to take a request not a seqno

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_drv.h |6 +++--- drivers/gpu/drm/i915/i915_gem.c |6 +++--- drivers/gpu/drm/i915/intel_overlay.c |4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/

[Intel-gfx] [RFC 18/21] drm/i915: Convert 'trace_irq' to use requests rather than seqnos

2014-10-06 Thread John . C . Harrison
From: John Harrison Note: i915_trace_irq_get is no longer inline as it requires accessing the internals of the request structure. As i915_drv.h includes intel_ringbuffer.h, an inline within the former is never going to be able to use details from the latter. For: VIZ-4377 Signed-off-by: john.c.h

[Intel-gfx] [RFC 07/21] drm/i915: Ensure requests stick around during waits

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_gem.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 2c33a83..53b48ad

[Intel-gfx] [RFC 06/21] drm/i915: Replace last_[rwf]_seqno with last_[rwf]_req

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c|6 +-- drivers/gpu/drm/i915/i915_drv.h|6 +-- drivers/gpu/drm/i915/i915_gem.c| 66 drivers/gpu/drm/i915/i915_g

[Intel-gfx] [RFC 04/21] drm/i915: Add reference count to request structure

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_drv.h | 16 drivers/gpu/drm/i915/i915_gem.c | 20 drivers/gpu/drm/i915/intel_lrc.c|2 ++ drivers/gpu/drm/i915/intel_ringb

[Intel-gfx] [RFC 09/21] drm/i915: Make 'i915_gem_check_olr' actually check by request not seqno

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_drv.h | 17 - drivers/gpu/drm/i915/i915_gem.c | 25 ++--- drivers/gpu/drm/i915/intel_display.c |2 +- 3 files changed, 27 insertions(+),

[Intel-gfx] [RFC 01/21] Bug: missing i915_seqno_passed() call?

2014-10-06 Thread John . C . Harrison
From: John Harrison --- drivers/gpu/drm/i915/i915_gem.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 2a5351d..8c68219 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem

[Intel-gfx] [RFC 03/21] drm/i915: Ensure OLS & PLR are always in sync

2014-10-06 Thread John . C . Harrison
From: John Harrison The new seqno alloction code pre-allocates a 'lazy' request structure and then tries to allocate the 'lazy' seqno. The seqno allocation can potential wrap around zero and when doing so, tries to idle the ring by waiting for all oustanding work to complete. With a scheduler in

[Intel-gfx] [RFC 00/21] Replace seqno values with request structures

2014-10-06 Thread John . C . Harrison
From: John Harrison Work in progress for replacing seqno usage with requst structures. There is a general feeling that it is better to move away from using a simple integer 'seqno' value to track batch buffer completion. Instead, the request structure should be used. That provides for much more

[Intel-gfx] [RFC 02/21] drm/i915: Remove redundant parameter to i915_gem_object_wait_rendering__tail()

2014-10-06 Thread John . C . Harrison
From: John Harrison For: VIZ-4377 Signed-off-by: john.c.harri...@intel.com --- drivers/gpu/drm/i915/i915_gem.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 8c68219..aa2d882 100644 --- a/drive

Re: [Intel-gfx] Kswapd 100% CPU since 3.8 on Sandybridge

2014-10-06 Thread Daniel Vetter
On Mon, Oct 6, 2014 at 11:37 AM, Mel Gorman wrote: > Minimally I wanted you to sample the stack traces for kswapd, narrow down > to the time of its failure and see if it was stuck in a shrinker loop. What > I suspected at the time was that it was hammering on the i915 shrinker and > possibly doing

Re: [Intel-gfx] Kswapd 100% CPU since 3.8 on Sandybridge

2014-10-06 Thread Mel Gorman
On Sat, Oct 04, 2014 at 10:05:20AM -0700, Sarah A Sharp wrote: > Please excuse the non-wrapped email. My personal system is currently > b0rked, so I'm sending this in frustration from my phone. > > My laptop is currently completely hosed. Disk light on full solid > Mouse movement sluggish to the p

Re: [Intel-gfx] Kswapd 100% CPU since 3.8 on Sandybridge

2014-10-06 Thread Daniel Vetter
On Sat, Oct 04, 2014 at 10:05:20AM -0700, Sarah A Sharp wrote: > Please excuse the non-wrapped email. My personal system is currently > b0rked, so I'm sending this in frustration from my phone. > > My laptop is currently completely hosed. Disk light on full solid > Mouse movement sluggish to the p

[Intel-gfx] Kswapd 100% CPU since 3.8 on Sandybridge

2014-10-06 Thread Sarah A Sharp
Please excuse the non-wrapped email. My personal system is currently b0rked, so I'm sending this in frustration from my phone. My laptop is currently completely hosed. Disk light on full solid Mouse movement sluggish to the point of moving a couple cms per second. Firefox window greyed out but not