Re: [Intel-gfx] [PATCH 0/6] Kill IS_ULT() in favour of the per-product variant

On Fri, Oct 03, 2014 at 03:52:18PM -0300, Paulo Zanoni wrote: > 2014-10-03 15:46 GMT-03:00 Paulo Zanoni : > > 2014-10-03 15:40 GMT-03:00 Paulo Zanoni : > >> 2014-10-01 17:36 GMT-03:00 Daniel Vetter : > >>> On Wed, Oct 01, 2014 at 08:04:12PM +0100, Damien Lespiau wrote: > A few reasons why I'd

Re: [Intel-gfx] [PATCH 14/14] drm/i915: kerneldoc for intel_fifo_underrun.c

On Fri, Oct 03, 2014 at 03:00:46PM -0300, Paulo Zanoni wrote: > 2014-09-30 5:56 GMT-03:00 Daniel Vetter : > > Signed-off-by: Daniel Vetter > > Patch 10/14: Needs rebase, but ok. Was just an || IS_GEN9 from the skl patches. > Patch 11/14: Ok. > Patch 12/14: Nice one, but: > - I've seen you compl

Re: [Intel-gfx] [PATCH 0/6] Kill IS_ULT() in favour of the per-product variant

2014-10-03 15:46 GMT-03:00 Paulo Zanoni : > 2014-10-03 15:40 GMT-03:00 Paulo Zanoni : >> 2014-10-01 17:36 GMT-03:00 Daniel Vetter : >>> On Wed, Oct 01, 2014 at 08:04:12PM +0100, Damien Lespiau wrote: A few reasons why I'd like to do that: - IS_ULT() started as a HSW-only macro but

Re: [Intel-gfx] [PATCH 0/6] Kill IS_ULT() in favour of the per-product variant

2014-10-03 15:40 GMT-03:00 Paulo Zanoni : > 2014-10-01 17:36 GMT-03:00 Daniel Vetter : >> On Wed, Oct 01, 2014 at 08:04:12PM +0100, Damien Lespiau wrote: >>> A few reasons why I'd like to do that: >>> >>> - IS_ULT() started as a HSW-only macro but has grown to mean >>> IS_BDW_ULT/ULX >>> as

Re: [Intel-gfx] [PATCH 0/6] Kill IS_ULT() in favour of the per-product variant

2014-10-01 17:36 GMT-03:00 Daniel Vetter : > On Wed, Oct 01, 2014 at 08:04:12PM +0100, Damien Lespiau wrote: >> A few reasons why I'd like to do that: >> >> - IS_ULT() started as a HSW-only macro but has grown to mean IS_BDW_ULT/ULX >> as well. That means a few usages of IS_ULT() were slightl

Re: [Intel-gfx] [PATCH 61/89] drm/i915/skl: Determine enabled PLL and its linkrate/pixel clock

2014-10-01 7:51 GMT-03:00 M, Satheeshakrishna : > On 9/23/2014 1:42 AM, Paulo Zanoni wrote: >> >> 2014-09-04 8:27 GMT-03:00 Damien Lespiau: >>> >>> From: Satheeshakrishna M >>> >>> v2: Fixup compilation due to the removal of the intel_ddi_dpll_id enum. >>> And add a fixme about the abuse of pipe_co

Re: [Intel-gfx] [PATCH 14/14] drm/i915: kerneldoc for intel_fifo_underrun.c

2014-09-30 5:56 GMT-03:00 Daniel Vetter : > Signed-off-by: Daniel Vetter Patch 10/14: Needs rebase, but ok. Patch 11/14: Ok. Patch 12/14: Nice one, but: - I've seen you complaining about lines bigger than 80 columns before, so I obviously have to do the same here :) - Can't we now unexport (make

Re: [Intel-gfx] [PATCH 18/18] drm/i915/audio: add DOC comment describing HDA over HDMI/DP

On Fri, Oct 03, 2014 at 03:44:01PM +0300, Jani Nikula wrote: > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_audio.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_audio.c > b/drivers/gpu/drm/i915/intel_audio.c > index

[Intel-gfx] [PATCH RFC 0/4] drm/core: restore suspend/resume calbacks in KMS drm drivers

The main intent of this patchset is to allow use of suspend/resume drm driver callbacks in KMS drivers, as these callbacks seems to me the best place to implement suspend/resume functionality in drm driver. Implementing this functionality in master component driver PM ops is problematic as those ca

[Intel-gfx] [PATCH RFC 3/4] drm/exynos: remove master component PM callbacks

The patch removes master PM callbacks as their functionality is already duplicated by suspend/resume drm callbacks. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 29 - 1 file changed, 29 deletions(-) diff --git a/drivers/gpu/drm/exynos/ex

[Intel-gfx] [PATCH RFC 4/4] drm/exynos: correct connector->dpms field before resuming

During system suspend after connector switch off its dpms field is set to connector previous dpms state. To properly resume dpms field should be set to its actual state (off) before resuming to previous dpms state. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 8

Re: [Intel-gfx] [PATCH RFC 0/4] drm/core: restore suspend/resume calbacks in KMS drm drivers

On 10/03/2014 10:31 AM, Daniel Vetter wrote: > On Fri, Oct 03, 2014 at 10:24:09AM +0200, Andrzej Hajda wrote: >> The main intent of this patchset is to allow use of suspend/resume drm driver >> callbacks in KMS drivers, as these callbacks seems to me the best place >> to implement suspend/resume fu

[Intel-gfx] [PATCH RFC 1/4] drm/i915: set PM callbacks only if modeset is turned off

Currently suspend and resume callbacks are called only if driver have modeset feature disabled. This patch moves the check directly to i915 driver, it will allow to remove the check from the core in the future. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/i915_drv.c | 6 ++ 1 file c

[Intel-gfx] [PATCH RFC 2/4] drm/core: re-enable suspend/resume callbacks for KMS drivers

Implementing suspend/resume functionality in componentized drm drivers using master component PM callbacks is problematic because those callbacks can be called asynchronously regardless of existence/state of drm device. The patch re-enables suspend/resume drm driver callbacks in drivers with modese

[Intel-gfx] Updated drm-intel-testing

Hi all, New -testing cycle with cool stuff: - first batch of skl stage 1 enabling - fixes from Rodrigo to the PSR, fbc and sink crc code - kerneldoc for the frontbuffer tracking code, runtime pm code and the basic interrupt enable/disable functions - smaller stuff all over Happy testing! Cheer

Re: [Intel-gfx] [PATCH RFC 0/4] drm/core: restore suspend/resume calbacks in KMS drm drivers

On Fri, Oct 03, 2014 at 01:39:21PM +0200, Daniel Vetter wrote: > On Fri, Oct 3, 2014 at 11:42 AM, Andrzej Hajda wrote: > > But this is an issue closely connected with component framework. > > Component framework separates master component probe and drm device > > initialization. As a result PM ops

Re: [Intel-gfx] [PATCH] drm/i915: Remove the duplicated logic between the two shrink phases

On Fri, Oct 03, 2014 at 10:29:51AM +0100, Chris Wilson wrote: > We can use the same logic to walk the different bound/unbound lists > during shrinker (as the unbound list is a degenerate case of the bound > list), slightly compacting the code. > > Signed-off-by: Chris Wilson Queued for -next, th

[Intel-gfx] [PATCH 17/18] drm/i915: make pipe/port based audio valid accessors easier to use

Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h| 20 ++-- drivers/gpu/drm/i915/intel_audio.c | 22 ++ drivers/gpu/drm/i915/intel_ddi.c | 2 +- 3 files changed, 17 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 12/18] drm/i915/audio: rewrite vlv/chv and gen 5-7 audio codec enable sequence

Similar to the hsw/bdw enable sequence rewrite. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_audio.c | 58 +- 1 file changed, 26 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c

[Intel-gfx] [PATCH 18/18] drm/i915/audio: add DOC comment describing HDA over HDMI/DP

Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_audio.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 58de48ff3585..6d1f8438dc4d 100644 --- a/drivers/gpu/drm/i915/intel_audio.c ++

[Intel-gfx] [PATCH 15/18] drm/i915/audio: add audio codec disable on g4x

This not based on any documentation... Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_audio.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 02d993c0d743..af19ecf87bb0 100644 ---

[Intel-gfx] [PATCH 16/18] drm/i915/audio: add audio codec enable debug log for g4x

Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_audio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index af19ecf87bb0..03caa8e9bf25 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 13/18] drm/i915/audio: add vlv/chv/gen5-7 audio codec disable sequence

Add support for disabling the audio codec on vlv/chv/gen5-7, similar to hsw/bdw. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_audio.c | 52 ++ drivers/gpu/drm/i915/intel_dp.c| 4 +++ drivers/gpu/drm/i915/intel_hdmi.c | 4 +++ 3 files change

[Intel-gfx] [PATCH 14/18] drm/i915: enable audio codec after port

As per spec, and similar to DDI. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dp.c | 13 - drivers/gpu/drm/i915/intel_hdmi.c | 15 +++ 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/in

[Intel-gfx] [PATCH 10/18] drm/i915: clean up and clarify audio related register defines

Make audio related register defines conform to existing style: Add _MASK where relevant, indent the defines for register contents, don't indent the defines for register addresses, prefix pipe specific register address defines with underscores, drop self explanatory comments. No functional changes.

[Intel-gfx] [PATCH 11/18] drm/i915: rewrite hsw/bdw audio codec enable/disable sequences

There's some serious confusion regarding ELD valid bit that gets set and cleared back and forth etc. Rewrite it all based on the documented audio codec enable/disable sequences. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_audio.c | 106 +++-- 1 file

[Intel-gfx] [PATCH 07/18] drm/i915/ddi: write ELD where it's supposed to be done

The audio programming sequence states that the ELD must be written and enabled after the pipe is ready. Indeed, this should clarify the situation with commit c79057922ed6c2c6df1214e6ab4414fea1b23db2 Author: Daniel Vetter Date: Wed Apr 16 16:56:09 2014 +0200 drm/i915: Remove vblank wait fro

[Intel-gfx] [PATCH 09/18] drm/i915/audio: remove misleading checks for !eld[0]

We'll never end up in the hooks with eld[0] unset, as that's checked by drm_select_eld(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_audio.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c in

[Intel-gfx] [PATCH 08/18] drm/i915: introduce intel_audio_codec_{enable, disable}

Introduce functions to enable/disable the audio codec, incorporating the ELD setup within enable. The disable is initially limited to HSW, covering exactly what was done previously. The only functional difference is that ELD valid is no longer set if there is no connector with ELD, which should be

[Intel-gfx] [PATCH 06/18] drm/i915/audio: set ELD Conn_Type at one place

Keep the driver modifications to ELD together. This also sets the Conn_Type for G4X DP which wasn't done before. Clean up the debugs while at it; this is all obvious from the connector name. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_audio.c | 19 +-- 1 file chang

[Intel-gfx] [PATCH 01/18] drm/i915: add new intel audio file to group DP/HDMI audio

In preparation for some additional cleanup. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/intel_audio.c | 352 +++ drivers/gpu/drm/i915/intel_display.c | 321 +---

[Intel-gfx] [PATCH 03/18] drm/i915/audio: beat some sense into the variable types and names

Most importantly, "i" need not be the universal variable used for everything. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_audio.c | 115 ++--- 1 file changed, 57 insertions(+), 58 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 04/18] drm/i915: pass intel_encoder to intel_write_eld

Everything else can be derived from that. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_audio.c | 9 + drivers/gpu/drm/i915/intel_ddi.c | 2 +- drivers/gpu/drm/i915/intel_dp.c| 2 +- drivers/gpu/drm/i915/intel_drv.h | 3 +-- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 02/18] drm/i915/audio: constify hdmi audio clock struct

Const is good. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 461363e881b3..2397ac3c9842 100644 --- a/drivers/gpu/drm/i915/intel_a

[Intel-gfx] [PATCH 00/18] drm/i915: hdmi/dp audio rework

So I set out to split out the audio stuff into its own file, doing some cleanups and maybe fixing a bug or two along the way. Here's the first 18 patches. ;) There's still some issues with vblank waits that need to be revisited, but I wanted to get early feedback anyway. So disregard those bits fo

[Intel-gfx] [PATCH 05/18] drm/i915/audio: pass intel_encoder on to platform specific ELD functions

This will simplify things later on. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h| 4 ++-- drivers/gpu/drm/i915/intel_audio.c | 14 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers

Re: [Intel-gfx] [PATCH 07/14] drm/i915: s/pm._irqs_disabled/pm.irqs_enabled/

On Fri, Oct 03, 2014 at 10:27:26AM +0100, Chris Wilson wrote: > On Fri, Oct 03, 2014 at 11:19:26AM +0200, Daniel Vetter wrote: > > On Thu, Oct 02, 2014 at 05:36:11PM -0300, Paulo Zanoni wrote: > > > 2014-09-30 5:56 GMT-03:00 Daniel Vetter : > > > > Double negations just parse harder. Also this allo

Re: [Intel-gfx] [PATCH RFC 0/4] drm/core: restore suspend/resume calbacks in KMS drm drivers

On Fri, Oct 3, 2014 at 11:42 AM, Andrzej Hajda wrote: > On 10/03/2014 10:31 AM, Daniel Vetter wrote: >> On Fri, Oct 03, 2014 at 10:24:09AM +0200, Andrzej Hajda wrote: >>> The main intent of this patchset is to allow use of suspend/resume drm >>> driver >>> callbacks in KMS drivers, as these callb

[Intel-gfx] [PATCH] drm/i915: Remove the duplicated logic between the two shrink phases

We can use the same logic to walk the different bound/unbound lists during shrinker (as the unbound list is a degenerate case of the bound list), slightly compacting the code. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 49 - 1 file c

Re: [Intel-gfx] [PATCH 07/14] drm/i915: s/pm._irqs_disabled/pm.irqs_enabled/

On Fri, Oct 03, 2014 at 11:19:26AM +0200, Daniel Vetter wrote: > On Thu, Oct 02, 2014 at 05:36:11PM -0300, Paulo Zanoni wrote: > > 2014-09-30 5:56 GMT-03:00 Daniel Vetter : > > > Double negations just parse harder. Also this allows us to ditch some > > > init code since clearing to 0 dtrt. Also dit

Re: [Intel-gfx] [PATCH 07/14] drm/i915: s/pm._irqs_disabled/pm.irqs_enabled/

On Thu, Oct 02, 2014 at 05:36:11PM -0300, Paulo Zanoni wrote: > 2014-09-30 5:56 GMT-03:00 Daniel Vetter : > > Double negations just parse harder. Also this allows us to ditch some > > init code since clearing to 0 dtrt. Also ditch the assignment in > > intel_pm_setup, that's not redundant since we

[Intel-gfx] [PULL] drm-intel-next-fixes for 3.18

Hi Dave, Bunch of fixes for 3.18. Major parts: - ppgtt fixes (but full ppgtt is for 3.19) from Chris, Michel, ... - hdmi pixel replication fixes (Clint Taylor) - leftover i830M patches from Ville - small things all over I'll be travelling the next two weeks (xdc&plumbers) but should be around a f

[Intel-gfx] [PULL] topic/core-stuff

Hi Dave, Two leftover core patches for 3.18, Clint found one more troublesome hdmi mode and some cleanup patch from Andrzej. Cheers, Daniel The following changes since commit 7a42e83d36d2d0a68622320900dc4e880b1d920a: Merge branch 'for-airlied-next' of git://people.freedesktop.org/~mlankhors

Re: [Intel-gfx] [PATCH RFC 0/4] drm/core: restore suspend/resume calbacks in KMS drm drivers

On Fri, Oct 03, 2014 at 10:24:09AM +0200, Andrzej Hajda wrote: > The main intent of this patchset is to allow use of suspend/resume drm driver > callbacks in KMS drivers, as these callbacks seems to me the best place > to implement suspend/resume functionality in drm driver. > Implementing this fun

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Clear TX FIFO reset master override bits on chv

On Thu, Oct 02, 2014 at 05:33:05PM +0300, Mika Kuoppala wrote: > ville.syrj...@linux.intel.com writes: > > > From: Ville Syrjälä > > > > Clear the override bits to make sure the hardware maanages > > the TX FIFO reset master on its own. > > > > v2: Squash with the earlier attempt at forcing the o