Re: [Intel-gfx] [PATCH] drm/i915: Revert "drm/i915: Reject the pin ioctl on gen6+"

2014-10-02 Thread Damien Lespiau
Hi Dave, On Fri, Oct 03, 2014 at 07:12:53AM +1000, Dave Airlie wrote: > I thought we had an agreement that no features that were specific to > the non-open source userspace drivers would be merged to the kernel, > due to security and maintenance concerns, i.e. exactly this concern, > we now have t

Re: [Intel-gfx] [PATCH] drm/i915: Revert "drm/i915: Reject the pin ioctl on gen6+"

2014-10-02 Thread Dave Airlie
On 2 October 2014 20:40, Bloomfield, Jon wrote: > On Fri, Sep 19, 2014 Daniel Vetter wrote: >> I still consider pinning stuff behind the kernels back too evil. So if people >> want that I'd like to see the use-case and why we can't do this differently. >> >> And I've never approved of the pin ioct

Re: [Intel-gfx] [PATCH 09/14] drm/i915: kerneldoc for interrupt enable/disable functions

2014-10-02 Thread Paulo Zanoni
2014-09-30 5:56 GMT-03:00 Daniel Vetter : > Just start with the basics for now. > > Since there's a lot of different functionality in i915_irq.c I've > decided to split it into different sections and pull in just the > relevant functions. Splitting into different files looks like a lot > more work

Re: [Intel-gfx] [PATCH 08/14] drm/i915: Use dev_priv instead of dev in irq setup functions

2014-10-02 Thread Paulo Zanoni
2014-09-30 5:56 GMT-03:00 Daniel Vetter : > It's the new world order! > > Not going full monty on these here and rolling this out throughout the > subsequent call chains since this is just for the kerneldoc. Later on > we can go more crazy, especially once we've embedded drm_device > correctly. > >

Re: [Intel-gfx] [PATCH 07/14] drm/i915: s/pm._irqs_disabled/pm.irqs_enabled/

2014-10-02 Thread Paulo Zanoni
2014-09-30 5:56 GMT-03:00 Daniel Vetter : > Double negations just parse harder. Also this allows us to ditch some > init code since clearing to 0 dtrt. Also ditch the assignment in > intel_pm_setup, that's not redundant since we do the assignement now > while setting up interrupts. > > While at it

Re: [Intel-gfx] randconfig build error with next-20141001, in drivers/gpu/drm/i915

2014-10-02 Thread Randy Dunlap
On 10/02/14 00:46, Jani Nikula wrote: > On Wed, 01 Oct 2014, Randy Dunlap wrote: >> On 10/01/14 10:57, Jani Nikula wrote: >>> On Wed, 01 Oct 2014, Jim Davis wrote: Building with the attached random configuration file, warning: (VIDEO_TIMBERDALE) selects TIMB_DMA which has unmet dir

Re: [Intel-gfx] [PATCH] lib/Android.mk: add define of IGT_DATADIR for igt_fb.c

2014-10-02 Thread Thomas Wood
On 2 October 2014 16:26, wrote: > From: Tim Gore > > Since the igt_create_stereo_fb function moved into igt_fb.c > we need to add the definition of IGT_DATADIR in the Android > makefile in order to build the cairo dependent tests. > > Signed-off-by: Tim Gore Patch merged, thanks. > --- > li

[Intel-gfx] [PATCH] lib/Android.mk: add define of IGT_DATADIR for igt_fb.c

2014-10-02 Thread tim . gore
From: Tim Gore Since the igt_create_stereo_fb function moved into igt_fb.c we need to add the definition of IGT_DATADIR in the Android makefile in order to build the cairo dependent tests. Signed-off-by: Tim Gore --- lib/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Clear TX FIFO reset master override bits on chv

2014-10-02 Thread Mika Kuoppala
ville.syrj...@linux.intel.com writes: > From: Ville Syrjälä > > Clear the override bits to make sure the hardware maanages > the TX FIFO reset master on its own. > > v2: Squash with the earlier attempt at forcing the override bits > > Signed-off-by: Ville Syrjälä Reviewed-by: Mika Kuoppala >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Make sure hardware uses the correct swing margin/deemph bits on chv

2014-10-02 Thread Mika Kuoppala
ville.syrj...@linux.intel.com writes: > From: Ville Syrjälä > > The register can house two different swing marging/deemph settings at > once. However only one gets used based on some other bits. Make sure we > set those bits correctly to make the hardware use the settings we > provided. > > Signe

[Intel-gfx] [PULL] drm-intel-fixes

2014-10-02 Thread Jani Nikula
Hi Dave, final regression fix for 3.17. BR, Jani. The following changes since commit fe82dcec644244676d55a1384c958d5f67979adb: Linux 3.17-rc7 (2014-09-28 14:29:07 -0700) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/drm-intel-fixes-2014-10-02 for y

Re: [Intel-gfx] [PATCH] tests: Sprinkle missing igt_exit() where needed.

2014-10-02 Thread Gore, Tim
> -Original Message- > From: root [mailto:daniel.vet...@ffwll.ch] > Sent: Thursday, October 02, 2014 10:36 AM > To: Intel Graphics Development > Cc: Daniel Vetter; Gore, Tim; Vetter, Daniel > Subject: [PATCH] tests: Sprinkle missing igt_exit() where needed. > > From: Daniel Vetter > >

Re: [Intel-gfx] limiting modes on 4k monitors on Haswell ULT

2014-10-02 Thread Damien Lespiau
On Thu, Oct 02, 2014 at 10:00:50AM +0200, Daniel Vetter wrote: > On Thu, Oct 02, 2014 at 01:30:48PM +1000, Dave Airlie wrote: > > Hey guys, > > > > so I have a haswell ULT laptop (lenovo t440s), and got access to a > > Samsung single panel 4k monitor (no MST). > > > > Now we detect the monitor fi

[Intel-gfx] [PATCH] tests: Sprinkle missing igt_exit() where needed.

2014-10-02 Thread root
From: Daniel Vetter Yay for breaking piles of tests. This regression has been introduced with commit 5782eca1e19e85a04ad402fa4094aa1b5f9c53ce Author: Tim Gore Date: Wed Oct 1 13:25:20 2014 +0100 lib/igt_core.c: disable lowmemorykiller during tests Cc: Tim Gore Signed-off-by: Daniel Ve

Re: [Intel-gfx] limiting modes on 4k monitors on Haswell ULT

2014-10-02 Thread Dave Airlie
On 2 October 2014 18:40, Ville Syrjälä wrote: > On Thu, Oct 02, 2014 at 10:00:50AM +0200, Daniel Vetter wrote: >> On Thu, Oct 02, 2014 at 01:30:48PM +1000, Dave Airlie wrote: >> > Hey guys, >> > >> > so I have a haswell ULT laptop (lenovo t440s), and got access to a >> > Samsung single panel 4k mo

Re: [Intel-gfx] [PATCH] drm/i915: Revert "drm/i915: Reject the pin ioctl on gen6+"

2014-10-02 Thread Bloomfield, Jon
On Fri, Sep 19, 2014 Daniel Vetter wrote: > I still consider pinning stuff behind the kernels back too evil. So if people > want that I'd like to see the use-case and why we can't do this differently. > > And I've never approved of the pin ioctl but really loudly complained about > each occasion I

Re: [Intel-gfx] limiting modes on 4k monitors on Haswell ULT

2014-10-02 Thread Ville Syrjälä
On Thu, Oct 02, 2014 at 10:00:50AM +0200, Daniel Vetter wrote: > On Thu, Oct 02, 2014 at 01:30:48PM +1000, Dave Airlie wrote: > > Hey guys, > > > > so I have a haswell ULT laptop (lenovo t440s), and got access to a > > Samsung single panel 4k monitor (no MST). > > > > Now we detect the monitor fi

Re: [Intel-gfx] [PATCH] drm/i915: fix short vs. long hpd detection

2014-10-02 Thread Daniel Vetter
On Thu, Oct 02, 2014 at 11:16:32AM +0300, Jani Nikula wrote: > Fix short vs. long hpd detection for non-g4x and non-pch split > platforms. > > Broken since introduction in > commit 13cf550448b58abf8f44f5d6a560f2d20871c965 > Author: Dave Airlie > Date: Wed Jun 18 11:29:35 2014 +1000 > > drm

[Intel-gfx] [PATCH] drm/i915: fix short vs. long hpd detection

2014-10-02 Thread Jani Nikula
Fix short vs. long hpd detection for non-g4x and non-pch split platforms. Broken since introduction in commit 13cf550448b58abf8f44f5d6a560f2d20871c965 Author: Dave Airlie Date: Wed Jun 18 11:29:35 2014 +1000 drm/i915: rework digital port IRQ handling (v2) Bugzilla: https://bugs.freedeskto

Re: [Intel-gfx] limiting modes on 4k monitors on Haswell ULT

2014-10-02 Thread Daniel Vetter
On Thu, Oct 02, 2014 at 01:30:48PM +1000, Dave Airlie wrote: > Hey guys, > > so I have a haswell ULT laptop (lenovo t440s), and got access to a > Samsung single panel 4k monitor (no MST). > > Now we detect the monitor fine, but unfortunately the ULT hsw can't > run it over DP, as it has clock lim

Re: [Intel-gfx] [PATCH] drm/i915: make sink_crc return -EIO on aux read/write failure

2014-10-02 Thread Daniel Vetter
On Wed, Oct 01, 2014 at 07:32:37AM -0700, Rodrigo Vivi wrote: Nothing is usually to little commit message. I've fixed this while applying. > Cc: Daniel Vetter > Cc: Todd Previte > Signed-off-by: Rodrigo Vivi Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_

Re: [Intel-gfx] randconfig build error with next-20141001, in drivers/gpu/drm/i915

2014-10-02 Thread Jani Nikula
On Wed, 01 Oct 2014, Randy Dunlap wrote: > On 10/01/14 10:57, Jani Nikula wrote: >> On Wed, 01 Oct 2014, Jim Davis wrote: >>> Building with the attached random configuration file, >>> >>> warning: (VIDEO_TIMBERDALE) selects TIMB_DMA which has unmet direct >>> dependencies (DMADEVICES && MFD_TIMBE

[Intel-gfx] [PATCH] drm/i915: Constify send buffer for intel_dp_aux_ch

2014-10-02 Thread Daniel Vetter
Inspired by Ville constifying the send buffer for pach_aux. Cc: Ville Syrjälä Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 7ba3e1bb711a

Re: [Intel-gfx] [PATCH v2] drm/i915: De-magic the PSR AUX message

2014-10-02 Thread Daniel Vetter
On Wed, Oct 01, 2014 at 04:56:56PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Use pack_aux() to construct the PSR exit DPMS D0 AUX message, > and use the defines from dp_dp_helper.h to populate the message > contents. > > v2: Use sizeof() for message size (Jani) >