Long ago, back in the racy haydays of 915gm interrupt handling, page
flips would occasionally go astray and leave the hardware stuck, and the
display not updating. This annoyed people who relied on their systems
being able to display continuously updating information 24/7, and so
some code to detec
Hi Daniel,
these are the first two patches in the flip boosting series pushed ahead
of the request rework. These are the interesting ones as they help paper
over oddities in our hardware and prevent the driver from wedging itself
with a stuck modeset.
-Chris
__
If we successfully confuse the hardware, and cause it to drop a queued
pageflip, we wait for 60s and issue a warning before continuing on with
the modeset. However, this leaves the pending pageflip still stuck
indefinitely. Pretend to userspace that it does complete, and let us
start afresh followi
adding suspend_autoresume on primary tests like this:
@ -470,6 +472,8 @@ igt_main
data.test_plane = PRIMARY;
data.op = op;
run_test(&data);
+ igt_system_suspend_autoresume();
+ run_te
Here goes results on BDW with pure today's nightly (with idle_frame=1)
# First run
IGT-Version: 1.7-gd4b43f0 (x86_64) (Linux: 3.17.0-rc2+ x86_64)
Subtest primary_page_flip: SUCCESS
Subtest primary_mmap_gtt: SUCCESS
Test assertion failure function test_crc, file kms_psr_sink_crc.c:307:
Failed ass
First of all sorry for the huge amount of emails.
I don't know what happened with my git send-email and my slow server...
Well, this series is one alternative for the debug using igt_core debug
helpers.
But I'm not confident igt_debug_wait and igt_dry_run are the best way to do
that.
So please le
This helps to debug and check if the CRC you are reading correspond
what you are seeing on the screen
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index bbe18f0..51e54a7 100644
IGT_DRY_RUN allows you to run tests independent of any desired condition.
For instance you can allow tests to run with the feature in test disabled
in order to compare what results you should expect when the feature is
actually enabled.
Signed-off-by: Rodrigo Vivi
---
lib/igt_core.c | 16 +++
That allows you to read the debug and look to the screen to make
sure what is on the screen is what you are expecting on debug line.
Signed-off-by: Rodrigo Vivi
---
lib/igt_core.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/igt_core.h b/lib/igt_core.h
index b4eb724..e0
This allows to run tests with psr disabled and know what to expect when
PSR is actually enabled.
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 8
1 file changed, 8 insertions(+)
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index 51e54a7..1380ca4 100644
Lets just do this small sleep to allow human eyes to see what is happening,
but let's avoid any kind of interference on the actual test.
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/kms_psr_sink_crc.c b/te
Lets just do this small sleep to allow human eyes to see what is happening,
but let's avoid any kind of interference on the actual test.
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/kms_psr_sink_crc.c b/te
This helps to debug and check if the CRC you are reading correspond
what you are seeing on the screen
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index bbe18f0..51e54a7 100644
IGT_DRY_RUN allows you to run tests independent of any desired condition.
For instance you can allow tests to run with the feature in test disabled
in order to compare what results you should expect when the feature is
actually enabled.
Signed-off-by: Rodrigo Vivi
---
lib/igt_core.c | 16 +++
That allows you to read the debug and look to the screen to make
sure what is on the screen is what you are expecting on debug line.
Signed-off-by: Rodrigo Vivi
---
lib/igt_core.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/igt_core.h b/lib/igt_core.h
index b4eb724..e0
This allows to run tests with psr disabled and know what to expect when
PSR is actually enabled.
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 8
1 file changed, 8 insertions(+)
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index 51e54a7..1380ca4 100644
This allows to run tests with psr disabled and know what to expect when
PSR is actually enabled.
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 8
1 file changed, 8 insertions(+)
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index 51e54a7..1380ca4 100644
Lets just do this small sleep to allow human eyes to see what is happening,
but let's avoid any kind of interference on the actual test.
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/kms_psr_sink_crc.c b/te
IGT_DRY_RUN allows you to run tests independent of any desired condition.
For instance you can allow tests to run with the feature in test disabled
in order to compare what results you should expect when the feature is
actually enabled.
Signed-off-by: Rodrigo Vivi
---
lib/igt_core.c | 16 +++
This helps to debug and check if the CRC you are reading correspond
what you are seeing on the screen
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index bbe18f0..51e54a7 100644
That allows you to read the debug and look to the screen to make
sure what is on the screen is what you are expecting on debug line.
Signed-off-by: Rodrigo Vivi
---
lib/igt_core.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/igt_core.h b/lib/igt_core.h
index b4eb724..e0
IGT_DRY_RUN allows you to run tests independent of any desired condition.
For instance you can allow tests to run with the feature in test disabled
in order to compare what results you should expect when the feature is
actually enabled.
Signed-off-by: Rodrigo Vivi
---
lib/igt_core.c | 16 +++
This allows to run tests with psr disabled and know what to expect when
PSR is actually enabled.
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 8
1 file changed, 8 insertions(+)
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index 51e54a7..1380ca4 100644
Lets just do this small sleep to allow human eyes to see what is happening,
but let's avoid any kind of interference on the actual test.
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/kms_psr_sink_crc.c b/te
This helps to debug and check if the CRC you are reading correspond
what you are seeing on the screen
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index bbe18f0..51e54a7 100644
That allows you to read the debug and look to the screen to make
sure what is on the screen is what you are expecting on debug line.
Signed-off-by: Rodrigo Vivi
---
lib/igt_core.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/igt_core.h b/lib/igt_core.h
index b4eb724..e0
please ignore these 5 patches...
On Thu, Sep 4, 2014 at 3:27 PM, Rodrigo Vivi wrote:
> This helps to debug and check if the CRC you are reading correspond
> what you are seeing on the screen
>
>
> Signed-off-by: Rodrigo Vivi
> ---
> tests/kms_psr_sink_crc.c | 2 ++
> 1 file changed, 2 inserti
This tests are unecessary. Mainly now with the software tracking for PSR.
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 69 +++-
1 file changed, 3 insertions(+), 66 deletions(-)
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_c
This allows to run tests with psr disabled and know what to expect when
PSR is actually enabled.
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 8
1 file changed, 8 insertions(+)
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index 51e54a7..1380ca4 100644
This is needed to be able to split tests in a matrix that tests different
input/write methods and operations for different type of planes.
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 67
1 file changed, 67 deletions(-)
diff --git a
This helps to debug and check if the CRC you are reading correspond
what you are seeing on the screen
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index bbe18f0..51e54a7 100644
IGT_DRY_RUN allows you to run tests independent of any desired condition.
For instance you can allow tests to run with the feature in test disabled
in order to compare what results you should expect when the feature is
actually enabled.
Signed-off-by: Rodrigo Vivi
---
lib/igt_core.c | 16 +++
From: Paulo Zanoni
If we don't cancel them, we may end up running them while the device
is runtime suspended, which will trigger lots and lots of WARNs on
dmesg.
Regression introduced by:
commit c76bb61a71083b2d90504cc6d0dda2047c5d63ca
Author: Daisy Sun
Date: Mon Aug 11 11:08:38 2014 -0700
2014-08-28 6:10 GMT-03:00 Chris Wilson :
> On Wed, Aug 27, 2014 at 08:57:56PM +0200, Daniel Vetter wrote:
>> On Thu, Aug 14, 2014 at 12:37:53PM -0700, Jesse Barnes wrote:
>> > On Mon, 11 Aug 2014 23:33:57 +0200
>> > Daniel Vetter wrote:
>> >
>> > > On Mon, Aug 11, 2014 at 11:08:38AM -0700, Daisy S
Oops, apparently intel_hdmi/intel_dp is the encoder - an object with a
distinct lifetime to the connector, and so we cannot simply reuse the
common function to unset and free the edid.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
drivers/gpu/drm/i915/intel_hdmi.c | 2
On Thu, Sep 4, 2014 at 2:04 AM, Daniel Vetter wrote:
> On Wed, Sep 03, 2014 at 09:30:03PM -0400, Rodrigo Vivi wrote:
> > In order to get all test cases fixed and the matrix planes-operations
> working
> > it was needed to use the common new igt kms functions for all cases.
> > Previously only spr
On Thu, Sep 4, 2014 at 9:16 PM, Rodrigo Vivi wrote:
>> Hm, I don't see a pattern at all. And that sprites seem to work best
>> also looks funky. Are the results stable when you randomize them
>> (piglit can do that for you)? Can you add a residency checks in the
>> testcase (i.e. before the update
On Thu, Sep 4, 2014 at 1:47 AM, Daniel Vetter wrote:
> On Wed, Sep 03, 2014 at 09:29:55PM -0400, Rodrigo Vivi wrote:
> > v2: Doesn't duplicate kernel's HAS_PSR. skip based on debugfs output.
> >
> > Signed-off-by: Rodrigo Vivi
>
> I'm not sure whether we should still keep this one here around gi
On 08/20/2014 03:54 AM, Thomas Wood wrote:
kmstest_edid_add_3d adds an EDID extension block with 3D support to a
copy of the specified EDID.
Signed-off-by: Thomas Wood
---
lib/igt_kms.c | 80 +++
lib/igt_kms.h | 1 +
2 files changed,
On Thu, Sep 4, 2014 at 1:06 AM, Ville Syrjälä wrote:
> On Wed, Sep 03, 2014 at 10:49:57PM -0400, Rodrigo Vivi wrote:
> > Now that we are tracking psr states on Software side we don't need HW
> help anymore.
> > So we can clean up the code a bit and avoid unecessary sets.
> >
> > Signed-off-by: Ro
On Thu, Sep 4, 2014 at 12:05 PM, Daniel Vetter wrote:
> On Thu, Sep 4, 2014 at 8:20 PM, Rodrigo Vivi
> wrote:
> > On Thu, Sep 4, 2014 at 2:22 AM, Daniel Vetter wrote:
> >>
> >> On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote:
> >> > With Software tracking we are going to PSR sooner
On Thu, Sep 4, 2014 at 8:20 PM, Rodrigo Vivi wrote:
> On Thu, Sep 4, 2014 at 2:22 AM, Daniel Vetter wrote:
>>
>> On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote:
>> > With Software tracking we are going to PSR sooner than we should and
>> > staying
>> > with blank screens in many cas
A couple of things have changed compared to Broadwell:
- Entry 9 is used for eDP
- No more FDI
v2: Update the translation values to latest specs.
v3: Rebase on top of the BDW HDMI translation patch
v4: Remove the low voltage edp tables,
Rebase on top of the patch not writing the HDMI entry
From: Pradeep Bhat
This patch reads the memory latency values for all the 8 levels for
SKL. These values are needed for the Watermark computation.
v2: Incorporated the review comments from Damien on register
indentation.
v3: Updated the code to use the sandybridge_pcode_read for reading
Readding intel-gfx since this is interesting for everyone.
On Thu, Sep 4, 2014 at 8:09 PM, Clint Taylor wrote:
> I will attempt to improve my patch submissions process. I also need to start
> annotating version in the subject field as well.
>
> When using --in_reply_to= do I just use the Message
On Thu, Sep 4, 2014 at 4:04 AM, Daniel Vetter wrote:
> On Thu, Sep 04, 2014 at 01:18:19PM +0300, Ville Syrjälä wrote:
> > On Thu, Sep 04, 2014 at 01:04:27PM +0300, Ville Syrjälä wrote:
> > > On Thu, Sep 04, 2014 at 11:29:16AM +0200, Daniel Vetter wrote:
> > > > On Thu, Sep 04, 2014 at 10:55:16AM
On Thu, Sep 4, 2014 at 3:04 AM, Ville Syrjälä wrote:
> On Thu, Sep 04, 2014 at 11:29:16AM +0200, Daniel Vetter wrote:
> > On Thu, Sep 04, 2014 at 10:55:16AM +0300, Ville Syrjälä wrote:
> > > On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote:
> > > > With Software tracking we are going
On Thu, Sep 4, 2014 at 2:22 AM, Daniel Vetter wrote:
> On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote:
> > With Software tracking we are going to PSR sooner than we should and
> staying
> > with blank screens in many cases.
> >
> > Using 2 identical frames to detect idleness is safi
On Thu, Sep 4, 2014 at 1:09 AM, Jani Nikula
wrote:
> On Thu, 04 Sep 2014, Rodrigo Vivi wrote:
> > With Software tracking we are going to PSR sooner than we should and
> staying
> > with blank screens in many cases.
> >
> > Using 2 identical frames to detect idleness is safier.
> >
> > Discovered
On Thu, Sep 4, 2014 at 12:55 AM, Ville Syrjälä <
ville.syrj...@linux.intel.com> wrote:
> On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote:
> > With Software tracking we are going to PSR sooner than we should and
> staying
> > with blank screens in many cases.
> >
> > Using 2 identical
On 08/26/2014 07:06 AM, Ville Syrjälä wrote:
On Tue, Aug 26, 2014 at 03:36:07PM +0200, Daniel Vetter wrote:
On Tue, Aug 26, 2014 at 04:21:00PM +0300, Jani Nikula wrote:
On Tue, 26 Aug 2014, Ville Syrjälä wrote:
On Tue, Aug 19, 2014 at 10:00:55AM +0300, Jani Nikula wrote:
On Mon, 18 Aug 2014,
On Thu, 4 Sep 2014 18:59:55 +0200
Daniel Vetter wrote:
> On Thu, Sep 4, 2014 at 6:24 PM, Jesse Barnes wrote:
> > On Thu, 4 Sep 2014 17:59:18 +0200
> > Daniel Vetter wrote:
> >
> >> On Thu, Aug 28, 2014 at 1:00 AM, Jesse Barnes
> >> wrote:
> >> >> diff --git a/drivers/gpu/drm/i915/i915_irq.c
On Tue, Sep 02, 2014 at 02:57:37PM +0100, Chris Wilson wrote:
> If we successfully confuse the hardware, and cause it to drop a queued
> pageflip, we wait for 60s and issue a warning before continuing on with
> the modeset. However, this leaves the pending pageflip still stuck
> indefinitely. Prete
On Thu, Sep 4, 2014 at 6:24 PM, Jesse Barnes wrote:
> On Thu, 4 Sep 2014 17:59:18 +0200
> Daniel Vetter wrote:
>
>> On Thu, Aug 28, 2014 at 1:00 AM, Jesse Barnes
>> wrote:
>> >> diff --git a/drivers/gpu/drm/i915/i915_irq.c
>> >> b/drivers/gpu/drm/i915/i915_irq.c
>> >> index 9eb303c1b621..76bc4
On Thu, Sep 04, 2014 at 04:38:39PM +0100, Chris Wilson wrote:
> On Thu, Sep 04, 2014 at 06:25:03PM +0300, Ville Syrjälä wrote:
> > On Thu, Sep 04, 2014 at 04:09:02PM +0100, Chris Wilson wrote:
> > > When run as a timer, i915_hangcheck_elapsed() must adhere to all the
> > > rules of running in a sof
On Thu, 4 Sep 2014 17:59:18 +0200
Daniel Vetter wrote:
> On Thu, Aug 28, 2014 at 1:00 AM, Jesse Barnes
> wrote:
> >> diff --git a/drivers/gpu/drm/i915/i915_irq.c
> >> b/drivers/gpu/drm/i915/i915_irq.c
> >> index 9eb303c1b621..76bc4d0de5a4 100644
> >> --- a/drivers/gpu/drm/i915/i915_irq.c
> >>
On Thu, Aug 28, 2014 at 1:00 AM, Jesse Barnes wrote:
>> diff --git a/drivers/gpu/drm/i915/i915_irq.c
>> b/drivers/gpu/drm/i915/i915_irq.c
>> index 9eb303c1b621..76bc4d0de5a4 100644
>> --- a/drivers/gpu/drm/i915/i915_irq.c
>> +++ b/drivers/gpu/drm/i915/i915_irq.c
>> @@ -589,6 +589,7 @@ __i915_enab
On Thu, 4 Sep 2014 13:29:06 +0100
Damien Lespiau wrote:
> On Thu, Sep 04, 2014 at 03:03:27PM +0300, Jani Nikula wrote:
> > On Thu, 04 Sep 2014, Damien Lespiau wrote:
> > > From: Jesse Barnes
> > >
> > > No need to mess with display.
> >
> > Why is this patch part of the skl enabling series? Th
On Thu, Sep 04, 2014 at 06:25:03PM +0300, Ville Syrjälä wrote:
> On Thu, Sep 04, 2014 at 04:09:02PM +0100, Chris Wilson wrote:
> > When run as a timer, i915_hangcheck_elapsed() must adhere to all the
> > rules of running in a softirq context. This is advantageous to us as we
> > want to minimise th
On Thu, Sep 04, 2014 at 03:14:45PM +0200, Daniel Vetter wrote:
> On Thu, Sep 04, 2014 at 12:26:31PM +0100, Damien Lespiau wrote:
> > From: Robert Beckett
> >
> > Fix ARB_MODE register read for gen >= 8 in i915_swizzle_info
> >
> > Signed-off-by: Robert Beckett
> > Signed-off-by: Damien Lespiau
On Thu, Sep 04, 2014 at 04:09:02PM +0100, Chris Wilson wrote:
> When run as a timer, i915_hangcheck_elapsed() must adhere to all the
> rules of running in a softirq context. This is advantageous to us as we
> want to minimise the risk that a driver bug will prevent us from
> detecting a hung GPU. H
On Wed, Sep 03, 2014 at 05:10:16PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Due to the upcoming atomic modesetting feature we need to separate
> some update functions into a check step that can fail and a commit
> step that should, ideally, never fail.
>
> This commit splits int
On Wed, Sep 03, 2014 at 05:10:18PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> As a preparation for atomic updates we need to split the code to check
> everything we are going to commit first. This patch starts the work to
> split intel_primary_plane_setplane() into check() and comm
When run as a timer, i915_hangcheck_elapsed() must adhere to all the
rules of running in a softirq context. This is advantageous to us as we
want to minimise the risk that a driver bug will prevent us from
detecting a hung GPU. However, that is irrelevant if the driver bug
prevents us from resettin
On Wed, Sep 03, 2014 at 05:10:17PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Due to the upcoming atomic modesetting feature we need to separate
> some update functions into a check step that can fail and a commit
> step that should, ideally, never fail.
>
> The commit part can st
On Thu, Sep 04, 2014 at 04:12:43PM +0200, Daniel Vetter wrote:
> On Thu, Sep 04, 2014 at 02:33:44PM +0100, Chris Wilson wrote:
> > On Thu, Sep 04, 2014 at 03:31:14PM +0200, Daniel Vetter wrote:
> > > Didn't 3.17 just gain the mod_delayed_work interface?
> >
> > Yes. It was so exciting and doesn't
Of course, the series now needs reviewers. There's a list of known
problems that I'm planning to address, a few of those problems are easy
to solve and ca be addressed as a new revision of those pathes. However
I'm hoping other ones can be follup up patches instead.
Known issues:
- There a kno
On Thu, Sep 04, 2014 at 03:05:11PM +0100, Damien Lespiau wrote:
> On Thu, Sep 04, 2014 at 04:00:32PM +0200, Daniel Vetter wrote:
> > On Thu, Sep 04, 2014 at 02:32:47PM +0100, Chris Wilson wrote:
> > > On Thu, Sep 04, 2014 at 12:27:43PM +0100, Damien Lespiau wrote:
> > > > Tired of copy/pasting thin
On Thu, Sep 04, 2014 at 02:33:44PM +0100, Chris Wilson wrote:
> On Thu, Sep 04, 2014 at 03:31:14PM +0200, Daniel Vetter wrote:
> > Didn't 3.17 just gain the mod_delayed_work interface?
>
> Yes. It was so exciting and doesn't appear to requeue.
I guess we could do the mod_delayed_work in add_reque
On Thu, Sep 04, 2014 at 04:00:32PM +0200, Daniel Vetter wrote:
> On Thu, Sep 04, 2014 at 02:32:47PM +0100, Chris Wilson wrote:
> > On Thu, Sep 04, 2014 at 12:27:43PM +0100, Damien Lespiau wrote:
> > > Tired of copy/pasting things around.
> > >
> > > v2: Rebase on top of the for_each_pipe() change
On Thu, Sep 04, 2014 at 02:32:47PM +0100, Chris Wilson wrote:
> > +#define for_each_plane(pipe, p) \
> > + for ((p) = 0; (p) < INTEL_INFO(dev)->num_sprites[(pipe)] + 1; (p)++)
>
> We are adding new magic macros taking dev...
>
> > #define for_each_sprite(p, s) for ((s) = 0; (s) <
> > INTEL_IN
On Thu, Sep 04, 2014 at 02:32:47PM +0100, Chris Wilson wrote:
> On Thu, Sep 04, 2014 at 12:27:43PM +0100, Damien Lespiau wrote:
> > Tired of copy/pasting things around.
> >
> > v2: Rebase on top of the for_each_pipe() change adding dev_priv as first
> > argument.
> >
> > Signed-off-by: Damien
On Thu, Sep 04, 2014 at 04:42:36PM +0300, Jani Nikula wrote:
> On Thu, 04 Sep 2014, Daniel Vetter wrote:
> > On Thu, Sep 04, 2014 at 02:12:10PM +0300, Jani Nikula wrote:
> >> On Wed, 27 Aug 2014, Daniel Vetter wrote:
> >> > A bunch of warnings fire on some ->irq_postinstall hooks since those
> >>
2014-09-04 5:48 GMT-03:00 Chris Wilson :
> On Thu, Sep 04, 2014 at 10:39:31AM +0200, Daniel Vetter wrote:
>> On Thu, Sep 04, 2014 at 10:34:13AM +0200, Daniel Vetter wrote:
>> > On Wed, Sep 03, 2014 at 02:47:21PM -0300, Paulo Zanoni wrote:
>> > > From: Paulo Zanoni
>> > >
>> > > If we don't reset e
On Thu, 04 Sep 2014, Daniel Vetter wrote:
> On Thu, Sep 04, 2014 at 02:12:10PM +0300, Jani Nikula wrote:
>> On Wed, 27 Aug 2014, Daniel Vetter wrote:
>> > A bunch of warnings fire on some ->irq_postinstall hooks since those
>> > can enable interrupts (e.g. rps interrupts). And then our ordering
>
On Thu, Sep 04, 2014 at 03:31:14PM +0200, Daniel Vetter wrote:
> Didn't 3.17 just gain the mod_delayed_work interface?
Yes. It was so exciting and doesn't appear to requeue.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mail
On Thu, Sep 04, 2014 at 12:27:43PM +0100, Damien Lespiau wrote:
> Tired of copy/pasting things around.
>
> v2: Rebase on top of the for_each_pipe() change adding dev_priv as first
> argument.
>
> Signed-off-by: Damien Lespiau
> ---
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> 1 file changed,
On Thu, Sep 04, 2014 at 01:26:36PM +0100, Chris Wilson wrote:
> On Thu, Sep 04, 2014 at 03:17:57PM +0300, Jani Nikula wrote:
> > On Thu, 04 Sep 2014, Chris Wilson wrote:
> > > When run as a timer, i915_hangcheck_elapsed() must adhere to all the
> > > rules of running in a softirq context. This is
On Thu, Sep 04, 2014 at 12:27:49PM +0100, Damien Lespiau wrote:
> v2: Don't check DDB on pre-SKL platforms
> Don't check DDB state on disabled pipes
>
> Signed-off-by: Damien Lespiau
We probably want to do this with a vfunc eventually ... but reall
deferring to Ville here, he'll know best wh
On Thu, Sep 04, 2014 at 12:27:43PM +0100, Damien Lespiau wrote:
> Tired of copy/pasting things around.
>
> v2: Rebase on top of the for_each_pipe() change adding dev_priv as first
> argument.
>
> Signed-off-by: Damien Lespiau
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/
On Thu, Sep 04, 2014 at 12:27:04PM +0100, Damien Lespiau wrote:
> SKL Uses the same hardware for all planes now, so called "universal"
> planes. Ie both the primary planes and sprite planes share the same
> logic. This patch implements the drm_plane vfuncs for "sprites" ie
> planes that aren't the
On Thu, Sep 04, 2014 at 12:26:58PM +0100, Damien Lespiau wrote:
> To accomodate the extra planes, the bit definitions were shuffled around
> a bit.
>
> v2: Rebase on top of the for_each_pipe() change adding dev_priv as first
> argument.
>
> Signed-off-by: Damien Lespiau
> ---
> drivers/gpu/
On Thu, Sep 04, 2014 at 12:26:31PM +0100, Damien Lespiau wrote:
> From: Robert Beckett
>
> Fix ARB_MODE register read for gen >= 8 in i915_swizzle_info
>
> Signed-off-by: Robert Beckett
> Signed-off-by: Damien Lespiau
given that the swizzle stuff is gone, shouldn't we just have a gen9+
check
On Thu, Sep 04, 2014 at 01:29:06PM +0100, Damien Lespiau wrote:
> On Thu, Sep 04, 2014 at 03:03:27PM +0300, Jani Nikula wrote:
> > On Thu, 04 Sep 2014, Damien Lespiau wrote:
> > > From: Jesse Barnes
> > >
> > > No need to mess with display.
> >
> > Why is this patch part of the skl enabling seri
On Thu, Sep 04, 2014 at 01:32:24PM +0100, Damien Lespiau wrote:
> On Thu, Sep 04, 2014 at 03:11:24PM +0300, Jani Nikula wrote:
> > On Thu, 04 Sep 2014, Damien Lespiau wrote:
> > > The new version of the macro does a few things better:
> > > - protect the arguments,
> > > - only evaluate the ar
On Thu, Sep 04, 2014 at 03:25:56PM +0300, Jani Nikula wrote:
> On Thu, 04 Sep 2014, Ville Syrjälä wrote:
> > On Thu, Sep 04, 2014 at 02:56:09PM +0300, Jani Nikula wrote:
> >> BDW is always in the PCH override mode, and the bit MBZ.
> >
> > BSpec doesn't seem to agree. In fact it says the override
On Thu, Sep 04, 2014 at 02:12:10PM +0300, Jani Nikula wrote:
> On Wed, 27 Aug 2014, Daniel Vetter wrote:
> > A bunch of warnings fire on some ->irq_postinstall hooks since those
> > can enable interrupts (e.g. rps interrupts). And then our ordering
> > self-checks fire and complain.
> >
> > To fix
On Thu, Sep 04, 2014 at 02:55:31PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Jani wanted some comments to explain why we call certain vdd on/off
> functions in certain places.
>
> v2: Make the comments more thorough (Imre)
>
> Reviewed-by: Imre Deak
> Signed-off-by:
On Mon, Aug 18, 2014 at 10:16:06PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Try to make sure we find the power sequencer that the BIOS used
> by first looking for one which has the panel power enabled, then
> fall back to one with VDD force bit enabled, and finally lo
On Thu, Sep 04, 2014 at 11:52:15AM +, Gupta, Sourab wrote:
> On Thu, 2014-09-04 at 10:01 +, Daniel Vetter wrote:
> > Interface design discussions should happen in public (so that
> > non-intel people can jump in, which happens rather often for other
> > drivers actually). But at least inclu
Damien Lespiau writes:
> From: Jesse Barnes
>
> No need to mess with display.
>
> Signed-off-by: Jesse Barnes
> Signed-off-by: Damien Lespiau
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncor
On Thu, Sep 04, 2014 at 03:11:24PM +0300, Jani Nikula wrote:
> On Thu, 04 Sep 2014, Damien Lespiau wrote:
> > The new version of the macro does a few things better:
> > - protect the arguments,
> > - only evaluate the arguments once,
> > - check that the arguments are of the same type,
> >
>
On Thu, Sep 04, 2014 at 03:03:27PM +0300, Jani Nikula wrote:
> On Thu, 04 Sep 2014, Damien Lespiau wrote:
> > From: Jesse Barnes
> >
> > No need to mess with display.
>
> Why is this patch part of the skl enabling series? The commit message is
> a bit thin on the details too...
I did hesitate w
On Thu, Sep 04, 2014 at 03:17:57PM +0300, Jani Nikula wrote:
> On Thu, 04 Sep 2014, Chris Wilson wrote:
> > When run as a timer, i915_hangcheck_elapsed() must adhere to all the
> > rules of running in a softirq context. This is advantageous to us as we
> > want to minimise the risk that a driver b
On Thu, 04 Sep 2014, Ville Syrjälä wrote:
> On Thu, Sep 04, 2014 at 02:56:09PM +0300, Jani Nikula wrote:
>> BDW is always in the PCH override mode, and the bit MBZ.
>
> BSpec doesn't seem to agree. In fact it says the override must be
> enabled on bdw.
Gah, I was looking at the skl bspec, which s
On Thu, 04 Sep 2014, Chris Wilson wrote:
> When run as a timer, i915_hangcheck_elapsed() must adhere to all the
> rules of running in a softirq context. This is advantageous to us as we
> want to minimise the risk that a driver bug will prevent us from
> detecting a hung GPU. However, that is irre
I thought about this one again and opposed to my previous comment now think
it's fine, also for drivers without hw vblank counter queries.
-mario
On Wed, Aug 6, 2014 at 1:49 PM, wrote:
> From: Ville Syrjälä
>
> If we already have a timestamp for the current vblank counter, don't
> update it
On Thu, 04 Sep 2014, Damien Lespiau wrote:
> The new version of the macro does a few things better:
> - protect the arguments,
> - only evaluate the arguments once,
> - check that the arguments are of the same type,
>
> Change LC_FREQ_2K to be a unsigned 64bit constant and removed the '()'
>
On Thu, Sep 04, 2014 at 02:56:09PM +0300, Jani Nikula wrote:
> BDW is always in the PCH override mode, and the bit MBZ.
BSpec doesn't seem to agree. In fact it says the override must be
enabled on bdw.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/intel_panel.c | 3 ---
> 1 file
When run as a timer, i915_hangcheck_elapsed() must adhere to all the
rules of running in a softirq context. This is advantageous to us as we
want to minimise the risk that a driver bug will prevent us from
detecting a hung GPU. However, that is irrelevant if the driver bug
prevents us from resettin
1 - 100 of 228 matches
Mail list logo
