Re: [Intel-gfx] [PATCH] drm/i915: Don't use WaGsvRC0ResidenncyMethod on chv

2014-08-29 Thread Deepak S
On Friday 29 August 2014 04:44 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä WaGsvRC0ResidenncyMethod is for vlv, it doesn't deal with chv appropriately (eg. doesn't limit rps values to even numbers). Fix a typo in the w/a name while at it. Cc: Deepak S Signed-off-by: Ville S

Re: [Intel-gfx] [PATCH] drm/i915: make fbdev initialization asynchronous v2

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 07:52:10PM +0100, Chris Wilson wrote: > On Wed, May 28, 2014 at 02:39:03PM -0700, Jesse Barnes wrote: > > This gets us out of our init code and out to userspace quite a bit > > faster, but does open us up to some bugs given the state of our init > > time locking. > > > > v2

Re: [Intel-gfx] [PATCH] drm/i915: make fbdev initialization asynchronous v2

2014-08-29 Thread Chris Wilson
On Wed, May 28, 2014 at 02:39:03PM -0700, Jesse Barnes wrote: > This gets us out of our init code and out to userspace quite a bit > faster, but does open us up to some bugs given the state of our init > time locking. > > v2: switch to async_schedule (Chris) > check with lockdep, seems happy (

Re: [Intel-gfx] [PATCH] drm/i915: Init some CHV workarounds via LRIs in ring->init_context()

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 03:43:25PM +, Barbalho, Rafael wrote: > > > > -Original Message- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > > Of Chris Wilson > > Sent: Wednesday, August 27, 2014 4:03 PM > > To: ville.syrj...@linux.intel.com > > Cc: intel-

Re: [Intel-gfx] [PATCH i-g-t 1/1] scripts: Add capability to resume interrupted run-tests.sh session

2014-08-29 Thread Thomas Wood
On 26 August 2014 21:31, Mike Mason wrote: > Piglit provides a 'resume' feature that can restart an interrupted > test run at the point where it stopped. This patch adds that > feature to run_tests.sh. > > Signed-off-by: Mike Mason > --- > scripts/run-tests.sh | 15 +++ > 1 file cha

Re: [Intel-gfx] [PATCH] drm/i915: Init some CHV workarounds via LRIs in ring->init_context()

2014-08-29 Thread Barbalho, Rafael
> -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Chris Wilson > Sent: Wednesday, August 27, 2014 4:03 PM > To: ville.syrj...@linux.intel.com > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Init some C

Re: [Intel-gfx] [PATCH 4/9] drm/i915: split intel_update_plane into check() and commit()

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 5:38 PM, Ville Syrjälä < ville.syrj...@linux.intel.com> wrote: > > Would grabbing > > struct drm_plane_state from the atomic branch fix this for you? > > That looks like it's meant to house the user requested coordinates > rather than the clipped ones. What you could do is

Re: [Intel-gfx] [PATCH 4/9] drm/i915: split intel_update_plane into check() and commit()

2014-08-29 Thread Ville Syrjälä
On Fri, Aug 29, 2014 at 12:09:39PM -0300, Gustavo Padovan wrote: > 2014-08-29 Ville Syrjälä : > > > On Thu, Aug 28, 2014 at 02:40:08PM -0300, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > Due to the upcoming atomic modesetting feature we need to separate > > > some update functi

Re: [Intel-gfx] [PATCH 4/9] drm/i915: split intel_update_plane into check() and commit()

2014-08-29 Thread Gustavo Padovan
2014-08-29 Ville Syrjälä : > On Thu, Aug 28, 2014 at 02:40:08PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Due to the upcoming atomic modesetting feature we need to separate > > some update functions into a check step that can fail and a commit > > step that should, ideally,

Re: [Intel-gfx] [PATCH] drm/i915: Don't use WaGsvRC0ResidenncyMethod on chv

2014-08-29 Thread Ville Syrjälä
On Fri, Aug 29, 2014 at 01:51:04PM +0100, Chris Wilson wrote: > On Fri, Aug 29, 2014 at 03:09:49PM +0300, Ville Syrjälä wrote: > > On Fri, Aug 29, 2014 at 12:21:27PM +0100, Chris Wilson wrote: > > > On Fri, Aug 29, 2014 at 02:14:07PM +0300, ville.syrj...@linux.intel.com > > > wrote: > > > > From:

Re: [Intel-gfx] [PATCH] drm/i915: Don't use WaGsvRC0ResidenncyMethod on chv

2014-08-29 Thread Chris Wilson
On Fri, Aug 29, 2014 at 03:09:49PM +0300, Ville Syrjälä wrote: > On Fri, Aug 29, 2014 at 12:21:27PM +0100, Chris Wilson wrote: > > On Fri, Aug 29, 2014 at 02:14:07PM +0300, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > WaGsvRC0ResidenncyMethod is for vlv, it does

Re: [Intel-gfx] [RFC] libdrm_intel: Rework BO allocs to avoid rounding up to bucket size

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 12:18:45PM +0100, Chris Wilson wrote: > What I've done in the past is kept a global pool of used pages to avoid > clflushing fresh allocations in the kernel. That runs afoul of the ABI > that we need to scrub new bo. With a create2 we could specify a pool to > use that would

Re: [Intel-gfx] [PATCH 4/9] drm/i915: split intel_update_plane into check() and commit()

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 10:55:41AM +0300, Ville Syrjälä wrote: > On Thu, Aug 28, 2014 at 02:40:08PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Due to the upcoming atomic modesetting feature we need to separate > > some update functions into a check step that can fail and a co

Re: [Intel-gfx] [PATCH] drm/i915: Don't use WaGsvRC0ResidenncyMethod on chv

2014-08-29 Thread Ville Syrjälä
On Fri, Aug 29, 2014 at 12:21:27PM +0100, Chris Wilson wrote: > On Fri, Aug 29, 2014 at 02:14:07PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > WaGsvRC0ResidenncyMethod is for vlv, it doesn't deal with chv > > appropriately (eg. doesn't limit rps values to even numb

Re: [Intel-gfx] [PATCH] drm/i915: Don't use WaGsvRC0ResidenncyMethod on chv

2014-08-29 Thread Chris Wilson
On Fri, Aug 29, 2014 at 02:14:07PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > WaGsvRC0ResidenncyMethod is for vlv, it doesn't deal with chv > appropriately (eg. doesn't limit rps values to even numbers). > > Fix a typo in the w/a name while at it. You could review my

Re: [Intel-gfx] [RFC] libdrm_intel: Rework BO allocs to avoid rounding up to bucket size

2014-08-29 Thread Chris Wilson
On Fri, Aug 29, 2014 at 11:45:13AM +0100, Siluvery, Arun wrote: > On 29/08/2014 11:16, Chris Wilson wrote: > >On Fri, Aug 29, 2014 at 11:02:01AM +0100, Arun Siluvery wrote: > >As a corollary to exact allocations, you can then reduce the number of > >buckets again (the number was increased to allow

[Intel-gfx] [PATCH] drm/i915: Don't use WaGsvRC0ResidenncyMethod on chv

2014-08-29 Thread ville . syrjala
From: Ville Syrjälä WaGsvRC0ResidenncyMethod is for vlv, it doesn't deal with chv appropriately (eg. doesn't limit rps values to even numbers). Fix a typo in the w/a name while at it. Cc: Deepak S Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 in

Re: [Intel-gfx] [RFC] libdrm_intel: Rework BO allocs to avoid rounding up to bucket size

2014-08-29 Thread Siluvery, Arun
On 29/08/2014 11:16, Chris Wilson wrote: On Fri, Aug 29, 2014 at 11:02:01AM +0100, Arun Siluvery wrote: From: Garry Lancaster libdrm includes a scheme where freed buffer objects (BOs) are held in a cache. This allows incoming allocation requests to be serviced by re-using an old BO, instead of

Re: [Intel-gfx] [RFC] libdrm_intel: Rework BO allocs to avoid rounding up to bucket size

2014-08-29 Thread Chris Wilson
On Fri, Aug 29, 2014 at 11:02:01AM +0100, Arun Siluvery wrote: > From: Garry Lancaster > > libdrm includes a scheme where freed buffer objects (BOs) > are held in a cache. This allows incoming allocation requests to be > serviced by re-using an old BO, instead of requiring a new > object to be al

[Intel-gfx] [RFC] libdrm_intel: Rework BO allocs to avoid rounding up to bucket size

2014-08-29 Thread Arun Siluvery
From: Garry Lancaster libdrm includes a scheme where freed buffer objects (BOs) are held in a cache. This allows incoming allocation requests to be serviced by re-using an old BO, instead of requiring a new object to be allocated. This is a performance enhancement. The cache is divided into "buck

[Intel-gfx] [RFC] libdrm_intel: Optimize BO alloc to avoid rounding to bucket size

2014-08-29 Thread Arun Siluvery
This patch reworks BO allocation to avoid rounding up to bucket size. Considering the current bucket sizes, certain BOs are allocated with more than the requested size wasting significant memory and it adds to the memory pressure on systems with low memory and in the worst case killing the benchmar

Re: [Intel-gfx] [PATCH 3/9] drm/i915: fix memleak in intel_set_config_save_state()

2014-08-29 Thread Jani Nikula
On Fri, 29 Aug 2014, Chris Wilson wrote: > On Fri, Aug 29, 2014 at 10:38:43AM +0300, Jani Nikula wrote: >> On Thu, 28 Aug 2014, Gustavo Padovan wrote: >> > From: Gustavo Padovan >> > >> > If the save_encoder_crtcs or save_connector_encoders allocation fail >> > we need to free everything we have

Re: [Intel-gfx] [PATCH 9/9] drm/i915: split intel_pipe_set_base() into check() and commit()

2014-08-29 Thread Ville Syrjälä
On Thu, Aug 28, 2014 at 02:40:13PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Take out some parts of code that can fail from it and move them to > intel_pipe_check_base(), the only failure point in intel_pipe_set_base() > now is the fb pinning procudure. I'd like to see intel_pip

Re: [Intel-gfx] [PATCH 4/9] drm/i915: split intel_update_plane into check() and commit()

2014-08-29 Thread Ville Syrjälä
On Thu, Aug 28, 2014 at 02:40:08PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Due to the upcoming atomic modesetting feature we need to separate > some update functions into a check step that can fail and a commit > step that should, ideally, never fail. > > This commit splits int

Re: [Intel-gfx] [PATCH 3/9] drm/i915: fix memleak in intel_set_config_save_state()

2014-08-29 Thread Chris Wilson
On Fri, Aug 29, 2014 at 10:38:43AM +0300, Jani Nikula wrote: > On Thu, 28 Aug 2014, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > If the save_encoder_crtcs or save_connector_encoders allocation fail > > we need to free everything we have already allocated. > > There is no memleak, bec

Re: [Intel-gfx] [PATCH 3/9] drm/i915: fix memleak in intel_set_config_save_state()

2014-08-29 Thread Jani Nikula
On Thu, 28 Aug 2014, Gustavo Padovan wrote: > From: Gustavo Padovan > > If the save_encoder_crtcs or save_connector_encoders allocation fail > we need to free everything we have already allocated. There is no memleak, because the caller of intel_set_config_save_state() checks the return value, a

Re: [Intel-gfx] [PATCH 2/9] drm/i915: trivial: remove unneed set to NULL

2014-08-29 Thread Jani Nikula
On Thu, 28 Aug 2014, Gustavo Padovan wrote: > From: Gustavo Padovan > > At this point of the code the obj var is already NULL, so we don't > need to set it again to NULL. Reviewed-by: Jani Nikula > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/i915/intel_display.c | 1 - > 1 file ch

[Intel-gfx] [PATCH] drm/i915: Remove bogus __init annotation from DMI callbacks

2014-08-29 Thread Mathias Krause
The __init annotations for the DMI callback functions are wrong as this code can be called even after the module has been initialized, e.g. like this: # echo 1 > /sys/bus/pci/devices/:00:02.0/remove # modprobe i915 # echo 1 > /sys/bus/pci/rescan The first command will remove the PCI dev

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-29 Thread Sun, Yi
I have tested both Jesse and Daniel's patch. On IVB both two will introduce a new warning. On HSW Daniel's patch can cause black screen. On BDW both two patch can cause black screen. _