Re: [Intel-gfx] Ping: Status of the i830 code?

2014-08-25 Thread Daniel Vetter
On Mon, Aug 25, 2014 at 03:13:46PM +0200, Thomas Richter wrote: > Hi Ville, hi Daniel, > > this is again a "ping" on the status of the i830 code. I reviewed the code I > received, at least the code I could review (I do not know enough about the > internal wirings of the intel_display source, only

Re: [Intel-gfx] [PATCH] drm/i915: don't check for i830 in vlv specific code

2014-08-25 Thread Daniel Vetter
On Fri, Aug 22, 2014 at 03:44:30PM +0300, Ville Syrjälä wrote: > On Fri, Aug 22, 2014 at 03:06:35PM +0300, Jani Nikula wrote: > > Signed-off-by: Jani Nikula > > --- > > drivers/gpu/drm/i915/intel_display.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu

[Intel-gfx] [PATCH] Merge two subtests for pm_rc6_residency IGT case

2014-08-25 Thread Wendy Wang
Combine two subtests(rc6_residency_check and rc6_residency_counter) into one subtest(residency_accuracy) diff --git a/tests/pm_rc6_residency.c b/tests/pm_rc6_residency.c index 8cf7be3..3f3363a 100644 --- a/tests/pm_rc6_residency.c +++ b/tests/pm_rc6_residency.c @@ -87,13 +87,22 @@ static void rea

Re: [Intel-gfx] [PATCH] drm/i915: Disallow any pinning when kms is enabled

2014-08-25 Thread Chris Wilson
On Mon, Aug 25, 2014 at 09:59:33PM +0200, Daniel Vetter wrote: > So apparently userspace managed to get itself into a corner with > tricky tricks and the kernel can't work around because the batch > buffer ends up being pinned. For simplicity let's just take the toys > away. No. Same nak as for th

Re: [Intel-gfx] [PATCH v3] drm/i915: Rework GPU reset sequence to match driver load & thaw

2014-08-25 Thread Chris Wilson
On Mon, Aug 25, 2014 at 10:18:09PM +0200, Daniel Vetter wrote: > On Wed, Aug 20, 2014 at 04:56:41PM +0100, Chris Wilson wrote: > > On Wed, Aug 20, 2014 at 03:21:55PM +, Mcaulay, Alistair wrote: > > > It is not the same. This is a special case when re-initialising the hw. > > > This flag is to

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Render moot context reset and switch with Execlists

2014-08-25 Thread Chris Wilson
On Mon, Aug 25, 2014 at 10:39:39PM +0200, Daniel Vetter wrote: > On Wed, Aug 20, 2014 at 04:36:05PM +0100, Chris Wilson wrote: > > On Wed, Aug 20, 2014 at 04:29:24PM +0100, Thomas Daniel wrote: > > > These two functions make no sense in an Logical Ring Context & Execlists > > > world. > > > > > >

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-25 Thread Oliver Hartkopp
On 26.08.2014 01:24, Jesse Barnes wrote: > This happens in irq_postinstall before we've set the pm._irqs_disabled flag, > but shouldn't warn. So add a nowarn variant to allow this to happen w/o > a backtrace and keep the rest of the IRQ tracking code happy. > > Signed-off-by: Jesse Barnes Repor

[Intel-gfx] Fwd: i915 (possibly): Suspend regression Macbook Pro 15 (late 2013)

2014-08-25 Thread Eric Rannaud
[Cross-post from LKML; apologies if you've all already seen this] Hi, Between 3.13.5 and 3.15.4, suspend became partially broken on Macbook Pro 15 (late 2013): a few minutes after wakeup from the *second* suspend following a fresh boot, the screen will randomly turn itself off at shorter and shor

[Intel-gfx] [PATCH 1/2] tests/pm_psr: Update pm_psr for new psr debug interface.

2014-08-25 Thread Rodrigo Vivi
Signed-off-by: Rodrigo Vivi --- tests/pm_psr.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/tests/pm_psr.c b/tests/pm_psr.c index 3ab7e7a..8b92d84 100644 --- a/tests/pm_psr.c +++ b/tests/pm_psr.c @@ -32,6 +32,10 @@ #include #include "drmtes

[Intel-gfx] [PATCH 2/2] tests/kms_psr_sink_crc: Fix edp_psr debugfs interface run only on HAS_PSR.

2014-08-25 Thread Rodrigo Vivi
Tests were broken on platforms that doesn't have psr or on new kernel that contains new interface. A lot more need to be done to get these tests really useful, but for now lets avoid it breaking tests framework. Signed-off-by: Rodrigo Vivi --- tests/kms_psr_sink_crc.c | 31

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-25 Thread Rodrigo Vivi
I tried your suggestion for nuke fbc less... so I was just nuking along with psr_exit and cleaning the cache along with psr_do_enable and it got really better... I could see false colors working nice enough... However it got worst on PC7 residency... PC7 flutuated much more with the sw version...

[Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-25 Thread Jesse Barnes
This happens in irq_postinstall before we've set the pm._irqs_disabled flag, but shouldn't warn. So add a nowarn variant to allow this to happen w/o a backtrace and keep the rest of the IRQ tracking code happy. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_irq.c | 18 -

Re: [Intel-gfx] [PATCH 00/68] Broadwell 48b addressing and prelocations (no relocs)

2014-08-25 Thread Jesse Barnes
On Fri, 22 Aug 2014 22:38:22 +0200 Daniel Vetter wrote: > On Fri, Aug 22, 2014 at 3:38 PM, Chris Wilson > wrote: > > On Fri, Aug 22, 2014 at 03:30:12PM +0200, Daniel Vetter wrote: > >> On Fri, Aug 22, 2014 at 9:03 AM, Chris Wilson > >> wrote: > >> >> > > If a GPU > >> >> > > client uses only

Re: [Intel-gfx] 3.17.0-rc1: WARNING: CPU: 1 PID: 1 at drivers/gpu/drm/i915/i915_irq.c:139 ironlake_enable_display_irq+0x7f/0x90()

2014-08-25 Thread Jesse Barnes
On Mon, 25 Aug 2014 20:29:27 +0200 Oliver Hartkopp wrote: > Hi Jesse, > > since the i915 stuff for 3.17 was merged I always get this > warning on my core i7 with internal Intel HD graphics. > > Intel(R) Core(TM) i7 CPU M 640 @ 2.80GHz > > As this warning is triggered by the code which w

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Render moot context reset and switch with Execlists

2014-08-25 Thread Scot Doyle
On Mon, 25 Aug 2014, Daniel Vetter wrote: On Wed, Aug 20, 2014 at 04:36:05PM +0100, Chris Wilson wrote: On Wed, Aug 20, 2014 at 04:29:24PM +0100, Thomas Daniel wrote: These two functions make no sense in an Logical Ring Context & Execlists world. v2: We got rid of lrc_enabled and centralized e

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Initialize workarounds in render ring init fn.

2014-08-25 Thread Daniel Vetter
On Fri, Aug 15, 2014 at 04:26:26PM -0700, Michael H. Nguyen wrote: > Also, should this be defined in a userspace accessible header? I see this > defined again locally in the IGT test. It's a debugfs interface, i.e. no real ABI guarantees. And so better not to expose this in any of the uapi header

Re: [Intel-gfx] [PATCH 35/43] drm/i915/bdw: Make sure error capture keeps working with Execlists

2014-08-25 Thread Daniel Vetter
On Thu, Aug 21, 2014 at 10:57:09AM +, Daniel, Thomas wrote: > > > > -Original Message- > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > > Vetter > > Sent: Friday, August 15, 2014 1:14 PM > > To: Daniel, Thomas > > Cc: intel-gfx@lists.freedesktop.org; Mika

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Suppress a WARN on reading an object back for a GPU hang

2014-08-25 Thread Daniel Vetter
On Fri, Aug 15, 2014 at 09:09:10PM +0300, Mika Kuoppala wrote: > Chris Wilson writes: > > > Signed-off-by: Chris Wilson > > Reviewed-by: Mika Kuoppala Ok, pulled in the error state fixes Mika reviewed, thanks. Now the big question: Is the s/seqno/request/ patch ready for prime-time? ... I'll

Re: [Intel-gfx] [PATCH 4/4] drm/i915: switch off backlight for backlight class 0 brightness

2014-08-25 Thread Daniel Vetter
On Tue, Aug 19, 2014 at 04:04:50PM -0700, Clint Taylor wrote: > On 08/12/2014 07:11 AM, Jani Nikula wrote: > >Make backlight class sysfs brightness 0 value switch off the backlight > >for connectors that have the backlight_power callback defined. For eDP, > >this has the similar caveats regarding p

Re: [Intel-gfx] [PATCH] drm/i915: Idleness detection for DRRS

2014-08-25 Thread Daniel Vetter
On Fri, Aug 15, 2014 at 10:57:08PM +0530, Vandana Kannan wrote: > On Aug-07-2014 7:27 PM, Daniel Vetter wrote: > > Hi Vandana, > > > > I think we need to start over from a fresh&clean slate with this part > > - too much changed and all the differen revisions of this patch don't > > provide that mu

Re: [Intel-gfx] [PATCH] drm/i915: fix i915_frequency_info on BDW

2014-08-25 Thread Daniel Vetter
On Mon, Aug 18, 2014 at 11:11:50AM -0700, Rodrigo Vivi wrote: > On Fri, Aug 15, 2014 at 10:12 AM, Paulo Zanoni wrote: > > > 2014-08-15 13:50 GMT-03:00 Rodrigo Vivi : > > > > > > > > > > > > On Fri, Aug 1, 2014 at 2:14 PM, Paulo Zanoni wrote: > > >> > > >> From: Paulo Zanoni > > >> > > >> The GE

Re: [Intel-gfx] [PATCH 35/43] drm/i915/bdw: Make sure error capture keeps working with Execlists

2014-08-25 Thread Daniel Vetter
On Thu, Aug 21, 2014 at 10:57:09AM +, Daniel, Thomas wrote: > > > > -Original Message- > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > > Vetter > > Sent: Friday, August 15, 2014 1:14 PM > > To: Daniel, Thomas > > Cc: intel-gfx@lists.freedesktop.org; Mika

Re: [Intel-gfx] [PATCH 27/43] drm/i915/bdw: Render state init for Execlists

2014-08-25 Thread Daniel Vetter
On Wed, Aug 20, 2014 at 03:55:42PM +, Daniel, Thomas wrote: > > > > -Original Message- > > From: Daniel, Thomas > > Sent: Friday, August 15, 2014 9:44 AM > > To: 'Daniel Vetter' > > Cc: intel-gfx@lists.freedesktop.org > > Subject: RE: [Intel-gfx] [PATCH 27/43] drm/i915/bdw: Render sta

Re: [Intel-gfx] [PATCH] drm/i915: Add 180 degree primary plane rotation support

2014-08-25 Thread Daniel Vetter
On Fri, Aug 22, 2014 at 02:06:04PM +0530, sonika.jin...@intel.com wrote: > From: Sonika Jindal > > Primary planes support 180 degree rotation. Expose the feature > through rotation drm property. > > v2: Calculating linear/tiled offsets based on pipe source width and > height. Added 180 degree ro

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Updating plane parameters for primary plane in setplane

2014-08-25 Thread Daniel Vetter
On Thu, Aug 21, 2014 at 11:44:39AM +0530, sonika.jin...@intel.com wrote: > From: Sonika Jindal > > v2: Moving setting of plane members in the end to take care of failure cases > and > not-visible cases (Matt). > > Signed-off-by: Sonika Jindal Queued for -next, thanks for the patch. But pleas

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Render moot context reset and switch with Execlists

2014-08-25 Thread Daniel Vetter
On Wed, Aug 20, 2014 at 04:36:05PM +0100, Chris Wilson wrote: > On Wed, Aug 20, 2014 at 04:29:24PM +0100, Thomas Daniel wrote: > > These two functions make no sense in an Logical Ring Context & Execlists > > world. > > > > v2: We got rid of lrc_enabled and centralized everything in the sanitized >

Re: [Intel-gfx] [PATCH v3] drm/i915: Rework GPU reset sequence to match driver load & thaw

2014-08-25 Thread Daniel Vetter
On Thu, Aug 21, 2014 at 12:38:58PM +, Mcaulay, Alistair wrote: > Hi Daniel, > > Is there anything else needing done before this patch can be merged? Me getting working internet mostly. Patch merged with the comment in check_wedge a bit extended. Also had to rebase, please double-check that I

Re: [Intel-gfx] [PATCH v3] drm/i915: Rework GPU reset sequence to match driver load & thaw

2014-08-25 Thread Daniel Vetter
On Wed, Aug 20, 2014 at 04:56:41PM +0100, Chris Wilson wrote: > On Wed, Aug 20, 2014 at 03:21:55PM +, Mcaulay, Alistair wrote: > > It is not the same. This is a special case when re-initialising the hw. > > This flag is to allow gem_init_hw() to complete successfully during reset. > > At any

[Intel-gfx] [PATCH] drm/i915: Disallow any pinning when kms is enabled

2014-08-25 Thread Daniel Vetter
So apparently userspace managed to get itself into a corner with tricky tricks and the kernel can't work around because the batch buffer ends up being pinned. For simplicity let's just take the toys away. References: http://mid.gmane.org/20140825063250.gc17...@nuc-i3427.alporthouse.com Cc: Chris

Re: [Intel-gfx] i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

2014-08-25 Thread Eric Rannaud
Hi Jani, Is there a way to restore the prior lower power consumption when idling? As I understand it, FBC should not have a direct effect on power consumption when idle, only when the FB is actively refreshed. Is it understood why no FBC would have such a dramatic impact (+4W) on a system sitting

Re: [Intel-gfx] [PATCH] drm/i915: Enable vblank interrupts for CRC generation

2014-08-25 Thread Chris Wilson
On Mon, Aug 25, 2014 at 04:24:56PM +0300, Ville Syrjälä wrote: > On Mon, Aug 25, 2014 at 01:28:11PM +0100, Chris Wilson wrote: > > Pineview requires this. But this changes the debug API... > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=82280 > > Isn't this just the same old igt_

[Intel-gfx] Ping: Status of the i830 code?

2014-08-25 Thread Thomas Richter
Hi Ville, hi Daniel, this is again a "ping" on the status of the i830 code. I reviewed the code I received, at least the code I could review (I do not know enough about the internal wirings of the intel_display source, only on the ns2501 dvo source), but I haven't heart anything back. Is there

Re: [Intel-gfx] [PATCH] drm/i915: Enable vblank interrupts for CRC generation

2014-08-25 Thread Ville Syrjälä
On Mon, Aug 25, 2014 at 01:28:11PM +0100, Chris Wilson wrote: > Pineview requires this. But this changes the debug API... > > References: https://bugs.freedesktop.org/show_bug.cgi?id=82280 Isn't this just the same old igt_display bug that it doesn't check that the pipe<->port combination is valid

Re: [Intel-gfx] [PATCH v2 0/7] Rename DP training vswing/pre-emph defines

2014-08-25 Thread Daniel Vetter
On Tue, Aug 19, 2014 at 08:12:06AM +, Jindal, Sonika wrote: > Hi, > > Did anybody get a chance to review other patches in this series? > I got r-b for 2 patches (patches with changes in drm and i915) from Damien. It helps if you cc the relevant driver maintainers on patch submissions. scripts

Re: [Intel-gfx] [PATCH] drm/i915: Differentiate between LLC or snooped for the user

2014-08-25 Thread Ville Syrjälä
On Fri, Aug 22, 2014 at 02:41:39PM +0100, Chris Wilson wrote: > Rather than describing an object as either "snooped or LLC", we can do > better as we should know what machine we are running on! > > Signed-off-by: Chris Wilson Indeed, makes things less confusing. Reviewed-by: Ville Syrjälä > -

[Intel-gfx] [PATCH] drm/i915: Enable vblank interrupts for CRC generation

2014-08-25 Thread Chris Wilson
Pineview requires this. But this changes the debug API... References: https://bugs.freedesktop.org/show_bug.cgi?id=82280 Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/g

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds in render ring init function

2014-08-25 Thread Ville Syrjälä
On Fri, Aug 22, 2014 at 08:39:11PM +0100, Arun Siluvery wrote: > For BDW workarounds are currently initialized in init_clock_gating() but > they are lost during reset, suspend/resume etc; this patch moves the WAs > that are part of register state context to render ring init fn otherwise > default c

Re: [Intel-gfx] i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

2014-08-25 Thread Jani Nikula
[just moving from lkml to intel-gfx for a better fitting audience] On Mon, 25 Aug 2014, Jani Nikula wrote: > On Fri, 22 Aug 2014, Eric Rannaud wrote: >> Hi, >> >> Between 3.15.4 and 3.15.8, there was an increase in idle power consumption on >> Apple Macbook Pro 15 (late 2013) on a freshly boote

Re: [Intel-gfx] [PATCH 3/3] drm/i915: s/seqno/request/ tracking inside objects

2014-08-25 Thread Chris Wilson
On Sun, Aug 24, 2014 at 04:54:22PM +0100, Chris Wilson wrote: > +static void execlists_submit(struct intel_engine_cs *engine) > { > - struct drm_i915_gem_object *ctx_obj0; > - struct drm_i915_gem_object *ctx_obj1 = NULL; > - > - ctx_obj0 = to0->ring[engine->id].state; > - BUG_ON(!c

Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-08-25 Thread Jani Nikula
On Sat, 23 Aug 2014, Hans de Goede wrote: > Hi, > > On 08/22/2014 08:48 AM, Jani Nikula wrote: >> On Fri, 22 Aug 2014, Bertrik Sikken wrote: >>> On 19-8-2014 3:29, Jani Nikula wrote: On Tue, 19 Aug 2014, Bertrik Sikken wrote: >> On Sun, 17 Aug 2014, Bertrik Sikken wrote: >>> On 15-