On Mon, Jul 28, 2014 at 01:44:12PM -0700, Jesse Barnes wrote:
> > +static void
> > +i915_gem_object_retire(struct drm_i915_gem_object *obj)
> > +{
> > + struct i915_gem_request *rq;
> > + int i;
> > +
> > + if (!obj->active)
> > + return;
> > +
> > + rq = obj->last_write.request;
On Mon, Jul 28, 2014 at 05:12:59PM +, Mcaulay, Alistair wrote:
> Hi Ben / Daniel,
> I agree that this needs to be properly tested. Are there any particular igt
> tests you would suggest I use?
> I've been running:
> drv_hangman, drv_suspend, gem_hangcheck_forcewake.
I thought IGT had added so
On Mon, Jul 28, 2014 at 03:37:15PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> Just like the cursor subtests, these also trigger WARNs on the current
> Kernel.
>
> Signed-off-by: Paulo Zanoni
I feel like a lot of the setup you have to do here is duplicating logic
we have in the igt_kms
On Mon, Jul 28, 2014 at 03:37:11PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> Hi
>
> This series fixes some bugs that happen when we're runtime suspended and try
> to
> use the planes APIs. I also wrote IGT test cases for the bugs, so we will be
> able to detect future regressions.
>
GTIER and DEIER doesn't have same interface on HSW so this "or" operation
makes the information provided useless.
Cc: Paulo Zanoni
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_gpu_error.c | 16 ++--
2 files changed, 11 inser
BDW has many other Display Engine interrupts and GT interrupts registers.
Collecting it properly on gpu_error_state.
On debugfs all was properly listed already but besides we were also listing old
DEIER and GTIER that doesn't exist on BDW anymore. This was causing
unclaimed register messages:
htt
On Sat, Jul 26, 2014 at 09:01:55AM +0100, Chris Wilson wrote:
> In i915, we have a big mutex around our device struct - every time before
> we attempt to communicate with the GPU, we acquire the mutex. This makes
> it a convenient juncture to place our GPU error handling - before we take
> the mute
On 28/07/2014 18:00, Ville Syrjälä wrote:
On Mon, Jul 28, 2014 at 05:31:46PM +0100, arun.siluv...@linux.intel.com wrote:
From: Arun Siluvery
The workarounds at the moment are initialized in init_clock_gating() but
they are lost during reset; In case of execlists some workarounds modify
registe
On Fri, 25 Jul 2014 13:27:00 +0100
Chris Wilson wrote:
> @@ -614,12 +615,12 @@ static int i915_gem_pageflip_info(struct
> seq_file *m, void *data) seq_printf(m, "Flip pending (waiting for
> vsync) on pipe %c (plane %c)\n", pipe, plane);
> }
> - if (work->
On 28/07/2014 20:22, Daniel Vetter wrote:
On Mon, Jul 28, 2014 at 08:00:39PM +0300, Ville Syrjälä wrote:
On Mon, Jul 28, 2014 at 05:31:46PM +0100, arun.siluv...@linux.intel.com wrote:
From: Arun Siluvery
The workarounds at the moment are initialized in init_clock_gating() but
they are lost du
On Mon, Jul 28, 2014 at 08:00:39PM +0300, Ville Syrjälä wrote:
> On Mon, Jul 28, 2014 at 05:31:46PM +0100, arun.siluv...@linux.intel.com wrote:
> > From: Arun Siluvery
> >
> > The workarounds at the moment are initialized in init_clock_gating() but
> > they are lost during reset; In case of execl
From: Rafael Barbalho
According to the specifications bit 6 is actually valid in the stride register.
Cc: Jesse Barnes
Cc: Ville Syrjälä
Signed-off-by: Rafael Barbalho
---
drivers/gpu/drm/i915/intel_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
On Mon, Jul 28, 2014 at 11:07:10PM +0530, sagar.a.kam...@intel.com wrote:
> From: Sagar Kamble
>
> Sequence to get gfx clocks on/off, allow/disallow wake and save/restore of
> gunit registers need to be followed in
> PM suspend and resume path similar to runtime suspend and resume.
>
> Cc: Imre
On Mon, Jul 28, 2014 at 06:29:41PM +0300, Ville Syrjälä wrote:
> On Tue, Jul 15, 2014 at 05:43:37PM +0530, sonika.jin...@intel.com wrote:
> > From: Sonika Jindal
> >
> > v2: Adding creation of rotation_property here.
> >
> > Signed-off-by: Sonika Jindal
> > ---
> > drivers/gpu/drm/drm_crtc.c |
From: Paulo Zanoni
Otherwise we may get WARNs saying we're writing registers while
runtime suspended.
Testcase: igt/pm_rpm/legacy-planes
Testcase: igt/pm_rpm/legacy-planes-dpms
Cc: sta...@vger.kernel.org
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_sprite.c | 3 +++
1 file change
From: Paulo Zanoni
Just like the cursor subtests, these also trigger WARNs on the current
Kernel.
Signed-off-by: Paulo Zanoni
---
tests/pm_rpm.c | 212 -
1 file changed, 211 insertions(+), 1 deletion(-)
diff --git a/tests/pm_rpm.c b/test
From: Paulo Zanoni
Otherwise we may get WARNs saying we're writing registers while
runtime suspended.
Testcase: igt/pm_rpm/universal-planes
Testcase: igt/pm_rpm/universal-planes-dpms
Cc: sta...@vger.kernel.org
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_display.c | 4
1 fil
From: Paulo Zanoni
If we're runtime suspended and try to use the cursor interfaces, we
will get a lot of WARNs saying we did the wrong thing.
For intel_crtc_update_cursor(), all we need to do is return if the
CRTC is not active, since writing the registers won't really have any
effect if the scr
From: Paulo Zanoni
These tests currently trigger WARNs on our Kernel. Let's make sure we
fix the bugs and they never come back.
v2: Reorganize the code a little bit, and improve the tests.
Signed-off-by: Paulo Zanoni
---
tests/pm_rpm.c | 123 +++
From: Paulo Zanoni
Hi
This series fixes some bugs that happen when we're runtime suspended and try to
use the planes APIs. I also wrote IGT test cases for the bugs, so we will be
able to detect future regressions.
The controversial part of these patches is that we had previously defined that
we
On Mon, 2014-07-28 at 23:07 +0530, sagar.a.kam...@intel.com wrote:
> From: Sagar Kamble
>
> Sequence to get gfx clocks on/off, allow/disallow wake and save/restore of
> gunit registers need to be followed in
> PM suspend and resume path similar to runtime suspend and resume.
>
> Cc: Imre Deak
From: Sagar Kamble
Sequence to get gfx clocks on/off, allow/disallow wake and save/restore of
gunit registers need to be followed in
PM suspend and resume path similar to runtime suspend and resume.
Cc: Imre Deak
Cc: Paulo Zanoni
Cc: Daniel Vetter
Cc: Jani Nikula
Signed-off-by: Sagar Kamble
On Mon, Jul 28, 2014 at 05:31:45PM +0100, arun.siluv...@linux.intel.com wrote:
> From: Arun Siluvery
>
> This patch moves BDW workarounds from init_clock_gating() to render ring
> init fn otherwise they are lost when gpu is reset.
> In case of execlists, some of the workarounds modify registers t
Hi Ben / Daniel,
I agree that this needs to be properly tested. Are there any particular igt
tests you would suggest I use?
I've been running:
drv_hangman, drv_suspend, gem_hangcheck_forcewake.
Also do you have a set of PPGTT Patches that should work with these tests.
Michel sent me a set of pat
On Mon, Jul 28, 2014 at 05:31:46PM +0100, arun.siluv...@linux.intel.com wrote:
> From: Arun Siluvery
>
> The workarounds at the moment are initialized in init_clock_gating() but
> they are lost during reset; In case of execlists some workarounds modify
> registers that are part of register state
From: Arun Siluvery
The workarounds at the moment are initialized in init_clock_gating() but
they are lost during reset; In case of execlists some workarounds modify
registers that are part of register state context, since these are not
initialized until init_clock_gating() default context ends u
From: Arun Siluvery
This patch moves BDW workarounds from init_clock_gating() to render ring
init fn otherwise they are lost when gpu is reset.
In case of execlists, some of the workarounds modify registers that are
part of register state context which doesn't get initialized until
init_clock_gat
On Fri, Jul 25, 2014 at 01:27:00PM +0100, Chris Wilson wrote:
> At the heart of this change is that the seqno is a too low level of an
> abstraction to handle the growing complexities of command tracking, both
> with the introduction of multiple command queues with execbuffer and the
> potential fo
On Mon, Jul 28, 2014 at 04:24:49PM +0100, Thomas Wood wrote:
> Ensure tests using igt_enable_connectors can still run even if the
> relevant debugfs files are not available.
>
> Signed-off-by: Thomas Wood
> ---
> lib/igt_kms.c | 19 ++-
> lib/igt_kms.h | 2 +-
> 2 files changed,
On Tue, Jul 15, 2014 at 05:43:37PM +0530, sonika.jin...@intel.com wrote:
> From: Sonika Jindal
>
> v2: Adding creation of rotation_property here.
>
> Signed-off-by: Sonika Jindal
> ---
> drivers/gpu/drm/drm_crtc.c |3 ++-
> include/drm/drm_crtc.h |1 +
> 2 files changed, 3 insertio
On Mon, Jul 28, 2014 at 01:20:58PM +0200, Pavel Machek wrote:
>
> Gcc warns that addr might be used uninitialized. It may not, but I see
> why gcc gets confused.
>
> Additionally, hiding code with side-effects inside WARN_ON() argument
> seems uncool, so I moved it outside.
>
> Signed-off-by: Pa
Ensure tests using igt_enable_connectors can still run even if the
relevant debugfs files are not available.
Signed-off-by: Thomas Wood
---
lib/igt_kms.c | 19 ++-
lib/igt_kms.h | 2 +-
2 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
On Fri, Jul 25, 2014 at 04:30:29PM +0300, Imre Deak wrote:
> On Sat, 2014-06-28 at 02:04 +0300, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > Add the TX wells for port D. The Punit subsystem numbers are a total
> > guess at this time. Also I'm not sure these even exist. Cer
On Fri, Jul 25, 2014 at 02:55:00PM +0300, Imre Deak wrote:
> On Sat, 2014-06-28 at 02:04 +0300, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > CHV has two display PHYs so there are also two cmnlane power wells. Add
> > the approriate code to power the wells up/down.
> >
> >
Check any test specific options for conflicts with the standard set of
options.
Signed-off-by: Thomas Wood
---
lib/igt_core.c | 46 ++
1 file changed, 42 insertions(+), 4 deletions(-)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index 0e254e3..f4761ca
On Sat, Jul 12, 2014 at 07:16:15PM +0530, Deepak S wrote:
>
> On Saturday 28 June 2014 04:33 AM, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > CHV wants even rps opcodes so make sure the min/max/rpe values are also
> > even.
> >
> > Signed-off-by: Ville Syrjälä
> > ---
> >
On Mon, Jul 07, 2014 at 11:42:04AM -0700, Rodrigo Vivi wrote:
> With this bit enabled, HW changes the color when compressing frames for
> debug purposes.
>
> ALthough the simple way to enable a single bit is over intel_reg_write,
> this value is overwriten on next update_fbc so depending on the wo
On Sat, 2014-07-26 at 01:44 +0200, Daniel Vetter wrote:
> On Fri, Jul 25, 2014 at 2:14 PM, Paul Bolle wrote:
> > Your commit 2225a28fd916 ("drm/i915: Ditch UMS config option") is
> > included in today's linux-next (ie, next-20140725). It removes the
> > Kconfig symbol DRM_I915_UMS.
> >
> > It didn
Gcc warns that addr might be used uninitialized. It may not, but I see
why gcc gets confused.
Additionally, hiding code with side-effects inside WARN_ON() argument
seems uncool, so I moved it outside.
Signed-off-by: Pavel Machek
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
b/drivers/gpu/d
On 25 July 2014 17:57, Paulo Zanoni wrote:
> 2014-07-25 13:08 GMT-03:00 Thomas Wood :
>> Most tests use a printable character as the value for getopt to return,
>> so avoid conflicts by using non-printing values for the standard options.
>
> Instead of this patch, isn't there any way to verify if
On Fri, Jul 25, 2014 at 06:05:29PM -0700, Ben Widawsky wrote:
> On Wed, Jul 16, 2014 at 04:05:59PM +0100, alistair.mcau...@intel.com wrote:
> > From: "McAulay, Alistair"
> >
> > This patch is to address Daniels concerns over different code during reset:
> >
> > http://lists.freedesktop.org/archi
On Fri, Jul 25, 2014 at 05:47:11PM -0700, Sun, Daisy wrote:
> we have reconsidered good suggestions and evaluated performance and
> complexity again.
>
> Timer Constant callback would continuously wake up CPU and entire
> package, results in lower CPU and package C-state and shorter battery life,
On Fri, Jul 25, 2014 at 04:30:29PM +0300, Imre Deak wrote:
> On Sat, 2014-06-28 at 02:04 +0300, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > Add the TX wells for port D. The Punit subsystem numbers are a total
> > guess at this time. Also I'm not sure these even exist. Cer
On Sat, Jul 26, 2014 at 11:27:38AM +0100, Chris Wilson wrote:
> On Wed, Jun 18, 2014 at 10:54:13PM +0200, Daniel Vetter wrote:
> > On Fri, Jun 13, 2014 at 04:38:03PM +0100, oscar.ma...@intel.com wrote:
> > > From: Oscar Mateo
> > >
> > > Or with a spinlock grabbed, because it might sleep, which i
44 matches
Mail list logo
