Hi Daniel,
Thanks for your time and comments.
The current design is exactly same as we discussed previously in the mail
chain, color manager is just the framework which does this job:
1. Create a DRM property for requesting object.
2. Attach the DRM property with the object.
There is no
On 2014/7/24 4:54, Konrad Rzeszutek Wilk wrote:
On Sat, Jul 19, 2014 at 12:27:21AM +, Kay, Allen M wrote:
For the MCH PCI registers that do need to be read - can you tell us which ones
those are?
In qemu/hw/xen_pt_igd.c/igd_pci_read(), following MCH PCI config register reads
are passthro
2014-07-23 19:41 GMT-03:00 Daniel Vetter :
> On Thu, Jul 24, 2014 at 12:35:25AM +0200, Daniel Vetter wrote:
>> On Wed, Jul 23, 2014 at 06:30:59PM -0300, Paulo Zanoni wrote:
>> > From: Paulo Zanoni
>> >
>> > If we're runtime suspended and try to use the cursor interfaces, we
>> > will get a lot of
On Thu, Jul 24, 2014 at 12:35:25AM +0200, Daniel Vetter wrote:
> On Wed, Jul 23, 2014 at 06:30:59PM -0300, Paulo Zanoni wrote:
> > From: Paulo Zanoni
> >
> > If we're runtime suspended and try to use the cursor interfaces, we
> > will get a lot of WARNs saying we did the wrong thing.
> >
> > For
On Wed, Jul 23, 2014 at 06:30:59PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> If we're runtime suspended and try to use the cursor interfaces, we
> will get a lot of WARNs saying we did the wrong thing.
>
> For intel_crtc_update_cursor(), all we need to do is return if the
> CRTC is not
From: Paulo Zanoni
These tests currently trigger WARNs on our Kernel. Let's make sure we
fix the bugs and they never come back.
Signed-off-by: Paulo Zanoni
---
tests/pm_rpm.c | 111 +++--
1 file changed, 101 insertions(+), 10 deletions(-)
di
From: Paulo Zanoni
If we're runtime suspended and try to use the cursor interfaces, we
will get a lot of WARNs saying we did the wrong thing.
For intel_crtc_update_cursor(), all we need to do is return if the
CRTC is not active, since writing the registers won't really have any
effect if the scr
On Sat, Jul 19, 2014 at 12:27:21AM +, Kay, Allen M wrote:
> > For the MCH PCI registers that do need to be read - can you tell us which
> > ones those are?
>
> In qemu/hw/xen_pt_igd.c/igd_pci_read(), following MCH PCI config register
> reads are passthrough to the host HW. Some of the regi
---
NEWS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS b/NEWS
index 1b5ee83ec849..4866d59b5619 100644
--- a/NEWS
+++ b/NEWS
@@ -10,6 +10,12 @@ Release 1.8 (-xx-xx)
- As usual piles of new tests.
+- Improved plane/pipe handling in the igt_kms library (Damien).
+
+- Unified
2014-07-23 16:16 GMT-03:00 Daniel Vetter :
> Thomas missed the add-hoc parameter parsing in here, which did break
> things for Paulo since the core now fails for unknown options.
>
> Convert them over to the new infrastructure, which has the nice upside
> that we can remove the comments and put the
Thomas missed the add-hoc parameter parsing in here, which did break
things for Paulo since the core now fails for unknown options.
Convert them over to the new infrastructure, which has the nice upside
that we can remove the comments and put them into the usage available
with --help.
Cc: Thomas
On Wed, Jul 23, 2014 at 5:37 PM, John Harrison
wrote:
>>> diff --git a/drivers/gpu/drm/i915/i915_drv.h
>>> b/drivers/gpu/drm/i915/i915_drv.h
>>> index 0977653..fbafa68 100644
>>> --- a/drivers/gpu/drm/i915/i915_drv.h
>>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>>> @@ -1075,6 +1075,16 @@ struct i91
On Wed, Jul 23, 2014 at 11:34:54PM +0530, shashank.sha...@intel.com wrote:
> From: Shashank Sharma
>
> This patchset adds color-manager, a new framework in I915 driver which
> adds color correction and tweak capabilities in the driver.
>
> Color manager creates a DRM propery based interface for
On Wed, Jul 23, 2014 at 05:33:42PM +0100, John Harrison wrote:
>
> On 07/07/2014 20:21, Daniel Vetter wrote:
> >On Wed, Jul 02, 2014 at 11:34:23AM -0700, Jesse Barnes wrote:
> >>On Thu, 26 Jun 2014 18:24:08 +0100
> >>john.c.harri...@intel.com wrote:
> >>
> >>>From: John Harrison
> >>>
> >>>The sc
From: Shashank Sharma
Call color manager exit from the CRTC destroy/ plane destroy
function to free all the allocated memory, and cleanup all
the registered DRM properties.
Signed-off-by: Shashank Sharma
---
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915/intel_sprite.c | 1 +
From: Shashank Sharma
Color manager's plane level correction properties are
registered as plane property. So its required to have a
.set_property function in plane functions.
This patch adds:
1. A .set_property function for intel_plane, intel_plane_set_property
which checks if a plane propert
From: Shashank Sharma
This patch adds support for color property to set sprite plane
contrast and brightness for intel color manager framework.
As, in valleyview the register for contrast and brightess
adjustment is same, one common function has been added to serve
both. It adds three functions:
From: Shashank Sharma
Call color manager init and attach color properties
during the pipe and plane init time. This will register
all pipe level properties with each intel_crtc and all plane
level properties with each intel_plane objects.
Signed-off-by: Shashank Sharma
---
drivers/gpu/drm/i915/
From: Shashank Sharma
This patch adds support for color property to set sprite plane
hue and saturation values, for intel color manager framework.
It adds two functions:
1. intel_clrmgr_set_hue_sat: This is a wrapper function
which checks the platform type, and calls the valleyview
sp
From: Shashank Sharma
This patch adds support for pipe CSC correction color property
for intel color manager framework. It adds two functions:
1. intel_clrmgr_set_csc: This is a wrapper function
which checks the platform type, and calls the valleyview
specific set_csc function. As different
From: Shashank Sharma
This patch adds support for pipe gamma correction color property
for intel color manager framework. It adds two functions:
1. intel_clrmgr_set_gamma: This is a wrapper function
which checks the platform type, and calls the valleyview
specific set_gamma function. As dif
From: Shashank Sharma
Color manager's pipe level correction properties are
registered as CRTC property. So its required to have a
.set_crtc function in CRTC functions.
This patch adds:
1. A .set_property function for intel_crtc, intel_crtc_set_property
which checks if a CRTC property is of ty
From: Shashank Sharma
In valleyview we have three possible sprite plane level
color correction:
1. Contrast
2. Brightness
What this patch does:
1. This patch adds software infrastructure to register plane level
color correction properties per plane. Adding a new function,
intel_att
From: Shashank Sharma
In valleyview we have two pipe level color correction
properties:
1. CSC correction (wide gamut)
2. Gamma correction
What this patch does:
1. This patch adds software infrastructure to register pipe level
color correction properties per CRTC. Adding a new function,
in
From: Shashank Sharma
Color manager is a framework which adds color correction
and tuning capabilities in I915 driver. This framework creates
DRM properties for each color correction property, and allows
userspace to tune the display appearance.
This is the first patch of the series, what this p
From: Shashank Sharma
This patchset adds color-manager, a new framework in I915 driver which
adds color correction and tweak capabilities in the driver.
Color manager creates a DRM propery based interface for each color
correction, and based on the property type, registers it with each
CRTC/plan
On Wed, Jul 23, 2014 at 05:39:49PM +0100, Tvrtko Ursulin wrote:
> On 07/21/2014 01:21 PM, Chris Wilson wrote:
> >+mn = i915_mmu_notifier_get(obj->userptr.mm);
> >+if (IS_ERR(mn))
> >+return PTR_ERR(mn);
>
> Very minor, but I would perhaps consider renaming this to _find
> since
On 07/21/2014 01:21 PM, Chris Wilson wrote:
During release of the GEM object we hold the struct_mutex. As the
object may be holding onto the last reference for the task->mm,
calling mmput() may trigger exit_mmap() which close the vma
which will call drm_gem_vm_close() and attempt to reacquire
th
On 07/07/2014 20:21, Daniel Vetter wrote:
On Wed, Jul 02, 2014 at 11:34:23AM -0700, Jesse Barnes wrote:
On Thu, 26 Jun 2014 18:24:08 +0100
john.c.harri...@intel.com wrote:
From: John Harrison
The scheduler decouples the submission of batch buffers to the driver with their
submission to the
Snapshot 2.99.914 (2014-07-23)
==
And a brown paper bag to hide the rebuilding from the tarball with
'autoreconf -fi' error that arose from not distributing the libobj/
directory.
Complete list of changes since 2.99.913
---
Chris Wi
On Wed, 23 Jul 2014 16:10:32 +0100
John Harrison wrote:
> On 02/07/2014 19:20, Jesse Barnes wrote:
> > On Thu, 26 Jun 2014 18:24:04 +0100
> > john.c.harri...@intel.com wrote:
> >
> >> From: John Harrison
> >>
> >> The scheduler decouples the submission of batch buffers to the driver with
> >> su
On 07/07/2014 20:14, Daniel Vetter wrote:
On Thu, Jun 26, 2014 at 06:24:06PM +0100, john.c.harri...@intel.com wrote:
From: John Harrison
The scheduler needs to do interrupt triggered work that is too complex to do in
the interrupt handler. Thus it requires a deferred work handler to process t
On Wed, Jul 23, 2014 at 04:12:55PM +0100, Tvrtko Ursulin wrote:
> Just tell the test to expect them to work then.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Chris Wilson
For funsies we should also make sure that the results written to one are
visible in the other.
-Chris
--
Chris Wilson, Intel O
Just tell the test to expect them to work then.
Signed-off-by: Tvrtko Ursulin
Cc: Chris Wilson
---
tests/gem_userptr_blits.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/gem_userptr_blits.c b/tests/gem_userptr_blits.c
index 2a52856..cc6d31f 100644
--- a/tests/gem_us
On 02/07/2014 19:29, Jesse Barnes wrote:
On Thu, 26 Jun 2014 18:24:07 +0100
john.c.harri...@intel.com wrote:
From: John Harrison
The scheduler needs to explicitly allocate a seqno to track each submitted batch
buffer. This must happen a long time before any commands are actually written to
th
On 02/07/2014 19:20, Jesse Barnes wrote:
On Thu, 26 Jun 2014 18:24:04 +0100
john.c.harri...@intel.com wrote:
From: John Harrison
The scheduler decouples the submission of batch buffers to the driver with
submission of batch buffers to the hardware. Thus it is possible for an
application to su
On 07/23/2014 03:34 PM, Daniel Vetter wrote:
On Wed, Jul 23, 2014 at 02:23:53PM +0100, Tvrtko Ursulin wrote:
I think it would be good to add some more tests to cover the tracking
"handover" between the interval tree and linear list to ensure invalidation
still works correctly in non-trivial cas
On Wed, Jul 23, 2014 at 02:23:53PM +0100, Tvrtko Ursulin wrote:
> Looks fine. Performance impact is potentially big as we discussed but I
> suppose we can leave that for later if an issue. So:
>
> Reviewed-by: Tvrtko Ursulin
Merged, thanks for patch and review.
> I think it would be good to add
Let's march ahead with the deprecation plan laid out in
commit b30324adaf8d2e5950a602bde63030d15a61826f
Author: Daniel Vetter
Date: Wed Nov 13 22:11:25 2013 +0100
drm/i915: Deprecated UMS support
Thus far no regression report yet, so the transparent fallback plan
seems to pan out.
Cc: Da
On Wed, Jul 23, 2014 at 02:14:19PM +0100, Tvrtko Ursulin wrote:
> Larger performance impact is expected with first draft of the kernel
> implementation for overlapping objects so this is just to confirm that.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Chris Wilson
Looks fine. I can't comment on li
Snapshot 2.99.913 (2014-07-23)
==
This should be it... A few fixes from testing the new code, we should be
ready for the final release. However, we do have one standout feature in
this snapshot, we now officially recognise HD Graphics 5300/5500/5600,
Iris Graphics 6100 a
On 07/21/2014 01:21 PM, Chris Wilson wrote:
Whilst I strongly advise against doing so for the implicit coherency
issues between the multiple buffer objects accessing the same backing
store, it nevertheless is a valid use case, akin to mmaping the same
file multiple times.
The reason why we forb
>> On Tue, Jul 22, 2014 at 8:42 AM, Hans de Goede
> Bertrik, can you try blacklisting the samsung-laptop module, then
> check /sys/class/backlight, the samsung_laptop dir should be gone
> replaced by an acpi_video0 (or some such) dir. Please try if that
> works. If that does not work, try booting
Larger performance impact is expected with first draft of the kernel
implementation for overlapping objects so this is just to confirm that.
Signed-off-by: Tvrtko Ursulin
Cc: Chris Wilson
---
benchmarks/gem_userptr_benchmark.c | 97 --
1 file changed, 72 inse
On Wed, Jul 23, 2014 at 01:33:18PM +0100, Tvrtko Ursulin wrote:
> Hardcoding has upsides and downsides.
>
> Signed-off-by: Tvrtko Ursulin
Ooops, merged.
-Daniel
> ---
> benchmarks/gem_userptr_benchmark.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/benchmarks/gem_u
All tests want that anyway.
Signed-off-by: Daniel Vetter
---
tests/drm_lib.sh | 2 ++
tests/test_rte_check | 2 --
tests/tools_test | 2 --
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/drm_lib.sh b/tests/drm_lib.sh
index 97f6f9253072..38befa88acb8 100755
--- a/tes
Just enough to stay compatible with simple subtests.
Signed-off-by: Daniel Vetter
---
tests/drm_lib.sh | 13 +
1 file changed, 13 insertions(+)
diff --git a/tests/drm_lib.sh b/tests/drm_lib.sh
index 38befa88acb8..d71e6ae2223e 100755
--- a/tests/drm_lib.sh
+++ b/tests/drm_lib.sh
@@ -
Hardcoding has upsides and downsides.
Signed-off-by: Tvrtko Ursulin
---
benchmarks/gem_userptr_benchmark.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/benchmarks/gem_userptr_benchmark.c
b/benchmarks/gem_userptr_benchmark.c
index bdfce12..4d7442b 100644
--- a/benchmarks/g
On Tue, Jul 22, 2014 at 12:33:49PM +0100, Tvrtko Ursulin wrote:
> copy() blit helper assumes a certain object size much larger than a page size.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Chris Wilson
Reviewed-by: Chris Wilson
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_
On Wed, Jul 23, 2014 at 02:13:14PM +0200, Daniel Vetter wrote:
> On Wed, Jul 23, 2014 at 11:57:50AM +0100, Thomas Wood wrote:
> > Move option parsing into common_init so it can be shared between simple
> > tests and tests with subtests. This allows for more common command line
> > behaviour across
On Wed, Jul 23, 2014 at 11:57:50AM +0100, Thomas Wood wrote:
> Move option parsing into common_init so it can be shared between simple
> tests and tests with subtests. This allows for more common command line
> behaviour across all tests.
>
> Signed-off-by: Thomas Wood
> ---
> lib/igt_core.c | 1
Move option parsing into common_init so it can be shared between simple
tests and tests with subtests. This allows for more common command line
behaviour across all tests.
Signed-off-by: Thomas Wood
---
lib/igt_core.c | 118 -
1 file change
Add --debug as a common command line option for all tests to enable
debug output.
Signed-off-by: Thomas Wood
---
lib/igt_core.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index 42b22fc..d90e6bb 100644
--- a/lib/igt_core.c
+++ b/lib/
All tests can now register extra options, so there should not be any
unknown options.
Signed-off-by: Thomas Wood
---
lib/igt_core.c | 27 ---
1 file changed, 4 insertions(+), 23 deletions(-)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index 0867c27..42b22fc 100644
--- a
Signed-off-by: Thomas Wood
---
lib/drmtest.c | 1 -
lib/igt_aux.c | 1 -
lib/rendercopy_gen6.c | 1 -
lib/rendercopy_gen7.c | 1 -
lib/rendercopy_gen8.c | 1 -
lib/rendercopy_i830.c | 1 -
lib/rendercopy_i915.c
None of the current tests have additional options that might make use of
any unknown options and igt_subtest_init_parse_opts is available that
integrates additional option parsing.
Signed-off-by: Thomas Wood
---
lib/igt_core.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
Signed-off-by: Thomas Wood
---
lib/igt_core.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index b197932..5c20581 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -204,6 +204,7 @@ static unsigned int exit_handler_count;
This function allows simple tests to register additional command line
options.
Signed-off-by: Thomas Wood
---
lib/igt_core.c | 22 ++
lib/igt_core.h | 5 +
2 files changed, 27 insertions(+)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index ee6f90c..72c77e6 100644
--- a
The following series attempts to standardise command line parsing and options
across the various types of tests. This allows all tests to respond to common
options such as --help and --debug, and also warn when unknown or invalid
options are used.
Thomas Wood (8):
lib: warn when attempting to ru
Convert simple tests to use igt_simple_init_parse_opts if they require
extra options.
Signed-off-by: Thomas Wood
---
lib/igt_core.h | 1 +
tests/gem_ctx_basic.c | 20 +++--
tests/gem_render_copy.c | 25 +---
tests/gem_seqno_wrap.c | 82 +++
Hi,
On 07/22/2014 08:52 AM, Daniel Vetter wrote:
> On Tue, Jul 22, 2014 at 8:42 AM, Hans de Goede wrote:
>> Hi Jani et al,
>>
>> A friend of mine Bertrik Sikken (in the Cc) his backlight control
>> stopped working for him on his Samsung N150Plus netbook.
>>
>> I took a quick look, and the raw int
61 matches
Mail list logo
