Re: [Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-07-21 Thread Daniel Vetter
On Tue, Jul 22, 2014 at 8:42 AM, Hans de Goede wrote: > Hi Jani et al, > > A friend of mine Bertrik Sikken (in the Cc) his backlight control > stopped working for him on his Samsung N150Plus netbook. > > I took a quick look, and the raw intel_backlight backlight interface > works under 3.14, but t

[Intel-gfx] [REGRESSION BISECTED] backlight control stops workin with 3.14 and later

2014-07-21 Thread Hans de Goede
Hi Jani et al, A friend of mine Bertrik Sikken (in the Cc) his backlight control stopped working for him on his Samsung N150Plus netbook. I took a quick look, and the raw intel_backlight backlight interface works under 3.14, but the firmware samsung_laptop backlight interface, which is what most

Re: [Intel-gfx] [PATCH v2] Displayport compliance testing

2014-07-21 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 12:10:35PM -0700, Todd Previte wrote: > >This patch set adds the foundational support for Displayport compliance > >testing in the > >i915 driver. It implements the framework for automated test support that > >preclude the > >need (most) for operator input during testing.

Re: [Intel-gfx] [PATCH] drm/i915/chv: Use timeout mode for RC6 on chv

2014-07-21 Thread Deepak S
On Monday 21 July 2014 10:42 PM, Ben Widawsky wrote: On Tue, Jul 22, 2014 at 01:50:20PM +0530, Deepak S wrote: On Thursday 17 July 2014 09:16 AM, deepa...@linux.intel.com wrote: From: Deepak S Higher RC6 residency is observed using timeout mode instead of EI mode. It's Recommended to use TO

Re: [Intel-gfx] [PATCH 10/12] drm/i915: Update link training automated test function for Displayport compliance

2014-07-21 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 12:10:45PM -0700, Todd Previte wrote: > Implements basic link training functionality for Displayport automated > compliance > testing. > > Signed-off-by: Todd Previte > --- > drivers/gpu/drm/i915/intel_dp.c | 47 > + > 1 file chan

Re: [Intel-gfx] [PATCH] drm/i915: fix freeze with blank screen booting highmem

2014-07-21 Thread Daniel Vetter
On Mon, Jul 21, 2014 at 09:34:30PM -0700, Hugh Dickins wrote: > x86_64 boots and displays fine, but booting x86_32 with CONFIG_HIGHMEM > has frozen with a blank screen throughout 3.16-rc on this ThinkPad T420s, > with i915 generation 6 graphics. > > Fix 9d0a6fa6c5e6 ("drm/i915: add render state in

[Intel-gfx] [PATCH v2] drm/i915: Setting legacy palette correctly for different platforms

2014-07-21 Thread sonika . jindal
From: Sonika Jindal v2: Adding !HAS_GMCH_DISPLAY(dev) Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index c89b4ac..3e73798

[Intel-gfx] [PATCH v2] drm/i915: Returning from increase/decrease of pllclock when invalid

2014-07-21 Thread sonika . jindal
From: Sonika Jindal v2: Adding !HAS_GMCH_DISPLAY(dev) Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_display.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 3e73798..bd1

[Intel-gfx] [PATCH v2] drm/i915: Replace HAS_PCH_SPLIT which incorrectly lets some platforms in

2014-07-21 Thread sonika . jindal
From: Sonika Jindal v2: Adding IS_G4X instead of gen < 5 as suggested by Daniel Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_hdmi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index

[Intel-gfx] [PATCH] drm/i915: fix freeze with blank screen booting highmem

2014-07-21 Thread Hugh Dickins
x86_64 boots and displays fine, but booting x86_32 with CONFIG_HIGHMEM has frozen with a blank screen throughout 3.16-rc on this ThinkPad T420s, with i915 generation 6 graphics. Fix 9d0a6fa6c5e6 ("drm/i915: add render state initialization"): kunmap() takes struct page * argument, not virtual addre

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Add a constant and function for getting the Displayport compliance failsafe video mode

2014-07-21 Thread Paulo Zanoni
2014-07-14 16:10 GMT-03:00 Todd Previte : > Adds the failsafe mode (640x480@60hz) as a constant and a function that > retrieves it. These are > designed for use in Displayport compliance testing only and should not be > used outside that > context. > > Signed-off-by: Todd Previte > --- > driver

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Add a function to get the EDID preferred mode for Displayport compliance testing

2014-07-21 Thread Paulo Zanoni
2014-07-14 16:10 GMT-03:00 Todd Previte : > Add a simple function to pull the preferred mode out of an EDID block. This > function > is designed for use during Displayport compliance testing. > The preferred mode can be changed by the quirks. Do you think that could be a problem? Also, as said e

Re: [Intel-gfx] [PATCH 04/12] drm/i915: Add wrapper function for intel_crtc_set_config()

2014-07-21 Thread Paulo Zanoni
2014-07-14 16:10 GMT-03:00 Todd Previte : > Add a wrapper around intel_crtc_set_config() to allow it to be called from the > DP compliance test functions. This is necessary to perform the internal mode > set operations required for compliance testing. > > Signed-off-by: Todd Previte > --- > drive

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Add counters in the drm_dp_aux struct for I2C NACKs and DEFERs

2014-07-21 Thread Paulo Zanoni
2014-07-14 16:10 GMT-03:00 Todd Previte : > These counters are used for Displayort complinace testing to detect error > conditions > when executing certain compliance tests. Currently these are used in the EDID > tests > to determine if the video mode needs to be set to the preferred mode or the

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Add a function to compute the EDID checksum for Displayport compliance

2014-07-21 Thread Paulo Zanoni
2014-07-14 16:10 GMT-03:00 Todd Previte : > This function computes the EDID checksum for a block of EDID data. This > function > is necessary for Displayport compliance testing as it does not not require the > complete EDID checking functionality provided by the DRM layer functions. Can you give

Re: [Intel-gfx] [PATCH 01/12] drm/i915: Add automated testing support for Displayport compliance testing

2014-07-21 Thread Paulo Zanoni
Hi 2014-07-14 16:10 GMT-03:00 Todd Previte : > Add the skeleton framework for supporting automation for Displayport > compliance testing. This patch > adds the necessary framework for the source device to appropriately responded > to test automation > requests from a sink device. These commit m

Re: [Intel-gfx] i915 kernel driver errors

2014-07-21 Thread Daniel Vetter
On Sat, Jul 19, 2014 at 4:01 PM, Adam Skillen wrote: > After upgrading my kernel from 3.11 to 3.13, I have been experiencing > issues with graphical freezes. Specific dmesg errors started showing up > after the upgrade (see below). > > When waking the screen from power saving/screensaver, the pri

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Prevent recursive deadlock on releasing a busy userptr

2014-07-21 Thread Chris Wilson
On Mon, Jul 21, 2014 at 01:21:24PM +0100, Chris Wilson wrote: > During release of the GEM object we hold the struct_mutex. As the > object may be holding onto the last reference for the task->mm, > calling mmput() may trigger exit_mmap() which close the vma > which will call drm_gem_vm_close() and

Re: [Intel-gfx] [PATCH] drm/i915/chv: Use timeout mode for RC6 on chv

2014-07-21 Thread Ben Widawsky
On Tue, Jul 22, 2014 at 01:50:20PM +0530, Deepak S wrote: > > On Thursday 17 July 2014 09:16 AM, deepa...@linux.intel.com wrote: > >From: Deepak S > > > >Higher RC6 residency is observed using timeout mode > >instead of EI mode. It's Recommended to use TO Method for RC6. > > > >Signed-off-by: Dee

Re: [Intel-gfx] [PATCH 0/8 v2] Future preparation patches

2014-07-21 Thread Daniel Vetter
On Mon, Jul 21, 2014 at 03:23:37PM +0530, sonika.jin...@intel.com wrote: > From: Sonika Jindal > > This series prepares future platform enabling by changing HAS_PCH_SPLIT to > more > appropriate check since the code accessed may not have anything to do with > having PCH or not. > > v2: Adding n

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Replace HAS_PCH_SPLIT which incorrectly lets some platforms in

2014-07-21 Thread Daniel Vetter
On Mon, Jul 21, 2014 at 03:23:44PM +0530, sonika.jin...@intel.com wrote: > From: Sonika Jindal > > Signed-off-by: Sonika Jindal > --- > drivers/gpu/drm/i915/intel_hdmi.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c > b/drivers/g

Re: [Intel-gfx] [PATCH 5/8] drm/i915: Returning from increase/decrease of pllclock when invalid

2014-07-21 Thread Daniel Vetter
On Mon, Jul 21, 2014 at 03:23:42PM +0530, sonika.jin...@intel.com wrote: > From: Sonika Jindal > > Signed-off-by: Sonika Jindal > --- > drivers/gpu/drm/i915/intel_display.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Setting legacy palette correctly for different platforms

2014-07-21 Thread Daniel Vetter
On Mon, Jul 21, 2014 at 03:23:41PM +0530, sonika.jin...@intel.com wrote: > From: Sonika Jindal > > Signed-off-by: Sonika Jindal > --- > drivers/gpu/drm/i915/intel_display.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/dri

[Intel-gfx] [PATCH] igt/build: Do not fail git build when there is no git

2014-07-21 Thread Tvrtko Ursulin
Git detection probably belongs to configure.ac with the version.h rule reworked accordingly. Feel free to drop this if someone wants to spend time on a better fix. Signed-off-by: Tvrtko Ursulin --- Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/M

[Intel-gfx] [PATCH 1/2] drm/i915: Allow overlapping userptr objects

2014-07-21 Thread Chris Wilson
Whilst I strongly advise against doing so for the implicit coherency issues between the multiple buffer objects accessing the same backing store, it nevertheless is a valid use case, akin to mmaping the same file multiple times. The reason why we forbade it earlier was that our use of the interval

[Intel-gfx] [PATCH 2/2] drm/i915: Prevent recursive deadlock on releasing a busy userptr

2014-07-21 Thread Chris Wilson
During release of the GEM object we hold the struct_mutex. As the object may be holding onto the last reference for the task->mm, calling mmput() may trigger exit_mmap() which close the vma which will call drm_gem_vm_close() and attempt to reacquire the struct_mutex. In order to avoid that recursio

[Intel-gfx] [PATCH 4/8] drm/i915: Setting legacy palette correctly for different platforms

2014-07-21 Thread sonika . jindal
From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index c89b4ac..442d8ba 100644 --- a/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 2/8] drm/i915: Allowing changing of wm latencies for valid platforms

2014-07-21 Thread sonika . jindal
From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/i915_debugfs.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index fc39610..517c266 100644 --- a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH 8/8] drm/i915: Avoid incorrect returning for some platforms

2014-07-21 Thread sonika . jindal
From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_hdmi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index 458dd4f..ecdb2d5 100644 --- a/drivers/gpu/drm/i915/intel_hdm

[Intel-gfx] [PATCH 1/8] drm/i915: Adding HAS_GMCH_DISPLAY macro

2014-07-21 Thread sonika . jindal
From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/i915_drv.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 991b663..4e28192 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/d

[Intel-gfx] [PATCH 3/8] drm/i915: Returning the right VGA control reg for platforms

2014-07-21 Thread sonika . jindal
From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/i915_drv.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 4e28192..b932548 100644 --- a/drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 0/8 v2] Future preparation patches

2014-07-21 Thread sonika . jindal
From: Sonika Jindal This series prepares future platform enabling by changing HAS_PCH_SPLIT to more appropriate check since the code accessed may not have anything to do with having PCH or not. v2: Adding new HAS_GMCH_DISPLAY macro suggested by Daniel. Also taking care of Ironlake(gen 5), by mak

[Intel-gfx] [PATCH 6/8] drm/i915: Writing proper check for reading of pipe status reg

2014-07-21 Thread sonika . jindal
From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index f6cf9bb..f74d1c2 100644 --- a/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 5/8] drm/i915: Returning from increase/decrease of pllclock when invalid

2014-07-21 Thread sonika . jindal
From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_display.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 442d8ba..f6cf9bb 100644 --- a/drivers/gpu/drm/i

[Intel-gfx] [PATCH 7/8] drm/i915: Replace HAS_PCH_SPLIT which incorrectly lets some platforms in

2014-07-21 Thread sonika . jindal
From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_hdmi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index 5f8f4ca..458dd4f 100644 --- a/drivers/gpu/drm/i915/intel_hdm

Re: [Intel-gfx] Intel Graphics Drivers

2014-07-21 Thread Nick Krause
On Sat, Jul 19, 2014 at 8:45 PM, Roberto J. Dohnert wrote: > This would probably be a better question for the Intel developers than the > kernel developers per say, but a great question nonetheless. The Intel > video drivers are perhaps the best supported on Linux. Most of the hardware > I ship d

[Intel-gfx] Intel Graphics Drivers

2014-07-21 Thread Nick Krause
Hey Daniel and others , I am correct after asking around on the mailing list that the intel graphics drivers are faster. I am wondering if we can improve this and try to remove regressions in this area of graphics support. I don't have the hardware but if people help doing the testing and maybe a b

[Intel-gfx] i915 kernel driver errors

2014-07-21 Thread Adam Skillen
After upgrading my kernel from 3.11 to 3.13, I have been experiencing issues with graphical freezes. Specific dmesg errors started showing up after the upgrade (see below). When waking the screen from power saving/screensaver, the primary display wakes but X stops responding to input (the mouse c

Re: [Intel-gfx] Intel Graphics Drivers

2014-07-21 Thread Nick Krause
On Sat, Jul 19, 2014 at 6:32 PM, Nick Krause wrote: Hey Daniel and others , If I am correct after asking around on the mailing list then the windows Intel graphics drivers are faster then their Linux counterparts. In addition , I am wondering if we can improve this and try to remove regressi

Re: [Intel-gfx] Intel Graphics Drivers

2014-07-21 Thread Roberto J. Dohnert
This would probably be a better question for the Intel developers than the kernel developers per say, but a great question nonetheless. The Intel video drivers are perhaps the best supported on Linux. Most of the hardware I ship does ship with Intel cards so in regards to performance, this wou

Re: [Intel-gfx] [PATCH] drm/i915: Fix possible overflow when recording semaphore states.

2014-07-21 Thread Daniel Vetter
On Fri, Jul 18, 2014 at 07:00:40PM -0700, Ben Widawsky wrote: > On Fri, Jul 18, 2014 at 02:19:40AM -0700, Rodrigo Vivi wrote: > > semaphore _sync_seqno, _seqno and _mbox are smaller than number of rings. > > This optimization is to remove the ring itself from the list and the logic > > to do that

Re: [Intel-gfx] [PATCH] drm/i915/chv: Use timeout mode for RC6 on chv

2014-07-21 Thread Deepak S
On Thursday 17 July 2014 09:16 AM, deepa...@linux.intel.com wrote: From: Deepak S Higher RC6 residency is observed using timeout mode instead of EI mode. It's Recommended to use TO Method for RC6. Signed-off-by: Deepak S --- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 1 file changed, 2 inse