[Intel-gfx] [PATCH 4/7] drm/i915: Returning from increase/decrease of pllclock when invalid

From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_display.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index d1c7105..e259c41 100644 --- a/drivers/gpu/drm/i

[Intel-gfx] [PATCH 7/7] drm/i915: Avoid incorrect returning for some platforms

From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_hdmi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index 2e70132..a15fc47 100644 --- a/drivers/gpu/drm/i915/intel_hdm

[Intel-gfx] [PATCH 3/7] drm/i915: Setting legacy palette correctly for different platforms

From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index c89b4ac..d1c7105 100644 --- a/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 6/7] drm/i915: Replace HAS_PCH_SPLIT which incorrectly lets some platforms in

From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_hdmi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index 5f8f4ca..2e70132 100644 --- a/drivers/gpu/drm/i915/intel_hdm

[Intel-gfx] [PATCH 5/7] drm/i915: Writing proper check for reading of pipe status reg

From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index e259c41..3f7089c 100644 --- a/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 2/7] drm/i915: Returning the right VGA control reg for platforms

From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/i915_drv.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 991b663..90a682c 100644 --- a/drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 0/7] Future preparation patches

From: Sonika Jindal This series prepares future platform enabling by changing HAS_PCH_SPLIT to more appropriate check since the code accessed may not have anything to do with having PCH or not. Sonika Jindal (7): drm/i915: Allowing changing of wm latencies for other valid platforms drm/i915:

[Intel-gfx] [PATCH 1/7] drm/i915: Allowing changing of wm latencies for valid platforms

From: Sonika Jindal Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/i915_debugfs.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index fc39610..ffb83e0 100644 --- a/drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH] drm/i915: Fix printing proper min/min/rpe values in debugfs

Oops, meant to reply-to-all On Thu, Jul 17, 2014 at 07:44:25PM -0700, Ben Widawsky wrote: > On Thu, Jul 17, 2014 at 10:42:20AM +0200, Daniel Vetter wrote: > > On Thu, Jul 17, 2014 at 02:21:14PM +0530, deepa...@linux.intel.com wrote: > > > From: Deepak S > > > > > > This was fumbled while trying

Re: [Intel-gfx] [PATCH] drm/i915: print full error ring semaphore mboxes and sync.

On Thu, Jul 17, 2014 at 10:58:17AM -0700, Rodrigo Vivi wrote: > With the increasing number of rings, > we probably have more information to print than we were printing. > > v2: Loop only over active rings and print info with ring names. > > Cc: Ben Widawsky > Signed-off-by: Rodrigo Vivi > --- >

[Intel-gfx] [PATCH] drm/i915: print full error ring semaphore mboxes and sync.

With the increasing number of rings, we probably have more information to print than we were printing. v2: Loop only over active rings and print info with ring names. Cc: Ben Widawsky Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_gpu_error.c | 24 1 file ch

Re: [Intel-gfx] [PATCH] drm/i915: print full error ring semaphore mboxes and sync.

On Thu, Jul 17, 2014 at 05:36:52PM -0700, Vivi, Rodrigo wrote: > You mean you prefer the the loop with for (i = 0; i < hweight(ring_mask); > i++) { > instead? I thought you were ok with either and I preferred this one just to > be on the safest side and let userspace parse it properly. I can li

Re: [Intel-gfx] [PATCH] drm/i915: print full error ring semaphore mboxes and sync.

You mean you prefer the the loop with for (i = 0; i < hweight(ring_mask); i++) { instead? I thought you were ok with either and I preferred this one just to be on the safest side and let userspace parse it properly. Or do you prefer that other version with double loop but with names of rings?

Re: [Intel-gfx] [PATCH] drm/i915: print full error ring semaphore mboxes and sync.

On Thu, Jul 17, 2014 at 09:39:55AM -0700, Rodrigo Vivi wrote: > With the increasing number of rings, > we probably have more information to print than we were printing. After our discussion were you going to send a new patch? [snip] -- Ben Widawsky, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH] drm/i915: Do not unmap object unless no other VMAs reference it

On Thu, Jul 17, 2014 at 04:45:02PM -0700, Ben Widawsky wrote: > On Fri, Jul 11, 2014 at 10:20:07AM -0700, armin.c.re...@intel.com wrote: > > From: Armin Reese > > > > Signed-off-by: Armin Reese > > --- > > drivers/gpu/drm/i915/i915_gem.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deleti

Re: [Intel-gfx] [PATCH] drm/i915: Do not unmap object unless no other VMAs reference it

On Fri, Jul 11, 2014 at 10:20:07AM -0700, armin.c.re...@intel.com wrote: > From: Armin Reese > > Signed-off-by: Armin Reese > --- > drivers/gpu/drm/i915/i915_gem.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i

[Intel-gfx] [PATCH] drm/i915: print full error ring semaphore mboxes and sync.

With the increasing number of rings, we probably have more information to print than we were printing. Cc: Ben Widawsky Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_gpu_error.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH] drm/i915: Optimize the i915_gem_gtt_finish_object function

On Fri, Jul 11, 2014 at 10:20:08AM -0700, armin.c.re...@intel.com wrote: > From: Armin Reese > > Signed-off-by: Armin Reese > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c >

Re: [Intel-gfx] [PATCH] drm/i915: Fix possible overflow when recording semaphore states.

On Thu, Jul 17, 2014 at 05:35:20AM -0700, Rodrigo Vivi wrote: > semaphore _sync_seqno, _seqno and _mbox are smaller than number of rings. > This optimization is to remove the ring itself from the list and the logic to > do that > is at intel_ring_sync_index as below: > > /* > * rcs -> 0 = vcs, 1

[Intel-gfx] i915 / 3.15 intermittently boots into blank screeen

Hi list, you were very helpful to nail down the interrupt storm issue a year ago, I hope we can track this down, too. I'm experiencing an issue with 3.15.5 on my Lenovo T400: When my machine boots, I can see some of the boot messages flying by (quite fast because the machine has a SSD). On a u

[Intel-gfx] [PATCH] drm/i915: freeze display before the interrupts and GT

From: Paulo Zanoni Since we started using intel_runtime_pm_disable_interrupts() at normal (non-runtime) suspend/resume, we had to remove a WARN from ironlake_disable_display_irq to avoid a case where we were doing the correct thing and the WARN was not really needed. The problem is that the WARN

[Intel-gfx] [PATCH] drm/i915: Fix possible overflow when recording semaphore states.

semaphore _sync_seqno, _seqno and _mbox are smaller than number of rings. This optimization is to remove the ring itself from the list and the logic to do that is at intel_ring_sync_index as below: /* * rcs -> 0 = vcs, 1 = bcs, 2 = vecs, 3 = vcs2; * vcs -> 0 = bcs, 1 = vecs, 2 = vcs2, 3 = rcs;

Re: [Intel-gfx] [PATCH] drm/i915: check the power wells on assert_{cursor, plane}

2014-07-17 13:58 GMT-03:00 Daniel Vetter : > On Thu, Jul 17, 2014 at 3:29 PM, Paulo Zanoni wrote: >> I can do this, but please notice that we already have >> power-well-checking code in many of the other assertions on our >> driver... And it will probably be just a matter of time since someone >>

Re: [Intel-gfx] [PATCH] drm/i915: Fix semaphore_seqno and semaphore_mboxes sizes

just ignore this one.. On Thu, Jul 17, 2014 at 5:00 AM, Rodrigo Vivi wrote: > Otherwise some iteractions depending on the current number of active rings > could overflow. > > Cc: Ben Widawsky > Signed-off-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_drv.h | 4 ++-- > 1 file changed, 2

[Intel-gfx] [PATCH] drm/i915: Fix semaphore_seqno and semaphore_mboxes sizes

Otherwise some iteractions depending on the current number of active rings could overflow. Cc: Ben Widawsky Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/

Re: [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

> That sounds great. Tiejun could you confirm that with windows driver guys too? I believe windows driver can also assume specific CPU/PCH combos. I will discuss this with native Windows driver guys. Preferably, the same code path can be used for both native and virtualization cases to avoid f

Re: [Intel-gfx] [PATCH] drm/i915: remove plane/cursor/pipe assertions from intel_crtc_disable

On Thu, Jul 17, 2014 at 11:16:39AM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Since we merged runtime PM support for DPMS, it is possible that these > assertions will be called when the power wells are disabled but a mode > is "set", resulting in "failed assertion" and "device suspended

[Intel-gfx] "[drm:intel_dp_start_link_train] *ERROR* too many full retries, give up" and others on an ASUS UX32A

Hi, I have an ASUS UX32A laptop, which have troubles booting up with an external HDMI display. The BIOS boot screen appears on the external display, and the internal one stays blank during the whole boot. After login I can make it work again if I turn it off and on, e.g. with Ubuntu's display

Re: [Intel-gfx] [PATCH] drm/i915: check the power wells on assert_{cursor, plane}

On Thu, Jul 17, 2014 at 3:29 PM, Paulo Zanoni wrote: > I can do this, but please notice that we already have > power-well-checking code in many of the other assertions on our > driver... And it will probably be just a matter of time since someone > starts using the assertions again on a place wher

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

On Thu, Jul 17, 2014 at 3:42 PM, Paulo Zanoni wrote: >> On Wed, Jul 16, 2014 at 06:19:13PM -0300, Paulo Zanoni wrote: >>> 2014-07-14 14:34 GMT-03:00 Daniel Vetter : >>> > On Mon, Jul 14, 2014 at 11:56:57AM -0300, Paulo Zanoni wrote: >>> >> 2014-07-07 18:53 GMT-03:00 Jesse Barnes : >>> >> > On Mon,

Re: [Intel-gfx] [RFC v2 2/3] drm/i915: duplicate i915_gem_ring_dispatch trace and add ctx parameter

On Wed, Jul 16, 2014 at 05:22:38PM +0100, daniele.ceraolospu...@intel.com wrote: > From: Daniele Ceraolo Spurio > > The context used to execute a batchbuffer is becoming increasingly > important. Duplicating to avoid modifications to the original trace. I am sure we don't want both. The structur

[Intel-gfx] [PATCH] drm/i915: remove plane/cursor/pipe assertions from intel_crtc_disable

From: Paulo Zanoni Since we merged runtime PM support for DPMS, it is possible that these assertions will be called when the power wells are disabled but a mode is "set", resulting in "failed assertion" and "device suspended while reading register" WARNs. To reproduce the bug: disable all screen

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-07-17 5:06 GMT-03:00 Daniel Vetter : > On Wed, Jul 16, 2014 at 06:19:13PM -0300, Paulo Zanoni wrote: >> 2014-07-14 14:34 GMT-03:00 Daniel Vetter : >> > On Mon, Jul 14, 2014 at 11:56:57AM -0300, Paulo Zanoni wrote: >> >> 2014-07-07 18:53 GMT-03:00 Jesse Barnes : >> >> > On Mon, 7 Jul 2014 18:48

Re: [Intel-gfx] [PATCH] drm/i915: check the power wells on assert_{cursor, plane}

2014-07-17 10:23 GMT-03:00 Daniel Vetter : > On Thu, Jul 17, 2014 at 2:53 PM, Paulo Zanoni wrote: >> 2014-07-17 5:38 GMT-03:00 Daniel Vetter : >>> On Wed, Jul 16, 2014 at 05:06:34PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni Since we merged runtime PM support for DPMS, it is pos

Re: [Intel-gfx] [PATCH] drm/i915: check the power wells on assert_{cursor, plane}

On Thu, Jul 17, 2014 at 2:53 PM, Paulo Zanoni wrote: > 2014-07-17 5:38 GMT-03:00 Daniel Vetter : >> On Wed, Jul 16, 2014 at 05:06:34PM -0300, Paulo Zanoni wrote: >>> From: Paulo Zanoni >>> >>> Since we merged runtime PM support for DPMS, it is possible that these >>> functions will be called when

Re: [Intel-gfx] [PATCH] drm/i915: check the power wells on assert_{cursor, plane}

2014-07-17 5:38 GMT-03:00 Daniel Vetter : > On Wed, Jul 16, 2014 at 05:06:34PM -0300, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> Since we merged runtime PM support for DPMS, it is possible that these >> functions will be called when the power wells are disabled but a mode >> is "set", resulti

Re: [Intel-gfx] [PATCH 00/16] Enabling GEN8 full PPGTT + fixes

On Tue, Jul 01, 2014 at 11:17:35AM -0700, Ben Widawsky wrote: > Here be all the patches to make full PPGTT relatively stable on Broadwell. > Most > of the work was actually to the generic PPGTT code, and not BDW specific. > There > are basically 3 fixes: > 1. Make the error state not horrible, bu

Re: [Intel-gfx] [PATCH 12/16] drm/i915: Reorder ctx unref on ppgtt cleanup

On Tue, Jul 01, 2014 at 11:17:47AM -0700, Ben Widawsky wrote: > The comment [which was mine] is wrong. The context object can never be > bound in a PPGTT because it is only capable of living in the Global GTT. > So, remove the comment, and reorder the unref. What's nice about the > latter is it kee

Re: [Intel-gfx] [PATCH 13/16] drm/i915: More correct (slower) ppgtt cleanup

On Tue, Jul 01, 2014 at 11:17:48AM -0700, Ben Widawsky wrote: > If a VM still have objects which are bound (exactly: have a node > reserved in the drm_mm), and we are in the middle of a reset, we have no > hope of the standard methods fixing the situation (ring idle won't > work). We must therefore

Re: [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

On 2014/7/16 22:20, Konrad Rzeszutek Wilk wrote: On Thu, Jul 03, 2014 at 11:27:40PM +0300, Michael S. Tsirkin wrote: On Thu, Jul 03, 2014 at 12:09:28PM -0700, Jesse Barnes wrote: On Thu, 3 Jul 2014 14:26:12 -0400 Konrad Rzeszutek Wilk wrote: On Thu, Jul 03, 2014 at 10:32:12AM +0300, Michae

Re: [Intel-gfx] [PATCH 1/1] Revert "drm/i915: drop i915_ prefix from enable_rc6, enable_fbc, enable_ppgtt parameters"

On (Thu) 17 Jul 2014 [11:11:15], Daniel Vetter wrote: > On Thu, Jul 17, 2014 at 02:32:41PM +0530, Amit Shah wrote: > > On (Thu) 17 Jul 2014 [09:35:20], Daniel Vetter wrote: > > > On Wed, Jul 16, 2014 at 9:54 PM, Linus Torvalds > > > wrote: > > > > Sorry for the top post, I'm on the road.. > > > >

Re: [Intel-gfx] [PATCH 1/1] Revert "drm/i915: drop i915_ prefix from enable_rc6, enable_fbc, enable_ppgtt parameters"

On Thu, Jul 17, 2014 at 02:32:41PM +0530, Amit Shah wrote: > On (Thu) 17 Jul 2014 [09:35:20], Daniel Vetter wrote: > > On Wed, Jul 16, 2014 at 9:54 PM, Linus Torvalds > > wrote: > > > Sorry for the top post, I'm on the road.. > > > > > > In wondering if we couldn't just keep both the old an the ne

Re: [Intel-gfx] [PATCH 1/1] Revert "drm/i915: drop i915_ prefix from enable_rc6, enable_fbc, enable_ppgtt parameters"

On (Thu) 17 Jul 2014 [09:35:20], Daniel Vetter wrote: > On Wed, Jul 16, 2014 at 9:54 PM, Linus Torvalds > wrote: > > Sorry for the top post, I'm on the road.. > > > > In wondering if we couldn't just keep both the old an the new names and have > > them both point at the same variable? Remove the d

Re: [Intel-gfx] [PATCH 08/16] drm/i915/error: Do a better job of disambiguating VMAs

On Fri, Jul 04, 2014 at 09:56:54AM -0700, Ben Widawsky wrote: > On Fri, Jul 04, 2014 at 08:57:08AM +0100, Chris Wilson wrote: > > On Tue, Jul 01, 2014 at 11:17:43AM -0700, Ben Widawsky wrote: > > > Some of the original PPGTT patches in this area where unmerged, and this > > > left a lot of confusio

Re: [Intel-gfx] [PATCH 06/16] drm/i915/error: Check the potential ctx obj's vm

On Tue, Jul 01, 2014 at 11:17:41AM -0700, Ben Widawsky wrote: > The bound list is global (all objects which back the VMAs are stored > here). Recently the BUG() in the offset lookup was demoted to a WARN, > but the fault actually lies in the caller, here. > > This bug has existed since the initial

Re: [Intel-gfx] [PATCH] drm/i915: Fix printing proper min/min/rpe values in debugfs

On Thu, Jul 17, 2014 at 02:21:14PM +0530, deepa...@linux.intel.com wrote: > From: Deepak S > > This was fumbled while trying to use the cached min/min/rpe values in > the vlv debugfs code. > > This is a regression from > > commit 03af20458a57a50735b12c1e3c23abc7ff70c6fa > Author: Vi

Re: [Intel-gfx] [PATCH] drm/i915: check the power wells on assert_{cursor, plane}

On Wed, Jul 16, 2014 at 05:06:34PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Since we merged runtime PM support for DPMS, it is possible that these > functions will be called when the power wells are disabled but a mode > is "set", resulting in "failed assertion" and "device suspended w

Re: [Intel-gfx] [PATCH] drm/i915: mark IRQs as disabled on unload

On Fri, Jun 20, 2014 at 11:57:33AM -0700, Jesse Barnes wrote: > To avoid more spew with the new warnings. > > Signed-off-by: Jesse Barnes Ok, I've pulled this all into dinq. I guess we'll see how it all works out. -Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 2 ++ > 1 file changed, 2

Re: [Intel-gfx] [PATCH 2/2] drm/i915: BDW can also detect unclaimed registers

On Wed, Jul 16, 2014 at 05:49:30PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > By the time I wrote this patch, it allowed me to catch some problems. > But due to patch reordering - in order to prevent fake "regression" > reports - this patch may be merged after the fixes of the problems >

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

On Wed, Jul 16, 2014 at 06:19:13PM -0300, Paulo Zanoni wrote: > 2014-07-14 14:34 GMT-03:00 Daniel Vetter : > > On Mon, Jul 14, 2014 at 11:56:57AM -0300, Paulo Zanoni wrote: > >> 2014-07-07 18:53 GMT-03:00 Jesse Barnes : > >> > On Mon, 7 Jul 2014 18:48:47 -0300 > >> > Paulo Zanoni wrote: > >> > > >

Re: [Intel-gfx] [PATCH 1/1] Revert "drm/i915: drop i915_ prefix from enable_rc6, enable_fbc, enable_ppgtt parameters"

On Wed, Jul 16, 2014 at 9:54 PM, Linus Torvalds wrote: > Sorry for the top post, I'm on the road.. > > In wondering if we couldn't just keep both the old an the new names and have > them both point at the same variable? Remove the description for the old > name, but keep it working? I'm really su