[Intel-gfx] [PATCH v6] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-26 Thread deepak . s
From: Deepak S v2: Disable media turbo and Add DOWN_IDLE_AVG support (Ville) v3: Mass rename of the dev_priv->rps variables in upstream. v4: Rebase against latest code. (Deepak) v5: Rebase against latest nightly code. (Deepak) v6: Rename the variables to match the spec (Mika) Signed-off-by:

Re: [Intel-gfx] [PATCH 3/7] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-26 Thread Deepak S
On Monday 26 May 2014 08:02 PM, Ville Syrjälä wrote: On Mon, May 26, 2014 at 07:24:21PM +0530, Deepak S wrote: On Monday 26 May 2014 07:00 PM, Mika Kuoppala wrote: Hi Deepak, deepa...@linux.intel.com writes: From: Deepak S v2: Disable media turbo and Add DOWN_IDLE_AVG support (Ville) v3:

Re: [Intel-gfx] [PATCH 3/7] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-26 Thread Deepak S
Thanks for the Review. I will address the comments On Monday 26 May 2014 08:07 PM, Mika Kuoppala wrote: Deepak S writes: On Monday 26 May 2014 07:00 PM, Mika Kuoppala wrote: Hi Deepak, deepa...@linux.intel.com writes: From: Deepak S v2: Disable media turbo and Add DOWN_IDLE_AVG support

Re: [Intel-gfx] WARNING on i915 - intel_panel

2014-05-26 Thread Pedro Ribeiro
On 26 May 2014 20:14, Daniel Vetter wrote: > On Mon, May 26, 2014 at 9:07 PM, Pedro Ribeiro wrote: >> sorry for my ignorance, but do you know where in a Debian system would >> I have the full log output since boot time? The /var/log/dmesg does >> not seem to contain all the output in the "dmesg"

Re: [Intel-gfx] [PATCH 11/9] drm/i915: Opt out of vblank disable timer on >gen2

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 05:26:48PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Now that the vblank races are plugged, we can opt out of using > the vblank disable timer and just let vblank interrupts get > disabled immediately when the last reference is dropped. > > Gen

Re: [Intel-gfx] WARNING on i915 - intel_panel

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 9:07 PM, Pedro Ribeiro wrote: > sorry for my ignorance, but do you know where in a Debian system would > I have the full log output since boot time? The /var/log/dmesg does > not seem to contain all the output in the "dmesg" command. /var/log/kern.log, althought that conta

Re: [Intel-gfx] WARNING on i915 - intel_panel

2014-05-26 Thread Pedro Ribeiro
On 26 May 2014 19:19, Daniel Vetter wrote: > On Mon, May 26, 2014 at 8:07 PM, Pedro Ribeiro wrote: >> On 26 May 2014 10:22, Jani Nikula wrote: >>> On Sat, 24 May 2014, Pedro Ribeiro wrote: Hi, I'm getting this error consistently with the Debian 3.14.4 after resuming from hib

Re: [Intel-gfx] [PATCH 2/7] drm/nouveau: replace drm_get_connector_name() with direct name field use

2014-05-26 Thread Jani Nikula
On Mon, 26 May 2014, Ilia Mirkin wrote: > On Mon, May 26, 2014 at 9:35 AM, Jani Nikula wrote: >> Generated using semantic patch: >> >> @@ >> expression E; >> @@ >> >> - drm_get_connector_name(E) >> + E->name >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/nouveau/dispnv04/dac.c

Re: [Intel-gfx] WARNING on i915 - intel_panel

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 8:07 PM, Pedro Ribeiro wrote: > On 26 May 2014 10:22, Jani Nikula wrote: >> On Sat, 24 May 2014, Pedro Ribeiro wrote: >>> Hi, >>> >>> I'm getting this error consistently with the Debian 3.14.4 after >>> resuming from hibernation: >> >> Does this ever happen on a fresh boo

Re: [Intel-gfx] WARNING on i915 - intel_panel

2014-05-26 Thread Pedro Ribeiro
On 26 May 2014 10:22, Jani Nikula wrote: > On Sat, 24 May 2014, Pedro Ribeiro wrote: >> Hi, >> >> I'm getting this error consistently with the Debian 3.14.4 after >> resuming from hibernation: > > Does this ever happen on a fresh boot or when resuming from suspend to > ram? > > BR, > Jani. > Hi

[Intel-gfx] [PATCH v2 1/9] drm: Always reject drm_vblank_get() after drm_vblank_off()

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä Make sure drm_vblank_get() never succeeds when called between drm_vblank_off() and drm_vblank_on(). Borrow a trick from the old drm_vblank_{pre,post}_modeset() functions and just bump the refcount in drm_vblank_off() and drop it in drm_vblank_on(). When drm_vblank_get() encou

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915: Leave interrupts enabled while disabling crtcs during suspend

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 02:46:32PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The new watermaek update mechanism requires interrupts to work > correctly. Because of this we need interrupts while disabling crtcs > during suspend. So move the irq disable to happen a bit l

Re: [Intel-gfx] [PATCH 11/9] drm/i915: Opt out of vblank disable timer on >gen2

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 05:26:48PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Now that the vblank races are plugged, we can opt out of using > the vblank disable timer and just let vblank interrupts get > disabled immediately when the last reference is dropped. > > Gen

Re: [Intel-gfx] [PATCH 6/7] drm/i915/chv: Added CHV specific DDR fetch into init_clock_gating

2014-05-26 Thread Mika Kuoppala
deepa...@linux.intel.com writes: > From: Deepak S > > Signed-off-by: Deepak S > [vsyrjala: Fix merge fubmle where the code ended up in > g4x_disable_trickle_feed() instead of cherryview_init_clock_gating()] > Signed-off-by: Ville Syrjälä > Acked-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i

Re: [Intel-gfx] [PATCH 0/7] drm & drivers: kill drm_get_connector_name() and drm_get_encoder_name()

2014-05-26 Thread David Herrmann
Hi On Mon, May 26, 2014 at 3:35 PM, Jani Nikula wrote: > As requested by David [1],[2]. > > These are on top of drm-intel-nightly which carries the required core > patches adding ->name field to drm_connector and drm_encoder. The i915 > patches could go in right away, the last patch need to wait

Re: [Intel-gfx] [PATCH 3/7] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-26 Thread Mika Kuoppala
Deepak S writes: > On Monday 26 May 2014 07:00 PM, Mika Kuoppala wrote: >> Hi Deepak, >> >> deepa...@linux.intel.com writes: >> >>> From: Deepak S >>> >>> v2: Disable media turbo and Add DOWN_IDLE_AVG support (Ville) >>> >>> v3: Mass rename of the dev_priv->rps variables in upstream. >>> >>> v4:

Re: [Intel-gfx] [PATCH 3/7] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-26 Thread Ville Syrjälä
On Mon, May 26, 2014 at 07:24:21PM +0530, Deepak S wrote: > > On Monday 26 May 2014 07:00 PM, Mika Kuoppala wrote: > > Hi Deepak, > > > > deepa...@linux.intel.com writes: > > > >> From: Deepak S > >> > >> v2: Disable media turbo and Add DOWN_IDLE_AVG support (Ville) > >> > >> v3: Mass rename of t

[Intel-gfx] [PATCH 10/9] drm: Add dev->vblank_disable_immediate flag

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä Add a flag to drm_device which will cause the vblank code to bypass the disable timer and always disable the vblank interrupt immediately when the last reference is dropped. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_irq.c | 6 +++--- include/drm/drmP.h|

[Intel-gfx] [PATCH 11/9] drm/i915: Opt out of vblank disable timer on >gen2

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä Now that the vblank races are plugged, we can opt out of using the vblank disable timer and just let vblank interrupts get disabled immediately when the last reference is dropped. Gen2 is the exception since it has no hardware frame counter. Signed-off-by: Ville Syrjälä ---

Re: [Intel-gfx] [PATCH 0/7] drm & drivers: kill drm_get_connector_name() and drm_get_encoder_name()

2014-05-26 Thread Christian König
Am 26.05.2014 15:52, schrieb Daniel Vetter: On Mon, May 26, 2014 at 3:52 PM, Daniel Vetter wrote: On Mon, May 26, 2014 at 04:35:39PM +0300, Jani Nikula wrote: As requested by David [1],[2]. These are on top of drm-intel-nightly which carries the required core patches adding ->name field to dr

Re: [Intel-gfx] [PATCH v2 01/16] drm/i915: Keep vblank interrupts enabled while enabling/disabling planes

2014-05-26 Thread Daniel Vetter
On Thu, May 22, 2014 at 05:48:06PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Because of the upcoming vblank interrupt driven watermark update > mechanism we will have use for vblank interrupts during plane > enabling/disabling. So don't call drm_vblank_off() until plan

Re: [Intel-gfx] [PATCH 3/7] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-26 Thread Deepak S
On Monday 26 May 2014 07:00 PM, Mika Kuoppala wrote: Hi Deepak, deepa...@linux.intel.com writes: From: Deepak S v2: Disable media turbo and Add DOWN_IDLE_AVG support (Ville) v3: Mass rename of the dev_priv->rps variables in upstream. v4: Rebase against latest code. (Deepak) v5: Rebase ag

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Warn if drm_vblank_get() still works after drm_vblank_off()

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 04:49:28PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > v2: Drop the drm_vblank_off() (Daniel) > Use drm_crtc_vblank_{get,put}() > > Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_display.c | 10

Re: [Intel-gfx] [PATCH 0/7] drm & drivers: kill drm_get_connector_name() and drm_get_encoder_name()

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 3:52 PM, Daniel Vetter wrote: > On Mon, May 26, 2014 at 04:35:39PM +0300, Jani Nikula wrote: >> As requested by David [1],[2]. >> >> These are on top of drm-intel-nightly which carries the required core >> patches adding ->name field to drm_connector and drm_encoder. The i9

Re: [Intel-gfx] [PATCH 0/7] drm & drivers: kill drm_get_connector_name() and drm_get_encoder_name()

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 04:35:39PM +0300, Jani Nikula wrote: > As requested by David [1],[2]. > > These are on top of drm-intel-nightly which carries the required core > patches adding ->name field to drm_connector and drm_encoder. The i915 > patches could go in right away, the last patch need to w

[Intel-gfx] [PATCH v2 2/9] drm/i915: Warn if drm_vblank_get() still works after drm_vblank_off()

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä v2: Drop the drm_vblank_off() (Daniel) Use drm_crtc_vblank_{get,put}() Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/inte

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Warn if drm_vblank_get() still works after drm_vblank_off()

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 04:36:26PM +0300, Ville Syrjälä wrote: > On Mon, May 26, 2014 at 03:22:45PM +0200, Daniel Vetter wrote: > > On Mon, May 26, 2014 at 02:46:25PM +0300, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > Signed-off-by: Ville Syrjälä > > > --- > >

Re: [Intel-gfx] [PATCH 1/9] drm: Always reject drm_vblank_get() after drm_vblank_off()

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 04:32:02PM +0300, Ville Syrjälä wrote: > On Mon, May 26, 2014 at 03:21:41PM +0200, Daniel Vetter wrote: > > On Mon, May 26, 2014 at 02:46:24PM +0300, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > Make sure drm_vblank_get() never succeeds w

[Intel-gfx] [PATCH 2/7] drm/nouveau: replace drm_get_connector_name() with direct name field use

2014-05-26 Thread Jani Nikula
Generated using semantic patch: @@ expression E; @@ - drm_get_connector_name(E) + E->name Signed-off-by: Jani Nikula --- drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/disp.c | 2 +- drivers/gpu/drm/n

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Warn if drm_vblank_get() still works after drm_vblank_off()

2014-05-26 Thread Ville Syrjälä
On Mon, May 26, 2014 at 03:22:45PM +0200, Daniel Vetter wrote: > On Mon, May 26, 2014 at 02:46:25PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/i915/intel_display.c | 15 +++ > > 1 file changed,

[Intel-gfx] [PATCH 7/7] drm: drop drm_get_connector_name() and drm_get_encoder_name()

2014-05-26 Thread Jani Nikula
No longer used or needed as the structs have a name field. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_crtc.c | 20 include/drm/drm_crtc.h | 2 -- 2 files changed, 22 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index d986b3f

[Intel-gfx] [PATCH 3/7] drm/radeon: replace drm_get_connector_name() with direct name field use

2014-05-26 Thread Jani Nikula
Generated using semantic patch: @@ expression E; @@ - drm_get_connector_name(E) + E->name Signed-off-by: Jani Nikula --- drivers/gpu/drm/radeon/radeon_connectors.c | 19 --- drivers/gpu/drm/radeon/radeon_display.c| 2 +- 2 files changed, 13 insertions(+), 8 deletions(-) d

[Intel-gfx] [PATCH 4/7] drm: replace drm_get_connector_name() with direct name field use

2014-05-26 Thread Jani Nikula
Generated using semantic patch: @@ expression E; @@ - drm_get_connector_name(E) + E->name Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_crtc.c | 4 ++-- drivers/gpu/drm/drm_crtc_helper.c | 6 +++--- drivers/gpu/drm/drm_edid.c | 6 +++--- drivers/gpu/drm/drm_edid_load.c

[Intel-gfx] [PATCH 6/7] drm: replace drm_get_encoder_name() with direct name field use

2014-05-26 Thread Jani Nikula
Generated using semantic patch: @@ expression E; @@ - drm_get_encoder_name(E) + E->name Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_crtc.c| 2 +- drivers/gpu/drm/drm_crtc_helper.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b

[Intel-gfx] [PATCH 5/7] drm/i915: replace drm_get_encoder_name() with direct name field use

2014-05-26 Thread Jani Nikula
Generated using semantic patch: @@ expression E; @@ - drm_get_encoder_name(E) + E->name Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 14 +++--- drivers/gpu/drm/i915/intel_dp.c | 2 +- 3 files changed, 9 insert

[Intel-gfx] [PATCH 0/7] drm & drivers: kill drm_get_connector_name() and drm_get_encoder_name()

2014-05-26 Thread Jani Nikula
As requested by David [1],[2]. These are on top of drm-intel-nightly which carries the required core patches adding ->name field to drm_connector and drm_encoder. The i915 patches could go in right away, the last patch need to wait for radeon and nouveau patches to get merged, obviously. BR, Jani

[Intel-gfx] [PATCH 1/7] drm/i915: replace drm_get_connector_name() with direct name field use

2014-05-26 Thread Jani Nikula
Generated using semantic patch: @@ expression E; @@ - drm_get_connector_name(E) + E->name Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- drivers/gpu/drm/i915/i915_irq.c | 8 drivers/gpu/drm/i915/intel_crt.c | 2 +- drivers/gpu/drm/i915/intel_

Re: [Intel-gfx] [PATCH 8/9] drm: Reduce the amount of dev->vblank[crtc] in the code

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 02:46:31PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Declare a local struct drm_vblank_crtc * and use that > instead of having to do dig it out via 'dev->vblank[crtc]' > everywhere. > > Performed with the following coccinelle incantation, > and

Re: [Intel-gfx] [PATCH 1/9] drm: Always reject drm_vblank_get() after drm_vblank_off()

2014-05-26 Thread Ville Syrjälä
On Mon, May 26, 2014 at 03:21:41PM +0200, Daniel Vetter wrote: > On Mon, May 26, 2014 at 02:46:24PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Make sure drm_vblank_get() never succeeds when called between > > drm_vblank_off() and drm_vblank_on(). Borrow a trick fr

Re: [Intel-gfx] [PATCH 3/7] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-26 Thread Mika Kuoppala
Hi Deepak, deepa...@linux.intel.com writes: > From: Deepak S > > v2: Disable media turbo and Add DOWN_IDLE_AVG support (Ville) > > v3: Mass rename of the dev_priv->rps variables in upstream. > > v4: Rebase against latest code. (Deepak) > > v5: Rebase against latest nightly code. (Deepak) > > Sig

Re: [Intel-gfx] [PATCH 6/9] drm: Avoid random vblank counter jumps if the hardware counter has been reset

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 02:46:29PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > When drm_vblank_on() is called the hardware vblank counter may have > been reset, so we can't trust that the old values sampled prior to > drm_vblank_off() have anything to do with the new val

Re: [Intel-gfx] [PATCH 5/9] drm: Have the vblank counter account for the time between vblank irq disable and drm_vblank_off()

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 02:46:28PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > If the vblank irq has already been disabled (via the disable timer) when > we call drm_vblank_off() sample the counter and timestamp one last time. > This will make the sure that the user spac

Re: [Intel-gfx] [PATCH 3/9] drm: Don't clear vblank timestamps when vblank interrupt is disabled

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 02:46:26PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Clearing the timestamps causes us to send zeroed timestamps to userspace > if they get sent out in response to the drm_vblank_off(). It's better > to send the very latest timestamp and count i

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Warn if drm_vblank_get() still works after drm_vblank_off()

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 02:46:25PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_display.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b

Re: [Intel-gfx] [PATCH 1/9] drm: Always reject drm_vblank_get() after drm_vblank_off()

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 02:46:24PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Make sure drm_vblank_get() never succeeds when called between > drm_vblank_off() and drm_vblank_on(). Borrow a trick from the > old drm_vblank_{pre,post}_modeset() functions and just bump > th

Re: [Intel-gfx] [PATCH 7/9] drm: Disable vblank interrupt immediately when drm_vblank_offdelay==0

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 02:46:30PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Make drm_vblank_put() disable the vblank interrupt immediately when the > refcount drops to zero and drm_vblank_offdelay==0. > > Currently drm_vblank_put() would just leave vblank interrupts

Re: [Intel-gfx] [PATCH 2/2] drm/i915: vlv/chv: fix DSI sideband register accessing

2014-05-26 Thread Jani Nikula
On Mon, 19 May 2014, Imre Deak wrote: > So far we used the wrong opcodes to access the DSI registers, so the > register writes during DSI programming didn't actually succeed and left > the registers unchanged. This wasn't a problem for the initial modeset, > where the BIOS-programmed values happen

Re: [Intel-gfx] [PATCH] tests/pm_pc8 -> pm_rpm rename

2014-05-26 Thread Jani Nikula
On Fri, 16 May 2014, Daniel Vetter wrote: > Plus naming convention for runtime pm tests to have "rpm" somewhere in > their tests. Note that all the pc8-specific tests (for e.g. residency > or similar) already have pc8 in their subtest names, so we don't lose > any information here. > > Cc: "Yang,

[Intel-gfx] [PATCH 8/9] drm: Reduce the amount of dev->vblank[crtc] in the code

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä Declare a local struct drm_vblank_crtc * and use that instead of having to do dig it out via 'dev->vblank[crtc]' everywhere. Performed with the following coccinelle incantation, and a few manual whitespace cleanups: @@ identifier func,member; expression num_crtcs; struct drm

[Intel-gfx] [PATCH 7/9] drm: Disable vblank interrupt immediately when drm_vblank_offdelay==0

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä Make drm_vblank_put() disable the vblank interrupt immediately when the refcount drops to zero and drm_vblank_offdelay==0. Currently drm_vblank_put() would just leave vblank interrupts enabled all the time if drm_vblank_offdelay==0. In case someone might still want that behav

[Intel-gfx] [PATCH v2 9/9] drm/i915: Leave interrupts enabled while disabling crtcs during suspend

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä The new watermaek update mechanism requires interrupts to work correctly. Because of this we need interrupts while disabling crtcs during suspend. So move the irq disable to happen a bit later. This also avoid clobbering the vblank.last count in case the vblank interrupt was

[Intel-gfx] [PATCH 0/9] drm: More vblank on/off work

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä Another vblank series with the following features: - Plug a race between drm_vblank_off() and marking the crtc inactive - Don't send zeroed vblank evens to userspace at drm_vblank_off() - Have the user visible vblank counter account the entire time when the crtc was active,

[Intel-gfx] [PATCH 4/9] drm: Move drm_update_vblank_count()

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä Move drm_update_vblank_count() to avoid forward a declaration. No functional change. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_irq.c | 128 +++--- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH 1/9] drm: Always reject drm_vblank_get() after drm_vblank_off()

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä Make sure drm_vblank_get() never succeeds when called between drm_vblank_off() and drm_vblank_on(). Borrow a trick from the old drm_vblank_{pre,post}_modeset() functions and just bump the refcount in drm_vblank_off() and drop it in drm_vblank_on(). Hopefully the use of inmode

[Intel-gfx] [PATCH 6/9] drm: Avoid random vblank counter jumps if the hardware counter has been reset

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä When drm_vblank_on() is called the hardware vblank counter may have been reset, so we can't trust that the old values sampled prior to drm_vblank_off() have anything to do with the new values. So update the .last count in drm_vblank_on() to make the first drm_vblank_enable()

[Intel-gfx] [PATCH 2/9] drm/i915: Warn if drm_vblank_get() still works after drm_vblank_off()

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 3da73ef..da318a7 100644 --- a/drivers/gpu/drm/i915/in

[Intel-gfx] [PATCH 5/9] drm: Have the vblank counter account for the time between vblank irq disable and drm_vblank_off()

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä If the vblank irq has already been disabled (via the disable timer) when we call drm_vblank_off() sample the counter and timestamp one last time. This will make the sure that the user space visible counter will account for time between vblank irq disable and drm_vblank_off().

[Intel-gfx] [PATCH 3/9] drm: Don't clear vblank timestamps when vblank interrupt is disabled

2014-05-26 Thread ville . syrjala
From: Ville Syrjälä Clearing the timestamps causes us to send zeroed timestamps to userspace if they get sent out in response to the drm_vblank_off(). It's better to send the very latest timestamp and count instead. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_irq.c | 11 --- 1

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Add Broadwell support for debugfs rps freq info

2014-05-26 Thread Daniel Vetter
On Fri, May 23, 2014 at 05:11:09PM -0700, Tom.O'rou...@intel.com wrote: > From: Tom O'Rourke > > Add Broadwell support to i915_frequency_info and i915_max|min_freq_get|set. > > Signed-off-by: Tom O'Rourke Many of the checks in here could be simplified to gen >= 6 checks. Would make life easier

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Improve irq handling after gpu resets

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 11:36:33AM +0300, Ville Syrjälä wrote: > On Thu, May 22, 2014 at 10:18:21PM +0200, Daniel Vetter wrote: > > Currently we do a full re-init of all interrupts after a gpu hang. > > Which is pretty bad since we don't restore the interrupts we've > > enabled at runtime correctly

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915/vlv: Modifying WA 'WaDisableL3Bank2xClockGate for vlv

2014-05-26 Thread Gupta, Sourab
On Mon, 2014-04-14 at 10:22 +, Gupta, Sourab wrote: > On Tue, 2014-04-01 at 10:53 +0530, sourab gupta wrote: > > On Tue, 2014-03-25 at 12:23 +0530, sourab gupta wrote: > > > On Mon, 2014-03-24 at 17:56 +, Lespiau, Damien wrote: > > > > On Mon, Mar 24, 2014 at 11:00:07PM +0530, sourab.gu...@

[Intel-gfx] [PATCH 4/4] Documentation/drm: Describing aspect ratio property

2014-05-26 Thread Vandana Kannan
Updated drm documentation to include description of aspect ratio property. HTML table structure created by Sagar Kamble. Signed-off-by: Vandana Kannan Cc: Sagar Kamble Cc: Daniel Vetter Cc: Thierry Reding --- Documentation/DocBook/drm.tmpl | 31 +++ 1 file changed,

Re: [Intel-gfx] Screen extremely dim on Dell Latitude D630 after upgrading to Linux kernel-3.14

2014-05-26 Thread Jani Nikula
On Thu, 22 May 2014, Marc Milgram wrote: > After upgrading to linux Kernel-3.14, the screen on my Dell Latitude > D630 was nearly unreadably dim. When I Boot the 3.13 kernel, my screen > is bright. Please file a new bug on DRM/Intel at [1]. Please attach /sys/kernel/debug/dri/0/i915_opregion a

[Intel-gfx] [PATCH v2 3/4] drm/i915: Add aspect ratio property for HDMI

2014-05-26 Thread Vandana Kannan
Create and attach the drm property to set aspect ratio. If there is no user specified value, then PAR_NONE/Automatic option is set by default. User can select aspect ratio 4:3 or 16:9. The aspect ratio selected by user would come into effect with a mode set. v2: Modifications made based on changes

[Intel-gfx] [PATCH v2 2/4] drm/edid: Check for user aspect ratio input

2014-05-26 Thread Vandana Kannan
In case user has specified an input for aspect ratio through the property, then the user space value for PAR would take preference over the value from CEA mode list. v2: Thierry's review comments. - Modified the comment "Populate..." as per review comments Signed-off-by: Vandana Kannan C

[Intel-gfx] [PATCH v2 1/4] drm/crtc: Add property for aspect ratio

2014-05-26 Thread Vandana Kannan
Added a property to enable user space to set aspect ratio. This patch contains declaration of the property and code to create the property. v2: Thierry's review comments. - Made aspect ratio enum generic instead of HDMI/CEA specfic - Removed usage of temporary aspect_ratio variable

Re: [Intel-gfx] WARNING on i915 - intel_panel

2014-05-26 Thread Jani Nikula
On Sat, 24 May 2014, Pedro Ribeiro wrote: > Hi, > > I'm getting this error consistently with the Debian 3.14.4 after > resuming from hibernation: Does this ever happen on a fresh boot or when resuming from suspend to ram? BR, Jani. > > [ 931.032142] [ cut here ] > [ 9

Re: [Intel-gfx] [PATCH v2 0/3] Replace Blitter ring based flips with MMIO flips

2014-05-26 Thread Gupta, Sourab
On Thu, 2014-05-22 at 14:36 +, Gupta, Sourab wrote: > From: Sourab Gupta > > This patch series replaces Blitter ring based flips with MMIO based flips. > This is useful for Media power well residency optimization. These may be > enabled on architectures where Render and Blitter engines reside

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Improve irq handling after gpu resets

2014-05-26 Thread Ville Syrjälä
On Thu, May 22, 2014 at 10:18:21PM +0200, Daniel Vetter wrote: > Currently we do a full re-init of all interrupts after a gpu hang. > Which is pretty bad since we don't restore the interrupts we've > enabled at runtime correctly. Even with that addressed it's rather > horribly race. > > But on g4x

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Fix up fifo underrun tracking, take N

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 10:09 AM, Ville Syrjälä wrote: > On Fri, May 23, 2014 at 10:21:24AM +0200, Daniel Vetter wrote: >> On Fri, May 23, 2014 at 10:11 AM, Ville Syrjälä >> wrote: >> >> For enabled->enabled I think that can happen in crtc_enable - we >> >> unconditionally enable underrun reporti

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Fix up fifo underrun tracking, take N

2014-05-26 Thread Ville Syrjälä
On Fri, May 23, 2014 at 10:21:24AM +0200, Daniel Vetter wrote: > On Fri, May 23, 2014 at 10:11 AM, Ville Syrjälä > wrote: > >> For enabled->enabled I think that can happen in crtc_enable - we > >> unconditionally enable underrun reporting againg to clear out old fail (or > >> firmware setups). But

Re: [Intel-gfx] [PATCH 2/7] drm/i915/chv: Added CHV specific register read and write and Streamline CHV forcewake stuff

2014-05-26 Thread Daniel Vetter
On Fri, May 23, 2014 at 09:00:16PM +0530, deepa...@linux.intel.com wrote: > From: Deepak S > > Support to individually control Media/Render well based on the register > access. > Add CHV specific write function to habdle difference between registers > that are sadowed vs those that need forcewak

Re: [Intel-gfx] [PATCH 1/3] drm/crtc: Add property for aspect ratio

2014-05-26 Thread Daniel Vetter
On Mon, May 26, 2014 at 11:00:41AM +0530, Vandana Kannan wrote: > On May-23-2014 4:18 PM, Vandana Kannan wrote: > > On May-22-2014 5:46 PM, Daniel Vetter wrote: > >> On Thu, May 22, 2014 at 04:50:48PM +0530, Vandana Kannan wrote: > >>> Added a property to enable user space to set aspect ratio. > >>

Re: [Intel-gfx] [PATCH] drm/i915: move psr_setup_done to psr struct

2014-05-26 Thread Daniel Vetter
On Fri, May 23, 2014 at 01:45:51PM -0700, Rodrigo Vivi wrote: > "Because our driver assumes only one panel is PSR capable, and we > already have other PSR information on dev_priv instead of intel_dp. If > we ever support multiple PSR panels, we'll have to move struct > i915_psr to intel_dp anyway."