From: Akash Goel
This workaround is needed on VLV for the HW context feature.
It is used after adding the mi_set_context command in ring buffer
for Hw context switch. As per the spec
"The software must send a pipe_control with a CS stall and a post sync
operation and then a dummy DRAW after every
From: Akash Goel
Added a new rendering specific Workaround 'WaTlbInvalidateStoreDataBefore'.
In this WA, before pipecontrol with TLB invalidate set, need to add 2 MI
Store data commands.
Signed-off-by: Akash Goel
Signed-off-by: Sourab Gupta
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 22 +++
From: Akash Goel
For VLV, disabling L3 clock gating- MMIO 940c[25] = 1
Signed-off-by: Akash Goel
Signed-off-by: Sourab Gupta
---
drivers/gpu/drm/i915/intel_pm.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/in
From: Akash Goel
In Valleyview, Operational flush cannot be enabled on
BWG A0 [Errata BWT006]
Signed-off-by: Akash Goel
Signed-off-by: Sourab Gupta
---
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_pm.c | 6 ++
2 files changed, 9 insertions(+)
diff --git a/drivers/g
From: Akash Goel
Removing the VS_TIMER_DISPATCH bit enable for MI MODE reg for
VLV platform as it is not required.
Signed-off-by: Akash Goel
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer
From: Akash Goel
This patch Enables the bit for TLB invalidate in GFX Mode register
for Gen7.
According to bspec, When enabled this bit limits the invalidation
of the TLB only to batch buffer boundaries, to pipe_control
commands which have the TLB invalidation bit set and sync flushes.
If disab
From: Sourab Gupta
This patch series adds rendering specific HW workarounds for VLV platform.
These patches leads to stable behavior on VLV, especially
when playing 3D Apps, benchmarks.
Though, the patch set was submitter earlier, this new patch set is initiating
a clean thread. We have addresse
On Sun, Mar 23, 2014 at 7:04 PM, Ben Widawsky wrote:
> On Sun, Mar 23, 2014 at 05:18:37PM +0100, Daniel Vetter wrote:
>> On Sun, Mar 23, 2014 at 03:18:34PM +0100, Daniel Vetter wrote:
>> > Hi all,
>> >
>> > So this thing turned out to be fairly ugly overall, and I don't think it's
>> > worth
>> >
Since
commit 5c673b60a9b3b23486f4eda75c72e91d31d26a2b
Author: Daniel Vetter
Date: Fri Mar 7 20:34:46 2014 +0100
drm/i915: Don't enable display error interrupts from the start
we don't enable underrun interrupts any more at takeover time.
Unfortunately I've forgotten to also adjust the sw-
On Sun, Mar 23, 2014 at 05:18:37PM +0100, Daniel Vetter wrote:
> On Sun, Mar 23, 2014 at 03:18:34PM +0100, Daniel Vetter wrote:
> > Hi all,
> >
> > So this thing turned out to be fairly ugly overall, and I don't think it's
> > worth
> > the effort to polish the series through some giant rebasing.
On Sun, Mar 23, 2014 at 10:44:19AM -0700, Ben Widawsky wrote:
> On Sun, Mar 23, 2014 at 04:22:35PM +0100, Daniel Vetter wrote:
> > On Sat, Mar 22, 2014 at 10:47:21PM -0700, Ben Widawsky wrote:
> > > This file contains all necessary defines, prototypes and typesdefs for
> > > manipulating GEN graphi
On Sun, Mar 23, 2014 at 04:22:35PM +0100, Daniel Vetter wrote:
> On Sat, Mar 22, 2014 at 10:47:21PM -0700, Ben Widawsky wrote:
> > This file contains all necessary defines, prototypes and typesdefs for
> > manipulating GEN graphics address translation (this does not include the
> > legacy AGP drive
On Sat, Mar 22, 2014 at 08:58:29PM +, Chris Wilson wrote:
> On Sat, Mar 22, 2014 at 12:43:28PM -0700, Ben Widawsky wrote:
> > On Tue, Mar 18, 2014 at 08:44:28AM +, Chris Wilson wrote:
> > > On Mon, Mar 17, 2014 at 10:48:39PM -0700, Ben Widawsky wrote:
> > > > The old code (I'm having troubl
On Sun, Mar 23, 2014 at 03:18:34PM +0100, Daniel Vetter wrote:
> Hi all,
>
> So this thing turned out to be fairly ugly overall, and I don't think it's
> worth
> the effort to polish the series through some giant rebasing. make distcheck
> still works so I don't think I've fumbled this too badly
On Sat, Mar 22, 2014 at 10:47:21PM -0700, Ben Widawsky wrote:
> This file contains all necessary defines, prototypes and typesdefs for
> manipulating GEN graphics address translation (this does not include the
> legacy AGP driver)
>
> Reiterating the comment in the header,
> "Please try to maintai
Should help in alleviating the header mess we have atm.
Signed-off-by: Daniel Vetter
---
lib/igt_core.c | 2 ++
lib/igt_debugfs.c | 2 ++
lib/intel_batchbuffer.c | 2 ++
lib/intel_chipset.c | 2 ++
lib/ioctl_wrappers.c| 2 ++
5 files changed, 10 insertions(+)
diff --git a
Unfortunately gtkdoc doesn't pick up the intel_pch enum.
Signed-off-by: Daniel Vetter
---
lib/intel_chipset.c | 50 +-
lib/intel_chipset.h | 5 +
2 files changed, 54 insertions(+), 1 deletion(-)
diff --git a/lib/intel_chipset.c b/lib/intel_ch
It's unused. There's still num_tiles getting in the way of things,
but that is used by gem_stress a bit.
Signed-off-by: Daniel Vetter
---
lib/intel_batchbuffer.h | 1 -
tests/gem_ringfill.c| 1 -
tests/gem_seqno_wrap.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/lib/intel_batchbuff
This time big with media_fill.h
Signed-off-by: Daniel Vetter
---
lib/igt_core.h | 3 +++
lib/igt_kms.h | 1 -
lib/intel_batchbuffer.h| 2 +-
lib/media_fill.h | 16 +---
lib/media_fill_gen7.c | 3 +++
lib/media_fill_gen8.c | 3 +++
Same deal as with rendercopy.h.
Signed-off-by: Daniel Vetter
---
.../intel-gpu-tools/intel-gpu-tools-docs.xml | 1 -
lib/Makefile.sources | 1 -
lib/intel_batchbuffer.c | 13 +
lib/intel_batchbuffer.h
At least with the core library headers the situation is now fairly
sane. There's still fun stuff going on around *_reg.h and most of the
source files just have a cargo-culted list of headers ...
Signed-off-by: Daniel Vetter
---
lib/intel_batchbuffer.c | 3 +++
1 file changed, 3 insertions(+)
di
Signed-off-by: Daniel Vetter
---
lib/intel_chipset.c | 45 -
lib/intel_chipset.h | 21 +
lib/intel_drm.c | 42 --
lib/intel_gpu_tools.h | 18 --
4 files changed, 65 in
Just a bit better namespacing.
Signed-off-by: Daniel Vetter
---
lib/intel_chipset.c | 10 +-
lib/intel_chipset.h | 8
tools/intel_infoframes.c | 4 ++--
tools/intel_reg_dumper.c | 10 +-
4 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/lib/int
This is to consolidate all the chipset related functions to
intel_chipset.[hc].
Unfortunately we need to rename a wrapper lib file in quick_dump, too.
And quick_dump makes automake a bit unhappy apparently.
Signed-off-by: Daniel Vetter
---
lib/Makefile.sources | 2 +-
lib/int
gtkdoc won't pick them up otherwise.
Signed-off-by: Daniel Vetter
---
lib/intel_batchbuffer.c | 10 ++
lib/intel_batchbuffer.h | 11 ++-
2 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index 29740bd93bd3..235c1d1d8
And shovel all the various helpers in there.
Also move igt_set_vt_graphics_mode to igt_kms.h since the function is
implemented in igt_kms.c. And it fits better. I kinda missed this in
the prep work.
Signed-off-by: Daniel Vetter
---
lib/Makefile.sources | 2 +
lib/drmtest.c
As usual de-inline functions for gtkdoc to see them.
I've decided to exclude the register map stuff since that's not
terribly interesting.
Aside: gtkdoc falls over when the title of a section contains a slash,
hence why it reads "IO" instead of "I/O". The fun ...
Signed-off-by: Daniel Vetter
--
This is prep work to extract a new igt aux library with all kinds
of random stuff. Also give it a bit a more suitable name to
indicate that this is just a flag and doesn't do the aub dumping
itself.
Signed-off-by: Daniel Vetter
---
lib/drmtest.c | 2 +-
lib/drmtest.h | 2 +-
Makes their intent a bit clearer.
Signed-off-by: Daniel Vetter
---
lib/intel_io.h | 4 ++--
lib/intel_mmio.c | 6 +++---
tools/intel_audio_dump.c | 4 ++--
tools/intel_backlight.c| 2 +-
tools/intel_gpu_time.c | 2 +-
tools/intel_gpu_top.c | 2 +-
tools/intel
I'm not really happy with the name of the igt_env_set function, I'll
follow up with a patch to change it.
Signed-off-by: Daniel Vetter
---
.../intel-gpu-tools/intel-gpu-tools-docs.xml | 1 +
lib/igt_aux.c | 129 -
lib/intel_os.c
Now everything is prepared to pour some neat api docs over this all.
Signed-off-by: Daniel Vetter
---
lib/intel_batchbuffer.c | 14 +++---
lib/intel_batchbuffer.h | 24
tests/gem_ctx_basic.c | 2 +-
tests/gem_media_fill.c | 4
So I wasn't really happy with env_set since it's way too close to
setenv(), whic actually _sets_ and environment variable. So use check
instead of set as the verb (well adjective for env_set).
Also sprinkle in some hints that we talk about a boolean setting here.
Signed-off-by: Daniel Vetter
---
Only the igt core and non-test tools should have asserts to catch
internal errors, tests and helper libraries should all user igt_asert
instead.
Fix things up where assert instead of igt_assert was used.
One tiny step towards header sanity.
Signed-off-by: Daniel Vetter
---
lib/drmtest.c
Occasionally useful to read documentation ...
Signed-off-by: Daniel Vetter
---
lib/igt_aux.c | 1 +
lib/igt_core.c | 3 +--
lib/igt_debugfs.c | 3 +--
lib/intel_batchbuffer.c | 3 +--
lib/intel_chipset.c | 3 +--
lib/intel_mmio.c| 3 +--
lib/ioctl_wrappers.c
Right now almost everything in there concerns itself with register
access. Move everything else out (into drmtest.h for lack of better
place) to prepare for api documentation.
Also rename intel_drm.c to intel_os.c since it contains OS, not
drm abstractions.
Signed-off-by: Daniel Vetter
---
lib/
Also rename the arguments of do_ioctl a bit for better clarity.
I haven't figured out a way to reference other section headers, hence
the links to igt_core and intel_batchbuffer are a bit fragile
unfortunately. It gets the job done though.
Signed-off-by: Daniel Vetter
---
lib/drmtest.c | 51 +++
Also fix a fumble in the documentation for intel_blt_copy. One thing
we might want to do is unify the parameter ordering here a bit ...
Again gtkdoc fails to pick up the documentation for struct igt_buf :(
Signed-off-by: Daniel Vetter
---
lib/intel_batchbuffer.c | 41 +++
Only include what the header itself needs. The big fish here is
intel-gpu-tools.h. More will follow.
One ugly thing removed here is the duplicated GEN6_TD_CTL #define, one
of which was broken.
Signed-off-by: Daniel Vetter
---
debugger/debug_rdata.c| 1 +
lib/drmtest.c |
I've left unistd.h in it - it's not strictly required but most users
of drmtest.h want it for the open helpers, and then you kinda need to
close that file descriptor again ...
Signed-off-by: Daniel Vetter
---
benchmarks/intel_upload_blit_large.c | 6 --
lib/drmtest.h|
And move the public interfaces into intel_batchbuffer.[hc].
A bit messy since we are fairly inconsistent with our header #include
handling.
Also exclude rendercopy.h from the documentation.
Signed-off-by: Daniel Vetter
---
.../intel-gpu-tools/intel-gpu-tools-docs.xml | 1 -
lib/intel_ba
Step one to properly namespace the rendercpy/mediafill functions. Als
give the buf_height/width helpers a proper igt_ prefix.
Signed-off-by: Daniel Vetter
---
lib/intel_batchbuffer.c | 4 +--
lib/intel_batchbuffer.h | 12
lib/media_fill.h| 4 +--
lib/me
Hi all,
So this thing turned out to be fairly ugly overall, and I don't think it's worth
the effort to polish the series through some giant rebasing. make distcheck
still works so I don't think I've fumbled this too badly and will hence just
push the patches as-is.
I'm still very much interested
On Fri, Mar 21, 2014 at 11:22 PM, Daniel Vetter wrote:
> With the recent addition of locking checks in
>
> commit 62ff94a5492175759546f8bc61383189d6b49122
> Author: Daniel Vetter
> AuthorDate: Thu Jan 23 22:18:47 2014 +0100
>
> drm/crtc-helper: remove LOCKING from kerneldoc
>
> drm_add_ed
From: Sourab Gupta
Using MMIO based flips on VLV for Media power well residency optimization.
The blitter ring is currently being used just for command streamer based
flip calls. For pure 3D workloads, with MMIO flips, there will be no use
of blitter ring and this will ensure the 100% residency f
From: Akash Goel
This patch adds a new drm crtc property for varying the size of
the horizontal & vertical borers of the output/display window.
This will control the output of Panel fitter.
v2: Added a new check for the invalid border size input
v3: Fixed bugs in output window calculation
Remov
On Sat, 2014-03-22 at 11:23 +, Daniel Vetter wrote:
> On Sat, Mar 22, 2014 at 03:29:11AM +, Gupta, Sourab wrote:
> > On Fri, 2014-03-21 at 17:18 +, Chris Wilson wrote:
> > > The documentation calls this GFX_MODE bit "Flush TLB invalidate Mode".
> > > However, that is not a good name for
46 matches
Mail list logo
