Greetings,
Sorry if I'm violating list etiquette in any way--the readme link to
intellinuxgraphics.org no longer works.
My hardware:
Asrock Z77 Extreme4 with iGPU Multi-Monitor enabled. Primary graphics is
set to PCIe but that doesn't make a difference.
i7 3770k / HD 4000
nVidia GTX 660 runn
On Wed, Mar 12, 2014 at 07:21:45PM -0700, Ben Widawsky wrote:
> On Thu, Mar 13, 2014 at 01:40:28AM +, Damien Lespiau wrote:
> > While wandering in the spec, I noticed that BDW removes those 2 bits
> > from INSTPM. I couldn't find any direct way to invalidate the TLB (ie
> > without the ring wor
On Thu, Mar 13, 2014 at 01:40:28AM +, Damien Lespiau wrote:
> While wandering in the spec, I noticed that BDW removes those 2 bits
> from INSTPM. I couldn't find any direct way to invalidate the TLB (ie
> without the ring working already). Maybe someone will be more lucky.
>
> At least, we now
While wandering in the spec, I noticed that BDW removes those 2 bits
from INSTPM. I couldn't find any direct way to invalidate the TLB (ie
without the ring working already). Maybe someone will be more lucky.
At least, we now know we may be a problem.
Signed-off-by: Damien Lespiau
---
drivers/gp
On Wed, Mar 12, 2014 at 6:11 PM, Rodrigo Vivi wrote:
>> We have it, it's called dirtyfb. But we need to keep the current userspace
>> stuff mostly working first, hence all this trouble. We can fix the gtt
>> trouble with a delayed work (one vblank or so) which
>> a) does a psr_exit
>> b) shots dow
On Thu, Mar 13, 2014 at 12:30:39AM +0100, Pavel Machek wrote:
> Hi!
>
> This cost me two half-written mails...
>
> So far it happened once, so it may be very infrequent; but I do not
> think I seen similar failure from i915 before, so it may be an
> regression. Well...
It's a userspace use-after
Hi!
This cost me two half-written mails...
So far it happened once, so it may be very infrequent; but I do not
think I seen similar failure from i915 before, so it may be an
regression. Well...
-22 should be EINVAL afaict.
Any ideas?
Again issues with an enum, this time intel_pipe_crc_source. The
typedefs seem to work better here though.
---
lib/igt_debugfs.c | 173 --
lib/igt_debugfs.h | 65 +---
2 files changed, 225 insertions(+), 13 deletions(-)
diff --gi
It's nowhere used and removing it gives us a cleaner, more
orthogonal interface.
---
lib/igt_debugfs.c | 5 +
lib/igt_debugfs.h | 2 +-
tests/kms_cursor_crc.c | 2 +-
tests/kms_fbc_crc.c| 2 +-
tests/kms_pipe_crc_basic.c | 2 +-
tests/kms_plane.c | 2 +-
(Almost) no one cared anyway.
---
lib/igt_debugfs.c | 13 ++---
lib/igt_debugfs.h | 2 +-
tests/gem_reset_stats.c | 2 +-
3 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index 32edc435e4bc..9c4c989c5437 100644
--- a/lib/igt
This way all debugfs library code is in one place, ready for some api
documentation care.
---
lib/drmtest.c | 38 --
lib/drmtest.h | 4
lib/igt_debugfs.c | 45 +
lib/igt_
Oops.
---
lib/ioctl_wrappers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 60512c7e1ab5..375693062eb6 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -785,7 +785,7 @@ void gem_require_caching(int fd)
/**
*
On Tue, Mar 11, 2014 at 05:41:06AM -0700, Jani Nikula wrote:
>
> Hi Bradley -
>
> I've now rather meticulously reviewed what *is* in the command and
> register tables, and didn't spot any obvious errors.
Thanks Jani! I know it's a huge pain, so I appreciate you taking the
time for it.
>
> Ther
From: Ville Syrjälä
We will call ppgtt_bind_vma() with flags != 0, so the WARN_ON(flags)
is bogus. Kill it.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
b/drivers/gpu/drm/i915/i915
From: Ville Syrjälä
When we change the cache_level for an object we need to make sure
we don't put differing types of snoopable memory too close to each
other on non-LLC machines.
Currently i915_gem_object_set_cache_level() will stop looking when
it finds just one vma that has such a conflict. D
On Wed, Mar 5, 2014 at 2:46 PM, Daniel Vetter wrote:
> On Mon, Mar 03, 2014 at 01:09:36PM -0300, Rodrigo Vivi wrote:
>> On Sat, Mar 1, 2014 at 6:10 PM, Chris Wilson
>> wrote:
>> > On Sat, Mar 01, 2014 at 03:29:41PM -0300, Rodrigo Vivi wrote:
>> >> On Sat, Mar 1, 2014 at 5:45 AM, Chris Wilson
>
On Tue, 11 Mar 2014, Mika Kuoppala wrote:
> ville.syrj...@linux.intel.com writes:
>
>> From: Ville Syrjälä
>>
>> The display interrupts changed on BDW, so the current ILK-HSW specific
>> code in ilk_pipe_in_vblank_locked() doesn't work there. Add the required
>> bits for BDW, and while at it, cha
On Mon, 10 Mar 2014, Ville Syrjälä wrote:
> On Fri, Mar 07, 2014 at 08:34:46PM +0100, Daniel Vetter wrote:
>> We need to enable interrupt processing before all the modeset
>> state is set up. But that means we can fall over when we get a pipe
>> underrun. This shouldn't happen as long as the bios
On Wed, Mar 12, 2014 at 03:55:10PM +, joao.san...@intel.com wrote:
> From: Joao Santos
>
> Remove code which is trigerring a kernel warning. The kernel sets the
> primary_enable flag prior to calling intel_enable_primary_plane() which also
> sets it. This causes the WARN to assert everytime.
I keep seeing a warning coming from intel_enable_primary_plane() in the kernel
log. It seems someone overzelous set the primary_plane flag before calling the
function and that causes the assert to trigger. It only seems to be polluting
log output.
I managed to boot and run a gl benchmark without
From: Joao Santos
Remove code which is trigerring a kernel warning. The kernel sets the
primary_enable flag prior to calling intel_enable_primary_plane() which also
sets it. This causes the WARN to assert everytime.
[ cut here ]
[5.458511] WARNING: at i915/intel_displ
At most a bit of comment of function declaration movement for more
polish. One tricky bit is to #ifdef out (only for gtkdoc of course)
the struct option; forward declaration - gtkdoc needlessly lists it.
FIXME: The struct documentation for igt_helper_process somehow doesn't
get picked up ... Same
I want to group the ioctl wrappers and related functions into their
own documentation section.
Apparently gtkdoc refuses to obey this wish without a corespdonding
header. So appease it. Also gtkdoc seems to struggle with rebuilding a
bit ...
Signed-off-by: Daniel Vetter
---
.../intel-gpu-tools/
Also some tiny polish to function interface:
- @caching in gem_set_tiling should be uint32_t to match the ioctl
struct.
- s/size/length/ for gem_write/read.
- move gem_get_num_rings to the other ring feature helpers.
v2: Also demote gem_require_ring from static inline and move it, too.
v3: Also
Piglit runner and QA are both looking at the dmesg for
DRM_ERRORs with test cases.
Add flag to stop_rings debugfs interface to prevent DRM_ERROR
output when default context banning is being tested.
References: https://bugs.freedesktop.org/show_bug.cgi?id=75876
Signed-off-by: Mika Kuoppala
---
d
On Wed, Mar 12, 2014 at 11:29:35AM +0200, Ville Syrjälä wrote:
> On Wed, Mar 12, 2014 at 09:13:13AM +, Chris Wilson wrote:
> > I have the occasional absent cursor on i845 and I want to know why.
> > This should help by revealing the last known cursor state.
> >
> > Signed-off-by: Chris Wilson
On Wed, Mar 12, 2014 at 08:32:41AM +, Chris Wilson wrote:
> On Tue, Mar 11, 2014 at 07:37:33PM +0200, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > We don't need to hold struct_mutex all through intel_pipe_set_base(),
> > just need to hold it while pinning/unpinning the
On Wed, Mar 12, 2014 at 11:01:35AM +0200, Jani Nikula wrote:
> On Mon, 10 Mar 2014, Daniel Vetter wrote:
> > When adding new gunk, _always_ think of a good place. Start/end
> > usually just means that this didn't happen, and on top of that results
> > in needless conflicts with other patches doing
On Wed, Mar 12, 2014 at 11:28:03AM +, Chris Wilson wrote:
> On Wed, Mar 12, 2014 at 04:39:39PM +0530, naresh.kumar.kac...@intel.com wrote:
> > From: Naresh Kumar Kachhi
> >
> > initial version: stop rings before sync flush
> >
> > v1: address the comments from Chris Wilson on
> > http://www.
On 03/05/2014 02:48 PM, Chris Wilson wrote:
On Wed, Feb 26, 2014 at 04:17:43PM +, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
A set of userptr test cases to support the new feature.
For the eviction and swapping stress testing I have extracted
some common behaviour from gem_evict_everyth
A common issue we have is that retiring requests causes recursion
through GTT manipulation or page table manipulation which we can only
handle at very specific points. However, to maintain internal
consistency (enforced through our sanity checks on write_domain at
various points in the GEM object l
On 02/21/2014 06:45 PM, Chris Wilson wrote:
By exporting the ability to map user address and inserting PTEs
representing their backing pages into the GTT, we can exploit UMA in order
to utilize normal application data as a texture source or even as a
render target (depending upon the capabilitie
On Wed, Mar 5, 2014 at 2:38 AM, Daniel Vetter wrote:
> On Tue, Mar 04, 2014 at 05:06:22PM +0200, Ville Syrjälä wrote:
>> On Tue, Mar 04, 2014 at 10:38:58PM +0800, Chia-I Wu wrote:
>> > On Tue, Mar 4, 2014 at 5:41 PM, Chris Wilson
>> > wrote:
>> > > This reverts commit 116f2b6da868dec7539103574d0
On Wed, Mar 12, 2014 at 04:39:39PM +0530, naresh.kumar.kac...@intel.com wrote:
> From: Naresh Kumar Kachhi
>
> initial version: stop rings before sync flush
>
> v1: address the comments from Chris Wilson on
> http://www.spinics.net/lists/intel-gfx/msg41025.html.
> Rather than adding stop and sta
Hi Sagar,
On Wednesday 12 March 2014 16:46:05 Sagar Arun Kamble wrote:
> On Mon, 2014-03-10 at 15:36 +0100, Laurent Pinchart wrote:
> > On Monday 10 March 2014 06:21:49 Daniel Vetter wrote:
> > > On Wed, Mar 5, 2014 at 11:56 AM, wrote:
> > > > +
> > > > +
> > > > +
> > > > +Owner Module/Drivers
On Wed, Mar 12, 2014 at 04:39:41PM +0530, naresh.kumar.kac...@intel.com wrote:
> From: Naresh Kumar Kachhi
>
> make sure we wait for rings to become idle once they are
> disabled. In case of timeout print an error message
>
> Signed-off-by: Naresh Kumar Kachhi
> ---
> drivers/gpu/drm/i915/i915
Hi Laurent, Daniel
On Mon, 2014-03-10 at 15:36 +0100, Laurent Pinchart wrote:
> Hi Daniel,
>
> On Monday 10 March 2014 06:21:49 Daniel Vetter wrote:
> > On Wed, Mar 5, 2014 at 11:56 AM, wrote:
> > > +
> > > +
> > > +
> > > +Owner Module/Drivers
> > > +Group
> > > +Property Object
> > > +Property
From: Naresh Kumar Kachhi
Rings should be idle before issuing sync_flush
(in intel_ring_setup_status_page). This patch moves the ring
disabling before doing the HW status page setup.
Signed-off-by: Naresh Kumar Kachhi
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 10
From: Naresh Kumar Kachhi
Based on Bspec the command parser must be stopped prior to
issuing sync flush. This should be done by the caller of
intel_ring_setup_status_page. Patch adds a warning if it is
not done.
v2: rebased based on new patch (wait for ring to become idle)
Signed-off-by: Naresh
From: Naresh Kumar Kachhi
initial version: stop rings before sync flush
v1: address the comments from Chris Wilson on
http://www.spinics.net/lists/intel-gfx/msg41025.html.
Rather than adding stop and start ring, we are moving
ring disable before hw_status_page_setup (sync flush).
v2: Based on C
From: Naresh Kumar Kachhi
make sure we wait for rings to become idle once they are
disabled. In case of timeout print an error message
Signed-off-by: Naresh Kumar Kachhi
---
drivers/gpu/drm/i915/i915_reg.h | 2 ++
drivers/gpu/drm/i915/intel_ringbuffer.c | 6 ++
drivers/gpu/drm/i915
On Wed, Mar 12, 2014 at 09:13:13AM +, Chris Wilson wrote:
> I have the occasional absent cursor on i845 and I want to know why.
> This should help by revealing the last known cursor state.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/i915_debugfs
On Wed, Mar 12, 2014 at 11:16:59AM +0200, Ville Syrjälä wrote:
> On Wed, Mar 12, 2014 at 08:35:39AM +, Chris Wilson wrote:
> > On Tue, Mar 11, 2014 at 07:37:35PM +0200, ville.syrj...@linux.intel.com
> > wrote:
> > > From: Ville Syrjälä
> > >
> > > Now that we've plugged the mmio vs. ring fli
On Wed, Mar 12, 2014 at 08:35:39AM +, Chris Wilson wrote:
> On Tue, Mar 11, 2014 at 07:37:35PM +0200, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > Now that we've plugged the mmio vs. ring flip race, we shouldn't need
> > these vblank waits in the modeset codepaths anym
On Wed, Mar 12, 2014 at 08:36:37AM +, Chris Wilson wrote:
> On Tue, Mar 11, 2014 at 07:37:36PM +0200, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > Now that the vblank wait is gone from intel_enable_primary_plane(),
> > hsw_enable_ips() needs to do the vblank wait itsel
I have the occasional absent cursor on i845 and I want to know why.
This should help by revealing the last known cursor state.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_debugfs.c | 57 -
1 file changed, 50 insertions(+), 7 deletions(-)
diff --
On Wed, Mar 12, 2014 at 08:30:08AM +, Chris Wilson wrote:
> On Tue, Mar 11, 2014 at 07:37:34PM +0200, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > Starting from ILK, mmio flips also cause a flip done interrupt to be
> > signalled. This means if we first do a set_base a
On Mon, 10 Mar 2014, Daniel Vetter wrote:
> When adding new gunk, _always_ think of a good place. Start/end
> usually just means that this didn't happen, and on top of that results
> in needless conflicts with other patches doing the same.
I'm a fan of unnamed structs within structs to group stuf
On Tue, Mar 11, 2014 at 07:37:36PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Now that the vblank wait is gone from intel_enable_primary_plane(),
> hsw_enable_ips() needs to do the vblank wait itself.
This should be done before removing the wait from
intel_enable_prima
On Tue, Mar 11, 2014 at 07:37:35PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Now that we've plugged the mmio vs. ring flip race, we shouldn't need
> these vblank waits in the modeset codepaths anymore. So get rid of
> them.
Hmm, could we not add an assert(DSPSURFLIVE
On Tue, Mar 11, 2014 at 07:37:33PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> We don't need to hold struct_mutex all through intel_pipe_set_base(),
> just need to hold it while pinning/unpinning the buffers.
>
> So reduce the struct_mutext usage in intel_pipe_set_base(
On Tue, Mar 11, 2014 at 07:37:34PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Starting from ILK, mmio flips also cause a flip done interrupt to be
> signalled. This means if we first do a set_base and follow it
> immediately with the CS flip, we might mistake the flip d
On Wed, Mar 12, 2014 at 08:06:26AM +, Chris Wilson wrote:
> On Wed, Mar 12, 2014 at 12:20:09PM +0530, naresh.kumar.kac...@intel.com wrote:
> > From: Naresh Kumar Kachhi
> >
> > initial version: stop rings before sync flush
> >
> > v1: address the comments from Chris Wilson on
> > http://www.
On Wed, Mar 12, 2014 at 12:20:09PM +0530, naresh.kumar.kac...@intel.com wrote:
> From: Naresh Kumar Kachhi
>
> initial version: stop rings before sync flush
>
> v1: address the comments from Chris Wilson on
> http://www.spinics.net/lists/intel-gfx/msg41025.html.
> Rather than adding stop and sta
54 matches
Mail list logo
