Re: [Intel-gfx] [Regression 3.14-rc2] drm/i915: Brightness adjustment is broken in 945GM

2014-02-13 Thread Jani Nikula
On Thu, 13 Feb 2014, Luis Ortega wrote: > On Thu, Feb 13, 2014 at 05:24:23PM +0100, Luis Ortega wrote: >> > I dare say either your bisect went sour or you don't have 945GM. Please >> > verify your steps. >> >> Well, what can I say? I was careful when testing and the last kernel I >> compiled >>

Re: [Intel-gfx] 3.13.1 - WARNING at drivers/gpu/drm/i915/i915_irq.c:1240

2014-02-13 Thread Thomas Meyer
Am Montag, den 10.02.2014, 09:58 +0100 schrieb Daniel Vetter: > On Sat, Feb 08, 2014 at 07:30:54PM +0100, Thomas Meyer wrote: > > Am Samstag, den 08.02.2014, 17:38 +0100 schrieb Daniel Vetter: > > > On Sat, Feb 8, 2014 at 12:51 PM, Thomas Meyer wrote: > > > > Am Freitag, den 07.02.2014, 09:46 +010

Re: [Intel-gfx] [PATCH] drm/i915: don't reference null pointer at i915_sink_crc

2014-02-13 Thread Daniel Vetter
On Thu, Feb 13, 2014 at 8:51 PM, Paulo Zanoni wrote: > encoder = to_intel_encoder(connector->base.encoder); > + if (!encoder) > + continue; to_intel_connector can change a NULL pointer to something slightly different if the base structure isn't

Re: [Intel-gfx] [Regression 3.14-rc2] drm/i915: Brightness adjustment is broken in 945GM

2014-02-13 Thread Luis Ortega
> I dare say either your bisect went sour or you don't have 945GM. Please > verify your steps. Well, what can I say? I was careful when testing and the last kernel I compiled shows the problem. I can replay the bisection if needed but if I have to start all over again it's gonna take some time. I'

[Intel-gfx] [Regression 3.14-rc2] drm/i915: Brightness adjustment is broken in 945GM

2014-02-13 Thread Luis Ortega
Hi, testing 3.14-rc2 I noticed I could not adjust the brightness of the screen any longer. This problem is already present in 3.14-rc1. 3.13 works fine. My hardware is a netbook with intel atom and a 945GM graphics card. I bisected the problem down to the next commit: bc0bb9fd1c7810407ab810d204b

Re: [Intel-gfx] What to do with xf86-video-intel backlight control when running Xorg as non root

2014-02-13 Thread Chris Wilson
On Thu, Feb 13, 2014 at 08:37:47PM +0100, Hans de Goede wrote: > Hi, > > On 02/13/2014 05:40 PM, Chris Wilson wrote: > > Otherwise, it seems like we need the > > proxy in order to keep the xrandr property available to users and > > prevent those who rely upon it in scripts from seeing regressions.

Re: [Intel-gfx] What to do with xf86-video-intel backlight control when running Xorg as non root

2014-02-13 Thread Mark Kettenis
> Date: Thu, 13 Feb 2014 20:37:47 +0100 > From: Hans de Goede > > Hi, Hi Hans, Apologies in advance for jumping into the discussion at a somewhat random point. > On 02/13/2014 05:40 PM, Chris Wilson wrote: > On Thu, Feb 13, 2014 > at 04:52:59PM +0100, Hans de Goede wrote: >> Hi All, > >> > >>

Re: [Intel-gfx] [PATCH] drm/i915/lvds: Remove dead code from failing case

2014-02-13 Thread Daniel Vetter
On Thu, Feb 13, 2014 at 05:04:48PM -0200, Paulo Zanoni wrote: > 2014-02-13 16:56 GMT-02:00 Damien Lespiau : > > Coverity points out that, if we end up in the 'failed' label, that's > > precisely because we couldn't retrieve a fixed mode (ie fixed_mode is > > NULL) and then "if (fixed_mode)" is alwa

[Intel-gfx] Multiple Instances of h264encode: Corruption and Cross-process interference

2014-02-13 Thread Bruce
*System from vainfo* *libva info: VA-API version 0.34.0* *libva info: va_getDriverName() returns 0* *libva info: Trying to open /usr/local/lib/dri/i965_drv_video.so* *libva info: Found init function __vaDriverInit_0_34* *libva info: va_openDriver() returns 0* *vainfo: VA-API version: 0.34 (

[Intel-gfx] [PATCH] drm/i915: don't reference null pointer at i915_sink_crc

2014-02-13 Thread Paulo Zanoni
From: Paulo Zanoni Reproducible by runtime suspending a Haswell machine with eDP + HDMI outputs connected. [ 209.600086] [drm:i915_runtime_suspend], Suspending device [ 209.688435] BUG: unable to handle kernel NULL pointer dereference at 0060 [ 209.688500] IP: [] i915_sink_crc+0x

[Intel-gfx] [PATCH v4 5/5] drm/i915: Add pipe update trace points

2014-02-13 Thread ville . syrjala
From: Ville Syrjälä Add trace points for observing the atomic pipe update mechanism. v2: Rebased due to earlier changes v3: Pass intel_crtc instead of drm_crtc (Daniel) v4: Pass frame counter from the caller to evaded/end since the caller now always has that ready Reviewed-by: Jesse Barnes

[Intel-gfx] [PATCH v5 3/5] drm/i915: Make sprite updates atomic

2014-02-13 Thread ville . syrjala
From: Ville Syrjälä Add a mechanism by which we can evade the leading edge of vblank. This guarantees that no two sprite register writes will straddle on either side of the vblank start, and that means all the writes will be latched together in one atomic operation. We do the vblank evade by che

Re: [Intel-gfx] What to do with xf86-video-intel backlight control when running Xorg as non root

2014-02-13 Thread Hans de Goede
Hi, On 02/13/2014 05:40 PM, Chris Wilson wrote: > On Thu, Feb 13, 2014 at 04:52:59PM +0100, Hans de Goede wrote: >> Hi All, >> >> Currently xf86-video-intel is unique in that it is the only video driver >> which does backlight control inside the driver rather then letting >> something else (ie the

Re: [Intel-gfx] [PATCH] drm/i915/lvds: Remove dead code from failing case

2014-02-13 Thread Paulo Zanoni
2014-02-13 16:56 GMT-02:00 Damien Lespiau : > Coverity points out that, if we end up in the 'failed' label, that's > precisely because we couldn't retrieve a fixed mode (ie fixed_mode is > NULL) and then "if (fixed_mode)" is always false. > > Remove that dead code. > > Signed-off-by: Damien Lespiau

[Intel-gfx] [PATCH] drm/i915/lvds: Remove dead code from failing case

2014-02-13 Thread Damien Lespiau
Coverity points out that, if we end up in the 'failed' label, that's precisely because we couldn't retrieve a fixed mode (ie fixed_mode is NULL) and then "if (fixed_mode)" is always false. Remove that dead code. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_lvds.c | 2 -- 1 file

Re: [Intel-gfx] [PATCH v4 3/5] drm/i915: Make sprite updates atomic

2014-02-13 Thread Ville Syrjälä
On Thu, Feb 13, 2014 at 04:01:52PM +, Chris Wilson wrote: > On Thu, Feb 13, 2014 at 05:42:52PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Add a mechanism by which we can evade the leading edge of vblank. This > > guarantees that no two sprite register writes w

Re: [Intel-gfx] What to do with xf86-video-intel backlight control when running Xorg as non root

2014-02-13 Thread Chris Wilson
On Thu, Feb 13, 2014 at 04:52:59PM +0100, Hans de Goede wrote: > Hi All, > > Currently xf86-video-intel is unique in that it is the only video driver > which does backlight control inside the driver rather then letting > something else (ie the desktop environment) deal with it. > > This is a prob

Re: [Intel-gfx] [PATCH v4 3/5] drm/i915: Make sprite updates atomic

2014-02-13 Thread Chris Wilson
On Thu, Feb 13, 2014 at 05:42:52PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Add a mechanism by which we can evade the leading edge of vblank. This > guarantees that no two sprite register writes will straddle on either > side of the vblank start, and that means all th

[Intel-gfx] What to do with xf86-video-intel backlight control when running Xorg as non root

2014-02-13 Thread Hans de Goede
Hi All, Currently xf86-video-intel is unique in that it is the only video driver which does backlight control inside the driver rather then letting something else (ie the desktop environment) deal with it. This is a problem when running the xserver without root rights because writing /sys/class/b

Re: [Intel-gfx] [PATCH] drm/i915: Fix correct FIFO size for Baytrail

2014-02-13 Thread Purushothaman, Vijay A
> -Original Message- > From: Deak, Imre > Sent: Wednesday, February 12, 2014 10:57 PM > To: Purushothaman, Vijay A > Cc: Intel Graphics; Daniel Vetter > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix correct FIFO size for Baytrail > > On Wed, 2014-02-12 at 19:24 +0200, Imre Deak wrote: > >

[Intel-gfx] [PATCH v3 2/5] drm/i915: Add intel_get_crtc_scanline()

2014-02-13 Thread ville . syrjala
From: Ville Syrjälä Add a new function intel_get_crtc_scanline() that returns the current scanline counter for the crtc. v2: Rebase after vblank timestamp changes. Use intel_ prefix instead of i915_ as is more customary for display related functions. Include DRM_SCANOUTPOS_INVBL in t

[Intel-gfx] [PATCH v3 0/5] drm/i915: Atomic sprites v3

2014-02-13 Thread ville . syrjala
From: Ville Syrjälä OK, so Daniel convinced me that the check+wait thing I used earlier wasn't really safe. I then decided that the only to make it safe it open coding the wait_for_event() mysefl, and after doing that I realized that we don't even need the silly vbl_received thingy, and just a wa

[Intel-gfx] [PATCH v4 3/5] drm/i915: Make sprite updates atomic

2014-02-13 Thread ville . syrjala
From: Ville Syrjälä Add a mechanism by which we can evade the leading edge of vblank. This guarantees that no two sprite register writes will straddle on either side of the vblank start, and that means all the writes will be latched together in one atomic operation. We do the vblank evade by che

[Intel-gfx] [PATCH 1/5] drm/i915: Fix scanout position for real

2014-02-13 Thread ville . syrjala
From: Ville Syrjälä Seems I've been a bit dense with regards to the start of vblank vs. the scanline counter / pixel counter. After staring at the pixel counter on gen4 I came to the conclusion that the start of vblank interrupt and scanline counter increment happen at the same time. The scanlin

[Intel-gfx] [PATCH v2 4/5] drm/i915: Perform primary enable/disable atomically with sprite updates

2014-02-13 Thread ville . syrjala
From: Ville Syrjälä Move the primary plane enable/disable to occur atomically with the sprite update that caused the primary plane visibility to change. FBC and IPS enable/disable is left to happen well before or after the primary plane change. v2: Pass intel_crtc instead of drm_crtc (Daniel)

[Intel-gfx] [PATCH v3 5/5] drm/i915: Add pipe update trace points

2014-02-13 Thread ville . syrjala
From: Ville Syrjälä Add trace points for observing the atomic pipe update mechanism. v2: Rebased due to earlier changes v3: Pass intel_crtc instead of drm_crtc (Daniel) Reviewed-by: Jesse Barnes Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_trace.h | 77 +++

Re: [Intel-gfx] [Regression 3.14-rc2] drm/i915: Brightness adjustment is broken in 945GM

2014-02-13 Thread Jani Nikula
On Thu, 13 Feb 2014, Luis Ortega wrote: > Hi, testing 3.14-rc2 I noticed I could not adjust the brightness of the > screen any longer. This problem is already present in 3.14-rc1. 3.13 works > fine. > > My hardware is a netbook with intel atom and a 945GM graphics card. > > I bisected the problem

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add parsing support for new MIPI blocks in VBT

2014-02-13 Thread Jani Nikula
On Thu, 13 Feb 2014, Shobhit Kumar wrote: > The parser extracts the config block(#52) and sequence(#53) data > and store in private data structures. > > Signed-off-by: Shobhit Kumar > --- > drivers/gpu/drm/i915/i915_drv.h | 6 ++ > drivers/gpu/drm/i915/intel_bios.c | 175 > +

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Rename primary plane rotation property to "plane-rotation"

2014-02-13 Thread Ville Syrjälä
On Thu, Feb 13, 2014 at 02:20:57PM +, Chris Wilson wrote: > On Thu, Feb 13, 2014 at 04:06:31PM +0200, Ville Syrjälä wrote: > > On Thu, Feb 13, 2014 at 03:46:39PM +0200, Ville Syrjälä wrote: > > > On Thu, Feb 13, 2014 at 06:07:27PM +0530, Sagar Arun Kamble wrote: > > > > On Wed, 2014-02-12 at 23

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update VBT data structures to have MIPI block enhancements

2014-02-13 Thread Jani Nikula
On Thu, 13 Feb 2014, Shobhit Kumar wrote: > +/* Block 53 contains MIPI sequences as needed by the panel > + * for enabling it. This block can be variable in size and > + * can be maximum of 6 blocks > + */ > +struct bdb_mipi_sequence { > + u8 version; > + void *data; Make this u8

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Rename primary plane rotation property to "plane-rotation"

2014-02-13 Thread Chris Wilson
On Thu, Feb 13, 2014 at 04:06:31PM +0200, Ville Syrjälä wrote: > On Thu, Feb 13, 2014 at 03:46:39PM +0200, Ville Syrjälä wrote: > > On Thu, Feb 13, 2014 at 06:07:27PM +0530, Sagar Arun Kamble wrote: > > > On Wed, 2014-02-12 at 23:15 +0200, ville.syrj...@linux.intel.com wrote: > > > > From: Ville Sy

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: add native aux defer retry limit

2014-02-13 Thread Jani Nikula
On Thu, 13 Feb 2014, Daniel Vetter wrote: > On Tue, Feb 11, 2014 at 03:17:58PM +0100, Daniel Vetter wrote: >> On Tue, Feb 11, 2014 at 10:52 AM, Jani Nikula wrote: >> > Retrying indefinitely places too much trust on the aux implementation of >> > the sink devices. >> > >> > Reported-by: Daniel Mar

Re: [Intel-gfx] [PATCH v2 0/4] drm/i915: dp: fix order of dp aux i2c device cleanup

2014-02-13 Thread Antti Koskipää
On 02/11/2014 05:12 PM, Imre Deak wrote: > The main point of this patchset is to fix a driver unload bug caused by > incorrect order of dp aux i2c cleanup wrt. destroying the corresponding > encoder/connector objects, see the second patch for details. > > Tested on vlv/dp. > > v2: move all sysfs

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Rename primary plane rotation property to "plane-rotation"

2014-02-13 Thread Ville Syrjälä
On Thu, Feb 13, 2014 at 03:46:39PM +0200, Ville Syrjälä wrote: > On Thu, Feb 13, 2014 at 06:07:27PM +0530, Sagar Arun Kamble wrote: > > On Wed, 2014-02-12 at 23:15 +0200, ville.syrj...@linux.intel.com wrote: > > > From: Ville Syrjälä > > > > > > I'd prefer have the crtc "rotation" property rotate

[Intel-gfx] [PATCH 3/3] tests/kms_flip: use igt logging

2014-02-13 Thread Daniel Vetter
Signed-off-by: Daniel Vetter --- tests/kms_flip.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index c397c9049d82..6b448be1267e 100644 --- a/tests/kms_flip.c +++ b/tests/kms_flip.c @@ -862,7 +862,7 @@ static unsigned int run_test_

[Intel-gfx] [PATCH 2/3] tests/gem_seqno_wrap: use igt logging

2014-02-13 Thread Daniel Vetter
Cc: Mika Kuoppala Signed-off-by: Daniel Vetter --- tests/gem_seqno_wrap.c | 28 +--- 1 file changed, 5 insertions(+), 23 deletions(-) diff --git a/tests/gem_seqno_wrap.c b/tests/gem_seqno_wrap.c index e37365f1d45c..0d90df6b7db0 100644 --- a/tests/gem_seqno_wrap.c +++ b/t

[Intel-gfx] [PATCH 1/3] test/pm_rps: use igt logging

2014-02-13 Thread Daniel Vetter
Cc: Jeff McGee Signed-off-by: Daniel Vetter --- tests/pm_rps.c | 112 +++-- 1 file changed, 37 insertions(+), 75 deletions(-) diff --git a/tests/pm_rps.c b/tests/pm_rps.c index 3d374f92f82d..a652cf580dc7 100644 --- a/tests/pm_rps.c +++ b/tests

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Rename primary plane rotation property to "plane-rotation"

2014-02-13 Thread Ville Syrjälä
On Thu, Feb 13, 2014 at 06:07:27PM +0530, Sagar Arun Kamble wrote: > On Wed, 2014-02-12 at 23:15 +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > I'd prefer have the crtc "rotation" property rotate the entire crtc > > (planes and all). So for that reason we'd need to co

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Rename primary plane rotation property to "plane-rotation"

2014-02-13 Thread Sagar Arun Kamble
On Wed, 2014-02-12 at 23:15 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > I'd prefer have the crtc "rotation" property rotate the entire crtc > (planes and all). So for that reason we'd need to come up with some > other name for the "rotate the primary plane only" property

Re: [Intel-gfx] [PATCH] drm/i915/opregion: work around buggy firmware that provides 8+ output devices

2014-02-13 Thread Daniel Vetter
On Thu, Feb 13, 2014 at 11:08 AM, Chris Wilson wrote: > On Thu, Feb 13, 2014 at 05:10:25PM +0800, Aaron Lu wrote: >> On 02/12/2014 06:31 PM, Chris Wilson wrote: >> > On Wed, Feb 12, 2014 at 11:05:40AM +0800, Aaron Lu wrote: >> >> The ACPI table on ASUS UX302LA has more than 8 output devices under

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Full pipe rotation & rotation property name bikeshedding

2014-02-13 Thread Ville Syrjälä
On Thu, Feb 13, 2014 at 11:20:49AM +, Chris Wilson wrote: > On Wed, Feb 12, 2014 at 11:14:59PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > After playing around Sagar's primary plane rotation a bit, I decided that > > extending that to full pipe rotation would b

Re: [Intel-gfx] [PATCH 0/9] [REPOST] BDW 4G GGTT + PPGTT cleanups

2014-02-13 Thread Ville Syrjälä
On Wed, Feb 12, 2014 at 02:28:43PM -0800, Ben Widawsky wrote: > Rebased series from what I submitted a while ago: > http://lists.freedesktop.org/archives/intel-gfx/2013-December/037815.html > > It was mostly a clean rebase, but there were a couple of major conflicts which > I think I cleaned up pr

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Full pipe rotation & rotation property name bikeshedding

2014-02-13 Thread Chris Wilson
On Wed, Feb 12, 2014 at 11:14:59PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > After playing around Sagar's primary plane rotation a bit, I decided that > extending that to full pipe rotation would be nice. Chris also seemed to > want that, but I'm not sure he does anymo

Re: [Intel-gfx] [PATCH] drm/i915/opregion: work around buggy firmware that provides 8+ output devices

2014-02-13 Thread Chris Wilson
On Thu, Feb 13, 2014 at 05:10:25PM +0800, Aaron Lu wrote: > On 02/12/2014 06:31 PM, Chris Wilson wrote: > > On Wed, Feb 12, 2014 at 11:05:40AM +0800, Aaron Lu wrote: > >> The ACPI table on ASUS UX302LA has more than 8 output devices under the > >> graphics controller device node. The problem is, th

Re: [Intel-gfx] [PATCH] drm/i915: don't preserve inherited configs with nothing on v2

2014-02-13 Thread Daniel Vetter
On Wed, Feb 12, 2014 at 03:03:40PM -0800, Jesse Barnes wrote: > It can be corrected later and may be what was actually desired, but > generally isn't, so if we find nothing is enabled, let the core DRM fb > helper figure something out. > > v2: free the array too (Jesse) > > Signed-off-by: Jesse B

Re: [Intel-gfx] [PATCH 1/5] drm: Pass name to drm_rotation_property_create()

2014-02-13 Thread Sagar Arun Kamble
Reviewed-by: Sagar Kamble On Wed, 2014-02-12 at 23:15 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Allow rotation properties to have custom names. > > TODO: maybe squash into "drm: Add drm_mode_create_rotation_property()" > > Cc: Sagar Kamble > Signed-off-by: Ville S

Re: [Intel-gfx] [PATCH 1/9] drm/i915/bdw: Split up PPGTT cleanup

2014-02-13 Thread Chris Wilson
On Wed, Feb 12, 2014 at 02:28:44PM -0800, Ben Widawsky wrote: > This will make the code more readable, and extensible which is needed > for upcoming feature work. Eventually, we'll do the same for init. > > Signed-off-by: Ben Widawsky I don't think I spotted any logic changes, Reviewed-by: Chris

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Split GEN6 PPGTT initialization up

2014-02-13 Thread Chris Wilson
On Wed, Feb 12, 2014 at 02:28:52PM -0800, Ben Widawsky wrote: > Simply to match the GEN8 style of PPGTT initialization, split up the > allocations and mappings. Unlike GEN8, we skip a separate dma_addr_t > allocation function, as it is much simpler pre-gen8. > > With this code it would be easy to

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Split GEN6 PPGTT cleanup

2014-02-13 Thread Chris Wilson
On Wed, Feb 12, 2014 at 02:28:51PM -0800, Ben Widawsky wrote: > This cleanup is similar to the GEN8 cleanup (though less necessary). > Having everything split will make cleaning the initialization path error > paths easier to understand. > > Signed-off-by: Ben Widawsky Reviewed-by: Chris Wilson

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Convert DIP port switch cases to a simple macro

2014-02-13 Thread Daniel Vetter
On Mon, Feb 10, 2014 at 12:11:33PM +, Damien Lespiau wrote: > On Thu, Jan 23, 2014 at 11:15:34PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > We have a couple of switch cases to compute the port value for the > > VIDEO_DIP_CTL register. Replace them with a simpl

Re: [Intel-gfx] [PATCH] drm/i915: Make num_pipes a per-pipe value

2014-02-13 Thread Jani Nikula
On Wed, 12 Feb 2014, Damien Lespiau wrote: > In the future, we need to be able to specify per-pipe number of planes. > Let's start today! > > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/i915_dma.c | 14 +++--- > drivers/gpu/drm/i915/i915_drv.h | 4 ++-- > driver

Re: [Intel-gfx] [PATCH] drm/i915/opregion: work around buggy firmware that provides 8+ output devices

2014-02-13 Thread Aaron Lu
On 02/12/2014 06:31 PM, Chris Wilson wrote: > On Wed, Feb 12, 2014 at 11:05:40AM +0800, Aaron Lu wrote: >> The ACPI table on ASUS UX302LA has more than 8 output devices under the >> graphics controller device node. The problem is, the real active output >> device, the LCD panel, is listed the last.

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Full pipe rotation & rotation property name bikeshedding

2014-02-13 Thread Ville Syrjälä
On Wed, Feb 12, 2014 at 11:17:27PM +, Chris Wilson wrote: > On Wed, Feb 12, 2014 at 11:14:59PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > After playing around Sagar's primary plane rotation a bit, I decided that > > extending that to full pipe rotation would b

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: add native aux defer retry limit

2014-02-13 Thread Daniel Vetter
On Tue, Feb 11, 2014 at 03:17:58PM +0100, Daniel Vetter wrote: > On Tue, Feb 11, 2014 at 10:52 AM, Jani Nikula wrote: > > Retrying indefinitely places too much trust on the aux implementation of > > the sink devices. > > > > Reported-by: Daniel Martin > > Bugzilla: https://bugs.freedesktop.org/sh

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update VBT data structures to have MIPI block enhancements

2014-02-13 Thread Jani Nikula
On Thu, 13 Feb 2014, Shobhit Kumar wrote: > Hi > > On Thursday 13 February 2014 12:47 PM, Jani Nikula wrote: >> On Thu, 13 Feb 2014, Shobhit Kumar wrote: >> Per the spec you sent me, there's 1 byte reserved, and 5 bytes of GPIO >> indexes below. >> >> All in all, the size of the struct is differe

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update VBT data structures to have MIPI block enhancements

2014-02-13 Thread Shobhit Kumar
Hi On Thursday 13 February 2014 12:47 PM, Jani Nikula wrote: On Thu, 13 Feb 2014, Shobhit Kumar wrote: MIPI Block #52 which provides configuration details for the MIPI panel including dphy settings as per panel and tcon specs Block #53 gives information on panel enable sequences Signed-off-b