Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Disable/Enable PM Intrrupts based on the current freq.

2013-12-18 Thread S, Deepak
Hi Chris, If I understand correctly we are using GEN6_RP_INTERRUPT_LIMITS to Make sure we continue to get interrupts until we hit the minimum or maximum frequencies for gen6 right? Also, we do setup the gen6_set_rps_thresholds based on the power in gen6_set_rps right? Instead of adding it in

Re: [Intel-gfx] kernel 3.11.6 general protection fault

2013-12-18 Thread Borislav Petkov
On Wed, Dec 18, 2013 at 09:59:22PM +0100, MPhil. Emanoil Kotsev wrote: > I was able to solve the issue by removing some of the modules I had in > xorg.conf. I noticed that it is not the cpu that is overheating, but > rather the video/graphic card. The area around the "Dell" logo on the > front of t

Re: [Intel-gfx] [PATCH v3.12 0/3] drm/i915: Backport some VLV clock fixes to 3.12

2013-12-18 Thread Greg KH
On Tue, Dec 10, 2013 at 05:07:13PM +0200, ville.syrj...@linux.intel.com wrote: > Hi stable team, > > Here's a backport of the following upstream commits for 3.12: > > commit 662c6ecbcdca1fe8a5402f6c83d98d242917a043 > Author: Chris Wilson > Date: Wed Sep 25 14:24:01 2013 -0700 > > drm/i915

Re: [Intel-gfx] kernel 3.11.6 general protection fault

2013-12-18 Thread MPhil. Emanoil Kotsev
Hi again, sorry for writing after such long time of silence, but I was busy with one project (and family as well) On Sunday 17 November 2013 21:05:46 you wrote: > On Sun, Nov 17, 2013 at 05:45:18PM +0100, MPhil. Emanoil Kotsev wrote: > > How - new libraries - more exhaustive algorythms - higher

Re: [Intel-gfx] [PATCH 05/10] drm/i915: retrieve current fb config into new plane_config structure at init v8

2013-12-18 Thread Jesse Barnes
On Wed, 18 Dec 2013 12:36:14 +0200 Jani Nikula wrote: > > + continue; > > + > > +#ifdef CONFIG_FB > > Déjà vu, I just told Daniel the same thing: > > #if IS_ENABLED(CONFIG_FB) > > if you want this to work for CONFIG_FB=m too. Ah yeah I even knew that when I was writing it.

Re: [Intel-gfx] [PATCH 45/48] drm/i915: Dump all ppgtt

2013-12-18 Thread Daniel Vetter
On Fri, Dec 06, 2013 at 02:11:30PM -0800, Ben Widawsky wrote: > From: Ben Widawsky > > Signed-off-by: Ben Widawsky > > Conflicts: > drivers/gpu/drm/i915/i915_debugfs.c Please take these conflict markers out next time around ... -Daniel > --- > drivers/gpu/drm/i915/i915_debugfs.c | 25 +

Re: [Intel-gfx] [PATCH 43/48] drm/i915: Warn on gem_pin usage

2013-12-18 Thread Daniel Vetter
On Fri, Dec 06, 2013 at 02:11:28PM -0800, Ben Widawsky wrote: > The pin IOCTL is leftover from the days of yore. It allows you to take a > buffer, pin it, and receive the offset of that buffer. The IOCTL does > not support the newer notion of contexts and VM, and therefore is not > suitable for mod

Re: [Intel-gfx] [PATCH 40/48] drm/i915: Add a tracepoint for new VMs

2013-12-18 Thread Daniel Vetter
On Fri, Dec 06, 2013 at 02:11:25PM -0800, Ben Widawsky wrote: > Signed-off-by: Ben Widawsky I'll leave this one out for now. -Daniel > --- > drivers/gpu/drm/i915/i915_gem.c | 1 + > drivers/gpu/drm/i915/i915_trace.h | 18 ++ > 2 files changed, 19 insertions(+) > > diff --git

Re: [Intel-gfx] [PATCH 39/48] drm/i915: Do not allow buffers at offset 0

2013-12-18 Thread Daniel Vetter
On Thu, Dec 12, 2013 at 10:59:03AM +, Chris Wilson wrote: > On Fri, Dec 06, 2013 at 02:11:24PM -0800, Ben Widawsky wrote: > > This is primarily a band aid for an unexplainable error in > > gem_reloc_vs_gpu/forked-faulting-reloc-thrashing. Essentially as soon as > > a relocated buffer (which had

Re: [Intel-gfx] [PATCH 38/48] drm/i915: Clean up VMAs before freeing

2013-12-18 Thread Daniel Vetter
On Wed, Dec 18, 2013 at 03:55:05PM +0100, Daniel Vetter wrote: > On Fri, Dec 06, 2013 at 02:11:23PM -0800, Ben Widawsky wrote: > > From: Ben Widawsky > > > > It's quite common for an object to simply be on the inactive list (and > > not unbound) when we want to free the context. This of course ha

Re: [Intel-gfx] [PATCH 38/48] drm/i915: Clean up VMAs before freeing

2013-12-18 Thread Daniel Vetter
On Fri, Dec 06, 2013 at 02:11:23PM -0800, Ben Widawsky wrote: > From: Ben Widawsky > > It's quite common for an object to simply be on the inactive list (and > not unbound) when we want to free the context. This of course happens > with lazy unbinding. Simply, this is needed when an object isn't

Re: [Intel-gfx] [PATCH 37/48] drm/i915: Defer request freeing

2013-12-18 Thread Daniel Vetter
On Thu, Dec 12, 2013 at 11:08:47AM +, Chris Wilson wrote: > On Fri, Dec 06, 2013 at 02:11:22PM -0800, Ben Widawsky wrote: > > From: Ben Widawsky > > > > With context destruction, we always want to be able to tear down the > > underlying address space. This is invoked on the last unreference t

Re: [Intel-gfx] [PATCH 18/48] drm/i915: Better reset handling for contexts

2013-12-18 Thread Daniel Vetter
On Fri, Dec 06, 2013 at 02:11:03PM -0800, Ben Widawsky wrote: > From: Ben Widawsky > > This patch adds to changes for contexts on reset: > Sets last context to default - this will prevent the context switch > happening after a reset. That switch is not possible because the > rings are hung during

Re: [Intel-gfx] [PATCH 03/48] drm/i915: Don't unconditionally try to deref aliasing ppgtt

2013-12-18 Thread Daniel Vetter
On Fri, Dec 06, 2013 at 02:10:48PM -0800, Ben Widawsky wrote: > Since the beginning, the functions which try to properly reference the > aliasing PPGTT have deferences a potentially null aliasing_ppgtt member. > Since the accessors are meant to be global, this will not do. > > Introduced originall

Re: [Intel-gfx] [PATCH 1/3] [VPG HSW-A] drm/i915: Add aspect ratio in drm_display_mode

2013-12-18 Thread Daniel Vetter
Re-adding dri-devel. On Wed, Dec 18, 2013 at 2:02 PM, Vandana Kannan wrote: >>> @@ -177,6 +180,8 @@ struct drm_display_mode { >>> >>> int vrefresh; /* in Hz */ >>> int hsync; /* in kHz */ >>> + >>> +enum hdmi_picture_aspect picture_aspect_ratio; >>> }; >> >>

Re: [Intel-gfx] [PATCH 1/3] [VPG HSW-A] drm/i915: Add aspect ratio in drm_display_mode

2013-12-18 Thread Vandana Kannan
On Aug-15-2013 12:36 PM, Ville Syrjälä wrote: > On Thu, Aug 15, 2013 at 10:29:01AM +0530, vandana.kan...@intel.com wrote: >> From: vkannan >> >> Mode is the video format, which is the information the sink needs to >> properly display an image. a complete definition of video format includes >> vide

Re: [Intel-gfx] [PATCH] drm/i915: grab a pages pin count for preallocate stolen

2013-12-18 Thread Chris Wilson
On Tue, Dec 17, 2013 at 11:42:11PM +0100, Daniel Vetter wrote: > But only when we indeed set up a gtt mapping. We need this since the > vma also holds a pages_pin_count, on top of the unconditional > pages_pin_count we grab for all stolen objects (to avoid swap-out). > > This should avoid a pages_

Re: [Intel-gfx] [PATCH] drm/i915: Add Baytrail PSR Support.

2013-12-18 Thread Chris Wilson
On Wed, Dec 18, 2013 at 08:27:32AM -0200, Rodrigo Vivi wrote: > On Wed, Dec 18, 2013 at 8:03 AM, Chris Wilson > wrote: > > On Tue, Dec 17, 2013 at 06:31:03PM -0200, Rodrigo Vivi wrote: > >> This patch adds PSR Support to Baytrail. > >> > >> Baytrail cannot easily detect screen updates and force P

Re: [Intel-gfx] [PATCH 05/10] drm/i915: retrieve current fb config into new plane_config structure at init v8

2013-12-18 Thread Jani Nikula
On Wed, 18 Dec 2013, Jesse Barnes wrote: > Read out the current plane configuration at init time into a new > plane_config structure. This allows us to track any existing > framebuffers attached to the plane and potentially re-use them in our > fbdev code for a smooth handoff. > > v2: update for

Re: [Intel-gfx] [PATCH] drm/i915: Add Baytrail PSR Support.

2013-12-18 Thread Rodrigo Vivi
On Wed, Dec 18, 2013 at 8:27 AM, Rodrigo Vivi wrote: > On Wed, Dec 18, 2013 at 8:03 AM, Chris Wilson > wrote: >> On Tue, Dec 17, 2013 at 06:31:03PM -0200, Rodrigo Vivi wrote: >>> This patch adds PSR Support to Baytrail. >>> >>> Baytrail cannot easily detect screen updates and force PSR exit. >>>

Re: [Intel-gfx] [PATCH] drm/i915: Add Baytrail PSR Support.

2013-12-18 Thread Rodrigo Vivi
On Wed, Dec 18, 2013 at 8:03 AM, Chris Wilson wrote: > On Tue, Dec 17, 2013 at 06:31:03PM -0200, Rodrigo Vivi wrote: >> This patch adds PSR Support to Baytrail. >> >> Baytrail cannot easily detect screen updates and force PSR exit. >> So we inactivate it on busy_ioctl and update to get it back >>

Re: [Intel-gfx] [PATCH 0/5] Enabling DRRS support in the kernel

2013-12-18 Thread Vandana Kannan
On Dec-18-2013 2:54 PM, Daniel Vetter wrote: > On Tue, Dec 17, 2013 at 10:58:22AM +0530, Vandana Kannan wrote: >> Dynamic Refresh Rate Switching (DRRS) is a power conservation feature which >> >> enables switching between low and high refresh rates based on the usage >> >> scenario.

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Adding VBT fields to support eDP DRRS feature

2013-12-18 Thread Vandana Kannan
On Dec-18-2013 2:41 PM, Chris Wilson wrote: > On Wed, Dec 18, 2013 at 01:38:44PM +0530, Vandana Kannan wrote: >> On Dec-17-2013 5:56 PM, Chris Wilson wrote: >>> On Tue, Dec 17, 2013 at 10:58:23AM +0530, Vandana Kannan wrote: From: Pradeep Bhat This patch reads the DRRS support and M

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Parse EDID probed modes for DRRS support

2013-12-18 Thread Vandana Kannan
On Dec-18-2013 2:36 PM, Chris Wilson wrote: > On Wed, Dec 18, 2013 at 01:41:21PM +0530, Vandana Kannan wrote: >> On Dec-17-2013 5:58 PM, Chris Wilson wrote: >>> On Tue, Dec 17, 2013 at 10:58:24AM +0530, Vandana Kannan wrote: From: Pradeep Bhat This patch and finds out the lowest ref

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Idleness detection for DRRS

2013-12-18 Thread Vandana Kannan
On Dec-18-2013 2:34 PM, Chris Wilson wrote: > On Wed, Dec 18, 2013 at 01:48:12PM +0530, Vandana Kannan wrote: >> On Dec-17-2013 5:59 PM, Chris Wilson wrote: >>> On Tue, Dec 17, 2013 at 10:58:26AM +0530, Vandana Kannan wrote: Adding support to detect display idleness by tracking page flip from

Re: [Intel-gfx] [PATCH 5/5] drm/i915/bdw: Add support for DRRS to switch RR

2013-12-18 Thread Vandana Kannan
On Dec-18-2013 2:31 PM, Chris Wilson wrote: > On Wed, Dec 18, 2013 at 01:54:56PM +0530, Vandana Kannan wrote: >> On Dec-17-2013 6:00 PM, Chris Wilson wrote: >>> On Tue, Dec 17, 2013 at 10:58:27AM +0530, Vandana Kannan wrote: For Broadwell, there is one instance of Transcoder MN values per >>>

Re: [Intel-gfx] [PATCH] drm/i915: Add Baytrail PSR Support.

2013-12-18 Thread Chris Wilson
On Tue, Dec 17, 2013 at 06:31:03PM -0200, Rodrigo Vivi wrote: > This patch adds PSR Support to Baytrail. > > Baytrail cannot easily detect screen updates and force PSR exit. > So we inactivate it on busy_ioctl and update to get it back > on next display mark_idle. That wasn't the plan, and certai

Re: [Intel-gfx] [PATCH 0/5] Enabling DRRS support in the kernel

2013-12-18 Thread Daniel Vetter
On Tue, Dec 17, 2013 at 10:58:22AM +0530, Vandana Kannan wrote: > Dynamic Refresh Rate Switching (DRRS) is a power conservation feature which > > enables switching between low and high refresh rates based on the usage > > scenario. This feature is applicable for internal eDP panel.

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Adding VBT fields to support eDP DRRS feature

2013-12-18 Thread Chris Wilson
On Wed, Dec 18, 2013 at 01:38:44PM +0530, Vandana Kannan wrote: > On Dec-17-2013 5:56 PM, Chris Wilson wrote: > > On Tue, Dec 17, 2013 at 10:58:23AM +0530, Vandana Kannan wrote: > >> From: Pradeep Bhat > >> > >> This patch reads the DRRS support and Mode type from VBT fields. > >> The read informa

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Parse EDID probed modes for DRRS support

2013-12-18 Thread Chris Wilson
On Wed, Dec 18, 2013 at 01:41:21PM +0530, Vandana Kannan wrote: > On Dec-17-2013 5:58 PM, Chris Wilson wrote: > > On Tue, Dec 17, 2013 at 10:58:24AM +0530, Vandana Kannan wrote: > >> From: Pradeep Bhat > >> > >> This patch and finds out the lowest refresh rate supported for the > >> resolution >

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Idleness detection for DRRS

2013-12-18 Thread Chris Wilson
On Wed, Dec 18, 2013 at 01:48:12PM +0530, Vandana Kannan wrote: > On Dec-17-2013 5:59 PM, Chris Wilson wrote: > > On Tue, Dec 17, 2013 at 10:58:26AM +0530, Vandana Kannan wrote: > >> Adding support to detect display idleness by tracking page flip from > >> user space. Switch to low refresh rate is

Re: [Intel-gfx] [PATCH 5/5] drm/i915/bdw: Add support for DRRS to switch RR

2013-12-18 Thread Chris Wilson
On Wed, Dec 18, 2013 at 01:54:56PM +0530, Vandana Kannan wrote: > On Dec-17-2013 6:00 PM, Chris Wilson wrote: > > On Tue, Dec 17, 2013 at 10:58:27AM +0530, Vandana Kannan wrote: > >> For Broadwell, there is one instance of Transcoder MN values per > >> transcoder. > >> For dynamic switching betwee

Re: [Intel-gfx] [PATCH 5/5] drm/i915/bdw: Add support for DRRS to switch RR

2013-12-18 Thread Vandana Kannan
On Dec-17-2013 6:00 PM, Chris Wilson wrote: > On Tue, Dec 17, 2013 at 10:58:27AM +0530, Vandana Kannan wrote: >> For Broadwell, there is one instance of Transcoder MN values per transcoder. >> For dynamic switching between multiple refreshr rates, M/N values may be >> reprogrammed on the fly. Link

[Intel-gfx] [PULL] drm-intel-fixes

2013-12-18 Thread Daniel Vetter
Hi Dave, Besides the 2 fixes for tricky corner cases in gem from Chris I've promised already two patche from Paulo to fix pc8 warnings (both ported from -next, bug report from Dave Jones) and one patch from to fix vga enable/disable on snb+. That one is a really old bug, but apparently it can caus

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Idleness detection for DRRS

2013-12-18 Thread Vandana Kannan
On Dec-17-2013 5:59 PM, Chris Wilson wrote: > On Tue, Dec 17, 2013 at 10:58:26AM +0530, Vandana Kannan wrote: >> Adding support to detect display idleness by tracking page flip from >> user space. Switch to low refresh rate is triggered after 2 seconds of >> idleness. The delay is configurable. If

Re: [Intel-gfx] [RFC Patch v1 11/13] ACPI, i915: replace open-coded _DSM specific code with helper functions

2013-12-18 Thread Daniel Vetter
On Wed, Dec 18, 2013 at 02:58:19PM +0800, Jiang Liu wrote: > Use helper functions to simplify _DSM related code in i915 driver. > > Function intel_dsm() is used to check functions supported by ACPI _DSM > method, but it has strange check for special value 0x8002. After > digging into nouveau d

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Parse EDID probed modes for DRRS support

2013-12-18 Thread Vandana Kannan
On Dec-17-2013 5:58 PM, Chris Wilson wrote: > On Tue, Dec 17, 2013 at 10:58:24AM +0530, Vandana Kannan wrote: >> From: Pradeep Bhat >> >> This patch and finds out the lowest refresh rate supported for the resolution >> same as the fixed_mode, based on the implementaion find_panel_downclock. >> It

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Adding VBT fields to support eDP DRRS feature

2013-12-18 Thread Vandana Kannan
On Dec-17-2013 5:56 PM, Chris Wilson wrote: > On Tue, Dec 17, 2013 at 10:58:23AM +0530, Vandana Kannan wrote: >> From: Pradeep Bhat >> >> This patch reads the DRRS support and Mode type from VBT fields. >> The read information will be stored in VBT struct during BIOS >> parsing. The above function

[Intel-gfx] [PATCH] drm/i915: s/hotplugt_status_gen4/hotplug_status_g4x/

2013-12-18 Thread Daniel Vetter
We specifically exclude original gen4 (i.e. i965g/gm), so update the naming for consistency. Spotted while reviewing related code due to a report from Jesse about byt needing again different values. v2: g4x, not gm45 since this also applies to the desktop version. Signed-off-by: Daniel Vetter --

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v7

2013-12-18 Thread Daniel Vetter
On Tue, Dec 17, 2013 at 11:51 PM, Chris Wilson wrote: > On Tue, Dec 17, 2013 at 10:58:51PM +0100, Daniel Vetter wrote: >> On Tue, Dec 17, 2013 at 10:30 PM, Jesse Barnes >> wrote: >> > So in the unlikely event that the fb helper code fails I don't want to >> > fall over. >> > >> > But that should

Re: [Intel-gfx] [PATCH] drm/i915: grab a pages pin count for preallocate stolen

2013-12-18 Thread Daniel Vetter
On Wed, Dec 18, 2013 at 1:00 AM, Ben Widawsky wrote: > I'm missing why _i915_gem_object_create_stolen() isn't good enough for > pinning the pages. Citing my commit message "... vma also holds a pages_pin_count". Which is on top of the general pages_pin_count we have for all stolen objects to avoi