[Intel-gfx] [PATCH 1/3] drm/i915: add bunit read/write routines

2013-10-28 Thread Jesse Barnes
For modifying self-refresh exit latency. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_sideband.c | 16 3 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH v4] drm/i915: rename i915_init_power_well to init_power_domains_init

2013-10-28 Thread Paulo Zanoni
2013/10/28 Imre Deak : > Similarly rename the other related functions in the power domain > interface. > > Higher level driver code calling these functions knows only about power > domains, not the underlying power wells which may be different on > different platforms. Also these functions really i

[Intel-gfx] [PATCH 3/3] drm/i915/vlv: update czclk freq if needed for high bandwidth modes

2013-10-28 Thread Jesse Barnes
Needed to support large panel resolutions. Tested-by: Josh Triplett Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_display.c | 64 2 files changed, 66 insertions(+) diff --git a/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 2/3] drm/i915: move VLV DDR freq fetch into init_clock_gating

2013-10-28 Thread Jesse Barnes
We don't want it delayed with the RPS work. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_pm.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index bf5261f..d355b

[Intel-gfx] [PATCH 2/3] drm/i915: move VLV DDR freq fetch into init_clock_gating

2013-10-28 Thread Jesse Barnes
We don't want it delayed with the RPS work. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_pm.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index bf5261f..d355b

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Remove WaFbcDisableDpfcClockGating on HSW

2013-10-28 Thread Ben Widawsky
On Mon, Oct 28, 2013 at 07:43:30PM +0200, Ville Syrjälä wrote: > On Mon, Oct 28, 2013 at 09:48:55AM -0700, Ben Widawsky wrote: > > On Mon, Oct 28, 2013 at 03:05:12PM +0200, Ville Syrjälä wrote: > > > On Mon, Oct 28, 2013 at 10:22:31AM -0200, Paulo Zanoni wrote: > > > > 2013/10/27 Daniel Vetter : >

Re: [Intel-gfx] [RFC 0/6] Haswell runtime PM support + D3

2013-10-28 Thread Jesse Barnes
On Mon, 28 Oct 2013 17:10:02 +0100 Daniel Vetter wrote: > On Mon, Oct 28, 2013 at 03:09:11PM +0200, Imre Deak wrote: > > Hi, > > > > On Tue, 2013-10-22 at 17:30 -0200, Paulo Zanoni wrote: > > > From: Paulo Zanoni > > > > > > Hi > > > > > > This RFC series adds runtime PM support on Haswell. T

Re: [Intel-gfx] [PATCH v3 3/4] drm/i915: remove device field from struct power_well

2013-10-28 Thread Imre Deak
On Mon, 2013-10-28 at 15:41 -0200, Paulo Zanoni wrote: > 2013/10/27 Daniel Vetter : > > On Fri, Oct 25, 2013 at 05:50:18PM -0200, Paulo Zanoni wrote: > >> 2013/10/25 Imre Deak : > >> > The only real need for this field was in > >> > i915_{request,release}_power_well, but there we can get at it by a

[Intel-gfx] [PATCH 3/3] drm/i915/vlv: update czclk freq if needed for high bandwidth modes

2013-10-28 Thread Jesse Barnes
Needed to support large panel resolutions. Tested-by: Josh Triplett Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_display.c | 64 2 files changed, 66 insertions(+) diff --git a/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 1/3] drm/i915: add bunit read/write routines

2013-10-28 Thread Jesse Barnes
For modifying self-refresh exit latency. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_sideband.c | 16 3 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/i915/

Re: [Intel-gfx] Tizen IVI EFI 3.0 graphics failure with FSP/OTM on Bayley Bay

2013-10-28 Thread Wang, Stephanie
That is what I am looking for. Kernel switching back to text mode triggered "drm_kms_helper" message. Thanks for the help. Stephanie -Original Message- From: Barnes, Jesse Sent: Monday, October 28, 2013 11:05 AM To: Wang, Stephanie Cc: Jani Nikula; intel-gfx@lists.freedesktop.org Subjec

Re: [Intel-gfx] Tizen IVI EFI 3.0 graphics failure with FSP/OTM on Bayley Bay

2013-10-28 Thread Jesse Barnes
The "drm_kms_helper" function is mentioned only because the kernel is switching back to the text console when the panic occurs. It's not actually the source of the panic. The graphics driver does have some code for booting without any BIOS support. But depending on the specific platform configur

Re: [Intel-gfx] Tizen IVI EFI 3.0 graphics failure with FSP/OTM on Bayley Bay

2013-10-28 Thread Wang, Stephanie
Jani and Jesse, There are two failures in the log file. One appears to be irq related, the other is related to "drm_kms_helper" which you can find under kernel source drivers\gpu\. That being said, the intention is not to point finger at the graphics driver. As I stated in the original email, th

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Remove WaFbcDisableDpfcClockGating on HSW

2013-10-28 Thread Ville Syrjälä
On Mon, Oct 28, 2013 at 09:48:55AM -0700, Ben Widawsky wrote: > On Mon, Oct 28, 2013 at 03:05:12PM +0200, Ville Syrjälä wrote: > > On Mon, Oct 28, 2013 at 10:22:31AM -0200, Paulo Zanoni wrote: > > > 2013/10/27 Daniel Vetter : > > > > On Fri, Oct 25, 2013 at 03:27:50PM -0200, Paulo Zanoni wrote: > >

Re: [Intel-gfx] [PATCH v3 3/4] drm/i915: remove device field from struct power_well

2013-10-28 Thread Paulo Zanoni
2013/10/27 Daniel Vetter : > On Fri, Oct 25, 2013 at 05:50:18PM -0200, Paulo Zanoni wrote: >> 2013/10/25 Imre Deak : >> > The only real need for this field was in >> > i915_{request,release}_power_well, but there we can get at it by a >> > container_of magic. Also since in the future we'll have mul

Re: [Intel-gfx] [PATCH 4/4] drm/i915: WaFbcDisableDpfcClockGating only with fbc

2013-10-28 Thread Ben Widawsky
On Fri, Oct 25, 2013 at 03:24:12PM -0200, Paulo Zanoni wrote: > 2013/10/24 Ben Widawsky : > > We were turning this on for SNB regardless of whether or not we use FBC. > > We can save the slightest amount of power if we don't disable it when > > not using FBC. > > > > The workaround should be bit 9

Re: [Intel-gfx] [PATCH] drm/i915: Clamp cursor coordinates to int16_t range

2013-10-28 Thread Daniel Vetter
On Mon, Oct 21, 2013 at 05:13:43PM +0100, Chris Wilson wrote: > On Mon, Oct 21, 2013 at 07:01:58PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > We store cursor_x/y as int16_t internally, but the user provided > > coordinates are int32_t. Clamp the coordinates so tha

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Do not enable package C8 on unsupported hardware

2013-10-28 Thread Chris Wilson
On Mon, Oct 28, 2013 at 02:55:02PM -0200, Paulo Zanoni wrote: > 2013/10/10 Chris Wilson : > > On Thu, Oct 10, 2013 at 05:17:31PM -0300, Paulo Zanoni wrote: > >> 2013/10/10 Chris Wilson : > >> > If the hardware does not support package C8, then do not even schedule > >> > work to enable it. Thereby

Re: [Intel-gfx] [PATCH 3/4] drm/i915: WaFbcDisableDpfcrClockGating only with fbc

2013-10-28 Thread Ben Widawsky
On Fri, Oct 25, 2013 at 03:14:50PM -0200, Paulo Zanoni wrote: > 2013/10/24 Ben Widawsky : > > We were turning this on for ILK regardless of whether or not we use FBC. > > We can save the slightest amount of power if we don't disable it when > > not using FBC. > > Finally someone did what I request

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Do not enable package C8 on unsupported hardware

2013-10-28 Thread Paulo Zanoni
2013/10/10 Chris Wilson : > On Thu, Oct 10, 2013 at 05:17:31PM -0300, Paulo Zanoni wrote: >> 2013/10/10 Chris Wilson : >> > If the hardware does not support package C8, then do not even schedule >> > work to enable it. Thereby we can eliminate a bunch of dangerous work. >> >> As I already explained

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Remove WaFbcDisableDpfcClockGating on HSW

2013-10-28 Thread Ben Widawsky
On Mon, Oct 28, 2013 at 03:05:12PM +0200, Ville Syrjälä wrote: > On Mon, Oct 28, 2013 at 10:22:31AM -0200, Paulo Zanoni wrote: > > 2013/10/27 Daniel Vetter : > > > On Fri, Oct 25, 2013 at 03:27:50PM -0200, Paulo Zanoni wrote: > > >> 2013/10/24 Ben Widawsky : > > >> > Production HSW does not need it

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Remove WaFbcDisableDpfcClockGating on HSW

2013-10-28 Thread Daniel Vetter
On Mon, Oct 28, 2013 at 10:22:31AM -0200, Paulo Zanoni wrote: > 2013/10/27 Daniel Vetter : > > On Fri, Oct 25, 2013 at 03:27:50PM -0200, Paulo Zanoni wrote: > >> 2013/10/24 Ben Widawsky : > >> > Production HSW does not need it. I confirmed this with Art. > >> > > >> > Signed-off-by: Ben Widawsky >

Re: [Intel-gfx] [RFC 0/6] Haswell runtime PM support + D3

2013-10-28 Thread Daniel Vetter
On Mon, Oct 28, 2013 at 03:09:11PM +0200, Imre Deak wrote: > Hi, > > On Tue, 2013-10-22 at 17:30 -0200, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > Hi > > > > This RFC series adds runtime PM support on Haswell. The current > > implementation > > puts the device in the PCI D3cold state w

Re: [Intel-gfx] [RFC i-g-t] tests: add runtime_pm

2013-10-28 Thread Daniel Vetter
On Mon, Oct 28, 2013 at 10:20:56AM -0200, Paulo Zanoni wrote: > 2013/10/27 Daniel Vetter : > > On Fri, Oct 25, 2013 at 11:44:05AM -0200, Paulo Zanoni wrote: > >> From: Paulo Zanoni > >> > >> This test is based on pc8.c. It copies most of the tests from pc8.c, > >> but it depends on runtime PM stat

Re: [Intel-gfx] Tizen IVI EFI 3.0 graphics failure with FSP/OTM on Bayley Bay

2013-10-28 Thread Jesse Barnes
On Mon, 28 Oct 2013 13:47:03 +0200 Jani Nikula wrote: > > FWIW there's nothing in the logs indicating it's a "graphics failure". > > BR, > Jani. > > > On Fri, 25 Oct 2013, "Wang, Stephanie" wrote: > > [4.354140] rtc_cmos 00:00: alarms up to one month, y3k, 242 bytes > > nvram, hpet irqs

Re: [Intel-gfx] Vblank timestamping improvements/fixes for Linux drm.

2013-10-28 Thread Alex Deucher
On Sat, Oct 26, 2013 at 4:27 AM, Mario Kleiner wrote: > Hi all, > > this patch set for the kernel pushes the latency sensitive bits of > vblank scanoutpos timestamping from the drm core into the kms drivers. > > A change in the locking of the intel-kms driver for Linux 3.11 made > the old approach

[Intel-gfx] [PATCH v4] drm/i915: rename i915_init_power_well to init_power_domains_init

2013-10-28 Thread Imre Deak
Similarly rename the other related functions in the power domain interface. Higher level driver code calling these functions knows only about power domains, not the underlying power wells which may be different on different platforms. Also these functions really init/cleanup/resume power domains a

Re: [Intel-gfx] [RFC 3/6] drm/i915: add enable_runtime_pm option

2013-10-28 Thread Imre Deak
On Tue, 2013-10-22 at 17:30 -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > And leave it off by default. We have way too many driver entry points, > we can't assume this will work without regressions without tons of > testing first. This option allows people to test and fix the problems. > >

Re: [Intel-gfx] [RFC 1/6] drm/i915: add initial Runtime PM functions

2013-10-28 Thread Imre Deak
On Tue, 2013-10-22 at 17:30 -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > This patch adds the initial infrastructure to allow a Runtime PM > implementation that sets the device to its D3 state. The patch just > adds the necessary callbacks and the initial infrastructure. > > We still don't

Re: [Intel-gfx] [RFC 0/6] Haswell runtime PM support + D3

2013-10-28 Thread Imre Deak
Hi, On Tue, 2013-10-22 at 17:30 -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > Hi > > This RFC series adds runtime PM support on Haswell. The current implementation > puts the device in the PCI D3cold state when we decide to sleep. It uses the > same refcount+timeout idea from the PC8 code

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Remove WaFbcDisableDpfcClockGating on HSW

2013-10-28 Thread Ville Syrjälä
On Mon, Oct 28, 2013 at 10:22:31AM -0200, Paulo Zanoni wrote: > 2013/10/27 Daniel Vetter : > > On Fri, Oct 25, 2013 at 03:27:50PM -0200, Paulo Zanoni wrote: > >> 2013/10/24 Ben Widawsky : > >> > Production HSW does not need it. I confirmed this with Art. > >> > > >> > Signed-off-by: Ben Widawsky >

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Remove WaFbcDisableDpfcClockGating on HSW

2013-10-28 Thread Paulo Zanoni
2013/10/27 Daniel Vetter : > On Fri, Oct 25, 2013 at 03:27:50PM -0200, Paulo Zanoni wrote: >> 2013/10/24 Ben Widawsky : >> > Production HSW does not need it. I confirmed this with Art. >> > >> > Signed-off-by: Ben Widawsky >> >> I just hope these things don't start uncovering bugs :) >> >> Reviewe

Re: [Intel-gfx] [Dell Inspiron 15R 5521] Can't toggle backlight brightness

2013-10-28 Thread Jani Nikula
On Fri, 25 Oct 2013, Nicolas Devillers wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Le lun. 14 oct. 2013 11:33:29 CEST, Jani Nikula a écrit : >> On Mon, 14 Oct 2013, Nicolas Devillers wrote: >>> Unfortunately this seems to cause others unpexected issue like ACPI >>> unstability an

Re: [Intel-gfx] Tizen IVI EFI 3.0 graphics failure with FSP/OTM on Bayley Bay

2013-10-28 Thread Jani Nikula
FWIW there's nothing in the logs indicating it's a "graphics failure". BR, Jani. On Fri, 25 Oct 2013, "Wang, Stephanie" wrote: > Jesse, hey > I work for ISG FSP/OTM boot loader team under Khadker Islam. I've recently > run into an issue that blocks FSP/OTM from supporting Tizen IVI 3.0 runnin

Re: [Intel-gfx] Vblank timestamping improvements/fixes for Linux drm.

2013-10-28 Thread Ville Syrjälä
On Sat, Oct 26, 2013 at 10:27:38AM +0200, Mario Kleiner wrote: > Hi all, > > this patch set for the kernel pushes the latency sensitive bits of > vblank scanoutpos timestamping from the drm core into the kms drivers. > > A change in the locking of the intel-kms driver for Linux 3.11 made > the ol

Re: [Intel-gfx] Using render nodes in i-g-t

2013-10-28 Thread Damien Lespiau
On Thu, Oct 24, 2013 at 03:40:51PM +0100, Damien Lespiau wrote: > Hi, > > This small series add the possibility for a test to ask for a render device. > This allows us to run render tests as a regular users. Pushed, there's a bit more work before we can run the right subset of tests on both rende

[Intel-gfx] [PATCH] drm/i915: handle faked missed interrupts as simulated hangs, too

2013-10-28 Thread Daniel Vetter
Otherwise QA will report this as a real hang when running igt ZZ_missed_irq. v2: Actually test the right stuff and really shut up the DRM_ERROR output ... Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70747 Tested-by: lu hua Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_i

Re: [Intel-gfx] [PATCH v5 0/4] Fix Win8 backlight issue

2013-10-28 Thread Jani Nikula
On Mon, 28 Oct 2013, Aaron Lu wrote: > On 10/25/2013 02:35 PM, Igor Gnatenko wrote: >> Aaron, add this notebook to list. I've CC'ed owner. >> And I've tested this patch on my TP X230 (add as Reported-and-Tested me >> please) >> +{ >> + .callback = video_set_use_native_backlight, >> + .

Re: [Intel-gfx] [PULL] drm-intel-fixes

2013-10-28 Thread Daniel Vetter
Hi Dave, Please do _not_ pull this. The pipe bpp readout stuff this crucially relies on is only partially backported from -next to -fixes and apparently missing bits on Haswell. Thanks, Daniel On Fri, Oct 25, 2013 at 12:50:12PM +0200, Daniel Vetter wrote: > Hi Dave, > > Just the edp bpp fix fro