Re: [Intel-gfx] intel_pre_enable_dp

2013-09-29 Thread Jesse Barnes
On Mon, 30 Sep 2013 01:53:47 +0200 Andi Kleen wrote: > On Mon, Sep 30, 2013 at 01:48:13AM +0200, Andi Kleen wrote: > > > > Jesse, > > > > I was playing with a static analyzer and it flagged the following > > code of yours. > > > > Is the val = 0 directly after the register read correct and int

[Intel-gfx] intel_pre_enable_dp

2013-09-29 Thread Andi Kleen
Jesse, I was playing with a static analyzer and it flagged the following code of yours. Is the val = 0 directly after the register read correct and intended? commit 89b667f86a62a99a7b484a7e1b3f8f7a108a7dee Author: Jesse Barnes Date: Thu Apr 18 14:51:36 2013 -0700 drm/i915: update VLV PL

Re: [Intel-gfx] intel_pre_enable_dp

2013-09-29 Thread Andi Kleen
On Mon, Sep 30, 2013 at 01:48:13AM +0200, Andi Kleen wrote: > > Jesse, > > I was playing with a static analyzer and it flagged the following > code of yours. > > Is the val = 0 directly after the register read correct and intended? Also the same pattern is in other places, like vlv_pre_enable_d

Re: [Intel-gfx] [PATCH] drm/i915: Only apply DPMS to the encoder if enabled

2013-09-29 Thread Daniel Vetter
On Sun, Sep 29, 2013 at 8:15 PM, Chris Wilson wrote: > The current test for an attached enabled encoder fails if we have > multiple connectors aliased to the same encoder - both connectors > believe they own the enabled encoder and so we attempt to both enable > and disable DPMS on the encoder, le

[Intel-gfx] [PATCH] drm/i915: Only apply DPMS to the encoder if enabled

2013-09-29 Thread Chris Wilson
The current test for an attached enabled encoder fails if we have multiple connectors aliased to the same encoder - both connectors believe they own the enabled encoder and so we attempt to both enable and disable DPMS on the encoder, leading to hilarity and an OOPs: [ 354.803064] WARNING: CPU: 0

Re: [Intel-gfx] Intel Haswell kernel warning (3.11.2)

2013-09-29 Thread Borislav Petkov
Let's CC some more people. On Sun, Sep 29, 2013 at 10:17:34AM -0400, Wakko Warner wrote: > Wakko Warner wrote: > > Please keep me in CC. > > > > I receive a warning in drivers/gpu/drm/i915/intel_display.c:3869. This > > happens when I'm on a console, the screen has gone into power save and I > >

Re: [Intel-gfx] Intel Haswell kernel warning (3.11.2)

2013-09-29 Thread Daniel Vetter
On Sun, Sep 29, 2013 at 04:58:39PM +0200, Borislav Petkov wrote: > Let's CC some more people. Please boot with drm.debug=0xe, reproduce the WARN and then attach the full dmesg. Thanks, Daniel > > On Sun, Sep 29, 2013 at 10:17:34AM -0400, Wakko Warner wrote: > > Wakko Warner wrote: > > > Please