[Intel-gfx] [PATCH] drm/i915: Fix __wait_seqno to use true infinite timeouts

2013-08-22 Thread Chris Wilson
Rather than continue to fix up the timeouts to work around the interface impedence in wait_event_*(), open code the combination of wait_event[_interruptible][_timeout]. And note the code size reduction, and dare say readability?, in doing so.. v2: In order to satisfy the debug requirement of loggi

[Intel-gfx] [PATCH] drm/i915: More vma fixups around unbind/destroy

2013-08-22 Thread Daniel Vetter
The important bugfix here is that we must not unlink the vma when we keep it around as a placeholder for the execbuf code. Since then we won't find it again when execbuf gets interrupt and restarted and create a 2nd vma. And since the code as-is isn't fit yet to deal with more than one vma, hilarit

Re: [Intel-gfx] How will Gfx driver support runtime PM on Haswell?

2013-08-22 Thread Jesse Barnes
On Wed, 21 Aug 2013 15:29:17 + "Lin, Mengdong" wrote: > Hi Ben, > > How will Gfx driver support runtime PM on Haswell? Will the Gfx driver > trigger "Adapter Power State" notification to BIOS when GPU switch state > between D0 and D3? > > We need to support RTD3 for HD-A legacy audio on H

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Enable Lower Slice on Haswell GT3.

2013-08-22 Thread Rodrigo Vivi
please ignore patch 1/2 This is a stand alone patch.. subsequent patches are related to slice shutdown to save power that I'm still working on... On Thu, Aug 22, 2013 at 5:32 PM, Rodrigo Vivi wrote: > Full HSW GT3 power can only be achieved with all Execution Units turned on. > This patch en

Re: [Intel-gfx] [PATCH] drm/i915: More vma fixups around unbind/destroy

2013-08-22 Thread Ben Widawsky
On Thu, Aug 22, 2013 at 09:41:07PM +0200, Daniel Vetter wrote: [snip] > > > > It's not clear from the commit message if this actually fixes the bug > > for you (which you seemed to be able to reproduce). Did it? > > Nope, just hard looking at the Oopses, haven't yet reproduced the bug > here. Bu

[Intel-gfx] [PATCH 1/2] drm/i915: Enable Lower Slice on Haswell GT3.

2013-08-22 Thread Rodrigo Vivi
Full HSW GT3 power can only be achieved with all Execution Units turned on. This patch enables all EUs present on HSW GT3 by enabling lower slice. Credits-by: Yejun Guo Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_gem.c | 5 + drivers/gpu

Re: [Intel-gfx] [PATCH] drm/i915: Fix context size calculation on SNB/IVB/VLV

2013-08-22 Thread Daniel Vetter
On Thu, Aug 22, 2013 at 12:05:31PM -0700, Ben Widawsky wrote: > On Thu, Aug 22, 2013 at 07:23:13PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > All the different context sizes reported in the CXT_SIZE register > > aren't meant to be simply added together. > > > > W

Re: [Intel-gfx] [PATCH] drm/i915: More vma fixups around unbind/destroy

2013-08-22 Thread Daniel Vetter
On Thu, Aug 22, 2013 at 6:19 PM, Ben Widawsky wrote: > On Thu, Aug 22, 2013 at 11:55:21AM +0200, Daniel Vetter wrote: >> The important bugfix here is that we must not unlink the vma when >> we keep it around as a placeholder for the execbuf code. Since then we >> won't find it again when execbuf g

Re: [Intel-gfx] [PATCH] drm/i915: Fix context size calculation on SNB/IVB/VLV

2013-08-22 Thread Ben Widawsky
On Thu, Aug 22, 2013 at 07:23:13PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > All the different context sizes reported in the CXT_SIZE register > aren't meant to be simply added together. > > While BSpec is somewhat unclear on the topic of the actual context > size, em

Re: [Intel-gfx] [PATCH] drm/i915: Fix context size calculation on SNB/IVB/VLV

2013-08-22 Thread Ben Widawsky
On Thu, Aug 22, 2013 at 09:52:53PM +0300, Ville Syrjälä wrote: > On Thu, Aug 22, 2013 at 11:30:55AM -0700, Ben Widawsky wrote: > > On Thu, Aug 22, 2013 at 07:23:13PM +0300, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > All the different context sizes reported in

Re: [Intel-gfx] [PATCH] drm/i915: Fix context size calculation on SNB/IVB/VLV

2013-08-22 Thread Ville Syrjälä
On Thu, Aug 22, 2013 at 11:30:55AM -0700, Ben Widawsky wrote: > On Thu, Aug 22, 2013 at 07:23:13PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > All the different context sizes reported in the CXT_SIZE register > > aren't meant to be simply added together. > > > > W

Re: [Intel-gfx] [PATCH] drm/i915: Fix context size calculation on SNB/IVB/VLV

2013-08-22 Thread Ville Syrjälä
On Thu, Aug 22, 2013 at 11:30:55AM -0700, Ben Widawsky wrote: > On Thu, Aug 22, 2013 at 07:23:13PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > All the different context sizes reported in the CXT_SIZE register > > aren't meant to be simply added together. > > > > W

Re: [Intel-gfx] [PATCH] drm/i915: Fix context size calculation on SNB/IVB/VLV

2013-08-22 Thread Ben Widawsky
On Thu, Aug 22, 2013 at 07:23:13PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > All the different context sizes reported in the CXT_SIZE register > aren't meant to be simply added together. > > While BSpec is somewhat unclear on the topic of the actual context > size, em

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update plane flip count registers

2013-08-22 Thread Ville Syrjälä
On Thu, Aug 22, 2013 at 11:12:13AM -0700, Ben Widawsky wrote: > On Thu, Aug 22, 2013 at 08:18:44PM +0300, Ville Syrjälä wrote: > > On Wed, Aug 21, 2013 at 08:15:52PM -0700, Ben Widawsky wrote: > > > Signed-off-by: Ben Widawsky > > > --- > > > drivers/gpu/drm/i915/i915_reg.h | 6 -- > > > 1 fi

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update plane flip count registers

2013-08-22 Thread Ben Widawsky
On Thu, Aug 22, 2013 at 08:18:44PM +0300, Ville Syrjälä wrote: > On Wed, Aug 21, 2013 at 08:15:52PM -0700, Ben Widawsky wrote: > > Signed-off-by: Ben Widawsky > > --- > > drivers/gpu/drm/i915/i915_reg.h | 6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/

[Intel-gfx] [PATCH] drm/i915: Don't mask EI UP interrupt on IVB|SNB

2013-08-22 Thread Mika Kuoppala
Submitting a batchbuffer which simulates a gpu hang by doing MI_BATCH_BUFFER_START into itself, to test hangcheck, started to hard hang the whole box (IVB). Bisecting lead to this commit: commit 664b422c2966cd39b8f67e8d53a566ea8c877cd6 Author: Vinit Azad Date: Wed Aug 14 13:34:33 2013 -0700

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update plane flip count registers

2013-08-22 Thread Ville Syrjälä
On Wed, Aug 21, 2013 at 08:15:52PM -0700, Ben Widawsky wrote: > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_reg.h | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 53d0e70..d1

[Intel-gfx] [PATCH] drm/i915: Fix context size calculation on SNB/IVB/VLV

2013-08-22 Thread ville . syrjala
From: Ville Syrjälä All the different context sizes reported in the CXT_SIZE register aren't meant to be simply added together. While BSpec is somewhat unclear on the topic of the actual context size, empirical tests have now revealed the truth. So let's add a big fat comment to remind people ho

[Intel-gfx] [PATCH] drm/i915: Print seqnos as unsigned in debugfs

2013-08-22 Thread ville . syrjala
From: Ville Syrjälä I don't like seeing signed seqnos. Make them unsigned. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 2

Re: [Intel-gfx] [PATCH] drm/i915: More vma fixups around unbind/destroy

2013-08-22 Thread Ben Widawsky
On Thu, Aug 22, 2013 at 11:55:21AM +0200, Daniel Vetter wrote: > The important bugfix here is that we must not unlink the vma when > we keep it around as a placeholder for the execbuf code. Since then we > won't find it again when execbuf gets interrupt and restarted and > create a 2nd vma. And sin

Re: [Intel-gfx] [PATCH 1/3] RFM drm/i915: Boost RPS frequency for CPU stalls

2013-08-22 Thread Jesse Barnes
Mengmeng and/or Ouping, can you collect full power & perf numbers of this patchset compared to the current mainline without these patches applied? Just running our existing set of benchmarks and tests would be a good start. Thanks, Jesse On Thu, 22 Aug 2013 03:40:56 +0100 Chris Wilson wrote: >

Re: [Intel-gfx] [PATCH] drm/i915: Use POSTING_READ in lcpll code

2013-08-22 Thread Daniel Vetter
On Wed, Aug 21, 2013 at 06:49:31PM -0300, Paulo Zanoni wrote: > 2013/8/21 Daniel Vetter : > > If we don't use the return value of a mmio read our coding style is to > > use the POSTING_READ macro. This avoids cluttering the mmio traces. > > > > While at it add the missing posting read in the lcpll

Re: [Intel-gfx] [PATCH 6/6] drm/i915: enable Package C8+ by default

2013-08-22 Thread Daniel Vetter
On Wed, Aug 21, 2013 at 12:43:54PM -0300, Rodrigo Vivi wrote: > Reviewed-by: Rodrigo Vivi > > On Mon, Aug 19, 2013 at 1:18 PM, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > This should be working, so enable it by default. Also easy to revert. > > > > v2: Rebase, s/allow/enable/. > > > > Si

Re: [Intel-gfx] linux-next: Tree for Aug 21 [ screen corruption in graphical mode ]

2013-08-22 Thread Daniel Vetter
On Thu, Aug 22, 2013 at 1:30 PM, Daniel Vetter wrote: > On Thu, Aug 22, 2013 at 1:13 PM, Sedat Dilek wrote: >> dmesg (a lot of traces) and kernel-config attached. >> >> UXA causes still screen corruption. > > Hm, was only a slim chance that this patch would fix anything - I > think you'd always s

Re: [Intel-gfx] linux-next: Tree for Aug 21 [ screen corruption in graphical mode ]

2013-08-22 Thread Daniel Vetter
On Thu, Aug 22, 2013 at 1:13 PM, Sedat Dilek wrote: > dmesg (a lot of traces) and kernel-config attached. > > UXA causes still screen corruption. Hm, was only a slim chance that this patch would fix anything - I think you'd always see an oops when you'd hit this bug instead of just a bit of corru

[Intel-gfx] [PATCH] drm/i915: More vma fixups around unbind/destroy

2013-08-22 Thread Daniel Vetter
The important bugfix here is that we must not unlink the vma when we keep it around as a placeholder for the execbuf code. Since then we won't find it again when execbuf gets interrupt and restarted and create a 2nd vma. And since the code as-is isn't fit yet to deal with more than one vma, hilarit

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Prevent loading of uninitialized context garbage

2013-08-22 Thread Ville Syrjälä
On Thu, Aug 22, 2013 at 12:18:10PM +0300, Abdiel Janulgue wrote: > On Wednesday, August 21, 2013 11:12:36 PM Daniel Vetter wrote: > > On Wed, Aug 21, 2013 at 06:31:07PM +0300, Ville Syrjälä wrote: > > > On Wed, Aug 21, 2013 at 04:43:33PM +0300, Ville Syrjälä wrote: > > > > On Thu, Aug 08, 2013 at 0

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Prevent loading of uninitialized context garbage

2013-08-22 Thread Abdiel Janulgue
On Wednesday, August 21, 2013 11:12:36 PM Daniel Vetter wrote: > On Wed, Aug 21, 2013 at 06:31:07PM +0300, Ville Syrjälä wrote: > > On Wed, Aug 21, 2013 at 04:43:33PM +0300, Ville Syrjälä wrote: > > > On Thu, Aug 08, 2013 at 08:00:26PM +0100, Chris Wilson wrote: > > > > The extended state bits are

Re: [Intel-gfx] linux-next: Tree for Aug 21 [ screen corruption in graphical mode ]

2013-08-22 Thread Daniel Vetter
On Thu, Aug 22, 2013 at 08:32:47AM +0200, Sedat Dilek wrote: > It's independent of the applied patch. > My problem goes away with SNA but still exists with UXA. > > As said in my previous analysis... switching back to Ubuntu's graphics > did not show the symptoms, too. > > It's interesting to see