Re: [Intel-gfx] [PATCH 4/4] [v4] drm/i915: Convert execbuf code to use vmas

2013-08-13 Thread Ben Widawsky
On Tue, Aug 13, 2013 at 06:09:09PM -0700, Ben Widawsky wrote: > From: Ben Widawsky > > In order to transition more of our code over to using a VMA instead of > an pair - we must have the vma accessible at execbuf time. Up > until now, we've only had a VMA when actually binding an object. > > Th

[Intel-gfx] [PATCH 4/4] [v4] drm/i915: Convert execbuf code to use vmas

2013-08-13 Thread Ben Widawsky
From: Ben Widawsky In order to transition more of our code over to using a VMA instead of an pair - we must have the vma accessible at execbuf time. Up until now, we've only had a VMA when actually binding an object. The previous patch helped handle the distinction on bound vs. unbound. This pa

[Intel-gfx] [PATCH 3/4] drm: WARN when removing unallocated node

2013-08-13 Thread Ben Widawsky
The conditional is usually a recoverable driver bug, and so WARNing, and preventing the drm_mm code from doing potential damage (BUG) is desirable. This issue was hit and fixed twice while developing the i915 multiple address space code. The first fix is the patch just before this, and is hit on a

[Intel-gfx] [PATCH 2/4] [v3] drm/i915: cleanup map&fence in bind

2013-08-13 Thread Ben Widawsky
Cleanup the map and fenceable setting during bind to make more sense, and not check i915_is_ggtt() 2 unnecessary times v2: Move the bools into the if block (Chris) - There are ways to tidy this function (fence calculations for instance) even further, but they are quite invasive, so I am punting on

[Intel-gfx] [PATCH 1/4] [v2] drm/i915: Remove node only when allocated

2013-08-13 Thread Ben Widawsky
VMAs can be created and not bound. One may think of it as lazy cleanup, and safely gloss over the conditions which manufacture it. In either case, when the object backing the i915 vma is destroyed, we must cleanup the vma without stumbling into a bunch of pitfalls that assume the vma is bound. NOT

[Intel-gfx] [PATCH] i915: Add a Kconfig option to turn on i915.preliminary_hw_support by default

2013-08-13 Thread Josh Triplett
When building kernels for a preliminary hardware target, having to add a kernel command-line option can prove inconvenient. Add a Kconfig option that changes the default of this option to 1. Signed-off-by: Josh Triplett --- I dropped the indication of the default in the module parameter documen

[Intel-gfx] [PATCH igt] intel_infoframes: Add support for decoding HDMI VICs

2013-08-13 Thread Damien Lespiau
The HDMI vendor infoframe can contain a HDMI VIC (as of HDMI 1.4, only used for 4k formats). Signed-off-by: Damien Lespiau --- tools/intel_infoframes.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/tools/intel_infoframes.c b/tools/intel_infoframe

[Intel-gfx] [PATCH 12/12] drm/i915/hdmi: Write HDMI vendor specific infoframes

2013-08-13 Thread Damien Lespiau
With all the common infoframe bits now in place, we can finally write the vendor specific infoframes in our driver. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_hdmi.c | 28 2 files changed, 30 insertions(+)

[Intel-gfx] [PATCH 10/12] video/hdmi: Hook the HDMI vendor infoframe with the generic _pack()

2013-08-13 Thread Damien Lespiau
With this last bit, hdmi_infoframe_pack() is now able to pack any infoframe we support. At the same time, because it's impractical to make two commits out of this, we get rid of the version that encourages the open coding of the vendor infoframe packing. We can do so because the only user of this

[Intel-gfx] [PATCH 11/12] drm: Add a helper to forge HDMI vendor infoframes

2013-08-13 Thread Damien Lespiau
This can then be used by DRM drivers to setup their vendor infoframes. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 36 include/drm/drm_edid.h | 4 2 files changed, 40 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/driver

[Intel-gfx] [PATCH 09/12] drm/edid: Move HDMI_IDENTIFIER to hdmi.h

2013-08-13 Thread Damien Lespiau
We'll need the HDMI OUI for the HDMI vendor infoframe data, so let's move the DRM one to hdmi.h, might as well use the hdmi header to store some hdmi defines. (Note that, in fact, infoframes are part of the CEA-861 standard, and only the HDMI vendor specific infoframe is special to HDMI, but detai

[Intel-gfx] [PATCH 08/12] gpu: host1x: Port the HDMI vendor infoframe code the common helpers

2013-08-13 Thread Damien Lespiau
I just wrote the bits to define and pack HDMI vendor specific infoframe. Port the host1x driver to use those so I can refactor the infoframe code a bit more. Cc: Thierry Reding Cc: Terje Bergström Cc: linux-te...@vger.kernel.org Signed-off-by: Damien Lespiau --- drivers/gpu/host1x/drm/hdmi.c

[Intel-gfx] [PATCH 07/12] video/hdmi: Introduce helpers for the HDMI vendor specific infoframe

2013-08-13 Thread Damien Lespiau
Provide the programming model than the other infoframe types. The generic _pack() function can't handle those yet as we need to move the vendor OUI in the generic hdmi_vendor_infoframe structure to know which kind of vendor infoframe we are dealing with. Signed-off-by: Damien Lespiau --- driver

[Intel-gfx] [PATCH 06/12] video/hdmi: Derive the bar data valid bit from the bar data fields

2013-08-13 Thread Damien Lespiau
Just like: Author: Damien Lespiau Date: Mon Aug 12 11:53:24 2013 +0100 video/hdmi: Don't let the user of this API create invalid infoframes But this time for the horizontal/vertical bar data present bits. Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 5 +++-- include/l

[Intel-gfx] [PATCH 05/12] video/hdmi: Don't let the user of this API create invalid infoframes

2013-08-13 Thread Damien Lespiau
To set the active aspect ratio value in the AVI infoframe today, you not only have to set the active_aspect field, but also the active_info_valid bit. Out of the 1 user of this API, we had 100% misuse, forgetting the _valid bit. This was fixed in: Author: Damien Lespiau Date: Tue Aug 6 20:3

[Intel-gfx] [PATCH 04/12] drm: Add support for alternate clocks of 4k modes

2013-08-13 Thread Damien Lespiau
Suggested-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 68 ++ 1 file changed, 62 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 0faa08e..606335f 100644 --- a

[Intel-gfx] [PATCH 03/12] drm/edid: Parse the HDMI CEA block and look for 4k modes

2013-08-13 Thread Damien Lespiau
HDMI 1.4 adds 4 "4k x 2k" modes in the the CEA vendor specific block. With this commit, we now parse this block and expose the 4k modes that we find there. v2: Fix the "4096x2160" string (nice catch!), add comments about do_hdmi_vsdb_modes() arguments and make it clearer that offset is re

[Intel-gfx] [PATCH 02/12] drm/edid: Fix add_cea_modes() style issues

2013-08-13 Thread Damien Lespiau
A few styles issues have crept in here, fix them before touching this code again. v2: constify arguments that can be (Ville Syrjälä) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/d

[Intel-gfx] [PATCH 01/12] drm: Don't export drm_find_cea_extension() any more

2013-08-13 Thread Damien Lespiau
This function is only used inside drm_edid.c. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 5 ++--- include/drm/drm_crtc.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index dfc7a1b..e014785 10

[Intel-gfx] HDMI 4k support v2

2013-08-13 Thread Damien Lespiau
Following up the first instance of this series: http://lists.freedesktop.org/archives/dri-devel/2013-August/043125.html Here is a v2 with Ville's review pass and a few additions: - Alternate clock modes for 4k resolutions - HDMI vendor specific infoframe support in drivers/video/hdmi.c - E

Re: [Intel-gfx] [PATCH 08/14] drm/i915: add basic MIPI DSI output support

2013-08-13 Thread Daniel Vetter
On Tue, Aug 13, 2013 at 04:29:47PM +0300, Jani Nikula wrote: > This does not include any panel specific sub-encoders yet. > > Signed-off-by: Jani Nikula > Signed-off-by: Shobhit Kumar Quick bikesheed on how you wire up the get_modes stuff, mostly because I'm just discussing this on irc with Rob

Re: [Intel-gfx] [PATCH i-g-t] tests: add pc8

2013-08-13 Thread Daniel Vetter
On Tue, Aug 06, 2013 at 05:43:23PM -0300, Paulo Zanoni wrote: > 2013/8/6 Daniel Vetter : > > On Tue, Aug 06, 2013 at 04:33:53PM -0300, Paulo Zanoni wrote: > >> 2013/8/5 Daniel Vetter : > >> > On Mon, Aug 05, 2013 at 10:42:08AM -0300, Paulo Zanoni wrote: > >> >> 2013/8/5 Daniel Vetter : > >> >> > On

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Initialize seqno for VECS too

2013-08-13 Thread Daniel Vetter
On Tue, Aug 13, 2013 at 01:55:36PM -0700, Ben Widawsky wrote: > On Mon, Aug 12, 2013 at 04:53:03PM -0700, Ben Widawsky wrote: > > Cc: Mika Kuoppala > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=65387 > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67198 > > Signed-off-by: B

Re: [Intel-gfx] [PATCH] drm/i915: Force a full modeset if the requested CRTC is disconnected

2013-08-13 Thread Chris Wilson
On Tue, Aug 13, 2013 at 10:32:19PM +0200, Daniel Vetter wrote: > On Tue, Aug 13, 2013 at 06:59:34PM +0100, Chris Wilson wrote: > > If the CRTC for this modeset is not attached to any encoder, it will be > > off. In this case, we will need to turn it on as well as update its > > base. This requires

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Initialize seqno for VECS too

2013-08-13 Thread Ben Widawsky
On Mon, Aug 12, 2013 at 04:53:03PM -0700, Ben Widawsky wrote: > Cc: Mika Kuoppala > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=65387 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67198 > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: tune the RC6 threshold for stability

2013-08-13 Thread Daniel Vetter
On Tue, Aug 13, 2013 at 11:55:17AM -0700, Stéphane Marchesin wrote: > It's basically the same deal as the RC6+ issues on ivy bridge > except this time with RC6 on sandy bridge. Like last time the > core of the issue is that the timings don't work 100% with our > voltage regulator. So from time to t

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
len); >>>> >> > return NULL; >>>> >> > >>>> >> > -- >>>> >> >>>> >> Now, 2/3 till 3/4 of my LightDM greeter screen is a black bar (seen >>>> >> from the top). >

Re: [Intel-gfx] [PATCH] drm/i915: Force a full modeset if the requested CRTC is disconnected

2013-08-13 Thread Chris Wilson
On Tue, Aug 13, 2013 at 10:32:19PM +0200, Daniel Vetter wrote: > On Tue, Aug 13, 2013 at 06:59:34PM +0100, Chris Wilson wrote: > > If the CRTC for this modeset is not attached to any encoder, it will be > > off. In this case, we will need to turn it on as well as update its > > base. This requires

Re: [Intel-gfx] [PATCH] drm/i915: Force a full modeset if the requested CRTC is disconnected

2013-08-13 Thread Daniel Vetter
On Tue, Aug 13, 2013 at 06:59:34PM +0100, Chris Wilson wrote: > If the CRTC for this modeset is not attached to any encoder, it will be > off. In this case, we will need to turn it on as well as update its > base. This requires a full modeset sequence. > > Bugzilla: https://bugs.freedesktop.org/sh

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Chris Wilson
with the known background. > >> So-to-say 3/4 "blind". > > > > That implies that the scanout is always reading from the base of stolen. > > Can you grab intel_reg_dumper so that I can check what values the > > transcoder is set to? > > > > At the m

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
can read "Ubuntu 12.04 LTS" with the known background. >> So-to-say 3/4 "blind". > > That implies that the scanout is always reading from the base of stolen. > Can you grab intel_reg_dumper so that I can check what values the > transcoder is set to? >

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Chris Wilson
On Tue, Aug 13, 2013 at 09:05:41PM +0200, Sedat Dilek wrote: > On Tue, Aug 13, 2013 at 8:53 PM, Chris Wilson > wrote: > > On Tue, Aug 13, 2013 at 08:40:37PM +0200, Sedat Dilek wrote: > >> On Tue, Aug 13, 2013 at 8:01 PM, Chris Wilson > >> wrote: > >> > On Tue, Aug 13, 2013 at 07:53:25PM +0200,

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
On Tue, Aug 13, 2013 at 8:53 PM, Chris Wilson wrote: > On Tue, Aug 13, 2013 at 08:40:37PM +0200, Sedat Dilek wrote: >> On Tue, Aug 13, 2013 at 8:01 PM, Chris Wilson >> wrote: >> > On Tue, Aug 13, 2013 at 07:53:25PM +0200, Sedat Dilek wrote: >> >> Files attached. >> > >> > Can you also please att

[Intel-gfx] [PATCH 2/2] drm/i915: tune the RC6 threshold for stability

2013-08-13 Thread Stéphane Marchesin
It's basically the same deal as the RC6+ issues on ivy bridge except this time with RC6 on sandy bridge. Like last time the core of the issue is that the timings don't work 100% with our voltage regulator. So from time to time, the kernel will print a warning message about the GPU not getting out o

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Chris Wilson
On Tue, Aug 13, 2013 at 08:40:37PM +0200, Sedat Dilek wrote: > On Tue, Aug 13, 2013 at 8:01 PM, Chris Wilson > wrote: > > On Tue, Aug 13, 2013 at 07:53:25PM +0200, Sedat Dilek wrote: > >> Files attached. > > > > Can you also please attach a full dmesg so I can check for anything > > unusual? > >

Re: [Intel-gfx] [PATCH] drm/i915: print a message when we detect an early Haswell SDV

2013-08-13 Thread Daniel Vetter
On Tue, Aug 13, 2013 at 02:41:15PM -0300, Rodrigo Vivi wrote: > Reviewed-by: Rodrigo Vivi > > On Mon, Aug 12, 2013 at 2:34 PM, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > The machines that fall in this category are the SDVs that have a PCI > > ID starting with 0x0C. These are very early

Re: [Intel-gfx] [PATCH] drm/i915: Print the changes required for modeset

2013-08-13 Thread Daniel Vetter
On Tue, Aug 13, 2013 at 03:00:59PM -0300, Paulo Zanoni wrote: > 2013/8/13 Chris Wilson : > > After computing the stage changes for the set_config, record those in > > the debug log. > > > > Signed-off-by: Chris Wilson > > I've already written different versions of this patch when debugging > thin

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
On Tue, Aug 13, 2013 at 7:13 PM, Chris Wilson wrote: > On Tue, Aug 13, 2013 at 07:03:44PM +0200, Sedat Dilek wrote: >> On Tue, Aug 13, 2013 at 6:37 PM, Sedat Dilek wrote: >> > On Tue, Aug 13, 2013 at 6:34 PM, Chris Wilson >> > wrote: >> >> On Tue, Aug 13, 2013 at 06:23:29PM +0200, Sedat Dilek w

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Chris Wilson
On Tue, Aug 13, 2013 at 07:53:25PM +0200, Sedat Dilek wrote: > Files attached. Can you also please attach a full dmesg so I can check for anything unusual? Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH] drm/i915: Print the changes required for modeset

2013-08-13 Thread Paulo Zanoni
2013/8/13 Chris Wilson : > After computing the stage changes for the set_config, record those in > the debug log. > > Signed-off-by: Chris Wilson I've already written different versions of this patch when debugging things in the past. Definitely useful. Reviewed-by: Paulo Zanoni > --- > drive

[Intel-gfx] [PATCH] drm/i915: Force a full modeset if the requested CRTC is disconnected

2013-08-13 Thread Chris Wilson
If the CRTC for this modeset is not attached to any encoder, it will be off. In this case, we will need to turn it on as well as update its base. This requires a full modeset sequence. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68030 Signed-off-by: Chris Wilson Cc: Rodrigo Vivi ---

[Intel-gfx] [PATCH] drm/i915: Print the changes required for modeset

2013-08-13 Thread Chris Wilson
After computing the stage changes for the set_config, record those in the debug log. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index a

Re: [Intel-gfx] [PATCH] drm/i915: print a message when we detect an early Haswell SDV

2013-08-13 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Mon, Aug 12, 2013 at 2:34 PM, Paulo Zanoni wrote: > From: Paulo Zanoni > > The machines that fall in this category are the SDVs that have a PCI > ID starting with 0x0C. These are very early pre-production machines > and may not fully work. Other Haswell SDVs have PC

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Chris Wilson
On Tue, Aug 13, 2013 at 07:03:44PM +0200, Sedat Dilek wrote: > On Tue, Aug 13, 2013 at 6:37 PM, Sedat Dilek wrote: > > On Tue, Aug 13, 2013 at 6:34 PM, Chris Wilson > > wrote: > >> On Tue, Aug 13, 2013 at 06:23:29PM +0200, Sedat Dilek wrote: > >>> On Tue, Aug 13, 2013 at 5:59 PM, Sedat Dilek >

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
On Tue, Aug 13, 2013 at 6:37 PM, Sedat Dilek wrote: > On Tue, Aug 13, 2013 at 6:34 PM, Chris Wilson > wrote: >> On Tue, Aug 13, 2013 at 06:23:29PM +0200, Sedat Dilek wrote: >>> On Tue, Aug 13, 2013 at 5:59 PM, Sedat Dilek wrote: >>> > I have bisected the issue on Linux v3.11-rc5 + drm-intel-nig

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
On Tue, Aug 13, 2013 at 6:34 PM, Chris Wilson wrote: > On Tue, Aug 13, 2013 at 06:23:29PM +0200, Sedat Dilek wrote: >> On Tue, Aug 13, 2013 at 5:59 PM, Sedat Dilek wrote: >> > I have bisected the issue on Linux v3.11-rc5 + drm-intel-nightly: >> > >> > 5456fe3882812aba251886e36fe55bfefb8e8829 is t

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Chris Wilson
On Tue, Aug 13, 2013 at 06:23:29PM +0200, Sedat Dilek wrote: > On Tue, Aug 13, 2013 at 5:59 PM, Sedat Dilek wrote: > > I have bisected the issue on Linux v3.11-rc5 + drm-intel-nightly: > > > > 5456fe3882812aba251886e36fe55bfefb8e8829 is the first bad commit > > commit 5456fe3882812aba251886e36fe55

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
gt;>> Did that make a difference? It shouldn't if the error is occuring before >>>>> X even starts... >>>> >>>> NO, was just confused not seeing "GT2" (HD-3000 was new to me) in my >>>> Xorg.log :-). >>>> >&g

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
Sedat - >>>>> >>>>> P.S.: I switched to intel-ddx v2-21-14-35-g5840bf in the meantime. >>>> >>>> Did that make a difference? It shouldn't if the error is occuring before >>>> X even starts... >>> >>> NO, was jus

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
make a difference? It shouldn't if the error is occuring before >>> X even starts... >> >> NO, was just confused not seeing "GT2" (HD-3000 was new to me) in my >> Xorg.log :-). >> >> As said logging out of Unity-2D and entering LightDM greeter

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
" (HD-3000 was new to me) in my > Xorg.log :-). > > As said logging out of Unity-2D and entering LightDM greeter - screen is fine. > Starting again a Unity-2D session - no screen corruption, too. > > - Sedat - Some more testing: [1] With my X stack: FIRST BAD: next-20130812 L

Re: [Intel-gfx] [PATCH] drm/i915: Fix __wait_seqno to use true infinite timeouts

2013-08-13 Thread Daniel Vetter
On Tue, Aug 13, 2013 at 02:39:55PM +0100, Chris Wilson wrote: > On Tue, Aug 13, 2013 at 10:36:04AM -0300, Rodrigo Vivi wrote: > > applied to experimental drm-intel-collector. > > > > drivers/gpu/drm/i915/i915_gem.c: In function ‘__wait_seqno’: > > drivers/gpu/drm/i915/i915_gem.c:1033:20: warning:

Re: [Intel-gfx] [PATCH] drm/i915: Fix __wait_seqno to use true infinite timeouts

2013-08-13 Thread Chris Wilson
On Tue, Aug 13, 2013 at 10:36:04AM -0300, Rodrigo Vivi wrote: > applied to experimental drm-intel-collector. > > drivers/gpu/drm/i915/i915_gem.c: In function ‘__wait_seqno’: > drivers/gpu/drm/i915/i915_gem.c:1033:20: warning: ‘timeout_jiffies’ may be > used > +uninitialized in this function Dumb

Re: [Intel-gfx] [PATCH] drm/i915: Fix __wait_seqno to use true infinite timeouts

2013-08-13 Thread Rodrigo Vivi
applied to experimental drm-intel-collector. drivers/gpu/drm/i915/i915_gem.c: In function ‘__wait_seqno’: drivers/gpu/drm/i915/i915_gem.c:1033:20: warning: ‘timeout_jiffies’ may be used +uninitialized in this function On Tue, Aug 6, 2013 at 10:03 PM, Chris Wilson wrote: > Rather than continue

[Intel-gfx] [PATCH 14/14] drm/i915: add AUO MIPI DSI display sub-encoder

2013-08-13 Thread Jani Nikula
From: Shobhit Kumar Signed-off-by: Shobhit Kumar Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm/i915/auo_dsi_display.c | 182 drivers/gpu/drm/i915/intel_dsi.c |5 + drivers/gpu/drm/i915/intel_dsi.h

[Intel-gfx] [PATCH 13/14] drm/i915: initialize DSI output on VLV

2013-08-13 Thread Jani Nikula
Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_display.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index e3ca335..7edb9c0 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/

[Intel-gfx] [PATCH 12/14] drm/i915: Parse the MIPI related VBT Block and store relevant info

2013-08-13 Thread Jani Nikula
From: Shobhit Kumar Initial parsing of the VBT MIPI block. For now, just store the panel id if found. Signed-off-by: Shobhit Kumar Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h |5 + drivers/gpu/drm/i915/intel_bios.c | 16 +++ drivers/gpu/drm/i915/inte

[Intel-gfx] [PATCH 11/14] drm/i915: Band Gap WA

2013-08-13 Thread Jani Nikula
From: Shobhit Kumar Signed-off-by: Shobhit Kumar Signed-off-by: ymohanma Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH 10/14] drm/i915: don't enable DPLL for DSI

2013-08-13 Thread Jani Nikula
DPLL is not needed for DSI Signed-off-by: Jani Nikula Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_display.c | 48 -- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH 09/14] drm/i915: add VLV DSI PLL Calculations

2013-08-13 Thread Jani Nikula
From: ymohanma Signed-off-by: ymohanma Signed-off-by: Shobhit Kumar Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile|1 + drivers/gpu/drm/i915/i915_reg.h | 10 ++ drivers/gpu/drm/i915/intel_display.c |2 + drivers/gpu/drm/i915/intel_dsi.c |5 + drive

[Intel-gfx] [PATCH 08/14] drm/i915: add basic MIPI DSI output support

2013-08-13 Thread Jani Nikula
This does not include any panel specific sub-encoders yet. Signed-off-by: Jani Nikula Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/Makefile|1 + drivers/gpu/drm/i915/intel_drv.h |1 + drivers/gpu/drm/i915/intel_dsi.c | 548 ++ 3 files ch

[Intel-gfx] [PATCH 07/14] drm/i915: add MIPI DSI command sending routines

2013-08-13 Thread Jani Nikula
Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile|1 + drivers/gpu/drm/i915/intel_dsi_cmd.c | 442 ++ drivers/gpu/drm/i915/intel_dsi_cmd.h | 109 + 3 files changed, 552 insertions(+) create mode 100644 drivers/gpu/drm/i915/intel_ds

[Intel-gfx] [PATCH 06/14] drm/i915: add structs for MIPI DSI output

2013-08-13 Thread Jani Nikula
The sub-encoder model is copied from DVO. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.h | 99 ++ 1 file changed, 99 insertions(+) create mode 100644 drivers/gpu/drm/i915/intel_dsi.h diff --git a/drivers/gpu/drm/i915/intel_dsi.h b/drivers/

[Intel-gfx] [PATCH 05/14] drm/i915: add MIPI DSI output type and subtypes

2013-08-13 Thread Jani Nikula
Signed-off-by: Jani Nikula Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_drv.h |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index 01455aa..a31abc6 100644 --- a/drivers/gpu/drm/i915/in

[Intel-gfx] [PATCH 03/14] drm/i915: add VLV pipeconf bit definition for DSI PLL lock

2013-08-13 Thread Jani Nikula
Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index a30e876..aced53a 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -297

[Intel-gfx] [PATCH 04/14] drm/i915: add MIPI DSI register definitions

2013-08-13 Thread Jani Nikula
Add definitions for VLV MIPI DSI registers. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 409 +++ 1 file changed, 409 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index aced53a..32e32b6 1006

[Intel-gfx] [PATCH 02/14] drm/i915: add more VLV IOSF sideband ports accessors

2013-08-13 Thread Jani Nikula
For GPIO NC, CCK, CCU, and GPS CORE. Signed-off-by: Jani Nikula Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/i915_drv.h |8 + drivers/gpu/drm/i915/i915_reg.h |4 +++ drivers/gpu/drm/i915/intel_sideband.c | 56 + 3 files changed,

[Intel-gfx] [PATCH 01/14] drm: add MIPI DSI encoder and connector types

2013-08-13 Thread Jani Nikula
From: Shobhit Kumar Signed-off-by: Shobhit Kumar Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_crtc.c |2 ++ include/uapi/drm/drm_mode.h |2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index fc83bb9..8768c5f 100644 ---

[Intel-gfx] [PATCH 00/14] drm/i915: Baytrail MIPI DSI support

2013-08-13 Thread Jani Nikula
Hi all - This series adds rudimentary MIPI DSI support to Baytrail. It's been built around the idea of panel specific sub-encoders, similar to the DVO support we have. This work is by no means complete; there are plenty of rough edges, but it should be a somewhat sane start to build upon. I'm awa

Re: [Intel-gfx] [PATCH] drm/i915: Drop the overzealous warning from i915_gem_set_cache_level

2013-08-13 Thread Ville Syrjälä
On Tue, Aug 13, 2013 at 01:20:13PM +0100, Chris Wilson wrote: > On Tue, Aug 13, 2013 at 03:12:59PM +0300, Ville Syrjälä wrote: > > Thinking about this stuff a bit, I think I actually came up with a > > scenario where we would currently fail to invalidate the CPU cache > > between non-snooped GPU/GT

Re: [Intel-gfx] [PATCH] drm/i915: Drop the overzealous warning from i915_gem_set_cache_level

2013-08-13 Thread Chris Wilson
On Tue, Aug 13, 2013 at 03:12:59PM +0300, Ville Syrjälä wrote: > Thinking about this stuff a bit, I think I actually came up with a > scenario where we would currently fail to invalidate the CPU cache > between non-snooped GPU/GTT access and CPU access: > > 1. make bo non-snooped w/ pin_display=tr

Re: [Intel-gfx] [PATCH] drm/i915: Drop the overzealous warning from i915_gem_set_cache_level

2013-08-13 Thread Ville Syrjälä
On Mon, Aug 12, 2013 at 11:46:17AM +0100, Chris Wilson wrote: > By our earlier reckoning, move from a snooped/llc setting to an uncached > setting, leaves the CPU cache in a consistent state irrespective of our > domain tracking - so we can forgo the warning about the lack of > invalidation. Simila

Re: [Intel-gfx] [PATCH] drm/i915: Drop the overzealous warning from i915_gem_set_cache_level

2013-08-13 Thread Daniel Vetter
On Tue, Aug 13, 2013 at 09:54:48AM +0200, Daniel Vetter wrote: > On Mon, Aug 12, 2013 at 11:46:17AM +0100, Chris Wilson wrote: > > By our earlier reckoning, move from a snooped/llc setting to an uncached > > setting, leaves the CPU cache in a consistent state irrespective of our > > domain tracking

Re: [Intel-gfx] [PATCH] drm/i915: Drop the overzealous warning from i915_gem_set_cache_level

2013-08-13 Thread Sedat Dilek
Hi, feel free to add... Reported -by: Sedat Dilek (against next-20130813 see [1]) Tested-by: Sedat Dilek Thanks. Regards, - Sedat - [1] http://lists.freedesktop.org/archives/intel-gfx/2013-August/031725.html ___ Intel-gfx mailing list Intel-gfx

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
On Tue, Aug 13, 2013 at 11:52 AM, Chris Wilson wrote: > On Tue, Aug 13, 2013 at 11:47:19AM +0200, Sedat Dilek wrote: >> On Tue, Aug 13, 2013 at 11:39 AM, Chris Wilson >> wrote: >> > On Tue, Aug 13, 2013 at 11:35:53AM +0200, Sedat Dilek wrote: >> >> After a logout from my "BROKEN" Unity-2D sessio

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Chris Wilson
On Tue, Aug 13, 2013 at 11:47:19AM +0200, Sedat Dilek wrote: > On Tue, Aug 13, 2013 at 11:39 AM, Chris Wilson > wrote: > > On Tue, Aug 13, 2013 at 11:35:53AM +0200, Sedat Dilek wrote: > >> After a logout from my "BROKEN" Unity-2D session - the login-screen > >> for LightDM seems to be OK. > >> Th

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
On Tue, Aug 13, 2013 at 11:39 AM, Chris Wilson wrote: > On Tue, Aug 13, 2013 at 11:35:53AM +0200, Sedat Dilek wrote: >> After a logout from my "BROKEN" Unity-2D session - the login-screen >> for LightDM seems to be OK. >> Then entering my Unity-2D desktop is OK - no screen corruptions. > > What ha

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Chris Wilson
On Tue, Aug 13, 2013 at 11:35:53AM +0200, Sedat Dilek wrote: > After a logout from my "BROKEN" Unity-2D session - the login-screen > for LightDM seems to be OK. > Then entering my Unity-2D desktop is OK - no screen corruptions. What hardware and display do you have? -Chris -- Chris Wilson, Intel

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
On Tue, Aug 13, 2013 at 11:25 AM, Chris Wilson wrote: > On Tue, Aug 13, 2013 at 11:10:18AM +0200, Sedat Dilek wrote: >> Hi, >> >> with today's next-20130813 I cannot see 1/10 of my desktop-screen's >> top, it's simply black. >> I can estimate the UR

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Chris Wilson
On Tue, Aug 13, 2013 at 11:10:18AM +0200, Sedat Dilek wrote: > Hi, > > with today's next-20130813 I cannot see 1/10 of my desktop-screen's > top, it's simply black. > I can estimate the URL line in Firefox (or open a new tab blindly and > get a known URL from my

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
; >>> The akpm tree gained a conflict against the staging tree. >>> >>> >>> >> >> Hi, >> >> with today's next-20130813 I cannot see 1/10 of my desktop-sc

Re: [Intel-gfx] linux-next: Tree for Aug 13 [ screen corruption in graphical mode ]

2013-08-13 Thread Sedat Dilek
ct against the staging tree. > > The akpm tree gained a conflict against the staging tree. > > ---- > Hi, with today's next-20130813 I cannot see 1/10 of my desktop-screen's top, it's simply black

Re: [Intel-gfx] [PATCH] drm/i915: Don't load context at driver init time on SNB

2013-08-13 Thread Ville Syrjälä
On Mon, Aug 12, 2013 at 10:33:37AM -0700, Stéphane Marchesin wrote: > On Fri, Aug 9, 2013 at 9:55 PM, Ben Widawsky wrote: > > On Fri, Aug 09, 2013 at 08:32:54PM -0700, Stéphane Marchesin wrote: > >> This is a partial revert of b4ae3f22d238617ca11610b29fde16cf8c0bc6e0 > >> (drm/i915: load boot cont

Re: [Intel-gfx] [PATCH] drm/i915: Drop the overzealous warning from i915_gem_set_cache_level

2013-08-13 Thread Daniel Vetter
On Mon, Aug 12, 2013 at 11:46:17AM +0100, Chris Wilson wrote: > By our earlier reckoning, move from a snooped/llc setting to an uncached > setting, leaves the CPU cache in a consistent state irrespective of our > domain tracking - so we can forgo the warning about the lack of > invalidation. Simila

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Initialize seqno for VECS too

2013-08-13 Thread Daniel Vetter
On Mon, Aug 12, 2013 at 04:53:03PM -0700, Ben Widawsky wrote: > Cc: Mika Kuoppala > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=65387 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67198 > Signed-off-by: Ben Widawsky Tested-by: lu hua (both bug reports) Please pimp the comm

Re: [Intel-gfx] [PATCH 2/5] [v2] drm/i915: cleanup map&fence in bind

2013-08-13 Thread Chris Wilson
On Mon, Aug 12, 2013 at 05:34:17PM -0700, Ben Widawsky wrote: > Cleanup the map and fenceable setting during bind to make more sense, > and not check i915_is_ggtt() 2 unnecessary times > > v2: Move the bools into the if block (Chris) - There are ways to tidy > this function (fence calculations for