Re: [Intel-gfx] [PATCH 13/20] drm/gem: create drm_gem_dumb_destroy

2013-07-22 Thread Laurent Pinchart
Hi Daniel, Thanks for the patch. On Tuesday 16 July 2013 09:12:04 Daniel Vetter wrote: > All the gem based kms drivers really want the same function to > destroy a dumb framebuffer backing storage object. > > So give it to them and roll it out in all drivers. > > This still leaves the option op

Re: [Intel-gfx] [PATCH] drm/i915: fix up error cleanup in i915_gem_object_bind_to_gtt

2013-07-22 Thread Daniel Vetter
On Mon, Jul 22, 2013 at 11:02:08PM +0200, Daniel Vetter wrote: > On Mon, Jul 22, 2013 at 01:12:30PM -0700, Ben Widawsky wrote: > > On Mon, Jul 22, 2013 at 12:12:38PM +0200, Daniel Vetter wrote: > > > This has been broken in > > > > > > commit 2f63315692b1d3c055972ad33fc7168ae908b97b > > > Author:

[Intel-gfx] ~2000ms pausing with GNOME3 desktop

2013-07-22 Thread Daniel J Blueman
I regularly experiencing a ~2000ms pause when clicking on 'Activities'/moving to the top-left corner in the GNOME3 desktop environment (eg once every 5 mins), both on IVB and SNB and kernels up to 3.10, seen on an 1920x1200 display on SNB and 2880x1440 display on IVB (Macbook Retina). This hurts t

Re: [Intel-gfx] [PATCH 5/5] drm/i915: add HAS_LP_PCH check

2013-07-22 Thread Paulo Zanoni
2013/7/22 Ben Widawsky : > On Fri, Jul 19, 2013 at 06:58:57PM -0300, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> We have 2 possible LPT PCHs: the normal version, which contains the >> pixel path (FDI, transcoders, VGA, etc), and the LP version, which >> comes with ULT machines and doesn't cont

Re: [Intel-gfx] drm/i915: correctly restore fences with objects attached

2013-07-22 Thread Daniel Vetter
Aside: When sending a mail to your maintainer please _always_ cc the relevant mailing list. On Tue, Jul 23, 2013 at 12:07 AM, member graysky wrote: > Hello Daniel. I believe you patch has introduced at minimum an ERROR > message to my dmesg. I applied to to 3.10.2 and whenever my screen > wakes

Re: [Intel-gfx] [PATCH] drm/i915: fix up error cleanup in i915_gem_object_bind_to_gtt

2013-07-22 Thread Daniel Vetter
On Mon, Jul 22, 2013 at 01:12:30PM -0700, Ben Widawsky wrote: > On Mon, Jul 22, 2013 at 12:12:38PM +0200, Daniel Vetter wrote: > > This has been broken in > > > > commit 2f63315692b1d3c055972ad33fc7168ae908b97b > > Author: Ben Widawsky > > Date: Wed Jul 17 12:19:03 2013 -0700 > > > > drm/i

Re: [Intel-gfx] i915 irq storm mitigation in 3.10

2013-07-22 Thread Egbert Eich
Jan Niggemann writes: > Egbert, Daniel, others, > It's a Lenovo ThinkPad T400, the model is 7434-AG2. > root@muretop:~# lspci -n > 00:00.0 0600: 8086:2a40 (rev 07) > 00:02.0 0300: 8086:2a42 (rev 07) Ok, this is a gm45. > > As to the log: I messed up the kernel parameters this morning... w

[Intel-gfx] External Monitor Cut Off with HDMI and a little blurry

2013-07-22 Thread brian downing
I have a intel hd graphics 3000 and Centos 6. This is a HP Pavilion dv7 laptop and a Samsung 2493HM monitor. When I use the hdmi port with an external monitor, the outer part of the screen is cut off. For example, I can't see the window control in the upper right. If I use VGA, then I can see e

Re: [Intel-gfx] [PATCH] drm/i915: fix up error cleanup in i915_gem_object_bind_to_gtt

2013-07-22 Thread Ben Widawsky
On Mon, Jul 22, 2013 at 12:12:38PM +0200, Daniel Vetter wrote: > This has been broken in > > commit 2f63315692b1d3c055972ad33fc7168ae908b97b > Author: Ben Widawsky > Date: Wed Jul 17 12:19:03 2013 -0700 > > drm/i915: Create VMAs > > which resulted in an OOPS the first time around we've hi

Re: [Intel-gfx] [PATCH 5/5] drm/i915: add HAS_LP_PCH check

2013-07-22 Thread Ben Widawsky
On Fri, Jul 19, 2013 at 06:58:57PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > We have 2 possible LPT PCHs: the normal version, which contains the > pixel path (FDI, transcoders, VGA, etc), and the LP version, which > comes with ULT machines and doesn't contain the pixel path. Both > mode

Re: [Intel-gfx] [PATCH] drm/i915: fix hdmi portclock limits

2013-07-22 Thread Damien Lespiau
On Mon, Jul 22, 2013 at 12:17:12PM +0100, Damien Lespiau wrote: > On Mon, Jul 22, 2013 at 08:05:10AM +0200, Daniel Vetter wrote: > > +static int hdmi_portclock_limit(struct intel_hdmi *hdmi) > > +{ > > + struct drm_device *dev = intel_hdmi_to_dev(hdmi); > > + > > + if (IS_G4X(dev)) > > +

Re: [Intel-gfx] [PATCH] drm/i915: fix hdmi portclock limits

2013-07-22 Thread Daniel Vetter
On Mon, Jul 22, 2013 at 05:24:34PM +0100, Damien Lespiau wrote: > On Mon, Jul 22, 2013 at 06:02:39PM +0200, Daniel Vetter wrote: > > In > > > > commit 325b9d048810f7689ec644595061c0b700e64bce > > Author: Daniel Vetter > > Date: Fri Apr 19 11:24:33 2013 +0200 > > > > drm/i915: fixup 12bpc h

Re: [Intel-gfx] [PATCH 00/12] Completion of i915 VMAs

2013-07-22 Thread Ben Widawsky
On Mon, Jul 22, 2013 at 11:42:40AM +0100, Chris Wilson wrote: > On Sun, Jul 21, 2013 at 07:08:07PM -0700, Ben Widawsky wrote: > > Map, and unmap are logical functionalities to add for an address space. > > They do more or less what you'd think: take an object and create a > > mapping via the GPU's

[Intel-gfx] [PATCH] drm/i915: fix hdmi portclock limits

2013-07-22 Thread Daniel Vetter
In commit 325b9d048810f7689ec644595061c0b700e64bce Author: Daniel Vetter Date: Fri Apr 19 11:24:33 2013 +0200 drm/i915: fixup 12bpc hdmi dotclock handling I've errornously claimed that we don't yet support the hdmi 1.4 dotclocks > 225 MHz on Haswell. But a bug report and a closer look at

Re: [Intel-gfx] i915 irq storm mitigation in 3.10

2013-07-22 Thread Jan Niggemann
Hi all, Am 21.07.2013 22:43, schrieb Daniel Vetter: Can you please boot with drm.debug=0xe added to your kernel cmdline, do a cold boot (so that we get a storm) and then once everything is quiet grab the full kernel log (you probably have to grab it from the disk, dmesg has likely overflown) and

Re: [Intel-gfx] [PATCH] drm/i915: fix hdmi portclock limits

2013-07-22 Thread Damien Lespiau
On Mon, Jul 22, 2013 at 06:02:39PM +0200, Daniel Vetter wrote: > In > > commit 325b9d048810f7689ec644595061c0b700e64bce > Author: Daniel Vetter > Date: Fri Apr 19 11:24:33 2013 +0200 > > drm/i915: fixup 12bpc hdmi dotclock handling > > I've errornously claimed that we don't yet support th

Re: [Intel-gfx] i915 irq storm mitigation in 3.10

2013-07-22 Thread Jan Niggemann
Hi list, I was busy, but this is important so I report my findings: Am 08.07.2013 22:03, schrieb Daniel Vetter: On Sat, Jul 06, 2013 at 11:41:07PM +0200, Jan Niggemann wrote: Hi list, I'm not sure, but I think the recent patch to keep i915 systems from locking up / slowing down in case of irq

Re: [Intel-gfx] [PATCH 09/12] drm/i915: create vmas at execbuf

2013-07-22 Thread Chris Wilson
On Sun, Jul 21, 2013 at 07:08:16PM -0700, Ben Widawsky wrote: > @@ -4054,7 +4051,7 @@ void i915_gem_free_object(struct drm_gem_object > *gem_obj) > struct i915_vma *i915_gem_vma_create(struct drm_i915_gem_object *obj, >struct i915_address_space *vm) > { > -

Re: [Intel-gfx] [PATCH] drm/i915: fix hdmi portclock limits

2013-07-22 Thread Damien Lespiau
On Mon, Jul 22, 2013 at 08:05:10AM +0200, Daniel Vetter wrote: > +static int hdmi_portclock_limit(struct intel_hdmi *hdmi) > +{ > + struct drm_device *dev = intel_hdmi_to_dev(hdmi); > + > + if (IS_G4X(dev)) > + return 165000; > + else if (IS_HASWELL(dev)) > + ret

Re: [Intel-gfx] [PATCH] drm/i915: fix hdmi portclock limits

2013-07-22 Thread Daniel Vetter
On Mon, Jul 22, 2013 at 08:05:10AM +0200, Daniel Vetter wrote: > In > > commit 325b9d048810f7689ec644595061c0b700e64bce > Author: Daniel Vetter > Date: Fri Apr 19 11:24:33 2013 +0200 > > drm/i915: fixup 12bpc hdmi dotclock handling > > I've errornously claimed that we don't yet support th

Re: [Intel-gfx] [PATCH 00/12] Completion of i915 VMAs

2013-07-22 Thread Chris Wilson
On Sun, Jul 21, 2013 at 07:08:07PM -0700, Ben Widawsky wrote: > Map, and unmap are logical functionalities to add for an address space. > They do more or less what you'd think: take an object and create a > mapping via the GPU's page tables to that object. Of course, without the > rest of the patch

Re: [Intel-gfx] [PATCH] drm/i915: fix up error cleanup in i915_gem_object_bind_to_gtt

2013-07-22 Thread Chris Wilson
On Mon, Jul 22, 2013 at 12:12:38PM +0200, Daniel Vetter wrote: > This has been broken in > > commit 2f63315692b1d3c055972ad33fc7168ae908b97b > Author: Ben Widawsky > Date: Wed Jul 17 12:19:03 2013 -0700 > > drm/i915: Create VMAs > > which resulted in an OOPS the first time around we've hi

[Intel-gfx] [PATCH] drm/i915: fix up error cleanup in i915_gem_object_bind_to_gtt

2013-07-22 Thread Daniel Vetter
This has been broken in commit 2f63315692b1d3c055972ad33fc7168ae908b97b Author: Ben Widawsky Date: Wed Jul 17 12:19:03 2013 -0700 drm/i915: Create VMAs which resulted in an OOPS the first time around we've hit -ENOSPC. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67156 Cc: Imre

Re: [Intel-gfx] [RFC PATCH 2/2] sna: Support running nested in Mir

2013-07-22 Thread Christopher James Halse Rogers
On Mon, 22 Jul, 2013 at 6:41 PM, Chris Wilson wrote: On Mon, Jul 22, 2013 at 04:44:40PM +1000, christopher.halse.rog...@canonical.com wrote: From: Christopher James Halse Rogers This is pretty much functional for both SNA and UXA, but can't reasonably be applied until the Xserver patch h

Re: [Intel-gfx] [RFC PATCH 2/2] sna: Support running nested in Mir

2013-07-22 Thread Chris Wilson
On Mon, Jul 22, 2013 at 04:44:40PM +1000, christopher.halse.rog...@canonical.com wrote: > From: Christopher James Halse Rogers > > This is pretty much functional for both SNA and UXA, but can't reasonably > be applied until the Xserver patch has landed, and that needs more work. > > This demons

Re: [Intel-gfx] [RFC PATCH 2/2] sna: Support running nested in Mir

2013-07-22 Thread Chris Wilson
On Mon, Jul 22, 2013 at 08:20:49AM +0010, Christopher James Halse Rogers wrote: > On Mon, 22 Jul, 2013 at 5:53 PM, Chris Wilson > wrote: > >With xorgMir this is not going to fly. Make sure the compatibility > >cruft, first of all, exists and is out of line in a header. > > > > Do you mean remove

Re: [Intel-gfx] [RFC PATCH 2/2] sna: Support running nested in Mir

2013-07-22 Thread Christopher James Halse Rogers
On Mon, 22 Jul, 2013 at 5:53 PM, Chris Wilson wrote: With xorgMir this is not going to fly. Make sure the compatibility cruft, first of all, exists and is out of line in a header. Do you mean remove the various #ifdef XMIR bits, or *all* the bits gated on xorgMir? Some of that's not going to

Re: [Intel-gfx] i915 irq storm mitigation in 3.10

2013-07-22 Thread Egbert Eich
Daniel Vetter writes: > On Sun, Jul 21, 2013 at 10:23 PM, Jan Niggemann wrote: > >> But every time this happens we only let through a few interrupts, so this > >> shouldn't affect you badly. Can you please check whether those slowdowns > >> line up with 2 minute intervalls? > > > > I observe

Re: [Intel-gfx] [RFC PATCH 2/2] sna: Support running nested in Mir

2013-07-22 Thread Chris Wilson
With xorgMir this is not going to fly. Make sure the compatibility cruft, first of all, exists and is out of line in a header. And expose the driving heartbeat of when to refresh the screen pixmap from Xmir. -Chris -- Chris Wilson, Intel Open Source Technology Centre _