The INTEL_INFO() macro extracts the dev_private pointer from the device,
so passing in the dev_private->dev is a long winded circumlocution.
v2: rebase onto uncore
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_uncore.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
From: Paulo Zanoni
Now it implements 3 different sequences from BSpec and also has
support for ULT.
v2: - Change IS_ULT checks for LPT-LP checks
- Add check for LPT-LP + with_fdi (Ben)
- Merge DBUFF0/GEN0 bit definitions since they're the same
register (Ben)
- DBUFF0 (1<<0) is
2013/7/18 Ben Widawsky :
> On Fri, Jul 12, 2013 at 02:19:42PM -0300, Paulo Zanoni wrote:
>> From: Paulo Zanoni
>>
>> Most of the hardware needs to be disabled before LCPLL is disabled, so
>> let's add a function to assert some of items listed in the "Display
>> Sequences for LCPLL disabling" docum
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=47941
BugLink: https://bugs.launchpad.net/bugs/1163720
BugLink: https://bugs.launchpad.net/bugs/1162026
Some machines suffer from non-functional backlight controls if
BLM_PCH_PWM_ENABLE is set, so provide a quirk to avoid doing so.
Apply this qu
From: Paulo Zanoni
We have 2 possible LPT PCHs: the normal version, which contains the
pixel path (FDI, transcoders, VGA, etc), and the LP version, which
comes with ULT machines and doesn't contain the pixel path. Both
models return true for HAS_PCH_LPT.
We already have a few places where we exp
On 07/19/2013 09:16 AM, Ben Widawsky wrote:
Make the uevent strings part of the user API for people who wish to
write their own listeners.
v2: Make a space in the string concatenation. (Chad)
Use the "UEVENT" suffix intead of "EVENT" (Chad)
Make kernel-doc parseable Docbook comments (Daniel)
v3
From: Paulo Zanoni
For now there are no callers, but these functions are going to be
needed for the code that allows Package C8+. Other future features may
also require this code.
Also merge the commit which introduced assert_can_disable_lcpll and
had the following commit message:
Most of the h
From: Paulo Zanoni
Requested by Chris Wilson on IRC.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 58ee826..f708e4e 100644
--- a/d
From: Paulo Zanoni
We currently don't support HDMI clock bending nor use SSC for DP or
HDMI on Haswell, so the only case where we need CLKOUT_DP is for VGA.
v2: - Replace the IS_ULT check for LPT-LP
- Simplify GEN0/DBUFF0 check due to change on the previous patch
- Also check for SBI_SSC
On Fri, Jul 19, 2013 at 07:05:29PM +0200, Daniel Vetter wrote:
> On Fri, Jul 19, 2013 at 05:49:48PM +0100, Damien Lespiau wrote:
> > Remembering to set an environment variable is too much trouble, we can
> > now specify --enable-simulation at configure time and always run the
> > test suite tuned f
The TRACE_EVENT_CONDITION is supposed to generate more efficient code
than if (cond) trace(), which is what we are currently using inside the
register access functions.
v2: Rebase onto uncore
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_debugfs.c | 2 +-
drivers/gpu/drm/i915/i915_t
The GT functions for enabling register access also need to occasionally
write to and read from registers. To avoid the potential recursion as we
modify the public interface to be stricter, introduce a private register
access API for the GT functions.
v2: Rebase
v3: Rebase onto uncore
v4: Use raw i
Detangle the confusion that NOTRACE variants of the register read/write
routines were directly using the raw register access. We need for those
routines to reuse the common code for serializing register access and
ensuring the correct register power states. This is only possible now
that the only r
In theory, the different register blocks were meant to be only ever
touched when holding either the struct_mutex, mode_config.lock or even a
specific localised lock. This does not seem to be the case, and the
hardware reacts extremely badly if we attempt to concurrently access two
registers within
2013/7/18 Ben Widawsky :
> On Fri, Jul 12, 2013 at 02:19:41PM -0300, Paulo Zanoni wrote:
>> From: Paulo Zanoni
>>
>> For now there are no callers, but these functions are going to be
>> needed for the code that allows Package C8+. Other future features may
>> also require this code.
>>
>
> The thi
2013/7/18 Ben Widawsky :
> On Thu, Jul 18, 2013 at 04:26:42PM -0700, Ben Widawsky wrote:
>> On Fri, Jul 12, 2013 at 02:19:41PM -0300, Paulo Zanoni wrote:
>> > From: Paulo Zanoni
>> >
>> > For now there are no callers, but these functions are going to be
>> > needed for the code that allows Package
Signed-off-by: Damien Lespiau
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 2eba12a..59d01cf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -61,7 +61,7 @@ XORG_MACROS_VERSION(1.16)
XORG_DEFAULT_OPTIONS
# warning flags f
Signed-off-by: Damien Lespiau
---
tests/drm_lib.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/drm_lib.sh b/tests/drm_lib.sh
index 2532352..25197d4 100755
--- a/tests/drm_lib.sh
+++ b/tests/drm_lib.sh
@@ -26,7 +26,8 @@ fi
# read everything we can
if [ `cat $i91
Remembering to set an environment variable is too much trouble, we can
now specify --enable-simulation at configure time and always run the
test suite tuned for simulation.
Signed-off-by: Damien Lespiau
---
configure.ac| 11 +++
lib/drmtest.c
This helps people compiling i-g-t figuring out what can be optional.
Signed-off-by: Damien Lespiau
---
configure.ac | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index caf929c..1626ce8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -192
One code path to maintain is always better.
Signed-off-by: Damien Lespiau
---
tests/sysfs_edid_timing | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/sysfs_edid_timing b/tests/sysfs_edid_timing
index 2a43cca..e90e374 100755
--- a/tests/sysfs_edid_timing
+++ b/tests/
So when the environment value isn't set, one can specify the default
value to return.
Signed-off-by: Damien Lespiau
---
lib/drmtest.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index 016619c..26748b3 100644
--- a/lib/drmtest.c
+++ b/li
warning: deprecated feature: target 'sr' overrides 'sr$(EXEEXT)'
Signed-off-by: Damien Lespiau
---
debugger/system_routine/Makefile.am | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/debugger/system_routine/Makefile.am
b/debugger/system_routine/Makefile.am
index 2576e2a.
Signed-off-by: Damien Lespiau
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 59d01cf..caf929c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -104,7 +104,7 @@ AM_CONDITIONAL(HAVE_NOUVEAU, [test "x$NOUVEAU" = xyes])
AC_ARG_EN
Jesse suggested an --enable-simulation configure option because having to
remember setting the env variable is too hard. After having experienced that
myself and gone through several painful stop/restart cycles of the simulation,
I decided it was worth making it happen.
--
Damien
___
On Fri, Jul 19, 2013 at 05:49:48PM +0100, Damien Lespiau wrote:
> Remembering to set an environment variable is too much trouble, we can
> now specify --enable-simulation at configure time and always run the
> test suite tuned for simulation.
>
> Signed-off-by: Damien Lespiau
tbh I'd vote for ru
On Fri, Jul 19, 2013 at 04:44:18PM +0300, Mika Kuoppala wrote:
> Paulo Zanoni writes:
>
> > From: Paulo Zanoni
> >
> > It was very similar to ironlake_irq_postinstall, so IMHO merging both
> > functions results in a code that is easier to maintain.
> >
> > With this change, all the irq handler v
On Fri, Jul 19, 2013 at 09:16:42AM -0700, Ben Widawsky wrote:
> Make the uevent strings part of the user API for people who wish to
> write their own listeners.
>
> v2: Make a space in the string concatenation. (Chad)
> Use the "UEVENT" suffix intead of "EVENT" (Chad)
> Make kernel-doc parseable D
On Fri, Jul 19, 2013 at 06:14:27PM +0200, Daniel Vetter wrote:
> On Fri, Jul 19, 2013 at 06:42:51PM +0800, Xiong Zhang wrote:
> > V2: add exit handler to enable prefault (Daniel)
> >
> > Signed-off-by: Xiong Zhang
>
> Thanks a lot for doing these patches, I've merged them both. Just to
> check:
On Fri, Jul 19, 2013 at 11:24:21AM -0300, Paulo Zanoni wrote:
> 2013/7/19 Mika Kuoppala :
> > Paulo Zanoni writes:
> >
> >> From: Paulo Zanoni
> >>
> >> It's the code that deals with de_iir.
> >>
> >> Signed-off-by: Paulo Zanoni
> >
> > Minor observation on the whole irq stuff: ilk, ironlake and
Make the uevent strings part of the user API for people who wish to
write their own listeners.
v2: Make a space in the string concatenation. (Chad)
Use the "UEVENT" suffix intead of "EVENT" (Chad)
Make kernel-doc parseable Docbook comments (Daniel)
v3: Undid reset change introduced in last submis
On Fri, Jul 19, 2013 at 06:42:51PM +0800, Xiong Zhang wrote:
> V2: add exit handler to enable prefault (Daniel)
>
> Signed-off-by: Xiong Zhang
Thanks a lot for doing these patches, I've merged them both. Just to
check: Are the subtests added now instead of your gem_prefault testcase
good enough
2013/7/18 Ben Widawsky :
> On Fri, Jul 12, 2013 at 02:19:39PM -0300, Paulo Zanoni wrote:
>> From: Paulo Zanoni
>>
>> Now it implements 3 different sequences from BSpec and also has
>> support for ULT.
>>
>> Signed-off-by: Paulo Zanoni
>> ---
>> drivers/gpu/drm/i915/i915_reg.h | 2 ++
>> dr
2013/7/19 Mika Kuoppala :
> Paulo Zanoni writes:
>
>> From: Paulo Zanoni
>>
>> It's the code that deals with de_iir.
>>
>> Signed-off-by: Paulo Zanoni
>
> Minor observation on the whole irq stuff: ilk, ironlake and ivb,
> ivybridge are both used and I couldn't figure out the pattern.
You mean t
Paulo Zanoni writes:
> From: Paulo Zanoni
>
> It was very similar to ironlake_irq_postinstall, so IMHO merging both
> functions results in a code that is easier to maintain.
>
> With this change, all the irq handler vfuncs between ironlake and
> ivybridge are now unified.
>
> v2: Add "(" and ")"
Paulo Zanoni writes:
> From: Paulo Zanoni
>
> The IVB funtions are exactly the same as the ILK ones, with the
> exception of the bit register. So add IVB/HSW support to
> ironlake_enable_vblank and ironlake_disable_vblank, then kill the
> ivybridge functions.
>
> Signed-off-by: Paulo Zanoni
Re
Paulo Zanoni writes:
> From: Paulo Zanoni
>
> And then rename it to ironlake_irq_handler. Also move
> ilk_gt_irq_handler up to avoid forward declarations.
>
> In the previous patches I did small modifications to both
> ironlake_irq_handler an ivybridge_irq_handler so they became very
> similar f
Paulo Zanoni writes:
> From: Paulo Zanoni
>
> We have this POSTING_READ inside ironlake_irq_handler. I suppose we
> also want it on IVB because we want to stop the IRQ handler as soon as
> possible at this point.
>
> Signed-off-by: Paulo Zanoni
Reviewed-by: Mika Kuoppala
> ---
> drivers/gpu
Paulo Zanoni writes:
> From: Paulo Zanoni
>
> The ironlake_irq_handler and ivybridge_irq_handler functions do
> basically the same thing, but they have different implementation
> styles. With this patch we reorganize ironlake_irq_handler in a way
> that makes it look very similar to ivybridge_ir
Paulo Zanoni writes:
> From: Paulo Zanoni
>
> The register doesn't exist on Gen 5.
>
> v2: Simplify checks since pm_iir is always 0 on Gen 5 (Chris)
>
> Signed-off-by: Paulo Zanoni
Reviewed-by: Mika Kuoppala
> ---
> drivers/gpu/drm/i915/i915_irq.c | 12 +++-
> 1 file changed, 7 inse
Paulo Zanoni writes:
> From: Paulo Zanoni
>
> Just like we did with ilk_display_irq_handler.
>
> Signed-off-by: Paulo Zanoni
Reviewed-by: Mika Kuoppala
> ---
> drivers/gpu/drm/i915/i915_irq.c | 63
> +++--
> 1 file changed, 35 insertions(+), 28 deletions
Paulo Zanoni writes:
> From: Paulo Zanoni
>
> It's the code that deals with de_iir.
>
> Signed-off-by: Paulo Zanoni
Minor observation on the whole irq stuff: ilk, ironlake and ivb,
ivybridge are both used and I couldn't figure out the pattern.
Reviewed-by: Mika Kuoppala
> ---
> drivers/gpu
Paulo Zanoni writes:
> From: Paulo Zanoni
>
> After Daniel's latest changes it's now equal to
> ironlake_irq_preinstall.
>
> Signed-off-by: Paulo Zanoni
> ---
> drivers/gpu/drm/i915/i915_irq.c | 21 +
> 1 file changed, 1 insertion(+), 20 deletions(-)
>
> diff --git a/driver
On Thu, Jul 18, 2013 at 05:50:55PM +0200, Daniel Vetter wrote:
> On Thu, Jul 18, 2013 at 04:19:05PM +0100, Damien Lespiau wrote:
> > It was high time to follow up on:
> > http://lists.freedesktop.org/archives/intel-gfx/2013-April/027361.html
> >
> > Changes from v2:
> > • Take into account Dan
V2: add exit handler to enable prefault (Daniel)
Signed-off-by: Xiong Zhang
---
lib/drmtest.c | 50 ++
lib/drmtest.h | 3 +++
2 files changed, 53 insertions(+)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index 011d8c1..980fa49 100644
--- a/lib/drm
the reloc, pread, pwrite slow path will be prevented by prefault,
these subtests will disable prefault first, then do reloc, pread,
pwrite, finally enable prefault.
Signed-off-by: Xiong Zhang
---
tests/gem_exec_faulting_reloc.c | 10 +-
tests/gem_mmap_gtt.c| 15 ++
On Fri, Jul 19, 2013 at 08:52:39AM +, Zhang, Xiong Y wrote:
> It just influence one page.
> During my test, I found one read slow path info when enable prefault. So I
> add this patch.
> Why don't move fault_in_multipages_writeable() from i915_gem_shmem_pread() to
> the beginning of i915_gem_
On Fri, Jul 19, 2013 at 08:52:39AM +, Zhang, Xiong Y wrote:
> It just influence one page.
> During my test, I found one read slow path info when enable prefault. So
> I add this patch. Why don't move fault_in_multipages_writeable() from
> i915_gem_shmem_pread() to the beginning of i915_gem_pre
It just influence one page.
During my test, I found one read slow path info when enable prefault. So I add
this patch.
Why don't move fault_in_multipages_writeable() from i915_gem_shmem_pread() to
the beginning of i915_gem_pread_ioctl() ?
So the pread_ioctl() is like pwrite_ioctl(). Is the cost
On Thu, Jul 18, 2013 at 10:42:48PM -0700, Ben Widawsky wrote:
> We've recently deferred error handling with a workqueue for a number of
> reasons. However, when we're trying to pass the information to
> userspace, it's likely more interesting to know when the error was
> detected by the kernel, and
On Fri, Jul 19, 2013 at 01:51:26PM +0800, Xiong Zhang wrote:
> fault_in_multipages_writeable() will load fault page into physical
> memory, then pread can run fast path, no need to run slow path
>
> Signed-off-by: Xiong Zhang
Hm, this avoids going through the slowpath for the first page. Does th
On Fri, Jul 19, 2013 at 01:51:25PM +0800, Xiong Zhang wrote:
> Signed-off-by: Xiong Zhang
I guess this was useful for debugging, but printks are rather expensive.
So I'll drop this - if we ever decide that this is useful information we
could expose it as a tracepoint, but since not even the core
On Fri, Jul 19, 2013 at 01:51:24PM +0800, Xiong Zhang wrote:
> prefault is stll enabled by default which prevent most of pwrite/pread/reloc
> from running slow path, in order to verify these slow pathes, prefault need
> to be disabled.
>
> Signed-off-by: Xiong Zhang
lgtm, queued for -next, thank
On Fri, Jul 19, 2013 at 01:53:10PM +0800, Xiong Zhang wrote:
> first disable prefault, then put relocate bo in gtt space and exec cmd,
> so it will run relocate_object_slow path, finally enable prefault
>
> Signed-off-by: Xiong Zhang
Hm, my idea was something much simpler like
diff --git a/tes
On Fri, Jul 19, 2013 at 01:53:08PM +0800, Xiong Zhang wrote:
> Signed-off-by: Xiong Zhang
> ---
> lib/drmtest.c | 43 +++
> lib/drmtest.h | 3 +++
> 2 files changed, 46 insertions(+)
>
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index 011d8c1..713c5ff
On Fri, Jul 19, 2013 at 08:46:27AM +0300, Dan Carpenter wrote:
> i915_gem_vma_destroy() frees its argument so we have to move the
> drm_mm_remove_node() call up a few lines.
>
> Signed-off-by: Dan Carpenter
Both applied, thanks for the patches.
-Daniel
>
> diff --git a/drivers/gpu/drm/i915/i91
On Thu, Jul 18, 2013 at 10:42:49PM -0700, Ben Widawsky wrote:
> Prior to this patch, we used ERROR=0 as a way of signifying the reset
> was complete. The functionality dates back quite a ways to:
>
> commit f316a42cc49eca73b33d85feb6177e32431747ff
> Author: Ben Gamari
> Date: Mon Sep 14 17:48:4
On Fri, Jul 12, 2013 at 02:19:38PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> The next step is to modify lpt_enable_clkout_dp to enable support for
> "Sequence to enable CLKOUT_DP" and "Sequence to enable CLKOUT_DP
> without spread".
>
> Signed-off-by: Paulo Zanoni
I've merged the fir
58 matches
Mail list logo
