Re: [Intel-gfx] [PATCH] drm/i915: fix pch_nop support

2013-05-30 Thread Ben Widawsky
On Wed, May 29, 2013 at 09:43:05PM +0200, Daniel Vetter wrote: > This was accidentally broken in the south error interrupt handling > work: > > commit 8664281b64c457705db72fc60143d03827e75ca9 > Author: Paulo Zanoni > Date: Fri Apr 12 17:57:57 2013 -0300 > > drm/i915: report Gen5+ CPU and P

[Intel-gfx] [PATCH 4/4 V7] i915/drm: Add private api for power well usage

2013-05-30 Thread Wang Xingchao
Haswell Display audio depends on power well in graphic side, it should request power well before use it and release power well after use. I915 will not shutdown power well if it detects audio is using. This patch protects display audio crash for Intel Haswell C3 stepping board. Signed-off-by: Wang

[Intel-gfx] [PATCH 3/4 V7] ALSA: hda - Add power-welll support for haswell HDA

2013-05-30 Thread Wang Xingchao
For Intel Haswell chip, HDA controller and codec have power well dependency from GPU side. This patch added support to request/release power well in audio driver. Power save feature should be enabled to get runtime power saving. There's deadlock when request_module(i915) in azx_probe. It looks lik

[Intel-gfx] [PATCH 2/4] ALSA: hda - Move azx_first_init() into azx_probe_continue()

2013-05-30 Thread Wang Xingchao
From: Takashi Iwai This is a preliminary work for the upcoming Haswell HDMI audio fixes. azx_first_init() function can be safely called after the f/w loader, since the f/w loader doesn't require the sound hardware initialization beforehand. Moving it into azx_probe_continue() cleans up the code

[Intel-gfx] [PATCH 1/4 V7] ALSA: hda - Fix runtime PM check

2013-05-30 Thread Wang Xingchao
The device can support runtime PM no matter whether it support signal wakeup or not. For some chips like Haswell which doesnot support PME by default, this patch let haswell Display HD-A controller enter runtime suspend, and bring more power saving whith power-well feature enabled. Signed-off-by:

[Intel-gfx] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-05-30 Thread Wang Xingchao
Hi all, This is V7 and here're some changes notes: change from V6-->V7: - rename variable - use HAS_POWER_WELL instead of IS_HASWELL - put structure inside drm_i915_private - use WARN_ON for global pointer check change from V5-->V6: - Remove duplication code in new introdu

[Intel-gfx] [PATCH] drm/i915: consolidate and tighten encoder cloning checks

2013-05-30 Thread Daniel Vetter
Only lvds/tv did actually check for cloning or not, but many more places should. Notices because my ivb tried to enable both cpu edp and vga on the first crtc - the resulting confusion between has_pch_encoder, has_dp_encoder but not actually being a pch dp encoder resulting in hilarity (hitting a

Re: [Intel-gfx] [PATCH 4/4 V6] i915/drm: Add private api for power well usage

2013-05-30 Thread Wang, Xingchao
Hi Damien, Thanks your review, comments inline. :) > -Original Message- > From: intel-gfx-bounces+xingchao.wang=intel@lists.freedesktop.org > [mailto:intel-gfx-bounces+xingchao.wang=intel@lists.freedesktop.org] On > Behalf Of Damien Lespiau > Sent: Thursday, May 30, 2013 2:11 AM