On 05/10/2013 03:28 PM, Ben Widawsky wrote:
The rest of the tool suite that uses python already uses python3.
The tool configure requires python >= 3 (which is confusing because of
the no backward compat problem).
The world is slowly moving to python3.
Converted with 2to3.
CC: Damien Lespiau
The rest of the tool suite that uses python already uses python3.
The tool configure requires python >= 3 (which is confusing because of
the no backward compat problem).
The world is slowly moving to python3.
Converted with 2to3.
CC: Damien Lespiau
CC: Kenneth Graunke
Signed-off-by: Ben Widaws
On Fri, May 10, 2013 at 9:21 AM, Daniel Vetter wrote:
> On Thu, May 09, 2013 at 01:28:12AM +0300, Ville Syrjälä wrote:
>> On Wed, May 08, 2013 at 02:01:02PM -0700, Jesse Barnes wrote:
>> > We can use this for fetching encoder specific pipe_config state, like
>> > mode flags, adjusted clock, etc.
>
Missed out when doing the rest of the outputs.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_ddi.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index cddcf4a..27a74a9 100644
--- a/d
We need to properly track PCH PLL sharing configs, and generally set up
PCH PLL state at init time as part of the state readout process.
v2: update to new code, use intel_crtc instead (Jesse)
I-told-you-so-by: Daniel Vetter
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c |
This needs better checking since the display could be off in this case.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
ind
On Fri, 10 May 2013 20:58:17 +0200
Daniel Vetter wrote:
> On Fri, May 10, 2013 at 09:10:27AM -0700, Jesse Barnes wrote:
> > On Fri, 10 May 2013 09:29:28 +0200
> > Daniel Vetter wrote:
> >
> > > On Wed, May 08, 2013 at 10:45:15AM -0700, Jesse Barnes wrote:
> > > > Works pretty well actually.
> >
We already fetch and track other state into the main CRTC and encoder
structs, and for fastboot we need to do the same with the mode and clock
data we read out.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c | 29 +
1 file changed, 29 insertion
Need better pfit tracking to do this right.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 53ad51c..591ac2d 100644
--- a/dr
We need this for comparing modes between configuration changes.
v2: try harder to calulate non-simple pixel clocks (Daniel)
call get_clock after getting the encoder config, needed for pixel multiply
(Jesse)
v3: drop get_clock now that the pixel_multiply has been moved into
get_pipe_con
On Fri, May 10, 2013 at 09:08:08AM -0700, Jesse Barnes wrote:
> On Thu, 9 May 2013 01:25:59 +0300
> Ville Syrjälä wrote:
>
> > On Wed, May 08, 2013 at 02:01:25PM -0700, Jesse Barnes wrote:
> > > Requested-by: Ville Syrjälä
> > > Signed-off-by: Jesse Barnes
> > > ---
> > > drivers/gpu/drm/drm_c
On Wed, May 08, 2013 at 01:54:17PM +0100, Damien Lespiau wrote:
> On Tue, May 07, 2013 at 03:40:21PM +0100, Damien Lespiau wrote:
> > On Tue, May 07, 2013 at 10:46:01AM -0300, Paulo Zanoni wrote:
> > > 2013/5/7 Damien Lespiau :
> > > > On Tue, May 07, 2013 at 02:10:05PM +0100, Damien Lespiau wrote:
On Fri, May 10, 2013 at 09:10:27AM -0700, Jesse Barnes wrote:
> On Fri, 10 May 2013 09:29:28 +0200
> Daniel Vetter wrote:
>
> > On Wed, May 08, 2013 at 10:45:15AM -0700, Jesse Barnes wrote:
> > > Works pretty well actually.
> > >
> > > Signed-off-by: Jesse Barnes
> >
> > Patches 1-3 merged to
On Fri, 10 May 2013 09:27:09 +0200
Daniel Vetter wrote:
> On Wed, May 08, 2013 at 10:45:16AM -0700, Jesse Barnes wrote:
> > This reverts commit fd0c06420d39958032655a04cfd194d5a7b38f83.
>
> A bit thin on details about what exactly blows up ... can you please dig a
> bit more?
Oh and this wasn't
On Fri, 10 May 2013 09:29:28 +0200
Daniel Vetter wrote:
> On Wed, May 08, 2013 at 10:45:15AM -0700, Jesse Barnes wrote:
> > Works pretty well actually.
> >
> > Signed-off-by: Jesse Barnes
>
> Patches 1-3 merged to dinq, thanks. I'm a bit unhappy that we don't have
> mipi yet, otoh mipi needs s
On Fri, 10 May 2013 09:27:09 +0200
Daniel Vetter wrote:
> On Wed, May 08, 2013 at 10:45:16AM -0700, Jesse Barnes wrote:
> > This reverts commit fd0c06420d39958032655a04cfd194d5a7b38f83.
>
> A bit thin on details about what exactly blows up ... can you please dig a
> bit more?
On unload, we cras
On Thu, 9 May 2013 01:25:59 +0300
Ville Syrjälä wrote:
> On Wed, May 08, 2013 at 02:01:25PM -0700, Jesse Barnes wrote:
> > Requested-by: Ville Syrjälä
> > Signed-off-by: Jesse Barnes
> > ---
> > drivers/gpu/drm/drm_crtc.c | 12
> > 1 file changed, 12 insertions(+)
> >
> > diff
On 05/08/2013 09:53 PM, Ben Widawsky wrote:
Bay Trail is the marketing name for the new Silvermont based SOCs we've
been calling Valleyview. All recent Intel disclosed documents use the
term "Bay Trail." AFAICT, only leaked docs (and our code) use the term
Valleyview. I've also verified with inte
On Wed, May 8, 2013 at 4:06 PM, Chris Wilson wrote:
> On Wed, May 08, 2013 at 04:02:00PM +0200, Daniel Vetter wrote:
>> On Wed, May 08, 2013 at 02:29:30PM +0100, Chris Wilson wrote:
>> > There is an unlikely corner case whereby a lockless wait may not notice
>> > a GPU hang and reset, and so conti
On Thu, May 09, 2013 at 10:44:48AM -0700, Matt Turner wrote:
> ---
> assembler/gram.y | 20
> assembler/lex.l | 1 +
> 2 files changed, 13 insertions(+), 8 deletions(-)
Looks good to me.
Reviewed-by: Damien Lespiau
--
Damien
>
> diff --git a/assembler/gram.y b/assembl
On Fri, May 10, 2013 at 02:33:17PM +0100, Damien Lespiau wrote:
> There was a race between Rodrigo writing those patches and me
> formalizing the addition of platform tags. This patches fixes it.
>
> Signed-off-by: Damien Lespiau
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/g
Daniel Vetter writes:
> Allows us to rip out a few fragile checks (which are duplicated in the
> hw state readout now, too). Also prepares us a bit for more than one
> panel/pfit.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Mika Kuoppala
___
Intel-
On Fri, May 10, 2013 at 02:42:03PM +0300, Jani Nikula wrote:
> On Tue, 30 Apr 2013, Daniel Vetter wrote:
> > Somehow this has been forgotten in
> >
> > commit 1974cad0ee4ce84e5cb792e49c4f0d9421e0312c
> > Author: Daniel Vetter
> > Date: Mon Nov 26 17:22:09 2012 +0100
> >
> > drm/i915: move i
Currently if we come across several sites that say that a specific
workaround is implemented for a platform, we just add the platform
several times to the list. eg.
WaFbcDisableDpfcClockGating: ivb, hsw, ivb, hsw
This patch prevent that by only adding the plaform if it's not already
there.
Signe
There was a race between Rodrigo writing those patches and me
formalizing the addition of platform tags. This patches fixes it.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_pm.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/
On Fri, May 10, 2013 at 02:01:51PM +0100, Damien Lespiau wrote:
> Up to now, we were using a static table to match the clock frequency
> with a (r2,n2,p) triplet. Despite this table being big, it's by no mean
> comprehensive and we had to fall back to the closest frequency when the
> requested TMDS
On Fri, May 10, 2013 at 3:07 PM, Mika Kuoppala
wrote:
> As discussed in irc, we might come across a case where panel fitter
> is not aligned to the same pipe in ilk+. Perhaps warn if we
> encounter such a weird setup?
Yeah, our current code doesn't support different pfit->pipe
associations. They'
On Thu, May 09, 2013 at 02:20:50PM -0300, Rodrigo Vivi wrote:
> Display register 46500h bit 23 must be set to 1b for the entire time that
> Frame Buffer Compression is enabled.
>
> v2: Ville suggested to enable it back when disabling fbc to avoid wasting
> power.
>
> v3: RMW to preserve other
Daniel Vetter writes:
> No more need to guard the write with a power well check on Haswell now
> that we have proper pfit state readout: We can simply only clear the
> pfit if it's actually on.
>
> This removes some duplication of knowledge between the haswell pfit
> disable and pfit state readou
Daniel Vetter writes:
> On Fri, May 10, 2013 at 02:37:59PM +0300, Mika Kuoppala wrote:
>>
>> Hi Daniel,
>>
>> Daniel Vetter writes:
>>
>> > Pfit state readout is a bit ugly on gen2/3 due to the intermingling
>> > with the lvds state, but alas.
>> >
>> > Also note that since state is always cl
Up to now, we were using a static table to match the clock frequency
with a (r2,n2,p) triplet. Despite this table being big, it's by no mean
comprehensive and we had to fall back to the closest frequency when the
requested TMDS clock wasn't in the table.
This patch computes (r2,n2,p) dynamically a
On Wed, May 08, 2013 at 09:37:14PM +0200, Daniel Vetter wrote:
> Oops, blows up on 32bit machines. I guess the igt will be useful once more
> to check that the 32bit version is solid, too. Dropped from dinq for now.
> -Daniel
Oops indeed.
Turns out the mistake was an easy one to spot. I used 1e6
On Thu, May 09, 2013 at 08:03:18PM -0300, Rodrigo Vivi wrote:
> drm_i915_private is getting bigger and bigger when adding new vbt stuff.
> So, the better way of getting drm_i915_private organized is to create
> a special structure for vbt stuff.
>
> v2: Basically conflicts fixes
>
> Reviewed-by:
Suggested-by: Chris Wilson
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/drm_crtc_helper.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c
b/drivers/gpu/drm/drm_crtc_helper.c
index 9085db6..ed1334e 100644
--- a/drive
drm_helper_probe_single_connector_modes() is responsible for pruning the
previously detected modes on a disconnected connector. We don't really
need to log, again, the full list of modes that used to be valid when
connected.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/drm_crtc_helper.c | 4
Instead of just printing "status updated from 1 to 2", make those enum
numbers immediately readable.
v2: Also patch output_poll_execute() (Daniel Vetter)
v3: Use drm_get_connector_status_name (Ville Syrjälä)
Signed-off-by: Damien Lespiau
Reviewed-by: Jesse Barnes (for v1)
---
drivers/gpu/drm/d
As we parse the string given on the command line one char at a time, it
seems that we do want a break at every case.
Signed-off-by: Damien Lespiau
Reviewed-by: Rodrigo Vivi
---
drivers/gpu/drm/drm_modes.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/
Updated series with:
- Reviews applied,
- Drop a patch that would conflict with Ville's latest changes,
- Drop Chris (Cummins)'s patch as he rebased it on top of drm-next and sent it
back himself,
- Add a suggestion from Chris (Wilson) to not repeat the message in the poll
handler. I did not d
Use msecs_to_jiffies_min instead of open-coding the same.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/intel_dp.c |2 +-
drivers/gpu/drm/i915/intel_drv.h |2 +-
drivers/gpu/drm/i915/intel_i2c.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/dr
On Fri, May 10, 2013 at 02:37:59PM +0300, Mika Kuoppala wrote:
>
> Hi Daniel,
>
> Daniel Vetter writes:
>
> > Pfit state readout is a bit ugly on gen2/3 due to the intermingling
> > with the lvds state, but alas.
> >
> > Also note that since state is always cleared to zero we can
> > unconditon
On Tue, 30 Apr 2013, Daniel Vetter wrote:
> We need to track this correctly. While at it shovel the boolean
> to track whether the sdvo is in tv mode or not into pipe_config.
Reviewed-by: Jani Nikula
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=36997
> Tested-by: Pierre Assal
> Bug
On Tue, 30 Apr 2013, Daniel Vetter wrote:
> Somehow this has been forgotten in
>
> commit 1974cad0ee4ce84e5cb792e49c4f0d9421e0312c
> Author: Daniel Vetter
> Date: Mon Nov 26 17:22:09 2012 +0100
>
> drm/i915: move is_dual_link_lvds to intel_lvds.c
>
Reviewed-by: Jani Nikula
> Signed-off-b
On Tue, 30 Apr 2013, Daniel Vetter wrote:
> More ugly stuff gone for good! The big special case left now is
> lvds (which is indeed really special).
Reviewed-by: Jani Nikula
A follow-up patch could switch the switches to ifs for the OCD folks. ;)
> Signed-off-by: Daniel Vetter
> ---
> driver
Hi Daniel,
Daniel Vetter writes:
> Pfit state readout is a bit ugly on gen2/3 due to the intermingling
> with the lvds state, but alas.
>
> Also note that since state is always cleared to zero we can
> unconditonally compare all the state and completely neglect the actual
> platform we're runni
On Tue, 30 Apr 2013, Daniel Vetter wrote:
> This seems to be an impressive piece of copy&pasta lore. I've
> checked all docs and on most platforms these bits are all MBZ, with
> the exception of the SDVO pixel multiplier on gen3. On gen4 that
> moved to a special DPLL_MD registers.
>
> No indicati
On Fri, May 10, 2013 at 1:26 PM, Fabio Coatti wrote:
> Hi Daniel,
> I'm contacting you as you are listed as i915 maintainer for linux
> kernel and I'm not sure if it is ok to write in mailing lists for this
> small issue.
_Always_ cc a mailing list, since your maintainer tends to be busy.
_Especi
On Tue, 30 Apr 2013, Daniel Vetter wrote:
> TV-out uses the same reference clock as everyone else. The only
> difference seems to be in the slightly different CB tuning limit.
>
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/i915/intel_display.c | 11 +--
> 1 file changed, 1 inse
On Tue, 30 Apr 2013, Daniel Vetter wrote:
> We have a very nice infrastructure for this now!
>
> Note that the multifunction sdvo support is pretty neatly broken: We
> completely ignore userspace's request for which connector to wire up
> with the encoder and just use whatever the last detect call
On Fri, 2013-05-10 at 10:49 +0200, Daniel Vetter wrote:
> On Wed, May 08, 2013 at 01:14:06PM +0300, Imre Deak wrote:
> > is_pch_edp() will be removed by the next patch, so replace it by a check
> > for the port and device type.
> >
> > Signed-off-by: Imre Deak
> > ---
> > drivers/gpu/drm/i915/in
On Wed, May 08, 2013 at 01:14:06PM +0300, Imre Deak wrote:
> is_pch_edp() will be removed by the next patch, so replace it by a check
> for the port and device type.
>
> Signed-off-by: Imre Deak
> ---
> drivers/gpu/drm/i915/intel_dp.c | 17 +++--
> 1 file changed, 11 insertions(+),
This allows us to drop a bunch of ugly hacks and finally implement
what
commit cc464b2a17c59adedbdc02cc54341d630354edc3
Author: Paulo Zanoni
Date: Fri Jan 25 16:59:16 2013 -0200
drm/i915: set TRANSCODER_EDP even earlier
tried to achieve, but that was reverted again in
commit bba2181c49f1
Summary
We finished a new round of kernel testing. Generally, in this circle, 4 new
bugs are filed, 20 bugs are still opened,4 Duplicated bugs, 7 bugs are closed.
Test Environment
Kernel: f59736c314fc8835b5294cb955f3f16a75cd72d2
Merge: 2b87f3b a9b054e
Author: Daniel Vetter
Date: Fri May
On Wed, May 08, 2013 at 10:45:15AM -0700, Jesse Barnes wrote:
> Works pretty well actually.
>
> Signed-off-by: Jesse Barnes
Patches 1-3 merged to dinq, thanks. I'm a bit unhappy that we don't have
mipi yet, otoh mipi needs sink drivers so meh.
-Daniel
--
Daniel Vetter
Software Engineer, Intel C
On Wed, May 08, 2013 at 10:45:16AM -0700, Jesse Barnes wrote:
> This reverts commit fd0c06420d39958032655a04cfd194d5a7b38f83.
A bit thin on details about what exactly blows up ... can you please dig a
bit more?
-Daniel
> ---
> drivers/gpu/drm/i915/intel_display.c | 19 +++
> dr
On Thu, May 09, 2013 at 01:28:12AM +0300, Ville Syrjälä wrote:
> On Wed, May 08, 2013 at 02:01:02PM -0700, Jesse Barnes wrote:
> > We can use this for fetching encoder specific pipe_config state, like
> > mode flags, adjusted clock, etc.
> >
> > Just used for mode flags atm, so we can check the pi
On Thu, May 09, 2013 at 12:09:30PM -0700, Jesse Barnes wrote:
> On Mon, 6 May 2013 16:45:52 +0300
> ville.syrj...@linux.intel.com wrote:
>
> > From: Ville Syrjälä
> >
> > Rewrite the ILK+ watermark code to allow:
> > - updating the watermarks safely (to avoid underruns)
> > - pre-computing wate
On Thu, May 09, 2013 at 05:51:13PM -0300, Paulo Zanoni wrote:
> 2013/4/24 :
> > From: Ville Syrjälä
> >
> > If the calculated FBC watermark is no good, we simply disable FBC
> > watermarks. But we fail to re-enable them later if the calculated
> > watermark becomes good again. Fix that, but remem
57 matches
Mail list logo
