Re: [Intel-gfx] [PATCH v3 05/16] drm/i915: track ring progression using seqnos

2013-04-20 Thread Ben Widawsky
On Thu, Apr 04, 2013 at 06:32:37PM +0300, Mika Kuoppala wrote: > Instead of relying in acthd, track ring seqno progression > to detect if ring has hung. > > v2: put hangcheck stuff inside struct (Chris Wilson) > > Signed-off-by: Mika Kuoppala This patch really scares me. I think we don't want t

Re: [Intel-gfx] [PATCH v3 02/16] drm/i915: cleanup i915_add_request

2013-04-20 Thread Ben Widawsky
On Thu, Apr 04, 2013 at 06:32:34PM +0300, Mika Kuoppala wrote: > Only execbuffer needs all the parameters. Cleanup everything > else behind macro. > > v2: _i915_add_request as function name (Chris Wilson) > Wouldn't the convention be __i915_add_request? > Signed-off-by: Mika Kuoppala In terms

Re: [Intel-gfx] [PATCH] drm/i915: reference count for i915_hw_contexts

2013-04-20 Thread Ben Widawsky
On Tue, Apr 09, 2013 at 05:12:22PM -0700, Ben Widawsky wrote: > From: Mika Kuoppala > > In preparation to do analysis of which context was > guilty of gpu hung, store kreffed context pointer > into request struct. > > This allows us to inspect contexts when gpu is reset > even if those contexts

Re: [Intel-gfx] [PATCH v3 01/16] drm/i915: return context from i915_switch_context()

2013-04-20 Thread Ben Widawsky
On Thu, Apr 04, 2013 at 06:32:33PM +0300, Mika Kuoppala wrote: > In preparation for the next commit, return context that > was switched to from i915_switch_context(). > > v2: context in return value instead of param. (Ben Widawsky) > > Signed-off-by: Mika Kuoppala I don't see this used in the n

[Intel-gfx] [PATCH] drm/i915: shovel compute clock into crtc->config.dpll on ilk

2013-04-20 Thread Daniel Vetter
This was somehow lost in the pipe_config->dpll introduction in commit f47709a9502f3715cc488b788ca91cf0c142b1b1 Author: Daniel Vetter Date: Thu Mar 28 10:42:02 2013 +0100 drm/i915: create pipe_config->dpll for clock state While at it, extract a few small helpers for common computations. v

[Intel-gfx] Updated testing tree for 3.11

2013-04-20 Thread Daniel Vetter
Hi all, Usual QA cycle continues, although most of the stuff this time around is still heading towards 3.10. On top of what's in -fixes now just a few things: - More vlv stuff from Jesse, code should now be in decent enough shape to boot on real systems. Hopefully we can drop the experimental su

Re: [Intel-gfx] [RFC][PATCH] drm/i915: Make struct dpll == intel_clock_t

2013-04-20 Thread Daniel Vetter
On Fri, Apr 19, 2013 at 02:36:51PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > This allows unifying a bunch of the PLL calculations and whatnot. > > Signed-off-by: Ville Syrjälä Yeah, makes sense. Originally my idea was to have a clear cut between old&new pll computat

Re: [Intel-gfx] [PATCH 3/7] drm/i915: add intel_display_power_enabled

2013-04-20 Thread Daniel Vetter
On Fri, Apr 19, 2013 at 11:54 PM, Paulo Zanoni wrote: > From: Paulo Zanoni > > This should replace intel_using_power_well. The idea is that we're > adding the requested power domain as an argument, so this might enable > the code to look less platform-specific and also allows us to easily > add n