Re: [Intel-gfx] commit drm/i915: disable shared panel fitter for pipe breaks resolution switching

2013-03-03 Thread Daniel Vetter
On Sat, Mar 2, 2013 at 8:40 PM, Hans de Bruin wrote: > Mika, > > I am a huge van of ald dos games. Since commit > 24a1f16de97c4cf0029d9acd04be06db32208726, "drm/i915: disable shared panel > fitter for pipe" my laptop does not change resolution when I use xdosemu > full screen. The screen is just m

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Use '1' instead of FORCEWAKE_KERNEL for ST force wake

2013-03-03 Thread Daniel Vetter
On Fri, Mar 01, 2013 at 01:35:53PM +, Chris Wilson wrote: > On Fri, Mar 01, 2013 at 02:35:38PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Use the number '1' instead of FORCEWAKE_KERNEL when requesting single > > thread force wake since there is only one bit in

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Kill a few pointless comments

2013-03-03 Thread Daniel Vetter
On Fri, Mar 01, 2013 at 11:35:58AM +, Chris Wilson wrote: > On Thu, Feb 28, 2013 at 07:19:46PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > The code is totally obvious so these comments serve no purpose. What's > > worse, one of them was wrong. Just remove them.

Re: [Intel-gfx] [PATCH] drm/i915: Fix Haswell/CRW PCI IDs.

2013-03-03 Thread Daniel Vetter
On Fri, Mar 01, 2013 at 05:00:50PM -0800, Kenneth Graunke wrote: > The second digit was off by one, which meant we accidentally treated > GT(n) as GT(n-1). This also meant no support for GT1 at all. > > Cc: sta...@kernel.org > Signed-off-by: Kenneth Graunke Picked up for -fixes, thanks for the p

Re: [Intel-gfx] [PATCH] intel_chipset: Fix Haswell CRW PCI IDs.

2013-03-03 Thread Daniel Vetter
On Fri, Mar 01, 2013 at 03:36:20PM -0800, Kenneth Graunke wrote: > The second digit was off by one, which meant we accidentally treated > GT(n) as GT(n-1). This also meant no support for GT1 at all. > > Signed-off-by: Kenneth Graunke Applied, thanks for the patch. -Daniel -- Daniel Vetter Soft

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't clobber crtc->fb when queue_flip fails

2013-03-03 Thread Daniel Vetter
On Fri, Feb 22, 2013 at 03:13:00PM +, Chris Wilson wrote: > On Fri, Feb 22, 2013 at 04:53:38PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Restore crtc->fb to the old framebuffer if queue_flip fails. > > > > While at it, kill the pointless intel_fb temp variab

Re: [Intel-gfx] [PATCH] drm/i915: Add to_user_ptr()

2013-03-03 Thread Daniel Vetter
On Fri, Feb 22, 2013 at 02:29:44PM +, Chris Wilson wrote: > On Fri, Feb 22, 2013 at 04:12:51PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > to_user_ptr() simply casts a pointer passed as u64 from user space > > to void __user * correctly. Using this lets us get

Re: [Intel-gfx] [PATCH] drm/i915: Don't clobber crtc->fb when queue_flip fails

2013-03-03 Thread Daniel Vetter
On Fri, Feb 22, 2013 at 04:36:38PM +0200, Ville Syrjälä wrote: > I don't think anyone should be poking at crtc->fb w/o holding the crtc > mutex. Except that intel_update_fbc() actually does. That thing would > appear to be just broken since it crawls around in the crtc state w/o > proper protection

[Intel-gfx] [PATCH] drm/i915: add pipe_config->has_pch_encoder

2013-03-03 Thread Daniel Vetter
This is used way too often in the enable/disable paths. And will be even more useful in the future. Note that correct semantics of this change highly depend upon correct updating of intel_crtc->config: Like with all other modeset state, we need to call ->disable with the old config, but ->mode_set

Re: [Intel-gfx] [PATCH 06/10] drm/i915: add pipe_config->has_pch_encoder

2013-03-03 Thread Daniel Vetter
On Tue, Feb 26, 2013 at 02:39:15PM -0300, Paulo Zanoni wrote: > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > b/drivers/gpu/drm/i915/intel_display.c > > index 3446e2b..c5f7c6e 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -294

Re: [Intel-gfx] [PATCH v.2 06/12] DRM/i915: Add HPD IRQ storm detection (v2)

2013-03-03 Thread Daniel Vetter
On Thu, Feb 28, 2013 at 04:19:15AM -0500, Egbert Eich wrote: > Add a hotplug IRQ storm detection (triggered when a hotplug interrupt > fires more than 5 times / sec). > Rationale: > Despite of the many attempts to fix the problem with noisy hotplug > interrupt lines we are still seeing systems whic

Re: [Intel-gfx] [PATCH 04/10] drm/i915: add pipe_config->pixel_multiplier

2013-03-03 Thread Daniel Vetter
On Tue, Feb 26, 2013 at 02:27:36PM -0300, Paulo Zanoni wrote: > Hi > > 2013/2/21 Daniel Vetter : > > Used by SDVO (and hopefully, eventually HDMI, if we ever get around > > to fixing up the low dotclock CEA modes ...). > > > > This required adding a new encoder->mode_set callback to be able to > >

Re: [Intel-gfx] [PATCH 03/10] drm/i915: add pipe_config->timings_set

2013-03-03 Thread Daniel Vetter
On Fri, Feb 22, 2013 at 03:51:15PM +0200, Ville Syrjälä wrote: > On Fri, Feb 22, 2013 at 12:56:47AM +0100, Daniel Vetter wrote: > > Only used by the lvds encoder. Note that we shouldn't do the same > > simple conversion with the FORCE_6BPC flag, since that's much better > > handled by moving all th

Re: [Intel-gfx] [PATCH 03/10] drm/i915: add pipe_config->timings_set

2013-03-03 Thread Daniel Vetter
On Tue, Feb 26, 2013 at 02:23:23PM -0300, Paulo Zanoni wrote: > Hi > > 2013/2/21 Daniel Vetter : > > Only used by the lvds encoder. Note that we shouldn't do the same > > simple conversion with the FORCE_6BPC flag, since that's much better > > handled by moving all the pipe_bpc computation around.

Re: [Intel-gfx] [PATCH] drm/i915: GFDT support for SNB/IVB

2013-03-03 Thread Chris Wilson
On Sun, Mar 03, 2013 at 05:28:52PM +0100, Daniel Vetter wrote: > The other thing was that I didn't manage to get things to work properly, > leaving some random cachline dirt on the screen. Looking at your code, you > add the gfdt flush to every ring_flush, whereas I've tried to be clever > and only

Re: [Intel-gfx] [PATCH] display: change the priority order of intel_backlight

2013-03-03 Thread Chris Wilson
On Tue, Feb 26, 2013 at 04:16:40PM +0800, Keng-Yu Lin wrote: > make the intel_backlight interface with a higher priority > than acpi_video, as it is more likely to work. It is not, and the priority is explicitly lower than firmware (which itself is lower than platform). -Chris -- Chris Wilson, I

Re: [Intel-gfx] [PATCH 5/8] drm/i915: wait_event_timeout's timeout is in jiffies

2013-03-03 Thread Daniel Vetter
On Mon, Feb 18, 2013 at 07:00:24PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > So use msecs_to_jiffies(10) to make the timeout the same as in the > "!has_aux_irq" case. > > This patch was initially written by Daniel Vetter and posted on > pastebin a few weeks ago. I'm just bringing it to

Re: [Intel-gfx] [PATCH] display: change the priority order of intel_backlight

2013-03-03 Thread Daniel Vetter
On Tue, Feb 26, 2013 at 04:16:40PM +0800, Keng-Yu Lin wrote: > make the intel_backlight interface with a higher priority > than acpi_video, as it is more likely to work. > > Signed-off-by: Keng-Yu Lin If you have a non-working acpi backlight, that's a bug in the kernel's acpi subsystem. Most lik

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Added SDP and VSC structures for handling PSR for eDP

2013-03-03 Thread Daniel Vetter
On Mon, Feb 25, 2013 at 07:55:17PM -0300, Rodrigo Vivi wrote: > From: Shobhit Kumar > > Signed-off-by: Sateesh Kavuri > > v2: Modified and corrected the structures to be more in line for > kernel coding guidelines and rebased the code on Paulo's DP patchset > > Signed-off-by: Shobhit Kumar >

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Use cpu_transcoder for HSW_TVIDEO_DIP_* instead of pipe

2013-03-03 Thread Daniel Vetter
On Wed, Feb 27, 2013 at 04:44:59PM -0300, Paulo Zanoni wrote: > Hi > > 2013/2/25 Rodrigo Vivi : > > While old platforms had 3 transcoders and 3 pipes (1:1), HSW has > > 4 transcoders and 3 pipes. > > These regs were being used only by HDMI code where pipe is always the same > > thing as cpu_transc

[Intel-gfx] [PATCH] display: change the priority order of intel_backlight

2013-03-03 Thread Keng-Yu Lin
make the intel_backlight interface with a higher priority than acpi_video, as it is more likely to work. Signed-off-by: Keng-Yu Lin --- src/intel_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel_display.c b/src/intel_display.c index 5ee955e..479afb7 1006

Re: [Intel-gfx] [PATCH] drm/i915: GFDT support for SNB/IVB

2013-03-03 Thread Daniel Vetter
On Fri, Mar 01, 2013 at 08:32:57PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Currently all scanout buffers must be uncached because the > display controller doesn't snoop the LLC. SNB introduced another > method to guarantee coherency for the display controller. It's >

Re: [Intel-gfx] [PATCH 04/26] drm/i915: update VLV PLL and DPIO code

2013-03-03 Thread Daniel Vetter
On Fri, Mar 01, 2013 at 02:08:20PM -0800, Jesse Barnes wrote: > From: Pallavi G > > In Valleyview voltage swing, pre-emphasis and lane control registers can > be programmed only through the h/w side band fabric. Update > vlv_update_pll, i9xx_crtc_enable, and intel_enable_pll with the > appropria