Re: [Intel-gfx] [PATCH intel-gpu-tools 1/2] Put -I m4 in ACLOCAL_AMFLAGS so ./autogen.sh just works

2013-02-08 Thread Ben Widawsky
On Fri, Feb 08, 2013 at 11:36:53AM -0800, Matt Turner wrote: > --- > Makefile.am |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index 0dd615b..20bca79 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -19,7 +19,7 @@ > # IN AN ACTION

Re: [Intel-gfx] [PATCH] drm/i915: Fix sprite_scaling_enabled for multiple sprites

2013-02-08 Thread Chris Wilson
On Fri, Feb 08, 2013 at 11:13:35PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We have more than one sprite, so a boolean simply won't cut it. > Turn sprite_scaling_enabled into a bitmask and track the state > of sprite scaler for each sprite independently. > > Also don

[Intel-gfx] [PATCH] drm/i915: Fix sprite_scaling_enabled for multiple sprites

2013-02-08 Thread ville . syrjala
From: Ville Syrjälä We have more than one sprite, so a boolean simply won't cut it. Turn sprite_scaling_enabled into a bitmask and track the state of sprite scaler for each sprite independently. Also don't re-enable LP watermarks until the sprite registers have actually been written, and thus sp

Re: [Intel-gfx] [PATCH] drm/i915: Implement pipe CSC based limited range RGB output

2013-02-08 Thread Ville Syrjälä
On Fri, Jan 18, 2013 at 07:11:38PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > HSW no longer has the PIPECONF bit for limited range RGB output. > Instead the pipe CSC unit must be used to perform that task. > > The CSC pre offset are set to 0, since the incoming data is

Re: [Intel-gfx] [PATCH 07/10] drm/i915: print Gen5+ CPU poison interrupts

2013-02-08 Thread Jesse Barnes
On Fri, 8 Feb 2013 17:54:23 -0200 Paulo Zanoni wrote: > Hi > > 2013/2/8 Jesse Barnes : > > On Fri, 8 Feb 2013 17:35:18 -0200 > > Paulo Zanoni wrote: > > > >> From: Paulo Zanoni > >> > >> On ILK/SNB all we need to do is to enable the "poison" bit, but on > >> IVB/HSW we need to enable the CPU

Re: [Intel-gfx] i915 PCH backlight vs. Dell XPS13

2013-02-08 Thread Daniel Vetter
You might want to try the latest drm-intel-nightly git branch from http://cgit.freedesktop.org/~danvet/drm-intel This has a few more tricks which helped on some similar platforsm to yours (and similar resume issues). And please always include a mailing list when reporting issues, since your dear m

Re: [Intel-gfx] [PATCH 07/10] drm/i915: print Gen5+ CPU poison interrupts

2013-02-08 Thread Paulo Zanoni
Hi 2013/2/8 Jesse Barnes : > On Fri, 8 Feb 2013 17:35:18 -0200 > Paulo Zanoni wrote: > >> From: Paulo Zanoni >> >> On ILK/SNB all we need to do is to enable the "poison" bit, but on >> IVB/HSW we need to enable the CPU error interrupt register, which is >> responsible not only for poison interr

[Intel-gfx] [PATCH v3] drm/i915: Extract ring init from hw_init

2013-02-08 Thread Ben Widawsky
The ring initialization will differ a bit in upcoming generations, and this split will prepare the code for what's needed. This patch also fixes a bug introduced in: commit 99433931950f33039d9e1a52b4ed9af3f1b58e84 Author: Mika Kuoppala Date: Tue Jan 22 14:12:17 2013 +0200 drm/i915: use gem

Re: [Intel-gfx] [PATCH 07/10] drm/i915: print Gen5+ CPU poison interrupts

2013-02-08 Thread Jesse Barnes
On Fri, 8 Feb 2013 17:35:18 -0200 Paulo Zanoni wrote: > From: Paulo Zanoni > > On ILK/SNB all we need to do is to enable the "poison" bit, but on > IVB/HSW we need to enable the CPU error interrupt register, which is > responsible not only for poison interrupts, but also other things. > This i

[Intel-gfx] [PATCH v2] drm/i915: Extract ring init from hw_init

2013-02-08 Thread Ben Widawsky
The ring initialization will differ a bit in upcoming generations, and this split will prepare the code for what's needed. This patch also fixes a bug introduced in: commit 99433931950f33039d9e1a52b4ed9af3f1b58e84 Author: Mika Kuoppala Date: Tue Jan 22 14:12:17 2013 +0200 drm/i915: use gem

[Intel-gfx] [PATCH 10/10] drm/i915: also POSTING_READ(DEIER) on ivybridge_irq_handler

2013-02-08 Thread Paulo Zanoni
From: Paulo Zanoni This is already done on ironlake_irq_handler. We want to make sure the interrupts are disabled before we check any of the other interrupt registers. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_irq.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[Intel-gfx] [PATCH 09/10] drm/i915: print CPU FIFO underruns

2013-02-08 Thread Paulo Zanoni
From: Paulo Zanoni Just like the PCH FIFO underruns, except that there's no place where we expect it to happen. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_drv.h |2 ++ drivers/gpu/drm/i915/i915_irq.c | 33 - drivers/gpu/drm/i915/i9

[Intel-gfx] [PATCH 08/10] drm/i915: print PCH FIFO underrun interrupts

2013-02-08 Thread Paulo Zanoni
From: Paulo Zanoni Also add an "ignore" bit that avoids printing the message in two cases: - When the message is in fact expected. - After we get the first message. In tihs case, we expect to get hundreds of consecutive messages, so we just ignore all the subsequent messages until the

[Intel-gfx] [PATCH 07/10] drm/i915: print Gen5+ CPU poison interrupts

2013-02-08 Thread Paulo Zanoni
From: Paulo Zanoni On ILK/SNB all we need to do is to enable the "poison" bit, but on IVB/HSW we need to enable the CPU error interrupt register, which is responsible not only for poison interrupts, but also other things. This includes the "unclaimed register" interrupt, so on the IVB irq handler

[Intel-gfx] [PATCH 06/10] drm/i915: print PCH poison interrupts

2013-02-08 Thread Paulo Zanoni
From: Paulo Zanoni This is bad news and shouldn't be happening. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_irq.c | 29 + drivers/gpu/drm/i915/i915_reg.h |4 2 files changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 05/10] drm/i915: also disable south interrupts when handling them

2013-02-08 Thread Paulo Zanoni
From: Paulo Zanoni >From the docs: "Only the rising edge of the PCH Display interrupt will cause the North Display IIR (DEIIR) PCH Display Interrupt even bit to be set, so all PCH Display Interrupts, including back to back interrupts, must be cleared before a new PCH Display interrupt can

[Intel-gfx] [PATCH 04/10] drm/i915: add ibx_irq_postinstall

2013-02-08 Thread Paulo Zanoni
From: Paulo Zanoni So we can remove duplicated code. Note that this function is used not only on IBX, but also CPT and LPT. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_irq.c | 66 ++- 1 file changed, 24 insertions(+), 42 deletions(-) diff --

[Intel-gfx] [PATCH 03/10] drm/i915: clear the FPGA_DBG_RM_NOCLAIM bit at driver init

2013-02-08 Thread Paulo Zanoni
From: Paulo Zanoni Otherwise, if the BIOS did anything wrong, our first I915_{WRITE,READ} will give us "unclaimed register" messages. V2: Even earlier. Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=58897 Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_dma.c |4 1 f

[Intel-gfx] [PATCH 02/10] drm/i915: use FPGA_DBG for the "unclaimed register" checks

2013-02-08 Thread Paulo Zanoni
From: Paulo Zanoni We plan to treat GEN7_ERR_INT as an interrupt, so use this register for the checks inside I915_WRITE. This way we can have the best of both worlds: the error message with a register address and the interrupt. V2: Split in 2 patches: one for the macro, one for changing the regi

[Intel-gfx] [PATCH 01/10] drm/i915: drm/i915: create macros for the "unclaimed register" checks

2013-02-08 Thread Paulo Zanoni
From: Paulo Zanoni This avoids polluting i915_write##x and also allows us to reuse code on i915_read##x. v2: Rebase Reviewed-by: Ben Widawsky (v1) Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_drv.c | 24 1 file changed, 16 insertions(+), 8 deletions(-)

[Intel-gfx] [PATCH 00/10] Display error reporting

2013-02-08 Thread Paulo Zanoni
From: Paulo Zanoni Hi This series is the first step to improve error reporting on our driver. The first 3 patches were already sent to the list and they're a requirement for the series (because of the relationship between our "unclaimed register" checks and the display error interrupts). Patch

[Intel-gfx] [PATCH intel-gpu-tools 2/2] quick_dump: Makefile.am best practices and fix distcheck

2013-02-08 Thread Matt Turner
A few changes - Put CPPFLAGS in AM_CPPFLAGS instead of a per-target CFLAGS var; - Use _LIBS/_CFLAGS from pkg-config instead of hard-coded values; - List non-generated scripts in dist_bin_SCRIPTS; - Add chipset.py to the run that implicitly generates it, which fixes distcheck. --- tools

[Intel-gfx] [PATCH intel-gpu-tools 1/2] Put -I m4 in ACLOCAL_AMFLAGS so ./autogen.sh just works

2013-02-08 Thread Matt Turner
--- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index 0dd615b..20bca79 100644 --- a/Makefile.am +++ b/Makefile.am @@ -19,7 +19,7 @@ # IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN # CONNECTION WITH TH

[Intel-gfx] [PATCH] drm/i915: Fix gen2 mappable calculations

2013-02-08 Thread Ben Widawsky
When I refactored the code initially, I forgot that gen2 uses a different bar for the CPU mappable aperture. The agp-less code knows nothing of generations less than 5, so we have to expand the gtt_probe function to include the mappable base and end. It was originally broken by me: commit baa09f5f

Re: [Intel-gfx] [PATCH 7/7] drm/i915: print Gen 7 error interrupts

2013-02-08 Thread Paulo Zanoni
Hi 2013/1/25 Ben Widawsky : > On Fri, 25 Jan 2013 18:57:42 -0200 > Paulo Zanoni wrote: > >> From: Paulo Zanoni >> >> If we get one of these messages it means we did something wrong, and >> the first step to fix wrong things is to detect them and recognize >> they exist. >> >> For now, leave most

[Intel-gfx] [PATCH] drm/i915: Extract ring init from hw_init

2013-02-08 Thread Ben Widawsky
The ring initialization will differ a bit in upcoming generations, and this split will prepare the code for what's needed. This patch also fixes a bug introduced in: commit 99433931950f33039d9e1a52b4ed9af3f1b58e84 Author: Mika Kuoppala Date: Tue Jan 22 14:12:17 2013 +0200 drm/i915: use gem

Re: [Intel-gfx] [PATCH 02/12] configure.ac: Move prime stuff to where it belongs

2013-02-08 Thread Paul Menzel
Am Donnerstag, den 07.02.2013, 10:39 -0800 schrieb Ben Widawsky: So where does it belong? > Signed-off-by: Ben Widawsky […] Thanks, Paul signature.asc Description: This is a digitally signed message part ___ Intel-gfx mailing list Intel-gfx@lists

Re: [Intel-gfx] ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!

2013-02-08 Thread Jesse Barnes
On Fri, 8 Feb 2013 10:51:48 +0100 Daniel Vetter wrote: > On Fri, Feb 8, 2013 at 10:30 AM, kbuild test robot > wrote: > > tree: git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-nightly > > head: 69f0d09dfd2d0579241389aee18ba50aa39d0de2 > > commit: d6bc5b0603e5bea1b5a214d21c0aba851

Re: [Intel-gfx] [PATCH 01/12] configure.ac: slightly more standard --disable-tests

2013-02-08 Thread Paul Menzel
Dear Ben, Am Donnerstag, den 07.02.2013, 10:39 -0800 schrieb Ben Widawsky: > This partially reverts missing empty line for better legibility. > commit 7c170724003f42cd4ceea9f6c805292bbe2e81b2 > Author: Rodrigo Vivi > Date: Tue Feb 5 16:17:54 2013 -0200 > > Build: Add --disable-tests con

[Intel-gfx] [PATCH 2/2] drm/i915: clean up panel fitter handling in lvds

2013-02-08 Thread Mika Kuoppala
commit c1d1f5aeda2033d96e872f416388653f05d4c16d Author: Mika Kuoppala Date: Tue Feb 5 17:26:52 2013 +0200 drm/i915: disable shared panel fitter for pipe moved panel fit disabling to be crtc property. Thus the need to explicitly turn pfit off in encoder side became obsolete. Take advantage

[Intel-gfx] [PATCH 1/2] drm/i915: disable shared panel fitter for pipe

2013-02-08 Thread Mika Kuoppala
If encoder is switched off by BIOS, but the panel fitter is left on, we never try to turn off the panel fitter and leave it still attached to the pipe - which can cause blurry output elsewhere. Based on work by Chris Wilson Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=58867 Cc: sta...@

Re: [Intel-gfx] [PATCH] Build: Add --disable-tests configure flag to avoid tests build.

2013-02-08 Thread Rodrigo Vivi
Apparently Cairo wasn't the main reason, beucase something at /libs depends on Cairo as well. So cairo dependencie wasn't removed from checks. But now on, when including any dependencies used only for tests please add pkg_check_modules only if tests build enalbed. On Thu, Feb 7, 2013 at 8:40 PM,

Re: [Intel-gfx] [RFC] [PATCH 0/7] arb robustness enablers

2013-02-08 Thread Daniel Vetter
On Mon, Feb 04, 2013 at 04:04:36PM +0200, Mika Kuoppala wrote: > Hi, > > This patchset adds ioctl and related changes to allow > userspace to query about the context loss status of the > specified context. The aim is to provide enabler > for the ARB_Robustness GL extension. > > I post this as RFC

Re: [Intel-gfx] ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!

2013-02-08 Thread Daniel Vetter
On Fri, Feb 8, 2013 at 10:30 AM, kbuild test robot wrote: > tree: git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-nightly > head: 69f0d09dfd2d0579241389aee18ba50aa39d0de2 > commit: d6bc5b0603e5bea1b5a214d21c0aba8518f1a01f fb: add support for drivers > not needing VT switch at sus

Re: [Intel-gfx] [PATCH] drm/i915: Clarify HW context size logic

2013-02-08 Thread Daniel Vetter
On Thu, Feb 07, 2013 at 01:34:19PM -0800, Ben Widawsky wrote: > This was a rebase error from when the patches originally landed. Since > the context size is unsigned, there is also no use in checking if it's > less than 0. > > The existing code is not really wrong, but it's not simple as it should