Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Zhang Rui
On Sun, 2013-01-27 at 16:45 +0100, Daniel Vetter wrote: > On Sun, Jan 27, 2013 at 4:21 PM, Zhang Rui wrote: > > i915 driver needs to do modeset when > > 1. system resumes from sleep > > 2. lid is opened > > > > In PM_SUSPEND_MEM state, all the GPEs are cleared when system resumes, > > thus it is t

Re: [Intel-gfx] Adding a i915 quirk (here: pipe A force quirk for testing purposes)?

2013-01-27 Thread Sedat Dilek
On Mon, Jan 28, 2013 at 1:16 AM, Sedat Dilek wrote: > On Mon, Jan 28, 2013 at 12:52 AM, Sedat Dilek wrote: >> Hi, >> >> From [1]: >> ... >> static struct intel_quirk intel_quirks[] = { >> /* HP Mini needs pipe A force quirk (LP: #322104) */ >> { 0x27ae, 0x103c, 0x361a, quirk_pipea

Re: [Intel-gfx] Adding a i915 quirk (here: pipe A force quirk for testing purposes)?

2013-01-27 Thread Sedat Dilek
On Mon, Jan 28, 2013 at 12:52 AM, Sedat Dilek wrote: > Hi, > > From [1]: > ... > static struct intel_quirk intel_quirks[] = { > /* HP Mini needs pipe A force quirk (LP: #322104) */ > { 0x27ae, 0x103c, 0x361a, quirk_pipea_force }, > ... > } > > Triple - which value is what? > > 00:0

[Intel-gfx] Adding a i915 quirk (here: pipe A force quirk for testing purposes)?

2013-01-27 Thread Sedat Dilek
Hi, >From [1]: ... static struct intel_quirk intel_quirks[] = { /* HP Mini needs pipe A force quirk (LP: #322104) */ { 0x27ae, 0x103c, 0x361a, quirk_pipea_force }, ... } Triple - which value is what? 00:02.0 VGA compatible controller [0300]: Intel Corporation 2nd Generation Core

Re: [Intel-gfx] [PATCH 5/7] drm/i915: check the power down well on assert_pipe()

2013-01-27 Thread Daniel Vetter
On Fri, Jan 25, 2013 at 04:59:14PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > If the power well is disabled, we should not try to read its > registers, otherwise we'll get "unclaimed register" messages. > > V2: Don't check whether the power well is enabled or not, just check > whether w

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Daniel Vetter
On Sun, Jan 27, 2013 at 11:21 PM, Rafael J. Wysocki wrote: >> Given that this essentially requires users to manually set this module >> option to make stuff work I don't like this. >> >> I see a few possible options: >> - plug the races between all the different parts - I've never really >> unders

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Rafael J. Wysocki
On Sunday, January 27, 2013 04:45:51 PM Daniel Vetter wrote: > On Sun, Jan 27, 2013 at 4:21 PM, Zhang Rui wrote: > > i915 driver needs to do modeset when > > 1. system resumes from sleep > > 2. lid is opened > > > > In PM_SUSPEND_MEM state, all the GPEs are cleared when system resumes, > > thus it

Re: [Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Daniel Vetter
On Sun, Jan 27, 2013 at 4:21 PM, Zhang Rui wrote: > i915 driver needs to do modeset when > 1. system resumes from sleep > 2. lid is opened > > In PM_SUSPEND_MEM state, all the GPEs are cleared when system resumes, > thus it is the i915_resume code does the modeset rather than > intel_lid_notify()

[Intel-gfx] [RFC PATCH 3/3] i915: ignore lid open event when resuming

2013-01-27 Thread Zhang Rui
i915 driver needs to do modeset when 1. system resumes from sleep 2. lid is opened In PM_SUSPEND_MEM state, all the GPEs are cleared when system resumes, thus it is the i915_resume code does the modeset rather than intel_lid_notify(). In PM_SUSPEND_FREEZE state, system is still resposive to the l

[Intel-gfx] [RFC PATCH 2/3] ACPI: enable ACPI SCI during suspend

2013-01-27 Thread Zhang Rui
Enable ACPI SCI during suspend so that SCI can be used as wake events for PM_SUSPEND_FREEZE. For S3/S4 transition, We disable all GPEs in suspend_ops->prepare_late() to fix a problem that GPEs may trigger SCI before arch_suspend_disable_irqs() is run. So it is safe to leave the SCI enabled until

[Intel-gfx] [RFC PATCH 1/3] PM: Introduce suspend state PM_SUSPEND_FREEZE

2013-01-27 Thread Zhang Rui
PM_SUSPEND_FREEZE state is a general state that does not need any platform specific support, it equals frozen processes + suspended devices + idle processors. Compared with PM_SUSPEND_MEMORY, PM_SUSPEND_FREEZE saves less power because the system is still in a running state. PM_SUSPEND_FREEZE has l