[Intel-gfx] [PATCH 2/2] drm/i915: Implement WaSetupGtModeTdRowDispatch

2012-12-14 Thread Daniel Vetter
I'm not really sure, since the w/a entry is as thin on details as ever, and Bspec doesn't say anything about it. But I've figured only dispatching to rows 0&1 instead of all four should be the right thing for GT1. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h |2 ++ driver

[Intel-gfx] [PATCH 1/2] drm/i915: Implement WaDisableHiZPlanesWhenMSAAEnabled

2012-12-14 Thread Daniel Vetter
Quoting from Bspec, 3D_CHICKEN1, bit 10 This bit needs to be set always to "1", Project: DevSNB " Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_reg.h |1 + drivers/gpu/drm/i915/intel_pm.c |4 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.

Re: [Intel-gfx] [PATCH 00/81] drm/i915: Atomic mode setting / page flip, yet again

2012-12-14 Thread Ville Syrjälä
On Wed, Dec 12, 2012 at 06:15:27PM +0200, ville.syrj...@linux.intel.com wrote: ... > Ever since the code started to resemble something sane, I've tried > to avoid squashing patches, just in case someone was actually trying > to follow what's changed. But clearly some of the patches can > be squashe

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Remove stale comment about intel_dp_detect()

2012-12-14 Thread Daniel Vetter
On Fri, Dec 14, 2012 at 11:46:20AM +0200, Jani Nikula wrote: > On Thu, 13 Dec 2012, Damien Lespiau wrote: > > From: Damien Lespiau > > > > The function doesn't use any of the registers mentioned, nor does it > > return true or false. Hard to do worse. Remove it, the function is > > absolutely des

Re: [Intel-gfx] [PATCH 3/6] drm/i915/dp: Read the HPD status before trying to read the DPCD

2012-12-14 Thread Daniel Vetter
On Thu, Dec 13, 2012 at 04:09:01PM +, Damien Lespiau wrote: > From: Damien Lespiau > > Just like: > > Author: Damien Lespiau > Date: Wed Dec 12 19:37:22 2012 + > > drm/i915/hdmi: Read the HPD status before trying to read the EDID > > But this time for DiplayPort. > > v2:

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Remove stale comment about intel_dp_detect()

2012-12-14 Thread Jani Nikula
On Thu, 13 Dec 2012, Damien Lespiau wrote: > From: Damien Lespiau > > The function doesn't use any of the registers mentioned, nor does it > return true or false. Hard to do worse. Remove it, the function is > absolutely descriptive enough to not need any comment. Reviewed-by: Jani Nikula > Si

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Implement ibx_digital_port_connected() for IBX

2012-12-14 Thread Jani Nikula
On Thu, 13 Dec 2012, Damien Lespiau wrote: > From: Damien Lespiau > > CPT+ PCHs have different bit definition to read the HPD live status. I > don't have an ILK with digital ports handy, which is why this patch is > separate from the CPT+ implementation. If the docs don't lie, it should > all be

Re: [Intel-gfx] [PATCH 4/6] drm/i915/dp: Log the DPCD only if we have successfully retrieved one

2012-12-14 Thread Jani Nikula
On Thu, 13 Dec 2012, Damien Lespiau wrote: > From: Damien Lespiau > > Moving the DPCD just after a successful read will allow to: > - log all DPCD reads (eDP ones, changes signalled by HPD IRQ) > - don't log it if we haven't been able to read it The first part does actually increase DPCD log

Re: [Intel-gfx] [PATCH 2/6] drm/i915/hdmi: Read the HPD status before trying to read the EDID

2012-12-14 Thread Jani Nikula
On Thu, 13 Dec 2012, Damien Lespiau wrote: > From: Damien Lespiau > > If you unplug the hdmi connector slowly enough, the hotplug interrupt > fires but then the kernel code tries to read the EDID and succeeds > (because the connector is still half connected, the HPD pin is shorter > than the othe

Re: [Intel-gfx] [PATCH 2/2] drm/exynos: reorder framebuffer init sequence

2012-12-14 Thread Daniel Vetter
On Fri, Dec 14, 2012 at 5:57 AM, Inki Dae wrote: > 2012/12/14 Daniel Vetter >> >> On Thu, Dec 13, 2012 at 4:16 PM, Inki Dae wrote: >> > How about rebasing this patch to top of >> > git://people.freedesktop.org/~airlied/linux.git drm-next? >> > Exynos's many patches have already been merged to dr