Re: [Intel-gfx] [PATCH 5/5] drm/i915: extract intel_set_pipe_timings from crtc_mode_set

2012-09-24 Thread Rodrigo Vivi
what about pipeconf |= PIPECONF_INTERLACE_W_FIELD_INDICATION;? isn't this useful anymore? in this case I think it would be better split this patch in 2: 1 to remove it and another one to organize the functions. On Thu, Sep 20, 2012 at 6:36 PM, Paulo Zanoni wrote: > From: Paulo Zanoni > > Versio

Re: [Intel-gfx] [PATCH 4/5] drm/i915: remove unused variables from ironlake_crtc_mode_set

2012-09-24 Thread Rodrigo Vivi
Feel free to use Reviewed-by: Rodrigo Vivi On Thu, Sep 20, 2012 at 6:36 PM, Paulo Zanoni wrote: > From: Paulo Zanoni > > The last patches moved a lot of code from ironlake_crtc_mode_set to > sub-functions, so these variables became useless. You could get > warnings by enabling -Wunused-but-set-

Re: [Intel-gfx] [PATCH 3/5] drm/i915: extract compute_dpll from ironlake_crtc_mode_set

2012-09-24 Thread Rodrigo Vivi
Feel free to use: Reviewed-by: Rodrigo Vivi On Thu, Sep 20, 2012 at 6:36 PM, Paulo Zanoni wrote: > From: Paulo Zanoni > > Too many lines just to compute the value of a single variable, so > move this to its own function. > > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_displ

Re: [Intel-gfx] [PATCH 2/5] drm/i915: extract set_m_n from ironlake_crtc_mode_set

2012-09-24 Thread Rodrigo Vivi
Feel free to use: Reviewed-by: Rodrigo Vivi On Thu, Sep 20, 2012 at 6:36 PM, Paulo Zanoni wrote: > From: Paulo Zanoni > > The set_m_n code was spread all over the mode_set function. > > Version 2: > Don't set the DP M/N registers on ironlake_set_m_n. Daniel Vetter has > plans to add some encode

Re: [Intel-gfx] [PATCH 1/5] drm/i915: don't recheck for invalid pipe bpp

2012-09-24 Thread Rodrigo Vivi
Feel free to use: Reviewed-by: Rodrigo Vivi On Thu, Sep 20, 2012 at 6:36 PM, Paulo Zanoni wrote: > From: Paulo Zanoni > > As noticed by Daniel Vetter, intel_pipe_choose_bpp_dither should > already check for invalid bpp values and set a valid value, so remove > the recheck inside ironlake_crtc_m

Re: [Intel-gfx] [PATCH 1/2] drm/i915: s/cacheing/caching/

2012-09-24 Thread Rodrigo Vivi
Feel free to use: Reviewed-by: Rodrigo Vivi On Fri, Sep 21, 2012 at 9:01 PM, Ben Widawsky wrote: > From: Ben Widawsky > > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_dma.c | 4 ++-- > drivers/gpu/drm/i915/i915_drv.h | 8 > drivers/gpu/drm/i915/i915_gem.c | 20

Re: [Intel-gfx] [PATCH 1/2] drm/i915: BUG() on unexpected HDMI register

2012-09-24 Thread Rodrigo Vivi
This was easy for me, feel free to use: Reviewed-by: Rodrigo Vivi On Mon, Sep 24, 2012 at 10:32 AM, Paulo Zanoni wrote: > From: Paulo Zanoni > > This should never happen, but the silent "return" makes me wonder > every time I try to debug InfoFrame bugs, so promote this to BUG() to > make sure

Re: [Intel-gfx] [PATCH 2/2] drm/i915: make sure we write at least 32 DIP bytes

2012-09-24 Thread Rodrigo Vivi
I know almost nothing about hdmi infoframes, but isn't hdmi infoframes limited to 30 bytes + 1 checksum byte? (From HDMI Spec 8.2 section) On Mon, Sep 24, 2012 at 10:32 AM, Paulo Zanoni wrote: > From: Paulo Zanoni > > If we don't write at least 32 DIP bytes the InfoFrame ECC may not be > correct

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Some HSW PTE fixes

2012-09-24 Thread Ben Widawsky
On Fri, 21 Sep 2012 17:01:21 -0700 Ben Widawsky wrote: > diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c > index 8f956db..08ba729 100644 > --- a/drivers/char/agp/intel-gtt.c > +++ b/drivers/char/agp/intel-gtt.c > @@ -1161,23 +1161,15 @@ static void haswell_write_entry(dma

[Intel-gfx] [PATCH 2/2] drm/i915: make sure we write at least 32 DIP bytes

2012-09-24 Thread Paulo Zanoni
From: Paulo Zanoni If we don't write at least 32 DIP bytes the InfoFrame ECC may not be correctly calculated in some cases (e.g., when changing the port), and this will lead to black screens on HDMI monitors. The ECC value is generated by the hardware. I don't see how this should break anything

[Intel-gfx] [PATCH 1/2] drm/i915: BUG() on unexpected HDMI register

2012-09-24 Thread Paulo Zanoni
From: Paulo Zanoni This should never happen, but the silent "return" makes me wonder every time I try to debug InfoFrame bugs, so promote this to BUG() to make sure people will complain if we ever break this. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_hdmi.c |2 ++ 1 file c

Re: [Intel-gfx] [PATCH] console: implement lockdep support for console_lock

2012-09-24 Thread Daniel Vetter
On Sat, Sep 22, 2012 at 01:06:29PM -0700, Greg KH wrote: > On Sat, Sep 22, 2012 at 07:52:11PM +0200, Daniel Vetter wrote: > > Dave Airlie recently discovered a locking bug in the fbcon layer, > > where a timer_del_sync (for the blinking cursor) deadlocks with the > > timer itself, since both (want