Re: [Intel-gfx] [PATCH] drm/i915: Prevent signals from interrupting memory recovery

2012-09-07 Thread Ben Widawsky
On Tue, 4 Sep 2012 21:00:58 +0100 Chris Wilson wrote: > Just a spark of an idea to see if this is valid. > > Given extreme memory pressure where we must zap our own caches and > bound buffers or else we fail to allocate a structure, we have a > choice of propagating that interrupt back to users

Re: [Intel-gfx] [PATCH] intel: properly test for HAS_LLC

2012-09-07 Thread Ben Widawsky
On Fri, 31 Aug 2012 11:18:53 +0200 Daniel Vetter wrote: > If the kernel supports the test, we need to check the param. > Copy&pasta from the above checks that only look at the return value. > Interesting how much one can get such a simple interface wrong. > > Issue created in > > commit 151cdcf

Re: [Intel-gfx] [PATCH] drm/i915: initialize dpio_lock spin lock

2012-09-07 Thread Ben Widawsky
On Fri, 31 Aug 2012 15:50:55 +0300 Jani Nikula wrote: > From: Alexander Shishkin > > This thing is killing lockdep. > > Signed-off-by: Alexander Shishkin > [Jani: move the init next to the other spin lock inits] > Signed-off-by: Jani Nikula Acked-by: Ben Widawsky -- Ben Widawsky, Intel Op

[Intel-gfx] [PATCH] sysfs rps test added

2012-09-07 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- tests/Makefile.am | 1 + tests/sysfs_rps.c | 179 ++ 2 files changed, 180 insertions(+) create mode 100644 tests/sysfs_rps.c diff --git a/tests/Makefile.am b/tests/Makefile.am index d4c7c46..d88a83a 100644 ---

[Intel-gfx] [REPOST PATCH 7/7] drm/i915: Show render P state thresholds in sysfs

2012-09-07 Thread Ben Widawsky
This is useful for userspace utilities which wish to use the previous interface, specifically for micromanaging the increase/decrease steps by setting min == max. Reviewed-by: Chris Wilson Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_sysfs.c | 36 +++

[Intel-gfx] [PATCH 6/7 v3] drm/i915: Add setters for min/max frequency

2012-09-07 Thread Ben Widawsky
Provide a standardized sysfs interface for setting min, and max frequencies. The code which reads the limits were lifted from the debugfs files. As a brief explanation, the limits are similar to the CPU p-states. We have 3 states: RP0 - ie. max frequency RP1 - ie. "preferred min" frequency RPn -

[Intel-gfx] [PATCH 5/7] drm/i915: Error checks in gen6_set_rps

2012-09-07 Thread Ben Widawsky
With the new "standardized" sysfs interfaces we need to be a bit more careful about setting the RPS values. Because the sysfs code and the rps workqueue can run at the same time, if the sysfs setter wins the race to the mutex, the workqueue can come in and set a value which is out of range (ie. we

[Intel-gfx] [PATCH 4/7] drm/i915: POSTING_READ the new rps value

2012-09-07 Thread Ben Widawsky
In order to keep our cached values in sync with the hardware, we need a posting read here. CC: Chris Wilson Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/intel_pm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c ind

[Intel-gfx] [REPOST PATCH 3/7 v2] drm/i915: Add current/max/min GPU freq to sysfs

2012-09-07 Thread Ben Widawsky
Userspace applications such as PowerTOP are interesting in being able to read the current GPU frequency. The patch itself sets up a generic array for gen6 attributes so we can easily add other items in the future (and it also happens to be just about the cleanest way to do this). The patch is a ni

[Intel-gfx] [REPOST PATCH 2/7] drm/i915: #define gpu freq multipler

2012-09-07 Thread Ben Widawsky
Magic numbers are bad mmmkay. In this case in particular the value is especially weird because the docs say multiple things. We'll need this value for sysfs, so extracting it is useful for that as well. Reviewed-by: Jesse Barnes Reviewed-by: Chris Wilson Signed-off-by: Ben Widawsky --- drivers

[Intel-gfx] [REPOST PATCH 1/7] drm/i915: variable renames

2012-09-07 Thread Ben Widawsky
Name variables a bit better for copy-pasters. This got turned up as part of review for upcoming sysfs patches. Reviewed-by: Chris Wilson Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_sysfs.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH 0/8 v2] Moar sysfs stuff

2012-09-07 Thread Ben Widawsky
This series is being resubmitted in full because I added two new patches which changes the orderings. In addition I found a bug using the newly included intel-gpu-tool test, and I've dropped Jesse's patch since there was some negative hooplah. I also dropped the previous patch 1, which Daniel has a

Re: [Intel-gfx] [PATCH] drm/fb helper: don't call drm_helper_connector_dpms directly

2012-09-07 Thread Daniel Vetter
On Fri, Sep 07, 2012 at 02:28:28PM -0700, Jesse Barnes wrote: > On Fri, 7 Sep 2012 10:14:52 +0200 > Daniel Vetter wrote: > > > Yet again a case where the fb helper is too intimate with the crtc > > helper and calls a crtc helepr function directly instead of going > > through the interface vtable

Re: [Intel-gfx] [PATCH] drm/fb helper: don't call drm_helper_connector_dpms directly

2012-09-07 Thread Jesse Barnes
On Fri, 7 Sep 2012 10:14:52 +0200 Daniel Vetter wrote: > Yet again a case where the fb helper is too intimate with the crtc > helper and calls a crtc helepr function directly instead of going > through the interface vtable. > > This fixes console blanking in drm/i915 with the new i915-specific

Re: [Intel-gfx] [PATCH 7/7] drm/i915: expose energy counter on SNB and IVB

2012-09-07 Thread Ben Widawsky
On Fri, 7 Sep 2012 12:03:37 +0200 Daniel Vetter wrote: > On Thu, Sep 06, 2012 at 01:54:10PM -0700, Ben Widawsky wrote: > > From: Jesse Barnes > > > > On SNB and IVB, there's an MSR (also exposed through MCHBAR) we can use > > to read out the amount of energy used over time. Expose this in sysf

Re: [Intel-gfx] [PATCH] tools: Update gitignore with intel_dpio_{read, write}

2012-09-07 Thread Daniel Vetter
On Fri, Sep 07, 2012 at 11:42:20AM +0100, Damien Lespiau wrote: > From: Damien Lespiau > > Signed-off-by: Damien Lespiau Applied, thanks. -Daniel > --- > tools/.gitignore | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/.gitignore b/tools/.gitignore > index c15e3c3..454d10e 100

[Intel-gfx] [PATCH] tools: Update gitignore with intel_dpio_{read, write}

2012-09-07 Thread Damien Lespiau
From: Damien Lespiau Signed-off-by: Damien Lespiau --- tools/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/.gitignore b/tools/.gitignore index c15e3c3..454d10e 100644 --- a/tools/.gitignore +++ b/tools/.gitignore @@ -4,6 +4,8 @@ intel_backlight intel_bios_dumper intel

Re: [Intel-gfx] [PATCH 7/7] drm/i915: expose energy counter on SNB and IVB

2012-09-07 Thread Daniel Vetter
On Thu, Sep 06, 2012 at 01:54:10PM -0700, Ben Widawsky wrote: > From: Jesse Barnes > > On SNB and IVB, there's an MSR (also exposed through MCHBAR) we can use > to read out the amount of energy used over time. Expose this in sysfs > to make it easy to do power comparisons with different configur

Re: [Intel-gfx] [PATCH 5/7 v2] drm/i915: Add setters for min/max frequency

2012-09-07 Thread Chris Wilson
The only bit of the series I don't like is the conversion to uJ which looks like it can overflow. Otherwise, Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.or

Re: [Intel-gfx] [PATCH] drm/i915: fixup the plane->pipe fixup code

2012-09-07 Thread Chris Wilson
On Thu, 6 Sep 2012 22:09:35 +0200, Daniel Vetter wrote: > We need to check whether the _other plane is on our pipe, not whether > our plane is on the other pipe. Otherwise if not both pipes/planes are > active, we won't properly clean up the mess and set up our desired > plane->pipe mapping. >

[Intel-gfx] [PATCH] drm/fb helper: don't call drm_helper_connector_dpms directly

2012-09-07 Thread Daniel Vetter
Yet again a case where the fb helper is too intimate with the crtc helper and calls a crtc helepr function directly instead of going through the interface vtable. This fixes console blanking in drm/i915 with the new i915-specific modeset code. Reported-by: Jesse Barnes Signed-off-by: Daniel Vett

Re: [Intel-gfx] [PATCH 00/58] modeset-rework, the basic conversion

2012-09-07 Thread Daniel Vetter
On Fri, Sep 7, 2012 at 3:08 AM, Jesse Barnes wrote: > Looks like I just found an issue with DPMS on fbcon on SNB though. > Leaving the system for awhile either results in corruption (part of the > fbcon on the screen) or just the screen left on. Indeed another case where the fb helper is too inti