Re: [Intel-gfx] [PATCH 25/81] drm: remove the list_head from drm_mode_set

2012-07-19 Thread Dave Airlie
On Thu, Jul 12, 2012 at 12:28 AM, Daniel Vetter wrote: > It's unused. At it confused me quite a bit until I've discovered that. Applied thanks, Dave. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinf

Re: [Intel-gfx] [PATCH 24/81] drm/fb helper: don't call drm_crtc_helper_set_config

2012-07-19 Thread Dave Airlie
On Thu, Jul 19, 2012 at 1:50 AM, Daniel Vetter wrote: > Actually including Dave on the recipient list might work bettter ;-) > > On Wed, Jul 18, 2012 at 05:49:22PM +0200, Daniel Vetter wrote: >> Hi Dave, >> >> Can you please pick this one up for -next? There are a few other issues >> where the fb

Re: [Intel-gfx] [PATCH] properly enable the blc controller on the right pipe

2012-07-19 Thread Carsten Emde
On 07/19/2012 04:40 PM, Daniel Vetter wrote: On Thu, Jul 19, 2012 at 4:00 PM, Carsten Emde wrote: On 06/11/2012 10:51 AM, Daniel Vetter wrote: I've updated my backlight-confusion branch with new patches for gen4 (it doesn't seem to work for these machines yet). Can you please test the updated

Re: [Intel-gfx] [PATCH 2/2] drm/i915/context: Add missing IVB context sizes

2012-07-19 Thread Daniel Vetter
On Wed, Jul 18, 2012 at 10:10:10AM -0700, Ben Widawsky wrote: > There were some fields missed. Daniel pointed this out in review, and I > know I fixed it, but something happened somehow and some time. > > Signed-off-by: Ben Widawsky Both patches queued for -next, thanks. -Daniel -- Daniel Vette

[Intel-gfx] [PATCH 9/9] intel gen4-5: Don't touch flatshaded values when clipping, only copy them.

2012-07-19 Thread Olivier Galibert
This patch ensures that integers will pass through unscathed. Doing (useless) computations on them is risky, especially when their bit patterns correspond to values like inf or nan. Signed-off-by: Olivier Galibert --- src/mesa/drivers/dri/i965/brw_clip_util.c | 48 ++--

[Intel-gfx] [PATCH 8/9] intel gen4-5: Make noperspective clipping work.

2012-07-19 Thread Olivier Galibert
At this point all interpolation tests with fixed clipping work. Signed-off-by: Olivier Galibert Reviewed-by: Paul Berry --- src/mesa/drivers/dri/i965/brw_clip.c |9 ++ src/mesa/drivers/dri/i965/brw_clip.h |1 + src/mesa/drivers/dri/i965/brw_clip_util.c | 147 +

[Intel-gfx] [PATCH 7/9] intel gen4-5: Correctly handle flat vs. non-flat in the clipper.

2012-07-19 Thread Olivier Galibert
At that point, all interpolation piglit tests involving fixed clipping work as long as there's no noperspective. Signed-off-by: Olivier Galibert Reviewed-by: Paul Berry --- src/mesa/drivers/dri/i965/brw_clip.c | 13 -- src/mesa/drivers/dri/i965/brw_clip.h |6 +-- src

[Intel-gfx] [PATCH 6/9] intel gen4-5: Correctly setup the parameters in the sf.

2012-07-19 Thread Olivier Galibert
This patch also correct a couple of problems with noperspective interpolation. At that point all the glsl 1.1/1.3 interpolation tests that do not clip pass (the -none ones). The fs code does not use the pre-resolved interpolation modes in order not to mess with gen6+. Sharing the resolution woul

[Intel-gfx] [PATCH 5/9] intel gen4-5: Compute the interpolation status for every variable in one place.

2012-07-19 Thread Olivier Galibert
The program keys are updated accordingly, but the values are not used yet. Signed-off-by: Olivier Galibert --- src/mesa/drivers/dri/i965/brw_clip.c| 90 ++- src/mesa/drivers/dri/i965/brw_clip.h|1 + src/mesa/drivers/dri/i965/brw_context.h | 11 sr

[Intel-gfx] [PATCH 4/9] intel gen4-5: Fix backface/frontface selection when one one color is written to.

2012-07-19 Thread Olivier Galibert
Shaders, piglit test ones in particular, may write only to one of gl_FrontColor/gl_BackColor. The standard is unclear on whether the behaviour is defined in that case, but it seems reasonable to support it. The choice done there to pick up whichever color was actually written to. That makes most

[Intel-gfx] [PATCH 3/9] intel gen4-5: fix GL_VERTEX_PROGRAM_TWO_SIDE selection.

2012-07-19 Thread Olivier Galibert
Previous code only selected two side in pure fixed-function setups. This version also activates it when needed with shaders programs. Signed-off-by: Olivier Galibert --- src/mesa/drivers/dri/i965/brw_sf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri

[Intel-gfx] [PATCH 2/9] intel gen4-5: simplify the bfc copy in the sf.

2012-07-19 Thread Olivier Galibert
This patch is mostly designed to make followup patches simpler, but it's a simplification by itself. Signed-off-by: Olivier Galibert --- src/mesa/drivers/dri/i965/brw_sf_emit.c | 93 +-- 1 file changed, 52 insertions(+), 41 deletions(-) diff --git a/src/mesa/driver

[Intel-gfx] [PATCH 1/9] intel gen4-5: fix the vue view in the fs.

2012-07-19 Thread Olivier Galibert
In some cases the fragment shader view of the vue registers was out of sync with the builder. This fixes it. Signed-off-by: Olivier Galibert --- src/mesa/drivers/dri/i965/brw_fs.cpp |9 - src/mesa/drivers/dri/i965/brw_wm_pass2.c | 10 +- 2 files changed, 17 insertions(

[Intel-gfx] (no subject)

2012-07-19 Thread Olivier Galibert
Hi, This is the second verion of the clipping/interpolation patches. Main differences: - I tried to take all of Paul's remarks into account - I exploded the first patch in 4 independant ones - I've added a patch to ensure that integers pass through unscathed Patch 4/9 is (slightly) controversi

Re: [Intel-gfx] [RFC] GPU reset notification interface

2012-07-19 Thread Ian Romanick
On 07/18/2012 09:55 AM, Daniel Vetter wrote: On Wed, Jul 18, 2012 at 09:23:46AM -0700, Ian Romanick wrote: On 07/18/2012 02:20 AM, Daniel Vetter wrote: - The "all contexts in a share group need to receive a reset notification" wording is irking me a bit because we currently only track all th

Re: [Intel-gfx] [PATCH] drm/i915: Use MLC (l3$) for context objects

2012-07-19 Thread Eric Anholt
Chris Wilson writes: > Enabling context support increases SwapBuffers latency by about 20% > (measured on an i7-3720qm). We can offset that loss slightly by enabling > faster caching for the contexts. As they are not backed by any > particular cache (such as the sampler or render caches) our only

Re: [Intel-gfx] [PATCH] properly enable the blc controller on the right pipe

2012-07-19 Thread Daniel Vetter
On Thu, Jul 19, 2012 at 4:00 PM, Carsten Emde wrote: > On 06/11/2012 10:51 AM, Daniel Vetter wrote: >> I've updated my backlight-confusion branch with new patches for gen4 >> (it doesn't seem to work for these machines yet). Can you please test >> the updated branch? > > I have added an additional

Re: [Intel-gfx] [PATCH] properly enable the blc controller on the right pipe

2012-07-19 Thread Carsten Emde
On 06/11/2012 10:51 AM, Daniel Vetter wrote: On Sun, Jun 3, 2012 at 1:08 AM, Daniel Vetter wrote: On Fri, Apr 27, 2012 at 10:18:08PM +0200, Carsten Emde wrote: Depending upon how things are set up, this might help. Yeah, thanks a lot, works great now! I removed patch 3/4 and 4/4 and pushed th

Re: [Intel-gfx] [BUG] intel_drv.so fails to load

2012-07-19 Thread Adam Jackson
On 7/18/12 6:34 PM, Chris Wilson wrote: On Wed, 18 Jul 2012 15:47:44 -0400, Adam Jackson wrote: It's not clear to me if, subsequent to your change, DRI would work with NoAccel. It does. The mapping of the ring and control registers was already managed outside of the XAA specific routines, so

Re: [Intel-gfx] [PATCH v5] Support for ns2501-DVO

2012-07-19 Thread Daniel Vetter
On Thu, Jul 19, 2012 at 02:20:11PM +0200, Thomas Richter wrote: > Hi Daniel, > > >>As a side question, have you been able to look into the video > >>overlay hang I reported lately? I haven't > >>had the time yet to update the i915 driver from the latest > >>repository, but the version from three w

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Reject page flips with changed format/offset/pitch

2012-07-19 Thread Daniel Vetter
On Thu, Jul 19, 2012 at 02:27:47PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Thursday 05 July 2012 13:31:17 Daniel Vetter wrote: > > On Thu, May 24, 2012 at 09:08:59PM +0300, ville.syrj...@linux.intel.com > wrote: > > > From: Ville Syrjälä > > > > > > MI display flips can't handle some

[Intel-gfx] [PATCH] drm/i915: Use MLC (l3$) for context objects

2012-07-19 Thread Chris Wilson
Enabling context support increases SwapBuffers latency by about 20% (measured on an i7-3720qm). We can offset that loss slightly by enabling faster caching for the contexts. As they are not backed by any particular cache (such as the sampler or render caches) our only option is to select the generi

Re: [Intel-gfx] [PATCH v5] Support for ns2501-DVO

2012-07-19 Thread Daniel Vetter
On Thu, Jul 19, 2012 at 09:44:02AM +0200, Thomas Richter wrote: > Am 18.07.2012 19:59, schrieb Daniel Vetter: > > > >Patch queued for -next, with the whitespace fail fixed up - please consult > >Documentation/CodingStyle and scripts/checkpatch.pl for your next patch > >submission. > > > >I've also

Re: [Intel-gfx] [BUG] intel_drv.so fails to load

2012-07-19 Thread Knut Petersen
Am 18.07.2012 21:34, schrieb Adam Jackson: So, one difference between the driver you built and the driver in factory: http://download.opensuse.org/pub/opensuse/factory/repo/oss/suse/i586/xf86-video-intel-2.20.0-1.1.i586.rpm Is that yours has this, and theirs doesn't: hate:~% eu-readelf -a inte