Re: [Intel-gfx] [PATCH] drm/i915: don't forget the PCH backlight registers

2012-07-14 Thread Daniel Vetter
On Sat, Jul 14, 2012 at 11:57:12AM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > When we enable/disable the CPU backlight registers we can't forget to > enable/disable the PCH backlight registers. Since we're using the CPU > registers we should also unset the override bit. > > Fixes a regr

Re: [Intel-gfx] [PATCH] Revert "drm/i915: allow PCH PWM override on IVB"

2012-07-14 Thread Paulo Zanoni
Hi 2012/6/27 Daniel Vetter : > This reverts commit f82cfb6bcda164ef3a66b8c3fc549b1f9bdd09ad. > > This breaks the backlight controls on my IVB asus zenbook with an eDP > panel. > > I guess the right fix would be to read this bit and use either the pch > or the cpu register to frob the backlight val

[Intel-gfx] [PATCH] drm/i915: don't forget the PCH backlight registers

2012-07-14 Thread Paulo Zanoni
From: Paulo Zanoni When we enable/disable the CPU backlight registers we can't forget to enable/disable the PCH backlight registers. Since we're using the CPU registers we should also unset the override bit. Fixes a regression on the following commit: drm/i915: properly enable the blc controll

Re: [Intel-gfx] [PATCH 05/13] drm/i915: Insert a flush between batches if the breadcrumb was dropped

2012-07-14 Thread Daniel Vetter
On Fri, Jul 13, 2012 at 02:14:08PM +0100, Chris Wilson wrote: > If we drop the breadcrumb request after a batch due to a signal for > example we aim to fix it up at the next opportunity. In this case we > emit a second batchbuffer with no waits upon the first and so no > opportunity to insert the m

Re: [Intel-gfx] [PATCH 01/13] drm/i915: Flush the context object from the CPU caches upon creation

2012-07-14 Thread Daniel Vetter
On Sat, Jul 14, 2012 at 2:48 PM, Chris Wilson wrote: > On Sat, 14 Jul 2012 13:58:58 +0200, Daniel Vetter wrote: >> So afact this first patch here seems to add another instance of the very >> bug this patch series tries squash ... Additionally I'm still hunting for >> that other failure case, whic

Re: [Intel-gfx] [PATCH 01/13] drm/i915: Flush the context object from the CPU caches upon creation

2012-07-14 Thread Chris Wilson
On Sat, 14 Jul 2012 13:58:58 +0200, Daniel Vetter wrote: > So afact this first patch here seems to add another instance of the very > bug this patch series tries squash ... Additionally I'm still hunting for > that other failure case, which can't be fixed by adding the flush in > execbuffer if rin

Re: [Intel-gfx] [PATCH 01/13] drm/i915: Flush the context object from the CPU caches upon creation

2012-07-14 Thread Daniel Vetter
On Fri, Jul 13, 2012 at 02:14:04PM +0100, Chris Wilson wrote: > Signed-off-by: Chris Wilson > Cc: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_gem_context.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_context.c > b/dr

Re: [Intel-gfx] [PATCH 02/13] drm/i915: fix invalid reference handling of the default ctx obj

2012-07-14 Thread Daniel Vetter
On Sat, Jul 14, 2012 at 10:55:19AM +0100, Chris Wilson wrote: > On Fri, 13 Jul 2012 17:37:14 +0200, Daniel Vetter wrote: > > On Fri, Jul 13, 2012 at 02:14:05PM +0100, Chris Wilson wrote: > > > Otherwise we end up trying to unpin a freed object and BUG. > > > > > > Signed-off-by: Chris Wilson > >

Re: [Intel-gfx] [PATCH 05/13] drm/i915: Insert a flush between batches if the breadcrumb was dropped

2012-07-14 Thread Chris Wilson
On Fri, 13 Jul 2012 17:46:20 +0200, Daniel Vetter wrote: > On Fri, Jul 13, 2012 at 02:14:08PM +0100, Chris Wilson wrote: > > If we drop the breadcrumb request after a batch due to a signal for > > example we aim to fix it up at the next opportunity. In this case we > > emit a second batchbuffer wi

Re: [Intel-gfx] [PATCH 02/13] drm/i915: fix invalid reference handling of the default ctx obj

2012-07-14 Thread Chris Wilson
On Fri, 13 Jul 2012 17:37:14 +0200, Daniel Vetter wrote: > On Fri, Jul 13, 2012 at 02:14:05PM +0100, Chris Wilson wrote: > > Otherwise we end up trying to unpin a freed object and BUG. > > > > Signed-off-by: Chris Wilson > > Cc: Ben Widawsky > > Afact this patch contains quite some code refact

Re: [Intel-gfx] Panning broken in i915?

2012-07-14 Thread Felix Miata
On 2012/07/13 20:59 (GMT-0400) Felix Miata composed: I wouldn't ask here, except Bugzilla seems stuck on unreachable. Anyone know when it should be back online? Anyone know the status of panning? For me, mouse cannot move into the extended area, so only content can't go there, not my eyes. It'

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Replace the pending_gpu_write flag with an explicit seqno

2012-07-14 Thread Chris Wilson
On Fri, 13 Jul 2012 17:41:01 +0200, Daniel Vetter wrote: > On Fri, Jul 13, 2012 at 02:14:07PM +0100, Chris Wilson wrote: > > As we always flush the GPU cache prior to emitting the breadcrumb, we no > > longer have to worry about the deferred flush causing the > > pending_gpu_write to be delayed. S

Re: [Intel-gfx] [PATCH 01/13] drm/i915: Flush the context object from the CPU caches upon creation

2012-07-14 Thread Chris Wilson
On Fri, 13 Jul 2012 17:54:54 +0200, Daniel Vetter wrote: > I think only the first hunk should be part of this patch - the later two > hunks make more sense squashed together with the last patch. At least that > would avoid me going a bit wtf here and then again on the last patch where > the from_o

Re: [Intel-gfx] [Mesa-dev] [PATCH 0/5] First batch of gm45 clipping/interpolation fixes

2012-07-14 Thread Olivier Galibert
On Fri, Jul 13, 2012 at 02:45:10PM -0700, Kenneth Graunke wrote: > Sorry...been really busy, and most of us haven't actually spent much if > any time in the clipper shaders. I'll try and review it within a week. Ok cool, lack of time is something I completely understand :-) > Despite the lack o