[Intel-gfx] Valleyview: 3DSTATE_URB_VS Minimum URB Entries

2012-07-02 Thread Cheah, Douglas
Hello folks, I am seeing corruption when running spectex from mesa demos which looks like vertex being randomly clipped on Valleyview, however spectex works fine on Ivy Bridge. After tracing down the codes I realize that the current Mesa driver would program the maximum number or URB entries (

Re: [Intel-gfx] [PATCH 04/10] drm/i915: add RPS configuration for Haswell

2012-07-02 Thread Ben Widawsky
On Mon, 02 Jul 2012 17:02:59 -0300 Eugeni Dodonov wrote: > On 07/02/2012 02:49 PM, Ben Widawsky wrote: > > On Mon, 2 Jul 2012 11:51:05 -0300 > > Eugeni Dodonov wrote: > > > >> Most of the RPS and RC6 enabling functionality is similar to what we had > >> on Gen6/Gen7, so we preserve most of the

Re: [Intel-gfx] [PATCH 04/10] drm/i915: add RPS configuration for Haswell

2012-07-02 Thread Eugeni Dodonov
On 07/02/2012 02:49 PM, Ben Widawsky wrote: > On Mon, 2 Jul 2012 11:51:05 -0300 > Eugeni Dodonov wrote: > >> Most of the RPS and RC6 enabling functionality is similar to what we had >> on Gen6/Gen7, so we preserve most of the registers. >> >> Note that Haswell only has RC6, so account for that a

Re: [Intel-gfx] [libva] GPU hung

2012-07-02 Thread Christophe Oosterlynck
Hi, Is there any update on this issue or has a bug been reported? I seem to have a similar issue ("[drm:i915_hangcheck_hung] *ERROR* Hangcheck timer") when using vaapi with gstreamer. Best regards, Christophe ___ Intel-gfx mailing list Intel-gfx@lis

Re: [Intel-gfx] [PATCH 10/10] drm/i915: move force wake support into intel_pm

2012-07-02 Thread Ben Widawsky
On Mon, 2 Jul 2012 11:51:11 -0300 Eugeni Dodonov wrote: > This commit moves force wake support routines into intel_pm modules, and > exports the gen6_gt_check_fifodbg routine (used in I915_READ). > > Signed-off-by: Eugeni Dodonov I seem to recall Chris not liking this idea. Did I make that up

Re: [Intel-gfx] [PATCH 09/10] drm/i915: enable RC6 workaround on Haswell

2012-07-02 Thread Ben Widawsky
On Mon, 2 Jul 2012 11:51:10 -0300 Eugeni Dodonov wrote: > For Haswell, on some of the early hardware revisions, it is possible to > run into issues when RC6 state is enabled and when pipes change state. > > v2: add comment saying that this is for early revisions only. > > v3: beautify as sugge

Re: [Intel-gfx] [PATCH 08/10] drm/i915: introduce haswell_init_clock_gating

2012-07-02 Thread Ben Widawsky
On Mon, 2 Jul 2012 11:51:09 -0300 Eugeni Dodonov wrote: > This is based on Ivy Bridge clock gating for now, but is subject to > changes in the future. I am a fan of not including this until it's actually needed. I only took a peek, but I didn't see a need in the remaining patches. > > Signed-

Re: [Intel-gfx] [PATCH 07/10] drm/i915: disable RC6 when disabling rps

2012-07-02 Thread Ben Widawsky
On Mon, 2 Jul 2012 11:51:08 -0300 Eugeni Dodonov wrote: > We weren't disabling RC6 bits when bringing down RPS. > > Signed-off-by: Eugeni Dodonov Reviewed-by: Ben Widawsky > --- > drivers/gpu/drm/i915/intel_pm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/i

Re: [Intel-gfx] [PATCH 06/10] drm/i915: enable RC6 by default on Haswell

2012-07-02 Thread Ben Widawsky
On Mon, 2 Jul 2012 11:51:07 -0300 Eugeni Dodonov wrote: > It should be working so let's turn it on by default and catch any possible > issues faster. > > Signed-off-by: Eugeni Dodonov Reviewed-by: Ben Widawsky > --- > drivers/gpu/drm/i915/intel_pm.c | 6 -- > 1 file changed, 4 insertions

Re: [Intel-gfx] [PATCH] drm/i915: Disable LVDS while modesetting for HD+ panels

2012-07-02 Thread Takashi Iwai
At Mon, 2 Jul 2012 19:55:17 +0200, Daniel Vetter wrote: > > On Mon, Jul 2, 2012 at 7:51 PM, Takashi Iwai wrote: > > It's just for avoiding the possible regressions by this change. > > We definitely need a fix for HD+ panels ASAP, while other panels work > > in the current code. Introducing the e

Re: [Intel-gfx] [PATCH] drm/i915: Disable LVDS while modesetting for HD+ panels

2012-07-02 Thread Daniel Vetter
On Mon, Jul 2, 2012 at 7:51 PM, Takashi Iwai wrote: > It's just for avoiding the possible regressions by this change. > We definitely need a fix for HD+ panels ASAP, while other panels work > in the current code. Introducing the extra disable code affecting all > laptops sounds too risky for 3.5

Re: [Intel-gfx] [PATCH] drm/i915: Disable LVDS while modesetting for HD+ panels

2012-07-02 Thread Takashi Iwai
At Mon, 2 Jul 2012 18:53:29 +0200, Daniel Vetter wrote: > > On Mon, Jul 02, 2012 at 06:14:54PM +0200, Takashi Iwai wrote: > > Some SNB/IVY Laptops with 1600x900 HD+ panel (e.g. Dell Latitude E6420 > > and HP ProBook 65xx) are known to show the whole black/white garbage > > or flickering screens wh

Re: [Intel-gfx] [PATCH 05/10] drm/i915: slightly improve gt enable/disable routines

2012-07-02 Thread Ben Widawsky
On Mon, 2 Jul 2012 11:51:06 -0300 Eugeni Dodonov wrote: > Just a cosmetic change to simplify the if statement. > > Signed-off-by: Eugeni Dodonov Reviewed-by: Ben Widawsky > --- > drivers/gpu/drm/i915/intel_pm.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/d

Re: [Intel-gfx] [PATCH 04/10] drm/i915: add RPS configuration for Haswell

2012-07-02 Thread Ben Widawsky
On Mon, 2 Jul 2012 11:51:05 -0300 Eugeni Dodonov wrote: > Most of the RPS and RC6 enabling functionality is similar to what we had > on Gen6/Gen7, so we preserve most of the registers. > > Note that Haswell only has RC6, so account for that as well. As suggested > by Daniel Vetter, to reduce th

Re: [Intel-gfx] [PATCH] drm/i915: Disable LVDS while modesetting for HD+ panels

2012-07-02 Thread Daniel Vetter
On Mon, Jul 02, 2012 at 06:14:54PM +0200, Takashi Iwai wrote: > Some SNB/IVY Laptops with 1600x900 HD+ panel (e.g. Dell Latitude E6420 > and HP ProBook 65xx) are known to show the whole black/white garbage > or flickering screens while starting up or changing the mode. > This can be worked around b

Re: [Intel-gfx] [PATCH] drm/i915: fix up ilk rc6 disabling confusion

2012-07-02 Thread Daniel Vetter
On Mon, Jul 02, 2012 at 08:44:00AM -0700, Ben Widawsky wrote: > On Sun, 1 Jul 2012 12:48:59 +0200 > Daniel Vetter wrote: > > Hm, I don't see the comment you're talking about ... Neither > > ironlake_disable_rc6 nor ironlake_teardown_rc6 nor any of the callers > > have one. Or am I totally missing

Re: [Intel-gfx] [PATCH 03/10] drm/i915: support Haswell force waking

2012-07-02 Thread Ben Widawsky
On Mon, 2 Jul 2012 11:51:04 -0300 Eugeni Dodonov wrote: > There is a different ACK register for force wake on Haswell, so account > for that. Well I guess that HSW bit in patch 2 that I just acked didn't belong there yet ;-) Also, since you've now put conditional registers in get/put, why not

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't return a spurious -EIO from intel_ring_begin

2012-07-02 Thread Daniel Vetter
On Mon, Jul 02, 2012 at 09:04:48AM -0700, Ben Widawsky wrote: > On Sun, 1 Jul 2012 12:41:19 +0200 > Daniel Vetter wrote: > > > On Sun, Jul 1, 2012 at 5:09 AM, Ben Widawsky wrote: > > > On Tue, 26 Jun 2012 23:08:50 +0200 > > > Daniel Vetter wrote: > > > > > >> Having this early check in intel_ri

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Implement w/a for sporadic read failures on waking from rc6

2012-07-02 Thread Ben Widawsky
On Mon, 2 Jul 2012 11:51:03 -0300 Eugeni Dodonov wrote: > From: Chris Wilson > > As a w/a to prevent reads sporadically returning 0, we need to wait for > the GT thread to return to TC0 before proceeding to read the registers. > > v2: adapt for Haswell changes (Eugeni). > > v3: use wait_for_

Re: [Intel-gfx] [PATCH 01/10] drm/i915: Group the GT routines together in both code and vtable

2012-07-02 Thread Ben Widawsky
On Mon, 2 Jul 2012 11:51:02 -0300 Eugeni Dodonov wrote: > From: Chris Wilson > > Tidy up the routines for interacting with the GT (in particular the > forcewake dance) which are scattered throughout the code in a single > structure. > > v2: use wait_for_atomic for polling. > > v3: *really* u

[Intel-gfx] [PATCH] drm/i915: Disable LVDS while modesetting for HD+ panels

2012-07-02 Thread Takashi Iwai
Some SNB/IVY Laptops with 1600x900 HD+ panel (e.g. Dell Latitude E6420 and HP ProBook 65xx) are known to show the whole black/white garbage or flickering screens while starting up or changing the mode. This can be worked around by disabling LVDS off while changing the mode. Since this doesn't give

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't return a spurious -EIO from intel_ring_begin

2012-07-02 Thread Ben Widawsky
On Sun, 1 Jul 2012 12:41:19 +0200 Daniel Vetter wrote: > On Sun, Jul 1, 2012 at 5:09 AM, Ben Widawsky wrote: > > On Tue, 26 Jun 2012 23:08:50 +0200 > > Daniel Vetter wrote: > > > >> Having this early check in intel_ring_begin doesn't buy us anything, > >> since we'll be calling into wait_reques

Re: [Intel-gfx] [PATCH] drm/i915: fix up ilk rc6 disabling confusion

2012-07-02 Thread Ben Widawsky
On Sun, 1 Jul 2012 12:48:59 +0200 Daniel Vetter wrote: > On Sun, Jul 1, 2012 at 5:04 AM, Ben Widawsky wrote: > > On Fri, 29 Jun 2012 23:32:16 +0200 > > Daniel Vetter wrote: > > > >> While creating the new enable/disable_gt_powersave functions in > >> > >> commit 8090c6b9daa04dda649ac0a220960104

Re: [Intel-gfx] Trouble with dell latitude E6420

2012-07-02 Thread Giacomo Comes
On Mon, Jul 02, 2012 at 10:18:43AM +0200, Takashi Iwai wrote: > At Thu, 28 Jun 2012 14:23:04 -0400, > Giacomo Comes wrote: > > > > On Thu, Jun 28, 2012 at 07:52:18AM +0200, Takashi Iwai wrote: > > > At Tue, 26 Jun 2012 15:08:32 -0400, > > > Giacomo Comes wrote: > > > > > > > > I have a dell latit

[Intel-gfx] [PATCH 10/10] drm/i915: move force wake support into intel_pm

2012-07-02 Thread Eugeni Dodonov
This commit moves force wake support routines into intel_pm modules, and exports the gen6_gt_check_fifodbg routine (used in I915_READ). Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_drv.c | 191 --- drivers/gpu/drm/i915/intel_drv.h | 1 + driv

[Intel-gfx] [PATCH 09/10] drm/i915: enable RC6 workaround on Haswell

2012-07-02 Thread Eugeni Dodonov
For Haswell, on some of the early hardware revisions, it is possible to run into issues when RC6 state is enabled and when pipes change state. v2: add comment saying that this is for early revisions only. v3: beautify as suggested by Daniel Vetter. Signed-off-by: Eugeni Dodonov --- drivers/gpu

[Intel-gfx] [PATCH 08/10] drm/i915: introduce haswell_init_clock_gating

2012-07-02 Thread Eugeni Dodonov
This is based on Ivy Bridge clock gating for now, but is subject to changes in the future. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/intel_pm.c | 54 - 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_pm

[Intel-gfx] [PATCH 07/10] drm/i915: disable RC6 when disabling rps

2012-07-02 Thread Eugeni Dodonov
We weren't disabling RC6 bits when bringing down RPS. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/intel_pm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index b00df1f..5ea8319 100644 --- a/drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH 06/10] drm/i915: enable RC6 by default on Haswell

2012-07-02 Thread Eugeni Dodonov
It should be working so let's turn it on by default and catch any possible issues faster. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/intel_pm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH 05/10] drm/i915: slightly improve gt enable/disable routines

2012-07-02 Thread Eugeni Dodonov
Just a cosmetic change to simplify the if statement. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/intel_pm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index a3ee1b1..64cd97e 100644 --- a/d

[Intel-gfx] [PATCH 02/10] drm/i915: Implement w/a for sporadic read failures on waking from rc6

2012-07-02 Thread Eugeni Dodonov
From: Chris Wilson As a w/a to prevent reads sporadically returning 0, we need to wait for the GT thread to return to TC0 before proceeding to read the registers. v2: adapt for Haswell changes (Eugeni). v3: use wait_for_atomic_us for thread status polling. v3: *really* use wait_for_atomic for

[Intel-gfx] [PATCH 04/10] drm/i915: add RPS configuration for Haswell

2012-07-02 Thread Eugeni Dodonov
Most of the RPS and RC6 enabling functionality is similar to what we had on Gen6/Gen7, so we preserve most of the registers. Note that Haswell only has RC6, so account for that as well. As suggested by Daniel Vetter, to reduce the amount of changes in the patch, we still write the RC6p/RC6pp thres

[Intel-gfx] [PATCH 03/10] drm/i915: support Haswell force waking

2012-07-02 Thread Eugeni Dodonov
There is a different ACK register for force wake on Haswell, so account for that. Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_drv.c | 22 ++ drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 01/10] drm/i915: Group the GT routines together in both code and vtable

2012-07-02 Thread Eugeni Dodonov
From: Chris Wilson Tidy up the routines for interacting with the GT (in particular the forcewake dance) which are scattered throughout the code in a single structure. v2: use wait_for_atomic for polling. v3: *really* use wait_for_atomic for polling. Signed-off-by: Chris Wilson Signed-off-by:

[Intel-gfx] [PATCH 00/10] Haswell force wake/rps v3

2012-07-02 Thread Eugeni Dodonov
Hi, Addressing bike color suggestions in the previous series: - simplify RPS function to reduce the number of changes. With this, we still write the RC6p/RC6pp bits, but those should be ignored on Haswell and experimental results have demonstrated no issues with it so far. - *really* use t

Re: [Intel-gfx] Trouble with dell latitude E6420

2012-07-02 Thread Takashi Iwai
At Mon, 2 Jul 2012 11:51:46 +0200, Georg Grabler wrote: > > Hello, > > Not sure if it's of any help, but Thiago Macieira has the same model > as mine, but with a different panel (lower resolution, 1366x768), and > he never suffered of this problem. So far, so good. > What comes to my mind readi

Re: [Intel-gfx] Trouble with dell latitude E6420

2012-07-02 Thread Georg Grabler
Hello, Not sure if it's of any help, but Thiago Macieira has the same model as mine, but with a different panel (lower resolution, 1366x768), and he never suffered of this problem. What comes to my mind reading your message - why should dual channel on HD+ be treated differently than on panels wit

Re: [Intel-gfx] Trouble with dell latitude E6420

2012-07-02 Thread Takashi Iwai
At Mon, 2 Jul 2012 10:54:43 +0200, Georg Grabler wrote: > > I've had this problem with the e6420 on 1600x900. Applying your work > around fixed it for me. Though, kernel 3.5-rc4 fixes the problem "for > real" (it even fixes the default resolutions set when X comes up, > which did not work properly

Re: [Intel-gfx] Trouble with dell latitude E6420

2012-07-02 Thread Georg Grabler
I've had this problem with the e6420 on 1600x900. Applying your work around fixed it for me. Though, kernel 3.5-rc4 fixes the problem "for real" (it even fixes the default resolutions set when X comes up, which did not work properly before). I'm not aware of what this could cause to other resoluti

Re: [Intel-gfx] Trouble with dell latitude E6420

2012-07-02 Thread Takashi Iwai
At Thu, 28 Jun 2012 14:23:04 -0400, Giacomo Comes wrote: > > On Thu, Jun 28, 2012 at 07:52:18AM +0200, Takashi Iwai wrote: > > At Tue, 26 Jun 2012 15:08:32 -0400, > > Giacomo Comes wrote: > > > > > > I have a dell latitude E6420 with Sandybridge Mobile (GT2). > > > Since I got it (about one year