The updated work is below, rebased on top of dinq.
http://cgit.freedesktop.org/~bwidawsk/drm-intel/log/?h=wait_rendering
git://people.freedesktop.org/~bwidawsk/drm-intel wait_rendering
I'll resubmit the patches once we settle on the review comments from
patch 1.
Thanks Chris, and Daniel for the f
On Wed, 2 May 2012 23:47:35 +0200
Daniel Vetter wrote:
> On Mon, Apr 30, 2012 at 06:39:58PM -0700, Ben Widawsky wrote:
> > Insert a wait parameter in the code so we can possibly timeout on a
> > seqno wait if need be. The code should be functionally the same as
> > before because all the callers
Hi
This is an initial set of patches related to InfoFrames I developed.
They're based on a few bugs I can reproduce and also on the register
specifications. The first patch is candidate to stable, but patches 2,
3 and 4 could also be (they fix my system when I boot only with an
HDMI monitor and no
From: Paulo Zanoni
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_display.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index a2617b2..f807d36 100644
--- a/drivers/gpu/drm/i915/
From: Paulo Zanoni
1 - The registers are on the PCH, so don't use the Gen number
2 - IBX has a port select (like Gen 4, but ports are different)
3 - CPT needs a workaround when enabling the AVI Infoframe
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i915_reg.h |1 +
drivers/gpu/dr
From: Paulo Zanoni
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i915_reg.h |1 +
drivers/gpu/drm/i915/intel_hdmi.c |3 +++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index cc0b90c..6e03732 100644
--- a/drive
From: Paulo Zanoni
That's what the VIDEO_DIP_CTL documentation says we need to do. Except
when it's the AVI InfoFrame and we're ironlake_write_infoframe.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_hdmi.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/
From: Paulo Zanoni
This will allow us to disable an infoframe without changing its
frequency.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_hdmi.c | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdm
From: Paulo Zanoni
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i915_reg.h |1 +
drivers/gpu/drm/i915/intel_hdmi.c |1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 8da0b40..cc0b90c 100644
--- a/drivers
From: Paulo Zanoni
Make sure we're doing the right thing, just like we do on gen5+.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_hdmi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
b/drivers/gpu/drm/i915/intel_hdmi.c
in
From: Paulo Zanoni
Don't use intermediate variables, change the value of 'val' as we go
through the function. The new style looks more similar to the rest of
our code. IMHO, it's also easier to read and change.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_hdmi.c | 43 ++
From: Paulo Zanoni
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_hdmi.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
b/drivers/gpu/drm/i915/intel_hdmi.c
index 1eef50d..8646a50 100644
--- a/drivers/gpu/drm/i915/inte
From: Paulo Zanoni
intel_wait_for_vblank uses PIPESTAT, which does not exist on Ironlake
and newer.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_display.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
From: Paulo Zanoni
Gen3+ is 13 bits (12:0).
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i915_reg.h |3 ++-
drivers/gpu/drm/i915/intel_display.c | 11 ---
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/dr
From: Paulo Zanoni
While testing with the intel_infoframes tool on gen4, I see that when
video DIP is disabled, what we write to the DATA memory is not exactly
what we read back later. This should fix some problems that can be
bisected to "drm/i915: fix ILK+ infoframe support". That commit was
se
On Wed, 2 May 2012 13:18:56 -0700
Ben Widawsky wrote:
> On Wed, 2 May 2012 11:55:48 -0700
> Jesse Barnes wrote:
>
> > On Wed, 2 May 2012 08:44:27 -0700
> > Ben Widawsky wrote:
> >
> > > On Wed, 2 May 2012 11:06:23 +0200
> > > Daniel Vetter wrote:
> > >
> > > > Unfortunately it looks like f
On Wed, May 02, 2012 at 11:36:15PM +0200, Daniel Vetter wrote:
> On Wed, May 02, 2012 at 10:22:33PM +0100, Chris Wilson wrote:
> > On Wed, 2 May 2012 23:12:36 +0200, Daniel Vetter wrote:
> > > For consistency I guess we can ditch the dev parameter (and even then, the
> > > ring would uniquely iden
On Mon, Apr 30, 2012 at 06:39:58PM -0700, Ben Widawsky wrote:
> Insert a wait parameter in the code so we can possibly timeout on a
> seqno wait if need be. The code should be functionally the same as
> before because all the callers will continue to retry if an arbitrary
> timeout elapses.
>
> We
On Wed, May 02, 2012 at 10:22:33PM +0100, Chris Wilson wrote:
> On Wed, 2 May 2012 23:12:36 +0200, Daniel Vetter wrote:
> > For consistency I guess we can ditch the dev parameter (and even then, the
> > ring would uniquely identify the device). Also, I guess you need to
> > explicitly pass in bloc
On Mon, Apr 30, 2012 at 06:41:08PM -0700, Ben Widawsky wrote:
> This helps implement GL_ARB_sync put stops short of allowing full blow
> sync objects.
>
> Finally we can use the new timed seqno waiting function to allow
> userspace to wait on a request with a timeout. This implements that
> interf
On Wed, 2 May 2012 23:12:36 +0200, Daniel Vetter wrote:
> For consistency I guess we can ditch the dev parameter (and even then, the
> ring would uniquely identify the device). Also, I guess you need to
> explicitly pass in blocking, because mutex_is_locked is rather racy -
> someone else could ho
On Mon, Apr 30, 2012 at 06:40:23PM -0700, Ben Widawsky wrote:
> v2: Don't do a trace event per loop. (Chris)
> Only get blocking/non-blocking info (Chris)
>
> Signed-off-by: Ben Widawsky
> ---
> drivers/gpu/drm/i915/i915_trace.h | 22 --
> 1 file changed, 20 insertions(+),
On Sun, Apr 29, 2012 at 03:22:32PM -0700, Ben Widawsky wrote:
> Refactor.
>
> v2: Don't use seqno as an outparam (Chris)
>
> Signed-off-by: Ben Widawsky
Queued for -next (with some paint added), thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
___
On Fri, Apr 27, 2012 at 06:36:37PM +0100, Chris Wilson wrote:
> Currently we call gen6_enable_rps() (which writes into the per-ring
> register mmio space) from intel_modeset_init_hw() which is called before
> we initialise the rings. If we defer intel_modeset_init_hw() until
> afterwards (in the in
On Wed, 2 May 2012 13:14:59 -0700, Ben Widawsky wrote:
> On Wed, 2 May 2012 20:43:56 +0100
> Chris Wilson wrote:
When initialising the PLL registers we may have to clear existing state
from the BIOS - that is the PLL may already be enabled. So we need to
disable it, wait for the clocks to settl
On Wed, 2 May 2012 11:55:48 -0700
Jesse Barnes wrote:
> On Wed, 2 May 2012 08:44:27 -0700
> Ben Widawsky wrote:
>
> > On Wed, 2 May 2012 11:06:23 +0200
> > Daniel Vetter wrote:
> >
> > > Unfortunately it looks like further vlv patches are still stalled due
> > > to fried hw, and too many peo
On Wed, 2 May 2012 20:43:56 +0100
Chris Wilson wrote:
> Cc: Ben Widawsky
> Cc: Jesse Barnes
Reported-and-tested-by: Ben Widawsky
> ---
> drivers/gpu/drm/i915/intel_display.c |7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display
some minor update:
it looks like as soon as kms get's activated during boot there is no
picture anymore when the A/V-receiver is between PC and TV (or a
projector which I connected for testing but which has the same
behaviour...).
According to OSD of the projector the PC generates 1280x720 (which
Hi
I'm currently using the Intel Core i3 integrated graphics:
[ 68585.994] (II) intel(0): Integrated Graphics Chipset: Intel(R) Clarkdale
I'm running Debian wheezy and I have my system connected via HDMI to my
flatscreen TV. I'm using a resolution of 1280x720 and everything is
working fine:
On 05/02/2012 12:33 PM, Daniel Vetter wrote:
While trying to fix up gen4 gpu reset in
commit f49f0586191fe16140410db0a46d43bdc690d6af
Author: Kenneth Graunke
Date: Sat Sep 11 01:19:14 2010 -0700
drm/i915: Actually set the reset bit in i965_reset
a little confusion about when wait_for ti
On Wed, 2 May 2012 09:52:12 +0100
Chris Wilson wrote:
> Signed-off-by: Chris Wilson
> ---
> drivers/gpu/drm/i915/i915_irq.c | 31 ++-
> drivers/gpu/drm/i915/i915_reg.h |7 +--
> 2 files changed, 27 insertions(+), 11 deletions(-)
>
Highly embarrassing.
R
Cc: Ben Widawsky
Cc: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index d5aa2d2..b97112c 100644
--- a/drivers/gpu/drm/i915/intel_dis
While trying to fix up gen4 gpu reset in
commit f49f0586191fe16140410db0a46d43bdc690d6af
Author: Kenneth Graunke
Date: Sat Sep 11 01:19:14 2010 -0700
drm/i915: Actually set the reset bit in i965_reset
a little confusion about when wait_for times out has been introduced -
wait for loops _u
On Wed, 2 May 2012 08:44:27 -0700
Ben Widawsky wrote:
> On Wed, 2 May 2012 11:06:23 +0200
> Daniel Vetter wrote:
>
> > Unfortunately it looks like further vlv patches are still stalled due
> > to fried hw, and too many people are a bit annoyed about the unused
> > function warning.
>
> It is
On Wed, 2 May 2012 11:06:23 +0200
Daniel Vetter wrote:
> Unfortunately it looks like further vlv patches are still stalled due
> to fried hw, and too many people are a bit annoyed about the unused
> function warning.
It is my preference that you never merge code which you know will
produce a wa
On Fri, Apr 27, 2012 at 09:56:55PM -0700, Ben Widawsky wrote:
> On Fri, 27 Apr 2012 15:17:38 +0200
> Daniel Vetter wrote:
>
> > gpu reset is a very important piece of our infrastructure.
> > Unfortunately we only really it test by actually hanging the gpu,
> > which often has bad side-effects for
On Tue, May 01, 2012 at 07:45:02PM +0200, Daniel Vetter wrote:
> On Tue, May 01, 2012 at 07:58:27AM -0700, Jesse Barnes wrote:
> > On Mon, 30 Apr 2012 19:35:02 +0100
> > Chris Wilson wrote:
> >
> > > On SandyBridge IPS was entirely implemented in hardware and not reliant
> > > on the driver monit
On Wed, May 02, 2012 at 12:07:06PM +0100, Chris Wilson wrote:
> We only execute intel_decrease_pllclock for pre-PCH hardware, typically
> gen4 mobiles. However, in the variable declaration we did read from the
> non-PCH DPLL register, quite naughty and detected by SandyBridge.
>
> Reported-by: And
On Tue, Apr 24, 2012 at 06:53:39PM +0100, Chris Wilson wrote:
> We seem to trigger an occasional error when the GPU tries to dereference
> a PTE for an overlay plane prior to us populating the offsets in the
> overlay registers. This is despite the Overlay Command being set to off.
> Close this win
On Thu, Apr 26, 2012 at 11:28:00PM +0200, Daniel Vetter wrote:
> Hi all,
>
> Essentially just rebased on top of latest dinq. Happy bikeshedding!
I've queued up the entire patchs series for -next with Jesse's irc-ack
added.
-Daniel
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 4
We only execute intel_decrease_pllclock for pre-PCH hardware, typically
gen4 mobiles. However, in the variable declaration we did read from the
non-PCH DPLL register, quite naughty and detected by SandyBridge.
Reported-by: Andrey Rahmatullin
References: https://bugs.freedesktop.org/show_bug.cgi?i
Unfortunately it looks like further vlv patches are still stalled due
to fried hw, and too many people are a bit annoyed about the unused
function warning.
So let's just rip it out, we can easily put it back in again.
Cc: Jesse Barnes
Signed-Off-by: Daniel Vetter
---
drivers/gpu/drm/i915/intel
Reduce the number of reads and writes required for handling a single
interrupt.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_irq.c | 94 ---
1 file changed, 38 insertions(+), 56 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/driver
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_irq.c | 31 ++-
drivers/gpu/drm/i915/i915_reg.h |7 +--
2 files changed, 27 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 39c4e68.
44 matches
Mail list logo
