[Intel-gfx] Xorg 1.10.4 / Intel(R) G35 / purple 2 pixel vertical line after resume from S3 sleep

2012-04-22 Thread Marc MERLIN
Howdy, On my HTPC with integrated graphics (G35), when I resume from S3 sleep, even if I switched to text mode before (which I guess is irrelevant now that text mode is graphical with modprobe i915 modeset=1), most often I see a 2 pixel purple line on the left of my screen. I only seem to be abl

[Intel-gfx] Does intel GM35 support libva?

2012-04-22 Thread Marc MERLIN
Howdy, Xorg says: [ 36196.880] (II) Loading /usr/lib/xorg/modules/drivers/intel_drv.so [ 36196.880] drmOpenDevice: node name is /dev/dri/card0 [ 36196.880] drmOpenDevice: open result is 9, (OK) [ 36196.880] drmOpenByBusid: Searching for BusID pci::00:02.0 [ 36196.880] drmOpenDevice: node name

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Ben Widawsky
On Sun, 22 Apr 2012 18:39:23 +0100 Chris Wilson wrote: > On Sun, 22 Apr 2012 10:35:29 -0700, Ben Widawsky > wrote: > > On Sun, 22 Apr 2012 16:49:53 +0100 > > Chris Wilson wrote: > > > > > On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky > > > wrote: > > > > Chris' fix for my 32b breakage was

[Intel-gfx] [PATCH] drm/i915: i8xx interrupt handler

2012-04-22 Thread Chris Wilson
gen2 hardware has some significant differences from the other interrupt routines that were glossed over and then forgotten about in the transition to KMS. Such as - 16bit IIR - PendingFlip status bit This patch reintroduces a handler specifically for gen2 for the purpose of handling pageflips cor

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Ben Widawsky
Google fail.  I'd like to go back to my 32b machine and try to reproduce this.   your patch seems fine to me though.  Original message Subject: Re: [PATCH] drm/i915: rc6 residency (fix the fix) From: Chris Wilson To: Ben Widawsky CC: intel-gfx@lists.freedesktop.org,Ben Widaw

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Chris Wilson
On Sun, 22 Apr 2012 11:02:32 -0700, Ben Widawsky wrote: > Does div_round64 work for you? I think that is the best solution. Only exists in drivers/cpuidle/governors/menu.c, and still would need a do_div to avoid the subsequent 64-bit division. The choice appears to be either perform the divide b

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Ben Widawsky
On Sun, 22 Apr 2012 18:39:23 +0100 Chris Wilson wrote: > On Sun, 22 Apr 2012 10:35:29 -0700, Ben Widawsky > wrote: > > On Sun, 22 Apr 2012 16:49:53 +0100 > > Chris Wilson wrote: > > > > > On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky > > > wrote: > > > > Chris' fix for my 32b breakage was

Re: [Intel-gfx] [PATCH 03/10] drm/i915: kill waiting_seqno

2012-04-22 Thread Ben Widawsky
On Sun, 22 Apr 2012 14:46:05 +0100 Chris Wilson wrote: > On Fri, 20 Apr 2012 18:23:25 -0700, Ben Widawsky > wrote: > > diff --git a/drivers/gpu/drm/i915/i915_irq.c > > b/drivers/gpu/drm/i915/i915_irq.c index cf0e9f0..52eb9ed 100644 > > --- a/drivers/gpu/drm/i915/i915_irq.c > > +++ b/drivers/gpu/

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Chris Wilson
On Sun, 22 Apr 2012 10:35:29 -0700, Ben Widawsky wrote: > On Sun, 22 Apr 2012 16:49:53 +0100 > Chris Wilson wrote: > > > On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky > > wrote: > > > Chris' fix for my 32b breakage was incorrect. do_div returns a > > > remainder. Go back to a divide macro wh

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Ben Widawsky
On Sun, 22 Apr 2012 16:49:53 +0100 Chris Wilson wrote: > On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky > wrote: > > Chris' fix for my 32b breakage was incorrect. do_div returns a > > remainder. Go back to a divide macro which is more 32b friendly. > > > > Tested on x86-64. > > > > This has

Re: [Intel-gfx] [PATCH] drm/i915: rc6 residency (fix the fix)

2012-04-22 Thread Chris Wilson
On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky wrote: > Chris' fix for my 32b breakage was incorrect. do_div returns a > remainder. Go back to a divide macro which is more 32b friendly. > > Tested on x86-64. > > This has only been compile tested on 32b systems. Doesn't compile on my 32-bit sys

Re: [Intel-gfx] [PATCH 06/10] drm/i915: use __wait_seqno for ring throttle

2012-04-22 Thread Chris Wilson
On Fri, 20 Apr 2012 18:23:28 -0700, Ben Widawsky wrote: > It turns out throttle had an almost identical bit of code to do the > wait. Now we can call the new helper directly. This is just a bonus, > and not needed for the overall series. If you defer this patch to later in the series you can si

Re: [Intel-gfx] [PATCH 09/10] drm/i915: wait render timeout ioctl

2012-04-22 Thread Chris Wilson
On Fri, 20 Apr 2012 18:23:31 -0700, Ben Widawsky wrote: > +out: > + args->timeout_ns = timeout * 1000; Multiple paths reach this point and a single one converted timeout to microseconds. -Chris -- Chris Wilson, Intel Open Source Technology Centre _

Re: [Intel-gfx] [PATCH 03/10] drm/i915: kill waiting_seqno

2012-04-22 Thread Chris Wilson
On Fri, 20 Apr 2012 18:23:25 -0700, Ben Widawsky wrote: > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index cf0e9f0..52eb9ed 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1846,11 +1846,9 @@ static bool i915_hangche

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Only the zap the VMA after updating the tiling parameters

2012-04-22 Thread Daniel Vetter
On Sat, Apr 21, 2012 at 04:23:24PM +0100, Chris Wilson wrote: > If we fail to unbind and so abort the change in tiling, we will have > removed the VMA for the object for no reason. The likelihood of unbind > failing is slim (other than ERESTARTSYS which will cause userspace to > try again), so the

Re: [Intel-gfx] [PATCH 07/10] drm/i915: timeout parameter for seqno wait

2012-04-22 Thread Daniel Vetter
On Fri, Apr 20, 2012 at 06:23:29PM -0700, Ben Widawsky wrote: > Insert a wait parameter in the code so we can possibly timeout on a > seqno wait if need be. The code should be functionally the same as > before because all the callers will continue to retry if an arbitrary > timeout elapses. > > Si

Re: [Intel-gfx] [PATCH 09/10] drm/i915: wait render timeout ioctl

2012-04-22 Thread Daniel Vetter
On Fri, Apr 20, 2012 at 06:23:31PM -0700, Ben Widawsky wrote: > Finally we can use the new timed seqno waiting function to allow > userspace to wait on a request with a timeout. This implements that > interface. > > The new ioctl is very straight forward, there is a flags field which I > envision

Re: [Intel-gfx] [PATCH 09/10] drm/i915: wait render timeout ioctl

2012-04-22 Thread Daniel Vetter
On Sun, Apr 22, 2012 at 10:48:01AM +0100, Chris Wilson wrote: > On Fri, 20 Apr 2012 18:23:31 -0700, Ben Widawsky wrote: > > +int > > +i915_gem_wait_ioctl(struct drm_device *dev, void *data, struct drm_file > > *file) > > +{ > > + struct drm_i915_gem_wait *args = data; > > + struct drm_i915_ge

Re: [Intel-gfx] [PATCH 09/10] drm/i915: wait render timeout ioctl

2012-04-22 Thread Chris Wilson
On Fri, 20 Apr 2012 18:23:31 -0700, Ben Widawsky wrote: > +int > +i915_gem_wait_ioctl(struct drm_device *dev, void *data, struct drm_file > *file) > +{ > + struct drm_i915_gem_wait *args = data; > + struct drm_i915_gem_object *obj; > + struct intel_ring_buffer *ring; > + long time

Re: [Intel-gfx] [PATCH 09/10] drm/i915: wait render timeout ioctl

2012-04-22 Thread Chris Wilson
On Sat, 21 Apr 2012 09:12:17 -0700, Ben Widawsky wrote: > On Sat, 21 Apr 2012 10:41:55 +0100 > Chris Wilson wrote: > > I think this whole interface is a stop-gap solution for pollable sync > > objects without a clear use case. Do we have a spec for a feature > > wishing to build upon this interfa

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fixup load-detect on enabled, but not active pipe

2012-04-22 Thread Daniel Vetter
On Fri, Apr 20, 2012 at 08:44:59PM +0100, Chris Wilson wrote: > On Fri, 20 Apr 2012 21:03:36 +0200, Daniel Vetter > wrote: > > Somehow we have a fast-path that tries to avoid going through > > the load-detect code when the encode already has a crtc associated. > > But this fails horribly when the

Re: [Intel-gfx] [PATCH] drm/i915: re-add static qualifier to get_cxsr_latency

2012-04-22 Thread Daniel Vetter
On Sat, Apr 21, 2012 at 07:43:40PM -0300, Eugeni Dodonov wrote: > On Sat, Apr 21, 2012 at 18:17, Daniel Vetter wrote: > > > This got lost in the intel_pm.c move. > > > > Signed-off-by: Daniel Vetter > > > > Yes, thanks for catching this! Patch is queued for -next. -Daniel -- Daniel Vetter Mai