Re: [Intel-gfx] [PATCH 1/2] drm/i915: Pull MTRR setup to its own function

2012-03-15 Thread Kenneth Graunke
On 03/14/2012 08:22 AM, Adam Jackson wrote: No functional change here, just clarifying code flow. Signed-off-by: Adam Jackson Reviewed-by: Kenneth Graunke I'm not qualified to review patch 2, though from the little I know it sounds like a good idea.

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-15 Thread Takashi Iwai
At Thu, 15 Mar 2012 14:30:35 +0100, Takashi Iwai wrote: > > At Thu, 15 Mar 2012 13:25:08 +, > Chris Wilson wrote: > > > > On Thu, 15 Mar 2012 14:15:54 +0100, Takashi Iwai wrote: > > > +static bool is_dual_link_lvds(struct drm_i915_private *dev_priv) > > > +{ > > > + /* BIOS should set the pr

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-15 Thread Takashi Iwai
At Thu, 15 Mar 2012 13:25:08 +, Chris Wilson wrote: > > On Thu, 15 Mar 2012 14:15:54 +0100, Takashi Iwai wrote: > > +static bool is_dual_link_lvds(struct drm_i915_private *dev_priv) > > +{ > > + /* BIOS should set the proper LVDS register value at boot, but > > +* in reality, it doesn't

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-15 Thread Chris Wilson
On Thu, 15 Mar 2012 14:15:54 +0100, Takashi Iwai wrote: > +static bool is_dual_link_lvds(struct drm_i915_private *dev_priv) > +{ > + /* BIOS should set the proper LVDS register value at boot, but > + * in reality, it doesn't set the value when the lid is closed; > + * thus when a mac

Re: [Intel-gfx] [PATCH] xf86-video-intel: Add support for toshiba backlight interface

2012-03-15 Thread Akio Idehara
Seth Forshee wrote: > On Wed, Mar 14, 2012 at 11:37:39PM +0900, Akio Idehara wrote: >> xfce4-power-manager cannot control backlight brightness via >> toshiba backlight sysfs interface. >> The reason is that xf86-video-intel doesn't treat it. >> This patch adds support for toshiba backlight sysfs i

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-15 Thread Takashi Iwai
At Wed, 14 Mar 2012 14:09:19 -0400, Adam Jackson wrote: > > On Wed, 2012-03-14 at 17:44 +0100, Takashi Iwai wrote: > > At Wed, 14 Mar 2012 10:45:06 -0400, > > Adam Jackson wrote: > > > There may or may not be a bit for this in the VBT in the BIOS. But the > > > more reliably correct thing I suspe