Re: [Intel-gfx] [PATCH] drm/i915: paper over missed irq issues with force wake vodoo

2012-01-14 Thread Keith Packard
On Sat, 14 Jan 2012 13:12:07 +0100, Daniel Vetter wrote: > I think that race is air-tight with your patch to rework the reset code > already. But better safe than sorry. And as I've said a good cleanup > anyway. Sounds good. I like clearer code, especially when it doesn't cost performance. I thi

[Intel-gfx] [PATCH] drm/i915: paper over missed irq issues with force wake voodoo

2012-01-14 Thread Daniel Vetter
Two things seem to do the trick on my ivb machine here: - prevent the gt from powering down while waiting for seqno notification interrupts by grabbing the force_wake in get_irq (and dropping it in put_irq again). - ordering writes from the ring's CS by reading a CS register, ACTHD seems to w

[Intel-gfx] [PATCH 2/2] drm/i915: allow interlaced mode output on the SDVO connector

2012-01-14 Thread Peter Ross
Signed-off-by: Peter Ross --- drivers/gpu/drm/i915/intel_sdvo.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index f7b9268..03a84f8 100644 --- a/drivers/gpu/drm/i915/intel_sdvo.c +++ b/drivers/gpu/

[Intel-gfx] [PATCH 1/2] drm/i915: specify vertical timings in frame units for interlaced modes (gen4+)

2012-01-14 Thread Peter Ross
The G35/G45/SandyBridge chipsets expect vertical timings in frame units, whereas the DRM subsystem uses field units internally for interlaced modes. Signed-off-by: Peter Ross --- drivers/gpu/drm/i915/intel_display.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/

[Intel-gfx] [PATCH 0/2] drm/i915: interlaced mode support (G35 VGA/SDVO)

2012-01-14 Thread Peter Ross
This patch set enables enables interlaced mode output on the VGA and SDVO connectors of the G35 chipset. History here: https://bugs.freedesktop.org/show_bug.cgi?id=11220 I have tested the changes on an ASUS P5E-VM-HDMI mainboard with VGA and HDMI CRTs attached. The G45 and SB documentation sugges

Re: [Intel-gfx] [PATCH] drm/i915: paper over missed irq issues with force wake vodoo

2012-01-14 Thread Daniel Vetter
On Fri, Jan 13, 2012 at 04:50:39PM -0800, Keith Packard wrote: > On Sat, 14 Jan 2012 01:31:40 +0100, Daniel Vetter wrote: > > On Fri, Jan 13, 2012 at 04:11:43PM -0800, Keith Packard wrote: > > > On Sat, 14 Jan 2012 00:52:31 +0100, Daniel Vetter wrote: > > > > acc101d drm/i915: Hold gt_lock across

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add branch/sink OUI debugging

2012-01-14 Thread Julien Cristau
On Fri, Jan 13, 2012 at 13:26:08 -0500, Adam Jackson wrote: > DisplayPort lets you discover the manufacturer OUI of the other end. > This is good, because it means you might be able to have per-phy quirks > to work around other people's bugs, but it's bad because it removes some > incentive to not