Re: [Intel-gfx] IVB fixes and 3 pipe support

2011-10-19 Thread Eugeni Dodonov
On Wed, Oct 19, 2011 at 13:12, Jesse Barnes wrote: > Latest patches; Eugeni can you reply with your tested-by? I think > they're all ready for upstream. > For the series: Tested-By: Eugeni Dodonov Reviewed-By: Eugeni Dodonov There three reproducible issues I found out, but they were present

Re: [Intel-gfx] [PATCH 1/6] drm/i915: hangcheck robustification

2011-10-19 Thread Chris Wilson
On Wed, 19 Oct 2011 08:02:57 -0700, Ben Widawsky wrote: > On Wed, 19 Oct 2011 12:32:25 +0100 > Chris Wilson wrote: > > NAK: This failed to detect a hang, leaving my box frozen. I suspect that > > the value of INSTDONE was fluctuating on the render ring even though we > > had now requests pending

[Intel-gfx] [PATCH 10/14] drm/i915: fix transcoder PLL select masking

2011-10-19 Thread Jesse Barnes
Transcoder A will always use PLL A and transcoder B will use PLL B. But transcoder C could use either, so always mask the select bits off before or'ing in a new value. Reported-by: Adam Jackson Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c | 15 ++- 1 files

[Intel-gfx] [PATCH 13/14] drm/i915: if transcoder disable fails, say which

2011-10-19 Thread Jesse Barnes
Just some extra debug output. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 2c30e36..c95ac7f 100644 --- a/drivers/gp

[Intel-gfx] [PATCH 12/14] drm/i915: set watermarks for third pipe on IVB

2011-10-19 Thread Jesse Barnes
The watermark reg for the third pipe is in an unusual offset; add support for it and set watermarks for 3 pipe configs. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_reg.h |1 + drivers/gpu/drm/i915/intel_display.c | 14 ++ 2 files changed, 15 insertions(+), 0

[Intel-gfx] [PATCH 11/14] drm/i915: export a CPT mode set verification function

2011-10-19 Thread Jesse Barnes
At the point where we check, we can't do much about the failure, but it can aid debugging. Note that the auto-train override bit will be reset as part of normal mode setting with this patch if a pipe ever does get stuck, but that's consistent with the workaround for CPT provided by the hardware te

[Intel-gfx] [PATCH 14/14] drm/i915: remove transcoder PLL mashing from mode_set per specs

2011-10-19 Thread Jesse Barnes
Belongs in PCH enable instead. The duplication is worrying and the specs explicitly list transcoder select *after* actual PLL enable, which doesn't occur until later. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c | 25 - 1 files changed, 0 insert

Re: [Intel-gfx] Where is SDVO mode setting code in kernel module sources?

2011-10-19 Thread 4ernov
2011/10/19 Adam Jackson : > On Wed, 2011-10-19 at 18:43 +0400, 4ernov wrote: > >> And is it guessed somewhere in case of VBT missing? > > Well, not yet, no.  Like I said, there's no code at all yet for tweaking > SDVO LVDS. OK, it's clear for me now. But is there any right place where I can hardco

[Intel-gfx] [PATCH 07/14] drm/i915: add PLL sharing support to handle 3 pipes

2011-10-19 Thread Jesse Barnes
Add two new fields to the intel_crtc struct for 3 pipe support: no_pll and use_pll_a. The no_pll field is only set on the 3rd pipe to indicate that it doesn't have a PLL of its own and so shouldn't try to write the main PLL regs. The use_pll_a field controls which PLL pipe 3 will share, A or B.

[Intel-gfx] [PATCH 09/14] drm/i915: fix IVB cursor support

2011-10-19 Thread Jesse Barnes
The cursor regs have moved around, add the offsets and new macros for getting at them. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_reg.h |8 ++ drivers/gpu/drm/i915/intel_display.c | 40 + 2 files changed, 43 insertions(+), 5 deletions

[Intel-gfx] [PATCH 08/14] drm/i915: fix debug output for 3 pipe configs

2011-10-19 Thread Jesse Barnes
We can have more than just A and B these days. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 347a949..0e556e7 100644

[Intel-gfx] [PATCH 06/14] drm/i915: always set FDI composite sync bit

2011-10-19 Thread Jesse Barnes
On IVB with CPT or PPT PCH chips, FDI sync can be done with one or two wires depending on the board configuration. For 3 pipe configurations, since FDI B and C share lanes, composite sync must be used. The board design specs require that composite sync always work in general too, so just use it b

[Intel-gfx] [PATCH 05/14] drm/i915: fix PCH PLL assertion check for 3 pipes

2011-10-19 Thread Jesse Barnes
Add a couple of checks now that we're using the 3rd transcoder: 1) make sure the transcoder PLL enable bit is set for the transcoder in question 2) when checking actual PLL enable, use the selected PLL number rather than the transcoder number (they could be different now) Signed-off-

[Intel-gfx] [PATCH 02/14] drm/i915: support 3 pipes on IVB+

2011-10-19 Thread Jesse Barnes
Well almost anyway. IVB has 3 planes, pipes, transcoders, and FDI interfaces, but only 2 pipe PLLs. So two of the pipes must use the same pipe timings (e.g. 2 DP plus one other, or two HDMI with the same mode and one other, etc.). Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_dma.c

[Intel-gfx] [PATCH 04/14] drm/i915: use transcoder select bits on VGA and HDMI on CPT

2011-10-19 Thread Jesse Barnes
Required for 3 pipe functionality. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_crt.c | 18 +++--- drivers/gpu/drm/i915/intel_hdmi.c | 10 -- 2 files changed, 11 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm

[Intel-gfx] [PATCH 01/14] drm/i915: PLL macro cleanup and pipe assertion check

2011-10-19 Thread Jesse Barnes
Add a macro for accessing the two pipe PLLs and add a check to make sure we don't access a non-existent one in the enable/disable functions. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_reg.h |6 +++--- drivers/gpu/drm/i915/intel_display.c |6 ++ 2 files changed, 9

[Intel-gfx] [PATCH 03/14] drm/i915: split refclk code out of ironlake_crtc_mode_set

2011-10-19 Thread Jesse Barnes
Just a cleanup to make the mode_set function more manageable. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c | 45 ++--- 1 files changed, 35 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i9

[Intel-gfx] IVB fixes and 3 pipe support

2011-10-19 Thread Jesse Barnes
Latest patches; Eugeni can you reply with your tested-by? I think they're all ready for upstream. Thanks, Jesse ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/6] drm/i915: hangcheck robustification

2011-10-19 Thread Ben Widawsky
On Wed, 19 Oct 2011 12:32:25 +0100 Chris Wilson wrote: > On Tue, 11 Oct 2011 16:39:09 +0200, Daniel Vetter > wrote: > > From: Ben Widawsky > > > > This was pulled out of the per ring error handling patch series as it > > actually fixes two issues, and bikeshedding appears to be going on > > t

Re: [Intel-gfx] Where is SDVO mode setting code in kernel module sources?

2011-10-19 Thread Adam Jackson
On Wed, 2011-10-19 at 18:43 +0400, 4ernov wrote: > And is it guessed somewhere in case of VBT missing? Well, not yet, no. Like I said, there's no code at all yet for tweaking SDVO LVDS. > In my case there's > no OpRegion support (i945GME chipset don't support it as mainboard > manufacturer info

Re: [Intel-gfx] Where is SDVO mode setting code in kernel module sources?

2011-10-19 Thread 4ernov
2011/10/19 Adam Jackson : > On Wed, 2011-10-19 at 17:48 +0400, 4ernov wrote: > >> Thanks, Adam. But is there any pipe setup part specific for certain >> output? I need to find a place where converter is set to use 24 or 18 >> bit LVDS mode. I examined intel_sdvo.c quite long but still cannot >> fin

Re: [Intel-gfx] Where is SDVO mode setting code in kernel module sources?

2011-10-19 Thread Adam Jackson
On Wed, 2011-10-19 at 17:48 +0400, 4ernov wrote: > Thanks, Adam. But is there any pipe setup part specific for certain > output? I need to find a place where converter is set to use 24 or 18 > bit LVDS mode. I examined intel_sdvo.c quite long but still cannot > find what I want. We don't appear t

Re: [Intel-gfx] Where is SDVO mode setting code in kernel module sources?

2011-10-19 Thread 4ernov
2011/10/19 Adam Jackson : > On Wed, 2011-10-19 at 13:08 +0400, 4ernov wrote: >> Hello, >> >> I'm experimenting with i915 kernel module to fix the problem with >> different brightness of LVDS displays when connected together via >> Chrontel SDVO converters. My biggest problem is that I simply >> can

Re: [Intel-gfx] Where is SDVO mode setting code in kernel module sources?

2011-10-19 Thread Adam Jackson
On Wed, 2011-10-19 at 13:08 +0400, 4ernov wrote: > Hello, > > I'm experimenting with i915 kernel module to fix the problem with > different brightness of LVDS displays when connected together via > Chrontel SDVO converters. My biggest problem is that I simply > can't find the place in code where t

Re: [Intel-gfx] [PATCH 1/6] drm/i915: hangcheck robustification

2011-10-19 Thread Chris Wilson
On Tue, 11 Oct 2011 16:39:09 +0200, Daniel Vetter wrote: > From: Ben Widawsky > > This was pulled out of the per ring error handling patch series as it > actually fixes two issues, and bikeshedding appears to be going on > there. > > First, remove setting hangcheck_count when we do notify ring

[Intel-gfx] Where is SDVO mode setting code in kernel module sources?

2011-10-19 Thread 4ernov
Hello, I'm experimenting with i915 kernel module to fix the problem with different brightness of LVDS displays when connected together via Chrontel SDVO converters. My biggest problem is that I simply can't find the place in code where the mode is set. I seem to find the place where the device is