[Intel-gfx] [PATCH 9/9] drm/i915: Initialize PCH refclks at modeset init time

2011-09-28 Thread Keith Packard
The reference clock configuration must be done before any mode setting can occur as all outputs must be disabled to change anything. Initialize the clocks after turning everything off during the initialization process. Also, re-initialize the refclk at resume time. Signed-off-by: Keith Packard -

Re: [Intel-gfx] PCH reference clock cleanups

2011-09-28 Thread Keith Packard
On Wed, 28 Sep 2011 15:22:48 -0300, Paulo Zanoni wrote: > I also tested the patch you sent today 1 hour ago (inline in one of > the emails) and things still work with it. I'll keep using these > patches since they fix my laptop. Any problem will be reported. Thanks. I think we're failing to rese

Re: [Intel-gfx] PCH reference clock cleanups

2011-09-28 Thread Paulo Zanoni
2011/9/27 Keith Packard : > Here's a patch sequence which cleans up a bunch of PCH refclk related > bits. For the series: Tested-by: Paulo Zanoni Tested all the patches on Ironlake (LVDS + VGA). Fixes fd.o bug #38750 for me. I also tested the patch you sent today 1 hour ago (inline in one of th

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Fix PCH SSC reference clock settings

2011-09-28 Thread Keith Packard
On Wed, 28 Sep 2011 10:09:13 +0100, Chris Wilson wrote: > My understanding was that we could not enable SSC at all if we had a VGA, > DVI/HDMI or TV output; DP may or may not work with SSC. Yeah, which makes no sense at all. If this were true, we'd have to turn off the LVDS/eDP panel whenever e

Re: [Intel-gfx] [PATCH 2/2] drm/i915: properly prefault for pread/pwrite

2011-09-28 Thread Chris Wilson
On Wed, 28 Sep 2011 11:57:24 +0200, Daniel Vetter wrote: > The helper functions used are designed for pagecache io and splice, > i.e. they prefault at most PAGE_SIZE bytes spanning at most 2 pages. > > pread/pwrite want to write/read much more to avoid dropping the > struct_mutex lock in between

[Intel-gfx] [PATCH 2/2] drm/i915: properly prefault for pread/pwrite

2011-09-28 Thread Daniel Vetter
The helper functions used are designed for pagecache io and splice, i.e. they prefault at most PAGE_SIZE bytes spanning at most 2 pages. pread/pwrite want to write/read much more to avoid dropping the struct_mutex lock in between. So write our helper function to prefault. We're the only user of th

[Intel-gfx] [PATCH 1/2] io-mapping: ensure io_mapping_map_atomic _is_ atomic

2011-09-28 Thread Daniel Vetter
For the !HAVE_ATOMIC_IOMAP case the stub functions did not call pagefault_disable/_enable. The i915 driver relies on the map actually being atomic, otherwise it can deadlock with it's own pagefault handler in the gtt pwrite fastpath. This is exercised by gem_mmap_gtt from the intel-gpu-toosl gem t

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Fix PCH SSC reference clock settings

2011-09-28 Thread Chris Wilson
On Tue, 27 Sep 2011 11:03:43 -0700, Keith Packard wrote: Non-text part: multipart/signed > On Tue, 27 Sep 2011 17:47:10 +0100, Chris Wilson > wrote: > > On Mon, 26 Sep 2011 23:11:43 -0700, Keith Packard wrote: > > > The PCH refclk settings are global, so we need to look at all of the > > > enco

Re: [Intel-gfx] [PATCH] drm/i915: kicking rings considered harmful

2011-09-28 Thread Daniel Vetter
On Wed, Sep 28, 2011 at 09:47:58AM +0100, Chris Wilson wrote: > On Tue, 27 Sep 2011 18:34:31 -0700, Ben Widawsky wrote: > > I'd definitely be in favo(u)r of removing the kick_ring() if it isn't really > > useful anymore. It has some forcewake race if I remember correctly which I > > never bothered

Re: [Intel-gfx] [PATCH] drm/i915: kicking rings considered harmful

2011-09-28 Thread Chris Wilson
On Tue, 27 Sep 2011 18:34:31 -0700, Ben Widawsky wrote: > I'd definitely be in favo(u)r of removing the kick_ring() if it isn't really > useful anymore. It has some forcewake race if I remember correctly which I > never bothered to fix. Agreed, enough brutality, kill the kick_ring! -Chris -- Ch