Re: [Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

2011-09-02 Thread Eric Anholt
On Thu, 1 Sep 2011 20:55:35 -0700, Ben Widawsky wrote: > While I think the previous code is correct, it was hard to follow and > hard to debug. Since we already have a ring abstraction, might as well > use it to handle the semaphore updates and compares. > > I don't expect this code to make sema

Re: [Intel-gfx] [PATCH] drm/i915: Separate fence pin counting from normal bind pin counting

2011-09-02 Thread Eugeni Dodonov
On 06/06/2011 03:10 AM, Chris Wilson wrote: In order to correctly account for reserving space in the GTT and fences for a batch buffer, we need to independently track whether the fence is pinned due to a fenced GPU access in the batch from from whether the buffer is pinned in the aperture. Curren

[Intel-gfx] Tearing video with Sandy Bridge

2011-09-02 Thread tino . keitel+xorg
Hi, I upgraded from a computer with i945 to a Sandy Bridge box with a i5-2400 CPU. Whereas the video tearing issue with XV output seemed to be solved with the i945 graphics, I now have heavy tearing again. I tried both mplayer -vo xv and mplayer -vo vaapi. I also upgraded to Mesa 7.11, Xserver 1.

Re: [Intel-gfx] [PATCH] drm/i915: small semaphore fix

2011-09-02 Thread Ben Widawsky
On Fri, Sep 02, 2011 at 09:56:31AM +0100, Chris Wilson wrote: > On Thu, 1 Sep 2011 19:51:11 -0700, Ben Widawsky wrote: > > On Thu, 01 Sep 2011 11:03:07 -0700 > > Eric Anholt wrote: > > > > > On Wed, 31 Aug 2011 12:47:22 -0700, Ben Widawsky > > > wrote: > > > > Assertion + unsigned helps catch p

Re: [Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

2011-09-02 Thread Ben Widawsky
On Fri, Sep 02, 2011 at 09:54:32AM +0100, Chris Wilson wrote: > On Thu, 1 Sep 2011 20:55:35 -0700, Ben Widawsky wrote: > > While I think the previous code is correct, it was hard to follow and > > hard to debug. Since we already have a ring abstraction, might as well > > use it to handle the sema

Re: [Intel-gfx] [PATCH] drm/i915: small semaphore fix

2011-09-02 Thread Chris Wilson
On Thu, 1 Sep 2011 19:51:11 -0700, Ben Widawsky wrote: > On Thu, 01 Sep 2011 11:03:07 -0700 > Eric Anholt wrote: > > > On Wed, 31 Aug 2011 12:47:22 -0700, Ben Widawsky > > wrote: > > > Assertion + unsigned helps catch potential issues. > > > > > > From the docs it is hard to tell if the global

Re: [Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

2011-09-02 Thread Chris Wilson
On Thu, 1 Sep 2011 20:55:35 -0700, Ben Widawsky wrote: > While I think the previous code is correct, it was hard to follow and > hard to debug. Since we already have a ring abstraction, might as well > use it to handle the semaphore updates and compares. > > I don't expect this code to make sema

Re: [Intel-gfx] [PATCH v4] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-02 Thread Wu Fengguang
Keith: this version completes the IvyBridge support :) Bossart: hotplug is working fine now, with some minor issues: - on G45, monitor hot removal is not handled at all in i915_driver_irq_handler(). I'll leave it as a future TODO. - on IvyBridge, _repeated_ plug/unplug will trigger [ 1183.6

[Intel-gfx] [PATCH v4] drm/i915: pass ELD to HDMI/DP audio driver

2011-09-02 Thread Wu Fengguang
Add ELD support for Intel Eaglelake, IbexPeak/Ironlake, SandyBridge/CougarPoint and IvyBridge/PantherPoint chips. ELD (EDID-Like Data) describes to the HDMI/DP audio driver the audio capabilities of the plugged monitor. It's built and passed to audio driver in 2 steps: (1) at get_modes time, pars