[Intel-gfx] [PATCH] drm/i915: Dumb down the semaphore logic

2011-09-01 Thread Ben Widawsky
While I think the previous code is correct, it was hard to follow and hard to debug. Since we already have a ring abstraction, might as well use it to handle the semaphore updates and compares. I don't expect this code to make semaphores better or worse, but you never know... Cc: Andrew Lutomirsk

Re: [Intel-gfx] [PATCH] drm/i915: small semaphore fix

2011-09-01 Thread Ben Widawsky
On Thu, 01 Sep 2011 11:03:07 -0700 Eric Anholt wrote: > On Wed, 31 Aug 2011 12:47:22 -0700, Ben Widawsky > wrote: > > Assertion + unsigned helps catch potential issues. > > > > From the docs it is hard to tell if the global GTT flag is actually > > needed, but it shouldn't hurt. > > We're upda

Re: [Intel-gfx] [PATCH] drm/i915: small semaphore fix

2011-09-01 Thread Eric Anholt
On Wed, 31 Aug 2011 12:47:22 -0700, Ben Widawsky wrote: > Assertion + unsigned helps catch potential issues. > > From the docs it is hard to tell if the global GTT flag is actually > needed, but it shouldn't hurt. We're updating a register, not the GTT, so I don't see why the flag would be relev

Re: [Intel-gfx] Repeated xorg crashes with intel driver

2011-09-01 Thread Eugeni Dodonov
On Wed, Aug 31, 2011 at 23:33, Marc MERLIN wrote: > I sure can, but I'm confused, doesn't the X log already contain a backtrace > that I already pasted? > > Will gdb bt give a different backtrace that what I already posted? > It would say in which source files and functions, and at what line of