Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Jesse Barnes
On Mon, 20 Dec 2010 22:55:46 -0500 Andrew Lutomirski wrote: > On Mon, Dec 20, 2010 at 10:47 PM, Keith Packard wrote: > > On Mon, 20 Dec 2010 22:34:12 -0500, Andrew Lutomirski wrote: > > > >> But five seconds is a *long* time, and anything short enough that the > >> interrupt actually gets turne

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andrew Lutomirski
On Mon, Dec 20, 2010 at 10:47 PM, Keith Packard wrote: > On Mon, 20 Dec 2010 22:34:12 -0500, Andrew Lutomirski wrote: > >> But five seconds is a *long* time, and anything short enough that the >> interrupt actually gets turned off in normal use risks the same race. > > Right, so eliminating any r

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Keith Packard
On Mon, 20 Dec 2010 22:34:12 -0500, Andrew Lutomirski wrote: > But five seconds is a *long* time, and anything short enough that the > interrupt actually gets turned off in normal use risks the same race. Right, so eliminating any race seems like the basic requirement. Can that be done? -- kei

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andrew Lutomirski
On Mon, Dec 20, 2010 at 10:23 PM, Keith Packard wrote: > On Mon, 20 Dec 2010 14:00:54 -0500, Andy Lutomirski wrote: > >> Enabling and disabling the vblank interrupt (on devices that >> support it) is cheap.  So disable it quickly after each >> interrupt. > > So, the concern (and reason for the or

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Keith Packard
On Mon, 20 Dec 2010 14:00:54 -0500, Andy Lutomirski wrote: > Enabling and disabling the vblank interrupt (on devices that > support it) is cheap. So disable it quickly after each > interrupt. So, the concern (and reason for the original design) was that you might lose count of vblank interrupts

Re: [Intel-gfx] [PATCH] drm/i915: no LVDS on Intel SandyBridge SDVs

2010-12-20 Thread Jesse Barnes
On Tue, 21 Dec 2010 12:43:38 +1000 Dave Airlie wrote: > On Tue, Dec 21, 2010 at 6:05 AM, Jesse Barnes > wrote: > > Add a DMI match entry for the SDV to indicate it has no LVDS present. > > Sounds wrong, generally the SDVs can get an LVDS panel plugged into > them, so they have an LVDS connecto

Re: [Intel-gfx] [PATCH] drm/i915: no LVDS on Intel SandyBridge SDVs

2010-12-20 Thread Dave Airlie
On Tue, Dec 21, 2010 at 6:05 AM, Jesse Barnes wrote: > Add a DMI match entry for the SDV to indicate it has no LVDS present. Sounds wrong, generally the SDVs can get an LVDS panel plugged into them, so they have an LVDS connector. I'd worry that this would break something upstream that isn't an

[Intel-gfx] [PATCH] drm/i915, intel_ips: When i915 loads after IPS, make IPS relink to i915.

2010-12-20 Thread Eric Anholt
The IPS driver is designed to be able to run detached from i915 and just not enable GPU turbo in that case, in order to avoid module dependencies between the two drivers. This means that we don't know what the load order between the two is going to be, and we had previously only supported IPS afte

Re: [Intel-gfx] [PATCH] drm/i915: no LVDS on Intel SandyBridge SDVs

2010-12-20 Thread Chris Wilson
On Mon, 20 Dec 2010 12:05:40 -0800, Jesse Barnes wrote: > Add a DMI match entry for the SDV to indicate it has no LVDS present. > > Signed-off-by: Jesse Barnes https://bugzilla.kernel.org/show_bug.cgi?id=22042 Caveat tester. -Chris -- Chris Wilson, Intel Open Source Technology Centre __

[Intel-gfx] [PATCH] drm/i915: no LVDS on Intel SandyBridge SDVs

2010-12-20 Thread Jesse Barnes
Add a DMI match entry for the SDV to indicate it has no LVDS present. Signed-off-by: Jesse Barnes diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c index aa23070..2f383f0 100644 --- a/drivers/gpu/drm/i915/intel_lvds.c +++ b/drivers/gpu/drm/i915/intel_lvds.c @@ -

[Intel-gfx] [PATCH] drm/i915: support overclocking on Sandy Bridge

2010-12-20 Thread Jesse Barnes
In some configuration, the PCU may allow us to overclock the GPU. Check for this case and adjust the max frequency as appropriate. Also initialize the min/max frequencies to default values as indicated by hardware. Signed-off-by: Jesse Barnes diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drive

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andy Lutomirski
Enabling and disabling the vblank interrupt (on devices that support it) is cheap. So disable it quickly after each interrupt. To avoid constantly enabling and disabling vblank when animations are running, after a predefined number (3) of consecutive enabled vblanks that someone cared about, just