Re: [Intel-gfx] [PATCH 15/15] drm/i915: no more agp for gem

2010-11-06 Thread Chris Wilson
Woohoo, we kill agp_memory. I'm in favour! Do we need to keep the sg_table around, or can we just temporary allocate it? This fits nicely into my plans, i915_gem_gtt.c has been a candidate to eliminate a few of the more expensive agp routines. Thanks, I'll look more closely at the series next wee

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Apply B-spec mandated workaround for read flushes on Ironlake.

2010-11-06 Thread Chris Wilson
On Sat, 6 Nov 2010 14:53:32 -0700, Eric Anholt wrote: > This is not known to fix any particular bugs we have, but the spec > says to do it, and the BIOS hadn't already set it up on my system. Whilst you haven't directly identified any bug caused by these two, adhering to the spec sounds like a s

[Intel-gfx] [PATCH 1/2] drm/i915: Apply B-spec mandated workaround for read flushes on Ironlake.

2010-11-06 Thread Eric Anholt
This is not known to fix any particular bugs we have, but the spec says to do it, and the BIOS hadn't already set it up on my system. Signed-off-by: Eric Anholt --- drivers/gpu/drm/i915/i915_reg.h | 13 + drivers/gpu/drm/i915/intel_display.c |6 ++ 2 files changed, 19

[Intel-gfx] [PATCH 2/2] drm/i915: Apply display workaround required according to the B-Spec.

2010-11-06 Thread Eric Anholt
Not known to fix any current bugs. Signed-off-by: Eric Anholt --- drivers/gpu/drm/i915/i915_reg.h |2 ++ drivers/gpu/drm/i915/intel_display.c |4 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h ind

[Intel-gfx] [PATCH 15/15] drm/i915: no more agp for gem

2010-11-06 Thread Daniel Vetter
Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h |9 +++-- drivers/gpu/drm/i915/i915_gem_gtt.c | 63 -- 2 files changed, 50 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h inde

[Intel-gfx] [PATCH 13/15] drm/i915: move gtt handling to i915_gem_gtt.c

2010-11-06 Thread Daniel Vetter
No more drm_*_agp in i915_gem.c! Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h |2 ++ drivers/gpu/drm/i915/i915_gem.c | 14 +++--- drivers/gpu/drm/i915/i915_gem_gtt.c | 28 3 files changed, 33 insertions(+), 11 deletions(-)

[Intel-gfx] [PATCH 14/15] intel-gtt: export api for drm/i915

2010-11-06 Thread Daniel Vetter
Just some minor shuffling to get rid of any agp traces in the exported functions. Signed-off-by: Daniel Vetter --- drivers/char/agp/intel-gtt.c | 120 -- include/drm/intel-gtt.h | 12 2 files changed, 80 insertions(+), 52 deletions(-) diff --

[Intel-gfx] [PATCH 11/15] drm/i915: restore gtt on resume in the drm instead of in intel-gtt.ko

2010-11-06 Thread Daniel Vetter
This still uses the agp functions to actually reinstate the mappings (with a gross hack to make agp cooperate), but it wires everything up correctly for the switchover. The call to agp_rebind_memory can be dropped because all non-kms drivers do all their rebinding on EnterVT. v2: Be more paranoid

[Intel-gfx] [PATCH 12/15] agp: kill agp_rebind_memory

2010-11-06 Thread Daniel Vetter
Its only user, intel-gtt.c is now gone. Cc: Dave Airlie Signed-off-by: Daniel Vetter --- drivers/char/agp/generic.c | 20 include/linux/agp_backend.h |1 - 2 files changed, 0 insertions(+), 21 deletions(-) diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/g

[Intel-gfx] [PATCH 09/15] agp: kill agp_flush_chipset and corresponding ioctl

2010-11-06 Thread Daniel Vetter
The intel drm calls the chipset functions now directly. Userspace never called the corresponding ioctl, hence it can be killed, too. Cc: Dave Airlie Signed-off-by: Daniel Vetter --- drivers/char/agp/agp.h |1 - drivers/char/agp/compat_ioctl.c |1 - drivers/char/agp/compat_ioctl

[Intel-gfx] [PATCH 10/15] drm/i915: track objects in the gtt

2010-11-06 Thread Daniel Vetter
This is required to restore gtt mappings on resume when agp is gone. The right way to do this would be to make sturct drm_mm_node embeddable and use the allocation list maintained by the drm memory manager. But that's a bigger project. Getting rid of the per bo agp_mem will save more memory than t

[Intel-gfx] [PATCH 07/15] drm/i915/gtt: call chipset flush directly

2010-11-06 Thread Daniel Vetter
Signed-off-by: Daniel Vetter --- drivers/char/agp/intel-gtt.c|7 +++ drivers/gpu/drm/i915/i915_gem.c |9 - include/drm/intel-gtt.h |2 +- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c

[Intel-gfx] [PATCH 08/15] drm: kill drm_agp_chipset_flush

2010-11-06 Thread Daniel Vetter
No longer used. Cc: Dave Airlie Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_agpsupport.c |6 -- include/drm/drmP.h |1 - 2 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agpsupport.c index 25

[Intel-gfx] [PATCH 05/15] intel-gtt: fold i81x-only dcache support into the generic driver

2010-11-06 Thread Daniel Vetter
Now the intel-gtt.c rewrite is complete! Signed-off-by: Daniel Vetter --- drivers/char/agp/intel-gtt.c | 150 +- 1 files changed, 61 insertions(+), 89 deletions(-) diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c index 8fff75a..f6

[Intel-gfx] [PATCH 06/15] drm/i915|intel-gtt: consolidate intel-gtt.h headers

2010-11-06 Thread Daniel Vetter
... and a few other defines. Signed-off-by: Daniel Vetter --- drivers/char/agp/intel-gtt.c|5 - drivers/gpu/drm/i915/i915_gem.c |1 - include/drm/intel-gtt.h | 12 include/linux/intel-gtt.h | 20 4 files changed, 12 insertions(+

[Intel-gfx] [PATCH 04/15] intel-gtt: switch i81x to the common initialization helpers

2010-11-06 Thread Daniel Vetter
Still a separate agp_bridge_driver because of the i81x-only dedicated vram support. Signed-off-by: Daniel Vetter --- drivers/char/agp/intel-gtt.c | 197 +++--- 1 files changed, 71 insertions(+), 126 deletions(-) diff --git a/drivers/char/agp/intel-gtt.c b/dr

[Intel-gfx] [PATCH 03/15] intel-gtt: switch i81x to the write_entry helpers

2010-11-06 Thread Daniel Vetter
Initialization is still done with the old code with a few added things sprinkled in to make the intel_fake_agp helper functions work. Signed-off-by: Daniel Vetter --- drivers/char/agp/intel-gtt.c | 152 +- 1 files changed, 60 insertions(+), 92 deletions(-

[Intel-gfx] [PATCH 02/15] intel-gtt: kill unneeded sandybridge memory types

2010-11-06 Thread Daniel Vetter
Used for the now dead agp type_to_mask stuff. Signed-off-by: Daniel Vetter --- drivers/char/agp/intel-gtt.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c index 8122aca..b677713 100644 --- a/drivers/char/a

[Intel-gfx] [PATCH 01/15] intel-gtt: drop dcache support for i830 and later

2010-11-06 Thread Daniel Vetter
i830_check_flags already disallows it, so no need to implement it in the write_entry function. Seems to be a remnant from i810 support. Signed-off-by: Daniel Vetter --- drivers/char/agp/intel-gtt.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/char/agp/i

[Intel-gfx] [PATCH 00/15] The "no more agp" series

2010-11-06 Thread Daniel Vetter
Hi all, The first few patches are a bunch of leftover cleanups from the intel-gtt rewrite in .36. Tested on my i815, i855, i945 and ironlake. Some items still on my todo-list for the gtt: - Embed drm_mm_node. - Kill /dev/agpgart for kms-only chips. Requires some small rework of the init sequen

Re: [Intel-gfx] [ANNOUNCE] xf86-video-intel snapshot: 2.13.901

2010-11-06 Thread Damnshock
On Saturday 06 November 2010 07:14:03 Arkadiusz Miskiewicz wrote: > AFAIK unreleased libdrm is required but someone forgot to release it and > bump dependency in intel driver configure Thanks, the problem seemed familiar ;) I'll try to update and check again! Regards ___

[Intel-gfx] [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits

2010-11-06 Thread Peter Clifton
Fixes corruption with glBufferSubData on my machine, Can someone review and push? (Resent with code comment fixed) -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in

[Intel-gfx] [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits

2010-11-06 Thread Peter Clifton
Fixes corruption with glBufferSubData on my machine, Can someone review and push? -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328

Re: [Intel-gfx] [ANNOUNCE] xf86-video-intel snapshot: 2.13.901

2010-11-06 Thread Clemens Eisserer
> AFAIK unreleased libdrm is required but someone forgot to release it and bump > dependency in intel driver configure. Seems to happen reliably every release ;) - Clemens ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedeskt

Re: [Intel-gfx] Increased latency from removal of GEM_THROTTLE in 2D driver

2010-11-06 Thread Chris Wilson
On Sat, 06 Nov 2010 01:44:59 +, Peter Clifton wrote: > Presumably this says something bad about my app, or its benchmarking > code. Any clues as to what that is? > > Without the commit, I can use other X11 apps whilst my PCB program is > benchmarking. With it, the X11 server graphics almost c