Re: [Intel-gfx] [PATCH] drm/i915: fix hibernation since 4bdadb9785696439c6e2b3efe34aa76df1149c83

2010-07-01 Thread Linus Torvalds
On Thu, Jul 1, 2010 at 5:37 PM, Greg KH wrote: > > This should go into .33 and .34-stable trees, right? Yup. I added a "cc: stable" to the patch, and it's now commit 985b823b919 in my tree, you'll see it when I push it out along with the other dri updates. Linus ___

Re: [Intel-gfx] [PATCH] drm/i915: Selectively enable self-reclaim

2010-07-01 Thread Linus Torvalds
On Thu, Jul 1, 2010 at 5:49 PM, Dave Airlie wrote: > > RECLAIMABLE added also seems fine, of course you can't have > RECLAIMABLE and MOVABLE (I find this out when it oopses on boot). Yes. They are both flags for the anti-fragmentation code, and I think I'll leave the decision as to whether the i9

Re: [Intel-gfx] [PATCH] drm/i915: Selectively enable self-reclaim

2010-07-01 Thread Dave Airlie
On Fri, Jul 2, 2010 at 10:06 AM, Dave Airlie wrote: > On Fri, Jul 2, 2010 at 9:59 AM, Linus Torvalds > wrote: >> On Thu, Jul 1, 2010 at 3:34 PM, M. Vefa Bicakci >> wrote: >>> >>> Based on my testing, I am happy to report that the change you suggest >>> fixes the "memory corruption (segfaults) a

Re: [Intel-gfx] [PATCH] drm/i915: fix hibernation since 4bdadb9785696439c6e2b3efe34aa76df1149c83

2010-07-01 Thread Greg KH
On Fri, Jul 02, 2010 at 10:04:42AM +1000, Dave Airlie wrote: > From: Linus Torvalds > > Since 4bdadb9785696439c6e2b3efe34aa76df1149c83, we've been passing > GFP_MOVABLE where we weren't before caused hibernate on Intel hardware > to results in a lot of memory corruptions on resume. > > [airlied:

Re: [Intel-gfx] [PATCH] drm/i915: Selectively enable self-reclaim

2010-07-01 Thread Dave Airlie
On Fri, Jul 2, 2010 at 9:59 AM, Linus Torvalds wrote: > On Thu, Jul 1, 2010 at 3:34 PM, M. Vefa Bicakci > wrote: >> >> Based on my testing, I am happy to report that the change you suggest >> fixes the "memory corruption (segfaults) after thaw" issue for me. >> I can't thank you enough times for

[Intel-gfx] [PATCH] drm/i915: fix hibernation since 4bdadb9785696439c6e2b3efe34aa76df1149c83

2010-07-01 Thread Dave Airlie
From: Linus Torvalds Since 4bdadb9785696439c6e2b3efe34aa76df1149c83, we've been passing GFP_MOVABLE where we weren't before caused hibernate on Intel hardware to results in a lot of memory corruptions on resume. [airlied: linus please enhance commit msg if you commit this] http://bugzilla.kerne

Re: [Intel-gfx] [PATCH] drm/i915: Selectively enable self-reclaim

2010-07-01 Thread Linus Torvalds
On Thu, Jul 1, 2010 at 3:34 PM, M. Vefa Bicakci wrote: > > Based on my testing, I am happy to report that the change you suggest > fixes the "memory corruption (segfaults) after thaw" issue for me. > I can't thank you enough times for this. Hey, goodie. And you're the one to be thanked - bisectin

[Intel-gfx] [PATCH 3/3] drm/i915: add tracepoints for flip requests & completions

2010-07-01 Thread Jesse Barnes
Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_trace.h| 36 ++ drivers/gpu/drm/i915/intel_display.c |5 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h

[Intel-gfx] [PATCH 2/3] drm: add per-event vblank event trace points

2010-07-01 Thread Jesse Barnes
Allows us to track each process that requests and completes events. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_irq.c |8 ++ drivers/gpu/drm/drm_trace.h | 57 -- include/drm/drmP.h |2 + 3 files changed, 53 insertions(+), 1

[Intel-gfx] [PATCH 1/3] drm: add vblank event trace point

2010-07-01 Thread Jesse Barnes
Emit a trace point for vblank events. This can be helpful for mapping drawing activity against the vblank frequency and period. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/Makefile |5 +++- drivers/gpu/drm/drm_irq.c |3 ++ drivers/gpu/drm/drm_trace.h| 37

Re: [Intel-gfx] [PATCH] drm/i915: don't queue flips during a flip pending event

2010-07-01 Thread Jesse Barnes
On Thu, 01 Jul 2010 16:09:00 -0700 Eric Anholt wrote: > On Mon, 3 May 2010 12:40:30 -0700, Jesse Barnes > wrote: > > On Thu, 29 Apr 2010 15:52:36 -0700 > > Eric Anholt wrote: > > > > + if (intel_crtc->plane) > > > > + flip_mask = > > > > I915_DISPLAY_PLANE_B_FLIP_PENDING_IN

Re: [Intel-gfx] [PATCH] drm/i915: don't queue flips during a flip pending event

2010-07-01 Thread Eric Anholt
On Mon, 3 May 2010 12:40:30 -0700, Jesse Barnes wrote: > On Thu, 29 Apr 2010 15:52:36 -0700 > Eric Anholt wrote: > > > + if (intel_crtc->plane) > > > + flip_mask = > > > I915_DISPLAY_PLANE_B_FLIP_PENDING_INTERRUPT; > > > + else > > > + flip_mask = > > > I915_DISPLAY_PLANE_A_FLIP_

Re: [Intel-gfx] [PATCH] drm/i915: change default panel fitting mode to preserve aspect ratio

2010-07-01 Thread Eric Anholt
On Thu, 24 Jun 2010 11:05:10 -0700, Jesse Barnes wrote: > We did this a long time ago in the DDX driver, but now this fix belongs > in the kernel. > > Preserving the aspect ratio is a nicer default. > > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=18033. > > Tested-by: Josh Triplett > S

Re: [Intel-gfx] [PATCH] drm/i915: Explosion following OOM in do_execbuffer.

2010-07-01 Thread Eric Anholt
On Wed, 9 Jun 2010 17:04:24 +0100, Chris Wilson wrote: > Oops, when merging the extra details following an OOM, I missed that > driver_private is now NULL and the correct way to convert from the > drm_gem_object into the drm_i915_gem_object is to use to_intel_bo(). > > BUG: unable to handle ker

Re: [Intel-gfx] [PATCH] gpu/drm/i915: Add a blacklist to omit modeset on LID open

2010-07-01 Thread Eric Anholt
On Wed, 9 Jun 2010 21:40:54 +0200, Thomas Bächler wrote: > On some machines (currently only the Toshiba Tecra A11 is known), the GPU > locks up when modeset is forced on LID open. This patch adds a new DMI > blacklist and omits modesetting for all matches. > > Fixes https://bugzilla.kernel.org/s

Re: [Intel-gfx] [PATCH] i915: Fix CRT hotplug regression in 2.6.35-rc1

2010-07-01 Thread Eric Anholt
On Sat, 12 Jun 2010 05:21:18 -0400, Andy Lutomirski wrote: > Commit 7a772c492fcfffae812ffca78a628e76fa57fe58 has two bugs which > made the hotplug problems on my laptop worse instead of better. > > First, it did not, in fact, disable the CRT plug interrupt -- it > disabled all the other hotplug i

Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup (v4)

2010-07-01 Thread Eric Anholt
On Wed, 30 Jun 2010 11:46:17 +1000, Dave Airlie wrote: > From: Dave Airlie > > The eDP spec claims a 20% overhead for the 8:10 encoding scheme used on the > wire. Take this into account when picking the lane/clock speed for the panel. > > v3: some panels are out of spec, try our best to deal w

Re: [Intel-gfx] [PATCH] drm/i915: don't access FW_BLC_SELF on 965G

2010-07-01 Thread Eric Anholt
On Wed, 30 Jun 2010 13:49:37 -0700, Jesse Barnes wrote: > The register offset for FW_BLC_SELF is a totally different set of bits > on Broadwater (it's actually MI_RDRET_STATE), so don't treat it like > FW_BLC_SELF on 965G chips. > > Fixes bug https://bugs.freedesktop.org/show_bug.cgi?id=26874. >

Re: [Intel-gfx] [PATCH] drm/i915: Account for space on the ring buffer consumed whilst wrapping.

2010-07-01 Thread Eric Anholt
On Thu, 1 Jul 2010 17:53:00 +0100, Chris Wilson wrote: > If we fill the tail of the physical ring buffer with NOOP when wrapping, > we need to account for the reduction in available space. > > Signed-off-by: Chris Wilson Applied to for-linus. Thanks! pgpeu7qPDQI2l.pgp Description: PGP sign

Re: [Intel-gfx] [ANNOUNCE] xf86-video-intel 2.11.901

2010-07-01 Thread Jesse Barnes
On Thu, 1 Jul 2010 16:55:47 -0400 Andrew Lutomirski wrote: > [Dave, cc-ing you because your vt panic patch is involved.] > > On Wed, Jun 23, 2010 at 12:07 PM, Jesse Barnes > wrote: > > On Mon, 21 Jun 2010 16:32:48 -0400 > > Andrew Lutomirski wrote: > > > >> On Sun, Jun 20, 2010 at 11:29 AM, A

Re: [Intel-gfx] [PATCH] i915: Fix CRT hotplug regression in 2.6.35-rc1

2010-07-01 Thread Andrew Lutomirski
On Mon, Jun 28, 2010 at 7:48 PM, Dave Airlie wrote: > On Sat, Jun 12, 2010 at 7:21 PM, Andy Lutomirski wrote: >> Commit 7a772c492fcfffae812ffca78a628e76fa57fe58 has two bugs which >> made the hotplug problems on my laptop worse instead of better. >> >> First, it did not, in fact, disable the CRT

Re: [Intel-gfx] [PATCH 1/2] [RFC] drm/i915: Restore LRU evict order, with a twist!

2010-07-01 Thread Chris Wilson
On Thu, 01 Jul 2010 12:49:33 -0700, Eric Anholt wrote: > On Thu, 1 Jul 2010 17:53:44 +0100, Chris Wilson > wrote: > > +static int > > +i915_gem_eviction_roster_add(struct i915_gem_eviction_roster *roster, > > +struct drm_i915_gem_object *obj_priv) > > +{ > > This functi

Re: [Intel-gfx] [PATCH 1/2] [RFC] drm/i915: Restore LRU evict order, with a twist!

2010-07-01 Thread Eric Anholt
On Thu, 1 Jul 2010 17:53:44 +0100, Chris Wilson wrote: > When we need to clear some space in the GTT in order to pin a new > buffer, scan through the inactive list amalgamating objects in LRU order > until we find a large enough contiguous space to fit the new buffer. > > Doing throughput testi

Re: [Intel-gfx] implement 'wait' instruction

2010-07-01 Thread Eric Anholt
On Tue, 29 Jun 2010 11:04:09 +0800, Zhenyu Wang wrote: > > 'Wait' instruction allows EU to stop and wait notification > register state clear to continue the execution. And we can > clear the notifications through MMIO, so we can track EU > execution step by step. > > I use below patch for implem

Re: [Intel-gfx] System freeze with 2.12 + 2.6.34

2010-07-01 Thread Jesse Barnes
On Thu, 01 Jul 2010 17:34:12 +0200 Stephan Raue wrote: > Am 01.07.2010 16:55, schrieb Clemens Eisserer: > > Hi, > > > > During the 2.6.11.901 testing phase a few people reported system freezes. > > What was the result of that discussion? > > > > I still experience those freezes with kernel-2.6.34

Re: [Intel-gfx] [Mesa3d-dev] mesa doesn't work with compiz (i965 + tips of all branches)

2010-07-01 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Note: I'm sending this reply to mesa-...@lists.freedesktop.org instead of the old mailing list. Maxim Levitsky wrote: > On Tue, 2010-06-29 at 15:49 -0700, Ian Romanick wrote: > Corbin Simpson wrote: Curious. Admittedly I can't look at the content

[Intel-gfx] [PATCH 2/2] drm/i915: Maintain LRU order of inactive objects upon access by CPU

2010-07-01 Thread Chris Wilson
In order to reduce the penalty of fallbacks under memory pressure and to avoid a potential immediate ping-pong of evicting a mmaped buffer, we move the object to the tail of the inactive list when a page is freshly faulted or the object is moved into the CPU domain. We choose not to protect the CP

[Intel-gfx] [PATCH 1/2] [RFC] drm/i915: Restore LRU evict order, with a twist!

2010-07-01 Thread Chris Wilson
When we need to clear some space in the GTT in order to pin a new buffer, scan through the inactive list amalgamating objects in LRU order until we find a large enough contiguous space to fit the new buffer. Doing throughput testing on a PineView machine with cairo-perf-trace indicates that there

[Intel-gfx] [PATCH] drm/i915: Account for space on the ring buffer consumed whilst wrapping.

2010-07-01 Thread Chris Wilson
If we fill the tail of the physical ring buffer with NOOP when wrapping, we need to account for the reduction in available space. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/

Re: [Intel-gfx] System freeze with 2.12 + 2.6.34

2010-07-01 Thread Stephan Raue
Am 01.07.2010 16:55, schrieb Clemens Eisserer: Hi, During the 2.6.11.901 testing phase a few people reported system freezes. What was the result of that discussion? I still experience those freezes with kernel-2.6.34 + intel 2.12, quite frequently when watching high resolution flash videos. An

Re: [Intel-gfx] System freeze with 2.12 + 2.6.34

2010-07-01 Thread Chris Wilson
On Thu, 1 Jul 2010 16:55:28 +0200, Clemens Eisserer wrote: > During the 2.6.11.901 testing phase a few people reported system freezes. > What was the result of that discussion? > > I still experience those freezes with kernel-2.6.34 + intel 2.12, > quite frequently when watching high resolution

[Intel-gfx] System freeze with 2.12 + 2.6.34

2010-07-01 Thread Clemens Eisserer
Hi, During the 2.6.11.901 testing phase a few people reported system freezes. What was the result of that discussion? I still experience those freezes with kernel-2.6.34 + intel 2.12, quite frequently when watching high resolution flash videos. Any idea what the problem could be? Thanks, Clemen

[Intel-gfx] [PATCH] Destroy screen pixmap on screen close.

2010-07-01 Thread Keith Packard
This avoids a memory leak on server reset. Signed-off-by: Keith Packard --- uxa/uxa.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/uxa/uxa.c b/uxa/uxa.c index a9a705c..dcfaaa9 100644 --- a/uxa/uxa.c +++ b/uxa/uxa.c @@ -1,7 +1,7 @@ /* - * Copyright © 2001 Keith P

Re: [Intel-gfx] [PATCH] drm/i915: Selectively enable self-reclaim

2010-07-01 Thread Chris Wilson
On Wed, 30 Jun 2010 18:24:04 -0700, Linus Torvalds wrote: > On Wed, Jun 30, 2010 at 4:07 PM, Linus Torvalds > wrote: > > > > That commit changes the page cache allocation to use > > > > +                                         > >  mapping_gfp_mask (mapping) | > > +    

Re: [Intel-gfx] [PATCH] drm/i915: Selectively enable self-reclaim

2010-07-01 Thread Dave Airlie
On Thu, Jul 1, 2010 at 11:24 AM, Linus Torvalds wrote: > On Wed, Jun 30, 2010 at 4:07 PM, Linus Torvalds > wrote: >> >> That commit changes the page cache allocation to use >> >> +                                          mapping_gfp_mask (mapping) | >> +                                          

Re: [Intel-gfx] [PATCH] i915: fix ironlake edp panel setup (v3)

2010-07-01 Thread Paul Menzel
Dear Dave, just a small typo. > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 6094e42..151ed49 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -139,6 +139,12 @@ intel_dp_link_required(struct drm_device *dev, […