Re: Patch for adding tls_honor_cipher_order

2014-12-30 Thread Mark Blackman
> On 17 Oct 2014, at 11:34, Jeroen van Meeuwen (Kolab Systems) > wrote: > > On 2014-10-16 19:32, Kristian Kræmmer Nielsen wrote: >> Hi, >> >> Patch attached. >> > > Something similar is already in cyrus-imapd-2.4: > > > http://git.cyrusimap.org/cyrus-imapd/commit/?h=cyrus-imapd-2.4&id=4b26

Re: Patch for adding tls_honor_cipher_order

2014-10-30 Thread Jeroen van Meeuwen (Kolab Systems)
On 2014-10-23 16:04, Wolfgang Breyha wrote: > Kristian Kræmmer Nielsen wrote on 17/10/14 15:13: >> The more important part of my previous mail are that there are issues >> with >> the patches that now have been merged into git. E.g. compression is >> not >> merged correctly and it is recommended

Re: Patch for adding tls_honor_cipher_order

2014-10-23 Thread Wolfgang Breyha
Kristian Kræmmer Nielsen wrote on 17/10/14 15:13: > The more important part of my previous mail are that there are issues with > the patches that now have been merged into git. E.g. compression is not > merged correctly and it is recommended to do negative list and not > positive lists of pro

Re: Patch for adding tls_honor_cipher_order

2014-10-17 Thread Kristian Kræmmer Nielsen
Hi Wolfgang, Not to start a flame war - but I was responding to Jeroen stating they were in cyrus-imapd-2.4 "Something similar is already in cyrus-imapd-2.4". I know that the bugs were there, my patches even refer to them :) The more important part of my previous mail are that there are issue

Re: Patch for adding tls_honor_cipher_order

2014-10-17 Thread Wolfgang Breyha
Kristian Kræmmer Nielsen wrote on 17/10/14 14:48: > "already" - I see you just added it ;-) No, they (and more) were there for month as https://bugzilla.cyrusimap.org/show_bug.cgi?id=3822 https://bugzilla.cyrusimap.org/show_bug.cgi?id=3823 https://bugzilla.cyrusimap.org/show_bug.cgi?id=3830 https:

Re: Patch for adding tls_honor_cipher_order

2014-10-17 Thread Kristian Kræmmer Nielsen
Hi, "already" - I see you just added it ;-) But really great Jeroen for implementing these - thanks. Just a few comments - I see you also added tls_compression - maybe you should consider also actually implementing it? ;-) Also I would recommend logging a failure if a wrong tls_eccurve is s

Re: Patch for adding tls_honor_cipher_order

2014-10-17 Thread Jeroen van Meeuwen (Kolab Systems)
On 2014-10-16 19:32, Kristian Kræmmer Nielsen wrote: > Hi, > > Patch attached. > Something similar is already in cyrus-imapd-2.4: http://git.cyrusimap.org/cyrus-imapd/commit/?h=cyrus-imapd-2.4&id=4b26d2d7244eeaa481871c337e57cd393fd76dfe For master / 2.5, I have a push pending of a similar

Patch for adding tls_honor_cipher_order

2014-10-16 Thread Kristian Kræmmer Nielsen
Hi, Patch attached. While at it we might as well also let the user set tls_honor_cipher_order if they want to so that the order of cipher specified using tls_cipher_list is honored. By default false, so changes nothing. For expert uses might give clients a bit of extra performance by usin